kennel 1.144.2 → 1.145.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d1cc43aa92bfd88e9cc7c7f33f1c91aaafc0c5a936e2c8dc0d153c20f7bfc85
-  data.tar.gz: e1f75c40c4c9a9d38438a2563241193172bc56e020f6ff3b3295dc8485ae415d
+  metadata.gz: e3043dcfb11f7d16c0ac340a1dc5d94488f801f52a75ed5946c7ec514a116f8d
+  data.tar.gz: 98b4a64f1b659bde487a5d18a5674b9b3c0022e45bbe48bf9150963fcf289e68
 SHA512:
-  metadata.gz: 1715277a99ad67ec234522351420712d3c69b617f8ca8cb05118a5d5207ff236177d08183c1315284f4219afd269051745fe6231c771bda943194b0ea2ce6724
-  data.tar.gz: cbf498bd57f5668806fab7142048e8e4864ebc745f094189ecc9993bd75a288dc994bac582bbc00ce2eaa704a36916066247ce9fd460d4e861733dc5df7b5843
+  metadata.gz: e5fee59bdac78be8f4797f3a6ff12117f19cbddf709fb9c1a4d66cc7b39f199ef451d0b014b4556ddedcf5f30285448c554c6bf5168d9bdb54a53beb2d1bf139
+  data.tar.gz: b0fba5079b184ed126d23a61d6b30daf3d9190665582f56e332a60909f832efa883a078d68f3cee3879ceaf9a2e461b729fc25d2fbada563e9f283c2456eab4a

data/Readme.md

@@ -171,7 +171,7 @@ for simple constants you may prefer to use the plain syntax (`critical: 5.0`).
  - `cp .env.example .env`
  - open [Datadog API Settings](https://app.datadoghq.com/account/settings#api)
  - create a `API Key` or get an existing one from an admin, then add it to `.env` as `DATADOG_API_KEY`
- - open [Datadog API Settings](https://app.datadoghq.com/access/application-keys) and create a new key, then add it to `.env` as `DATADOG_APP_KEY=`
+ - open [Datadog API Settings](https://app.datadoghq.com/personal-settings/application-keys) and create a new key, then add it to `.env` as `DATADOG_APP_KEY=`
  - if you have a custom subdomain, change the `DATADOG_SUBDOMAIN=app` in `.env`
  - verify it works by running `rake plan`, it might show some diff, but should not crash
 -->

data/lib/kennel/models/monitor.rb

@@ -60,7 +60,8 @@ module Kennel
         variables: -> { MONITOR_OPTION_DEFAULTS.fetch(:variables) },
         on_missing_data: -> { MONITOR_OPTION_DEFAULTS.fetch(:on_missing_data) },
         notification_preset_name: -> { MONITOR_OPTION_DEFAULTS.fetch(:notification_preset_name) },
-        notify_by: -> { MONITOR_OPTION_DEFAULTS.fetch(:notify_by) }
+        notify_by: -> { MONITOR_OPTION_DEFAULTS.fetch(:notify_by) },
+        require_full_window: -> { false }
       )
 
       def build_json
@@ -205,7 +206,7 @@ module Kennel
         # fields are not returned when set to true
         if ["service check", "event alert"].include?(actual[:type])
           options[:include_tags] = true unless options.key?(:include_tags)
-          options[:require_full_window] = true unless options.key?(:require_full_window)
+          options[:require_full_window] = false unless options.key?(:require_full_window)
         end
 
         case actual[:type]
@@ -218,6 +219,7 @@ module Kennel
           OPTIONAL_SERVICE_CHECK_THRESHOLDS.each do |t|
             options[:thresholds][t] ||= 1
           end
+        else # do nothing
         end
 
         # nil / "" / 0 are not returned from the api when set via the UI
@@ -233,12 +235,6 @@ module Kennel
 
       private
 
-      def require_full_window
-        # default 'on_average', 'at_all_times', 'in_total' aggregations to true, otherwise false
-        # https://docs.datadoghq.com/ap/#create-a-monitor
-        type != "query alert" || query.start_with?("avg", "min", "sum")
-      end
-
       def validate_json(data)
         super
 
@@ -358,6 +354,7 @@ module Kennel
               "Warning threshold (#{warning}) must be less than the alert threshold (#{critical}) with > comparison"
             )
           end
+        else # do nothing
         end
       end
     end

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.144.2"
+  VERSION = "1.145.1"
 end

data/template/Readme.md

@@ -154,7 +154,7 @@ for simple constants you may prefer to use the plain syntax (`critical: 5.0`).
  - `cp .env.example .env`
  - open [Datadog API Settings](https://app.datadoghq.com/account/settings#api)
  - create a `API Key` or get an existing one from an admin, then add it to `.env` as `DATADOG_API_KEY`
- - open [Datadog API Settings](https://app.datadoghq.com/access/application-keys) and create a new key, then add it to `.env` as `DATADOG_APP_KEY=`
+ - open [Datadog API Settings](https://app.datadoghq.com/personal-settings/application-keys) and create a new key, then add it to `.env` as `DATADOG_APP_KEY=`
  - if you have a custom subdomain, change the `DATADOG_SUBDOMAIN=app` in `.env`
  - verify it works by running `rake plan`, it might show some diff, but should not crash
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.144.2
+  version: 1.145.1
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-28 00:00:00.000000000 Z
+date: 2023-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs