kennel 1.144.1 → 1.145.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5bf4216bfa5c2ae40c29b50d3891a8fe7c08d6a2f75229a923c28991d4537d39
-  data.tar.gz: 2a36e4b94db5a0c41ed1d1b1986f52938b564a80cc887e5cd7fbe76bbb480185
+  metadata.gz: ed091ba0fa4fda310e5444a6e01fd21cf03f2b19dee5c7d4b0988a61855ca28e
+  data.tar.gz: 8a720d21972b01c5863722bf56834eccbcaf91ebcd949512142239afa364ec77
 SHA512:
-  metadata.gz: 71d0cde39adf53dcd3d77460be78c6cb08ea3f9bb4f44d08e7a50d86fba3058f9fc47fdc51574262de3357dce9e81d8d7b8d102f139683dae76b0bc04547262a
-  data.tar.gz: 6fd4919a07e88a14eca5c14931f77ee08ec0bdfc3be6f446707c9e29aca4aad9b68ca9bbad3cc550e410c89bfaec51d2b9929de720ce9aab7a21a732339b5fa9
+  metadata.gz: e478b0fea488349ef09f1402f146d5d1383849f292b34fd9575378abdb547d1de00124f9063a0e4dab5f80749470013d22416198db912723cd23e2588ffdf2dc
+  data.tar.gz: f64c88e17f5b1e016c8e8503b9e098bdaf56167b5d9084c4245199bad52fd142253b9f672647597fb24c0dd4b798c1382f9b45eeaaf1cdc76c4cc04fdeb70956

data/lib/kennel/models/monitor.rb

@@ -4,7 +4,6 @@ module Kennel
     class Monitor < Record
       include TagsValidation
 
-      RENOTIFY_INTERVALS = [0, 10, 20, 30, 40, 50, 60, 90, 120, 180, 240, 300, 360, 720, 1440].freeze # minutes
       OPTIONAL_SERVICE_CHECK_THRESHOLDS = [:ok, :warning].freeze
       READONLY_ATTRIBUTES = superclass::READONLY_ATTRIBUTES + [
         :multi, :matching_downtimes, :overall_state_modified, :overall_state, :restricted_roles
@@ -61,7 +60,8 @@ module Kennel
         variables: -> { MONITOR_OPTION_DEFAULTS.fetch(:variables) },
         on_missing_data: -> { MONITOR_OPTION_DEFAULTS.fetch(:on_missing_data) },
         notification_preset_name: -> { MONITOR_OPTION_DEFAULTS.fetch(:notification_preset_name) },
-        notify_by: -> { MONITOR_OPTION_DEFAULTS.fetch(:notify_by) }
+        notify_by: -> { MONITOR_OPTION_DEFAULTS.fetch(:notify_by) },
+        require_full_window: -> { false }
       )
 
       def build_json
@@ -206,7 +206,7 @@ module Kennel
         # fields are not returned when set to true
         if ["service check", "event alert"].include?(actual[:type])
           options[:include_tags] = true unless options.key?(:include_tags)
-          options[:require_full_window] = true unless options.key?(:require_full_window)
+          options[:require_full_window] = false unless options.key?(:require_full_window)
         end
 
         case actual[:type]
@@ -219,6 +219,7 @@ module Kennel
           OPTIONAL_SERVICE_CHECK_THRESHOLDS.each do |t|
             options[:thresholds][t] ||= 1
           end
+        else # do nothing
         end
 
         # nil / "" / 0 are not returned from the api when set via the UI
@@ -234,12 +235,6 @@ module Kennel
 
       private
 
-      def require_full_window
-        # default 'on_average', 'at_all_times', 'in_total' aggregations to true, otherwise false
-        # https://docs.datadoghq.com/ap/#create-a-monitor
-        type != "query alert" || query.start_with?("avg", "min", "sum")
-      end
-
       def validate_json(data)
         super
 
@@ -261,11 +256,6 @@ module Kennel
           end
         end
 
-        # verify renotify interval is valid
-        unless RENOTIFY_INTERVALS.include? data.dig(:options, :renotify_interval)
-          invalid! :invalid_renotify_interval, "renotify_interval must be one of #{RENOTIFY_INTERVALS.join(", ")}"
-        end
-
         if ["query alert", "service check"].include?(type) # TODO: most likely more types need this
           validate_message_variables(data)
         end
@@ -364,6 +354,7 @@ module Kennel
               "Warning threshold (#{warning}) must be less than the alert threshold (#{critical}) with > comparison"
             )
           end
+        else # do nothing
         end
       end
     end

data/lib/kennel/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Kennel
-  VERSION = "1.144.1"
+  VERSION = "1.145.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kennel
 version: !ruby/object:Gem::Version
-  version: 1.144.1
+  version: 1.145.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-09-21 00:00:00.000000000 Z
+date: 2023-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: diff-lcs