keikokuc 0.1 → 0.2

data/lib/keikokuc/notification_list.rb

@@ -46,6 +46,7 @@ class Keikokuc::NotificationList
     result, error = client.get_notifications
     if error.nil?
       @notifications = result.map do |attributes|
+        attributes.merge!(client: client, remote_id: attributes.delete(:id))
         Keikokuc::Notification.new(attributes)
       end
     end
@@ -53,6 +54,16 @@ class Keikokuc::NotificationList
     error.nil?
   end
 
+  # Public: marks all notifications as read
+  #
+  # This is a convenience method for marking all underlying notifications
+  # as read.
+  #
+  # Returns a Boolean set to true if all notifications were read successfully.
+  def read_all
+    self.inject(true) { |result, notification| result && notification.read }
+  end
+
   # Public: the number of notifications
   #
   # Returns an Integer set to the number of notifications
@@ -64,7 +75,7 @@ class Keikokuc::NotificationList
   #
   # Yields every notification in this collection
   def each
-    @notifications.each
+    @notifications.each { |n| yield n }
   end
 
 private

data/lib/keikokuc/version.rb

@@ -1,3 +1,3 @@
 module Keikokuc
-  VERSION = "0.1"
+  VERSION = "0.2"
 end

data/spec/keikoku/notification_list_spec.rb

@@ -1,9 +1,34 @@
 require 'spec_helper'
 
 module Keikokuc
+  shared_context 'specs with a fake client' do
+    let(:fake_client) { double(:fake_client) }
+  end
+  shared_context 'with user notifications' do
+    let(:user_notifications) do
+      [
+        {
+          id:           1,
+          target_name:  'flying-monkey-123',
+          message:      'Database HEROKU_POSTGRESQL_BROWN is over row limits',
+          url:          'https://devcenter.heroku.com/how-to-fix-problem',
+          severity:     'info'
+        },
+        {
+          id:           2,
+          target_name:  'rising-cloud-42',
+          message:      'High OOM rates',
+          url:          'https://devcenter.heroku.com/oom',
+          severity:     'fatal'
+        }
+      ]
+    end
+  end
+
   describe NotificationList, '#fetch' do
+    include_context 'specs with a fake client'
+    include_context 'with user notifications'
     it 'finds all notifications for the current user' do
-      fake_client = double
       fake_client.should_receive(:get_notifications).
         and_return([user_notifications, nil])
       list = build(:notification_list, client: fake_client)
@@ -20,21 +45,48 @@ module Keikokuc
       end
     end
 
-    def user_notifications
-      [
-        {
-          resource: 'flying-monkey-123',
-          message:  'Database HEROKU_POSTGRESQL_BROWN is over row limits',
-          url:      'https://devcenter.heroku.com/how-to-fix-problem',
-          severity: 'info'
-        },
-        {
-          resource: 'rising-cloud-42',
-          message:  'High OOM rates',
-          url:      'https://devcenter.heroku.com/oom',
-          severity: 'fatal'
-        }
-      ]
+  end
+
+  describe NotificationList, '#read_all' do
+    include_context 'specs with a fake client'
+    include_context 'with user notifications'
+
+    it 'marks all notifications as read' do
+      fake_client.stub(get_notifications: [user_notifications, nil])
+
+      now = Time.now
+      fake_client.should_receive(:read_notification).with(1).
+        and_return([{read_at: now}, nil])
+      fake_client.should_receive(:read_notification).with(2).
+        and_return([{read_at: now}, nil])
+
+      list = build(:notification_list, client: fake_client)
+
+      list.fetch or raise "error fetching"
+
+      expect(list.read_all).to be_true
+
+      list.each do |notification|
+        expect(notification).to be_read
+        expect(notification.read_at).to eq(now)
+      end
     end
+
+    it 'returns false if any notification fails to be marked as read' do
+      fake_client.stub(get_notifications: [user_notifications, nil])
+
+      now = Time.now
+      fake_client.should_receive(:read_notification).with(1).
+        and_return([{read_at: now}, nil])
+      fake_client.should_receive(:read_notification).with(2).
+        and_return([[], :an_error])
+
+      list = build(:notification_list, client: fake_client)
+
+      list.fetch or raise "error fetching"
+
+      expect(list.read_all).to be_false
+    end
+
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: keikokuc
 version: !ruby/object:Gem::Version
-  version: '0.1'
+  version: '0.2'
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-10-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
-  requirement: &70298442791900 !ruby/object:Gem::Requirement
+  requirement: &70251215460580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70298442791900
+  version_requirements: *70251215460580
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
-  requirement: &70298442791480 !ruby/object:Gem::Requirement
+  requirement: &70251215460160 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70298442791480
+  version_requirements: *70251215460160
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70298442791040 !ruby/object:Gem::Requirement
+  requirement: &70251215459720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70298442791040
+  version_requirements: *70251215459720
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &70298442790620 !ruby/object:Gem::Requirement
+  requirement: &70251215459300 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70298442790620
+  version_requirements: *70251215459300
 - !ruby/object:Gem::Dependency
   name: sham_rack
-  requirement: &70298442790180 !ruby/object:Gem::Requirement
+  requirement: &70251215458860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,7 +65,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70298442790180
+  version_requirements: *70251215458860
 description: Keikoku client
 email:
 - harold.gimenez@gmail.com