keepr 0.3.0 → 0.6.0

data/spec/keepr/contact_export_spec.rb

@@ -1,22 +1,25 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::ContactExport do
-  let!(:account_1000)  { FactoryGirl.create :account, :kind => :asset,     :number => 1000,  :name => 'Kasse'      }
-  let!(:account_10000) { FactoryGirl.create :account, :kind => :creditor,  :number => 10000, :name => 'Meyer GmbH' }
-  let!(:account_70000) { FactoryGirl.create :account, :kind => :debtor,    :number => 70000, :name => 'Schulze AG' }
+  let!(:account_1000)  { FactoryBot.create :account, kind: :asset,     number: 1000, name: 'Kasse' }
+  let!(:account_10000) { FactoryBot.create :account, kind: :creditor,  number: 10_000, name: 'Meyer GmbH' }
+  let!(:account_70000) { FactoryBot.create :account, kind: :debtor,    number: 70_000, name: 'Schulze AG' }
 
   let(:scope) { Keepr::Account.all }
 
-  let(:export) {
-    Keepr::ContactExport.new(scope,
-      'Berater'     => 1234567,
-      'Mandant'     => 78901,
-      'WJ-Beginn'   => Date.new(2016,1,1),
+  let(:export) do
+    Keepr::ContactExport.new(
+      scope,
+      'Berater'     => 1_234_567,
+      'Mandant'     => 78_901,
+      'WJ-Beginn'   => Date.new(2016, 1, 1),
       'Bezeichnung' => 'Keepr-Kontakte'
     ) do |account|
       { 'Kurzbezeichnung' => account.name }
     end
-  }
+  end
 
   describe :to_s do
     subject { export.to_s }
@@ -25,31 +28,31 @@ describe Keepr::ContactExport do
       subject.lines[2..-1]
     end
 
-    it "should return CSV lines" do
+    it 'should return CSV lines' do
       subject.lines.each { |line| expect(line).to include(';') }
     end
 
-    it "should include header data" do
+    it 'should include header data' do
       expect(subject.lines[0]).to include('1234567;')
       expect(subject.lines[0]).to include('78901;')
-      expect(subject.lines[0]).to include('Keepr-Kontakte;')
+      expect(subject.lines[0]).to include('"Keepr-Kontakte";')
     end
 
-    it "should include debtor/creditor accounts only" do
+    it 'should include debtor/creditor accounts only' do
       expect(account_lines.count).to eq(2)
 
       expect(account_lines[0]).to include('10000;')
       expect(account_lines[1]).to include('70000;')
     end
 
-    it "should include data from block" do
-      expect(account_lines[0]).to include('Meyer GmbH;')
-      expect(account_lines[1]).to include('Schulze AG;')
+    it 'should include data from block' do
+      expect(account_lines[0]).to include('"Meyer GmbH";')
+      expect(account_lines[1]).to include('"Schulze AG";')
     end
   end
 
   describe :to_file do
-    it "should create CSV file" do
+    it 'should create CSV file' do
       Dir.mktmpdir do |dir|
         filename = "#{dir}/EXTF_Stammdaten.csv"
         export.to_file(filename)

data/spec/keepr/cost_center_spec.rb

@@ -1,15 +1,17 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::CostCenter do
-  let(:cost_center) { FactoryGirl.create(:cost_center) }
-  let(:account)     { FactoryGirl.create(:account, :number => 8400, :kind => :revenue) }
+  let(:cost_center) { FactoryBot.create(:cost_center) }
+  let(:account)     { FactoryBot.create(:account, number: 8400, kind: :revenue) }
 
   it 'should have postings' do
-    posting = Keepr::Posting.create! :amount            => 10,
-                                     :side              => 'debit',
-                                     :keepr_account     => account,
-                                     :keepr_cost_center => cost_center,
-                                     :keepr_journal_id  => 42
+    posting = Keepr::Posting.create! amount: 10,
+                                     side: 'debit',
+                                     keepr_account: account,
+                                     keepr_cost_center: cost_center,
+                                     keepr_journal_id: 42
 
     expect(cost_center.keepr_postings).to eq([posting])
   end

data/spec/keepr/group_spec.rb

@@ -1,25 +1,27 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::Group do
   describe 'validations' do
-    it "should allow is_result for liability" do
-      group = Keepr::Group.new(:is_result => true, :target => :liability, :name => 'foo')
+    it 'should allow is_result for liability' do
+      group = Keepr::Group.new(is_result: true, target: :liability, name: 'foo')
       expect(group).to be_valid
     end
 
-    [ :asset, :profit_and_loss ].each do |target|
+    %i[asset profit_and_loss].each do |target|
       it "should not allow is_result for #{target}" do
-        group = Keepr::Group.new(:is_result => true, :target => target, :name => 'foo')
+        group = Keepr::Group.new(is_result: true, target: target, name: 'foo')
         expect(group).not_to be_valid
-        expect(group.errors.added? :base, :liability_needed_for_result).to eq(true)
+        expect(group.errors.added?(:base, :liability_needed_for_result)).to eq(true)
       end
     end
   end
 
   describe :get_from_parent do
     it 'should preset parent' do
-      root = FactoryGirl.create :group, :target => :asset
-      child = root.children.create! :name => 'Bar'
+      root = FactoryBot.create :group, target: :asset
+      child = root.children.create! name: 'Bar'
 
       expect(child.target).to eq('asset')
     end
@@ -27,16 +29,16 @@ describe Keepr::Group do
 
   describe :keepr_accounts do
     it 'should not destroy if there are accounts' do
-      group = FactoryGirl.create :group
-      account = FactoryGirl.create :account, :number => 1000, :keepr_group => group
+      group = FactoryBot.create :group
+      FactoryBot.create :account, number: 1000, keepr_group: group
 
-      expect { group.destroy }.to_not change { Keepr::Group.count }
+      expect { group.destroy }.to_not change(Keepr::Group, :count)
       expect(group.destroy).to eq(false)
       expect(group.reload).to eq(group)
     end
 
     it 'should destroy if there are no accounts' do
-      group = FactoryGirl.create :group
+      group = FactoryBot.create :group
 
       expect { group.destroy }.to change { Keepr::Group.count }.by(-1)
     end
@@ -44,58 +46,60 @@ describe Keepr::Group do
 
   describe :keepr_postings do
     # Simple asset group hierarchy
-    let(:group_1)     { FactoryGirl.create :group, :target => :asset }
-    let(:group_1_1)   { FactoryGirl.create :group, :target => :asset, :parent => group_1 }
-    let(:group_1_1_1) { FactoryGirl.create :group, :target => :asset, :parent => group_1_1 }
+    let(:group_1)     { FactoryBot.create :group, target: :asset }
+    let(:group_1_1)   { FactoryBot.create :group, target: :asset, parent: group_1 }
+    let(:group_1_1_1) { FactoryBot.create :group, target: :asset, parent: group_1_1 }
 
     # Group for P&L accounts
-    let(:group_2)     { FactoryGirl.create :group, :target => :profit_and_loss }
+    let(:group_2)     { FactoryBot.create :group, target: :profit_and_loss }
 
     # Group for balance result
-    let(:group_result){ FactoryGirl.create :group, :target => :liability, :is_result => true }
+    let(:group_result) { FactoryBot.create :group, target: :liability, is_result: true }
 
     # Accounts
-    let(:account_1a)  { FactoryGirl.create :account, :number => '0001', :keepr_group => group_1_1_1 }
-    let(:account_1b)  { FactoryGirl.create :account, :number => '0011', :keepr_group => group_1_1_1 }
-    let(:account_1c)  { FactoryGirl.create :account, :number => '0111', :keepr_group => group_1_1_1 }
+    let(:account_1a)  { FactoryBot.create :account, number: '0001', keepr_group: group_1_1_1 }
+    let(:account_1b)  { FactoryBot.create :account, number: '0011', keepr_group: group_1_1_1 }
+    let(:account_1c)  { FactoryBot.create :account, number: '0111', keepr_group: group_1_1_1 }
 
-    let(:account_2)   { FactoryGirl.create :account, :number => '8400', :keepr_group => group_2, :kind => :revenue }
+    let(:account_2)   { FactoryBot.create :account, number: '8400', keepr_group: group_2, kind: :revenue }
 
     # Journals
-    let!(:journal1)   { Keepr::Journal.create! :keepr_postings_attributes => [
-                          { :keepr_account => account_1a, :amount => 100.99, :side => 'debit' },
-                          { :keepr_account => account_2,  :amount => 100.99, :side => 'credit' }
-                        ]
-                      }
-    let!(:journal2)   { Keepr::Journal.create! :keepr_postings_attributes => [
-                          { :keepr_account => account_1b, :amount => 100.99, :side => 'debit' },
-                          { :keepr_account => account_2, :amount => 100.99, :side => 'credit' }
-                        ]
-                      }
-    let!(:journal3)   { Keepr::Journal.create! :keepr_postings_attributes => [
-                          { :keepr_account => account_1c, :amount => 100.99, :side => 'debit' },
-                          { :keepr_account => account_2,  :amount => 100.99, :side => 'credit' }
-                        ]
-                      }
+    let!(:journal1)   do
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1a, amount: 100.99, side: 'debit' },
+        { keepr_account: account_2, amount: 100.99, side: 'credit' }
+      ]
+    end
+    let!(:journal2) do
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1b, amount: 100.99, side: 'debit' },
+        { keepr_account: account_2, amount: 100.99, side: 'credit' }
+      ]
+    end
+    let!(:journal3) do
+      Keepr::Journal.create! keepr_postings_attributes: [
+        { keepr_account: account_1c, amount: 100.99, side: 'debit' },
+        { keepr_account: account_2, amount: 100.99, side: 'credit' }
+      ]
+    end
 
     context 'for normal groups' do
-      it "should return postings of all accounts within the group" do
-        postings_1 = [journal1.debit_postings.first, journal2.debit_postings.first, journal3.debit_postings.first]
-        expect(group_1.keepr_postings).to eq(postings_1)
-        expect(group_1_1.keepr_postings).to eq(postings_1)
-        expect(group_1_1_1.keepr_postings).to eq(postings_1)
-
-        postings_2 = [journal1.credit_postings.first, journal2.credit_postings.first, journal3.credit_postings.first]
-        expect(group_2.keepr_postings).to eq(postings_2)
+      it 'should return postings of all accounts within the group' do
+        postings1 = [journal1.debit_postings.first, journal2.debit_postings.first, journal3.debit_postings.first]
+        expect(group_1.keepr_postings).to eq(postings1)
+        expect(group_1_1.keepr_postings).to eq(postings1)
+        expect(group_1_1_1.keepr_postings).to eq(postings1)
+
+        postings2 = [journal1.credit_postings.first, journal2.credit_postings.first, journal3.credit_postings.first]
+        expect(group_2.keepr_postings).to eq(postings2)
       end
     end
 
-    context "for result group" do
-      it "should return postings for P&L accounts" do
-        result_postings = [ journal1.credit_postings.first,
-                            journal2.credit_postings.first,
-                            journal3.credit_postings.first
-                          ]
+    context 'for result group' do
+      it 'should return postings for P&L accounts' do
+        result_postings = [journal1.credit_postings.first,
+                           journal2.credit_postings.first,
+                           journal3.credit_postings.first]
 
         expect(group_result.keepr_postings).to eq(result_postings)
       end

data/spec/keepr/groups_creator_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::GroupsCreator do
@@ -6,7 +8,7 @@ describe Keepr::GroupsCreator do
       Keepr::GroupsCreator.new(:balance).run
     end
 
-    it "should create groups" do
+    it 'should create groups' do
       expect(Keepr::Group.count).to eq(64)
       expect(Keepr::Group.asset.count).to eq(36)
       expect(Keepr::Group.liability.count).to eq(28)
@@ -15,7 +17,7 @@ describe Keepr::GroupsCreator do
       compare_with_source(Keepr::Group.liability, 'liability.txt')
     end
 
-    it "should create result group" do
+    it 'should create result group' do
       expect(Keepr::Group.result).to be_a(Keepr::Group)
     end
   end
@@ -25,7 +27,7 @@ describe Keepr::GroupsCreator do
       Keepr::GroupsCreator.new(:profit_and_loss).run
     end
 
-    it "should create profit & loss groups" do
+    it 'should create profit & loss groups' do
       expect(Keepr::Group.count).to eq(31)
       expect(Keepr::Group.profit_and_loss.count).to eq(31)
 
@@ -33,7 +35,8 @@ describe Keepr::GroupsCreator do
     end
   end
 
-private
+  private
+
   def compare_with_source(scope, filename)
     full_filename = File.join(File.dirname(__FILE__), "../../lib/keepr/groups_creator/#{filename}")
     source = File.read(full_filename)

data/spec/keepr/journal_export_spec.rb

@@ -1,34 +1,35 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Keepr::JournalExport do
-  let(:ust) { Keepr::Tax.create! :name => 'USt19', :value => 19.0, :keepr_account => account_1776 }
-  let(:vst) { Keepr::Tax.create! :name => 'VSt19', :value => 19.0, :keepr_account => account_1576 }
+  let(:ust) { Keepr::Tax.create! name: 'USt19', value: 19.0, keepr_account: account_1776 }
+  let(:vst) { Keepr::Tax.create! name: 'VSt19', value: 19.0, keepr_account: account_1576 }
 
-  let(:account_1000)  { FactoryGirl.create :account, :number => 1000, :kind => :asset     }
-  let(:account_1200)  { FactoryGirl.create :account, :number => 1200, :kind => :asset     }
-  let(:account_1576)  { FactoryGirl.create :account, :number => 1576, :kind => :asset     }
-  let(:account_1776)  { FactoryGirl.create :account, :number => 1776, :kind => :liability }
-  let(:account_1600)  { FactoryGirl.create :account, :number => 1600, :kind => :liability }
-  let(:account_1718)  { FactoryGirl.create :account, :number => 1718, :kind => :liability, :keepr_tax => ust }
-  let(:account_4920)  { FactoryGirl.create :account, :number => 4920, :kind => :expense,   :keepr_tax => vst }
-  let(:account_8400)  { FactoryGirl.create :account, :number => 8400, :kind => :revenue,   :keepr_tax => ust }
+  let(:account_1000)  { FactoryBot.create :account, number: 1000, kind: :asset     }
+  let(:account_1200)  { FactoryBot.create :account, number: 1200, kind: :asset     }
+  let(:account_1576)  { FactoryBot.create :account, number: 1576, kind: :asset     }
+  let(:account_1776)  { FactoryBot.create :account, number: 1776, kind: :liability }
+  let(:account_1600)  { FactoryBot.create :account, number: 1600, kind: :liability }
+  let(:account_1718)  { FactoryBot.create :account, number: 1718, kind: :liability, keepr_tax: ust }
+  let(:account_4920)  { FactoryBot.create :account, number: 4920, kind: :expense,   keepr_tax: vst }
+  let(:account_8400)  { FactoryBot.create :account, number: 8400, kind: :revenue,   keepr_tax: ust }
 
-  let(:account_10000) { FactoryGirl.create :account, :number => 10000, :kind => :debtor   }
+  let(:account_10000) { FactoryBot.create :account, number: 10_000, kind: :debtor }
 
   let(:scope) { Keepr::Journal.reorder(:number) }
 
-  let(:export) {
+  let(:export) do
     Keepr::JournalExport.new(scope,
-      'Berater'     => 1234567,
-      'Mandant'     => 78901,
-      'Datum vom'   => Date.new(2016,6,1),
-      'Datum bis'   => Date.new(2016,6,30),
-      'WJ-Beginn'   => Date.new(2016,1,1),
-      'Bezeichnung' => 'Keepr-Buchungen'
-    ) do |posting|
+                             'Berater'     => 1_234_567,
+                             'Mandant'     => 78_901,
+                             'Datum vom'   => Date.new(2016, 6, 1),
+                             'Datum bis'   => Date.new(2016, 6, 30),
+                             'WJ-Beginn'   => Date.new(2016, 1, 1),
+                             'Bezeichnung' => 'Keepr-Buchungen') do |posting|
       { 'Identifikationsnummer' => "ID:#{posting.id}" }
     end
-  }
+  end
 
   describe :to_s do
     subject { export.to_s }
@@ -37,127 +38,127 @@ describe Keepr::JournalExport do
       subject.lines[2..-1]
     end
 
-    it "should return CSV lines" do
+    it 'should return CSV lines' do
       expect(subject.lines.count).to eq(2)
       subject.lines.each { |line| expect(line).to include(';') }
     end
 
-    it "should include header data" do
+    it 'should include header data' do
       expect(subject.lines[0]).to include('1234567;')
       expect(subject.lines[0]).to include('78901;')
       expect(subject.lines[0]).to include('20160601;20160630;')
-      expect(subject.lines[0]).to include('Keepr-Buchungen;')
+      expect(subject.lines[0]).to include('"Keepr-Buchungen";')
     end
 
-    context "Journal without tax" do
+    context 'Journal without tax' do
       let!(:journal_without_tax) do
-        Keepr::Journal.create! :number                    => 'BELEG-1',
-                               :subject                   => 'Geldautomat',
-                               :date                      => Date.new(2016,06,23),
-                               :keepr_postings_attributes => [
-                                 { :keepr_account => account_1000, :amount => 105, :side => 'debit' },
-                                 { :keepr_account => account_1200, :amount => 105, :side => 'credit' }
+        Keepr::Journal.create! number: 'BELEG-1',
+                               subject: 'Geldautomat',
+                               date: Date.new(2016, 0o6, 23),
+                               keepr_postings_attributes: [
+                                 { keepr_account: account_1000, amount: 105, side: 'debit' },
+                                 { keepr_account: account_1200, amount: 105, side: 'credit' }
                                ]
       end
 
-      it "should include data" do
+      it 'should include data' do
         expect(booking_lines.count).to eq(1)
 
-        expect(booking_lines[0]).to include('Geldautomat;')
+        expect(booking_lines[0]).to include('"Geldautomat";')
         expect(booking_lines[0]).to include('1000;1200;')
         expect(booking_lines[0]).to include('105,00;')
-        expect(booking_lines[0]).to include(';S;')
+        expect(booking_lines[0]).to include(';"S";')
         expect(booking_lines[0]).to include('2306;')
-        expect(booking_lines[0]).to include('BELEG-1;')
+        expect(booking_lines[0]).to include('"BELEG-1";')
         expect(booking_lines[0]).to include(';0;')
       end
     end
 
-    context "Journal with tax" do
+    context 'Journal with tax' do
       let!(:journal_with_tax) do
-        Keepr::Journal.create! :number                    => 'BELEG-2',
-                               :subject                   => 'Telefonrechnung',
-                               :date                      => Date.new(2016,06,24),
-                               :keepr_postings_attributes => [
-                                 { :keepr_account => account_4920, :amount =>  8.40, :side => 'debit' },
-                                 { :keepr_account => account_1576, :amount =>  1.60, :side => 'debit' },
-                                 { :keepr_account => account_1600, :amount => 10.00, :side => 'credit' }
+        Keepr::Journal.create! number: 'BELEG-2',
+                               subject: 'Telefonrechnung',
+                               date: Date.new(2016, 0o6, 24),
+                               keepr_postings_attributes: [
+                                 { keepr_account: account_4920, amount:  8.40, side: 'debit' },
+                                 { keepr_account: account_1576, amount:  1.60, side: 'debit' },
+                                 { keepr_account: account_1600, amount: 10.00, side: 'credit' }
                                ]
       end
 
-      it "should include data" do
+      it 'should include data' do
         expect(booking_lines.count).to eq(2)
 
-        expect(booking_lines[0]).to include('Telefonrechnung;')
+        expect(booking_lines[0]).to include('"Telefonrechnung";')
         expect(booking_lines[0]).to include('4920;1600;')
         expect(booking_lines[0]).to include('8,40;')
-        expect(booking_lines[0]).to include(';S;')
+        expect(booking_lines[0]).to include(';"S";')
         expect(booking_lines[0]).to include('2406;')
-        expect(booking_lines[0]).to include('BELEG-2;')
+        expect(booking_lines[0]).to include('"BELEG-2";')
         expect(booking_lines[0]).to include(';0;')
 
-        expect(booking_lines[1]).to include('Telefonrechnung;')
+        expect(booking_lines[1]).to include('"Telefonrechnung";')
         expect(booking_lines[1]).to include('1576;1600;')
         expect(booking_lines[1]).to include('1,60;')
-        expect(booking_lines[1]).to include(';S;')
+        expect(booking_lines[1]).to include(';"S";')
         expect(booking_lines[1]).to include('2406;')
-        expect(booking_lines[1]).to include('BELEG-2;')
+        expect(booking_lines[1]).to include('"BELEG-2";')
         expect(booking_lines[1]).to include(';0;')
       end
     end
 
-    context "Journal with debtor" do
+    context 'Journal with debtor' do
       let!(:journal_with_debtor) do
-        Keepr::Journal.create! :number                    => 'BELEG-3',
-                               :subject                   => 'Warenverkauf mit Anzahlung',
-                               :date                      => Date.new(2016,06,25),
-                               :keepr_postings_attributes => [
-                                 { :keepr_account => account_10000, :amount => 4760.00, :side => 'debit'  },
-                                 { :keepr_account => account_1718,  :amount => 1000.00, :side => 'debit'  },
-                                 { :keepr_account => account_1776,  :amount =>  190.00, :side => 'debit'  },
-
-                                 { :keepr_account => account_8400,  :amount => 5000.00, :side => 'credit' },
-                                 { :keepr_account => account_1776,  :amount =>  950.00, :side => 'credit' }
+        Keepr::Journal.create! number: 'BELEG-3',
+                               subject: 'Warenverkauf mit Anzahlung',
+                               date: Date.new(2016, 0o6, 25),
+                               keepr_postings_attributes: [
+                                 { keepr_account: account_10000, amount: 4760.00, side: 'debit'  },
+                                 { keepr_account: account_1718,  amount: 1000.00, side: 'debit'  },
+                                 { keepr_account: account_1776,  amount: 190.00, side: 'debit' },
+
+                                 { keepr_account: account_8400,  amount: 5000.00, side: 'credit' },
+                                 { keepr_account: account_1776,  amount: 950.00, side: 'credit' }
                                ]
       end
 
-      it "should include data" do
+      it 'should include data' do
         expect(booking_lines.count).to eq(4)
 
-        expect(booking_lines[0]).to include('Warenverkauf mit Anzahlung;')
+        expect(booking_lines[0]).to include('"Warenverkauf mit Anzahlung";')
         expect(booking_lines[0]).to include('10000;8400;')
         expect(booking_lines[0]).to include('5000,00;')
-        expect(booking_lines[0]).to include(';S;')
+        expect(booking_lines[0]).to include(';"S";')
         expect(booking_lines[0]).to include('2506;')
-        expect(booking_lines[0]).to include('BELEG-3;')
+        expect(booking_lines[0]).to include('"BELEG-3";')
         expect(booking_lines[0]).to include(';0;')
 
-        expect(booking_lines[1]).to include('Warenverkauf mit Anzahlung;')
+        expect(booking_lines[1]).to include('"Warenverkauf mit Anzahlung";')
         expect(booking_lines[1]).to include('10000;1776;')
         expect(booking_lines[1]).to include('950,00;')
-        expect(booking_lines[1]).to include(';S;')
+        expect(booking_lines[1]).to include(';"S";')
         expect(booking_lines[1]).to include('2506;')
-        expect(booking_lines[1]).to include('BELEG-3;')
+        expect(booking_lines[1]).to include('"BELEG-3";')
         expect(booking_lines[1]).to include(';0;')
 
-        expect(booking_lines[2]).to include('Warenverkauf mit Anzahlung;')
+        expect(booking_lines[2]).to include('"Warenverkauf mit Anzahlung";')
         expect(booking_lines[2]).to include('1718;10000;')
         expect(booking_lines[2]).to include('1000,00;')
-        expect(booking_lines[2]).to include(';S;')
+        expect(booking_lines[2]).to include(';"S";')
         expect(booking_lines[2]).to include('2506;')
-        expect(booking_lines[2]).to include('BELEG-3;')
+        expect(booking_lines[2]).to include('"BELEG-3";')
         expect(booking_lines[2]).to include(';0;')
 
-        expect(booking_lines[3]).to include('Warenverkauf mit Anzahlung;')
+        expect(booking_lines[3]).to include('"Warenverkauf mit Anzahlung";')
         expect(booking_lines[3]).to include('1776;10000;')
         expect(booking_lines[3]).to include('190,00;')
-        expect(booking_lines[3]).to include(';S;')
+        expect(booking_lines[3]).to include(';"S";')
         expect(booking_lines[3]).to include('2506;')
-        expect(booking_lines[3]).to include('BELEG-3;')
+        expect(booking_lines[3]).to include('"BELEG-3";')
         expect(booking_lines[3]).to include(';0;')
       end
 
-      it "should include data from block" do
+      it 'should include data from block' do
         expect(booking_lines[0]).to include('ID:')
         expect(booking_lines[1]).to include('ID:')
       end
@@ -165,7 +166,7 @@ describe Keepr::JournalExport do
   end
 
   describe :to_file do
-    it "should create CSV file" do
+    it 'should create CSV file' do
       Dir.mktmpdir do |dir|
         filename = "#{dir}/EXTF_Buchungsstapel.csv"
         export.to_file(filename)