kdeploy 1.3.3 → 1.3.5

data/lib/kdeploy/cli/cli.rb

@@ -58,16 +58,16 @@ module Kdeploy
     method_option :retry_policy, type: :string, desc: 'Retry policy JSON to override config file'
     method_option :retry_policy_file, type: :string, desc: 'Retry policy JSON file to override config file'
     def execute(task_file, task_name = nil)
-      load_config_file
-      show_banner_once
       @task_file_dir = File.dirname(File.expand_path(task_file))
+      Configuration.load_for_execute(task_dir: @task_file_dir)
+      show_banner_once
       load_task_file(task_file)
 
       tasks_to_run = determine_tasks(task_name)
       all_results = execute_tasks(tasks_to_run)
 
-      # Exit non-zero if any executed host failed.
-      exit 1 if any_failed?(all_results)
+      # Exit non-zero if any executed host failed or a task could not run.
+      exit 1 if any_failed?(all_results) || @task_errors
     rescue StandardError => e
       puts Kdeploy::Banner.show_error(e.message)
       exit 1
@@ -76,7 +76,8 @@ module Kdeploy
     private
 
     def load_config_file
-      Configuration.load_from_file
+      # ponytail: kept for compatibility; prefer Configuration.load_for_execute
+      Configuration.load_for_execute(task_dir: @task_file_dir)
     end
 
     def load_task_file(file)
@@ -107,6 +108,8 @@ module Kdeploy
       return hosts unless limit
 
       host_names = limit.split(',').map(&:strip)
+      unknown = host_names.reject { |name| hosts.key?(name) }
+      warn "Warning: --limit ignored unknown host(s): #{unknown.join(', ')}" if unknown.any?
       hosts.slice(*host_names)
     end
 
@@ -149,7 +152,7 @@ module Kdeploy
     end
 
     def print_host_result(host, result, formatter)
-      if %i[success changed].include?(result[:status])
+      if %i[success].include?(result[:status])
         print_success_result(host, result, formatter)
       else
         print_failure_result(host, result, formatter)
@@ -225,19 +228,31 @@ module Kdeploy
     end
 
     def determine_tasks(task_name)
-      task_name ? [task_name.to_sym] : self.class.kdeploy_tasks.keys
+      if task_name
+        sym = task_name.to_sym
+        raise TaskNotFoundError, task_name unless self.class.kdeploy_tasks.key?(sym)
+
+        [sym]
+      else
+        self.class.kdeploy_tasks.keys
+      end
     end
 
     def execute_tasks(tasks_to_run)
       all_results = {}
+      @task_errors = false
+
+      if tasks_to_run.empty?
+        puts Kdeploy::Banner.show_error('No tasks defined in task file')
+        @task_errors = true
+        return all_results
+      end
 
       tasks_to_run.each do |task|
         task_results = execute_single_task(task)
-        # Collect results for final summary
         all_results[task] = task_results if task_results
 
-        # Stop executing remaining tasks once any host failed for this task.
-        break if task_failed?(task_results)
+        break if task_failed?(task_results) || @task_errors
       end
 
       # Show combined summary at the end for all tasks
@@ -252,6 +267,8 @@ module Kdeploy
 
       if hosts.empty?
         puts Kdeploy::Banner.show_error("No hosts found for task: #{task}")
+        puts 'This usually means no hosts matched the task configuration or --limit filter.'
+        @task_errors = true
         return nil
       end
 
@@ -323,10 +340,9 @@ module Kdeploy
       all_hosts = {}
       all_results.each do |task_name, task_results|
         task_results.each do |host, result|
-          all_hosts[host] ||= { ok: 0, changed: 0, failed: 0, tasks: [] }
+          all_hosts[host] ||= { ok: 0, failed: 0, tasks: [] }
           counts = formatter.calculate_summary_counts(result)
           all_hosts[host][:ok] += counts[:ok]
-          all_hosts[host][:changed] += counts[:changed]
           all_hosts[host][:failed] += counts[:failed]
           all_hosts[host][:tasks] << task_name
         end

data/lib/kdeploy/config/configuration.rb

@@ -56,6 +56,22 @@ module Kdeploy
         nil
       end
 
+      # Load config for execute: CWD walk-up, then task file dir (overrides), then env vars.
+      def load_for_execute(task_dir: nil, cwd: Dir.pwd)
+        reset
+        load_from_file(find_config_file(cwd))
+        load_from_file(find_config_file(task_dir)) if task_dir
+        apply_env_overrides
+      end
+
+      def apply_env_overrides
+        parallel = positive_int_env('KDEPLOY_PARALLEL')
+        @default_parallel = parallel if parallel
+
+        ssh_timeout = positive_int_env('KDEPLOY_SSH_TIMEOUT')
+        @default_ssh_timeout = ssh_timeout if ssh_timeout
+      end
+
       def find_config_file(start_dir = Dir.pwd)
         current_dir = File.expand_path(start_dir)
 
@@ -90,6 +106,14 @@ module Kdeploy
         @default_sync_parallel = config['sync_parallel'] if config.key?('sync_parallel')
       end
 
+      def positive_int_env(key)
+        raw = ENV.fetch(key, nil)
+        return nil if raw.nil? || raw.to_s.strip.empty?
+
+        value = raw.to_i
+        value.positive? ? value : nil
+      end
+
       def parse_verify_host_key(value)
         case value
         when true, 'true', 'yes', 'always'

data/lib/kdeploy/output/output_formatter.rb

@@ -18,7 +18,6 @@ module Kdeploy
     def format_host_status(host, status)
       status_str = case status
                    when :success then @pastel.green('✓ ok')
-                   when :changed then @pastel.yellow('~ changed')
                    else @pastel.red('✗ failed')
                    end
       @pastel.bright_white("  #{host.ljust(20)} #{status_str}")
@@ -101,21 +100,18 @@ module Kdeploy
     end
 
     def calculate_summary_counts(result)
-      ok = %i[success changed].include?(result[:status]) ? result[:output].size : 0
+      ok = result[:status] == :success ? result[:output].size : 0
       failed = result[:status] == :failed ? 1 : 0
-      changed = result[:status] == :changed ? result[:output].size : 0
-      { ok: ok, failed: failed, changed: changed }
+      { ok: ok, failed: failed }
     end
 
     def build_summary_line(host, counts, max_host_len)
       ok_w = 7
-      changed_w = 11
       failed_w = 10
 
       ok_str = @pastel.green("ok=#{counts[:ok].to_s.ljust(ok_w - 3)}")
-      changed_str = @pastel.yellow("changed=#{counts[:changed].to_s.ljust(changed_w - 8)}")
       failed_str = @pastel.red("failed=#{counts[:failed].to_s.ljust(failed_w - 7)}")
-      "#{host.ljust(max_host_len)} : #{ok_str}  #{changed_str}  #{failed_str}"
+      "#{host.ljust(max_host_len)} : #{ok_str}  #{failed_str}"
     end
 
     def colorize_summary_line(line, counts)

data/lib/kdeploy/runner/runner.rb

@@ -11,8 +11,7 @@ module Kdeploy
                    retry_on_nonzero: Configuration.default_retry_on_nonzero,
                    host_timeout: Configuration.default_host_timeout,
                    step_timeout: Configuration.default_step_timeout,
-                   retry_policy: Configuration.default_retry_policy,
-                   on_step: nil)
+                   retry_policy: Configuration.default_retry_policy)
       @hosts = hosts
       @tasks = tasks
       @parallel = parallel
@@ -25,7 +24,6 @@ module Kdeploy
       @host_timeout = normalize_timeout(host_timeout)
       @step_timeout = normalize_timeout(step_timeout)
       @retry_policy = retry_policy
-      @on_step = on_step
       @pool = Concurrent::FixedThreadPool.new(@parallel)
       @results = Concurrent::Hash.new
     end
@@ -67,6 +65,7 @@ module Kdeploy
             pending.delete(future)
             progressed = true
           elsif timeout_exceeded?(started_at, now)
+            future.cancel if future.respond_to?(:cancel)
             @results[host_name] ||= {
               status: :failed,
               error: "execution timeout after #{@host_timeout}s",
@@ -132,7 +131,6 @@ module Kdeploy
       commands.each do |command|
         step_result = execute_command(command_executor, command, name)
         result[:output] << step_result
-        emit_step(name, step_result, result, task_name)
       rescue StandardError => e
         step = step_description(command)
         result[:status] = :failed
@@ -144,7 +142,6 @@ module Kdeploy
           error: "#{e.class}: #{e.message}",
           output: error_output_for_step(e)
         }
-        emit_step(name, result[:output].last, result, task_name)
         break
       end
     end
@@ -218,15 +215,6 @@ module Kdeploy
       end
     end
 
-    def emit_step(host_name, step_result, result, task_name)
-      return unless @on_step
-
-      @on_step.call(host_name, step_result, result, task_name)
-    rescue StandardError
-      # Best-effort only; never fail execution because of streaming hooks.
-      nil
-    end
-
     def execute_command(command_executor, command, host_name)
       case command[:type]
       when :run

data/lib/kdeploy/version.rb

@@ -2,5 +2,5 @@
 
 # Kdeploy module for version management
 module Kdeploy
-  VERSION = '1.3.3' unless const_defined?(:VERSION)
+  VERSION = '1.3.5' unless const_defined?(:VERSION)
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kdeploy
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.5
 platform: ruby
 authors:
 - Kk
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-04-15 00:00:00.000000000 Z
+date: 2026-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bcrypt_pbkdf
@@ -160,7 +160,6 @@ extensions:
 - ext/mkrf_conf.rb
 extra_rdoc_files: []
 files:
-- AGENTS.md
 - README.md
 - README_EN.md
 - exe/kdeploy

data/AGENTS.md

@@ -1,18 +0,0 @@
-<!-- OPENSPEC:START -->
-# OpenSpec Instructions
-
-These instructions are for AI assistants working in this project.
-
-Always open `@/openspec/AGENTS.md` when the request:
-- Mentions planning or proposals (words like proposal, spec, change, plan)
-- Introduces new capabilities, breaking changes, architecture shifts, or big performance/security work
-- Sounds ambiguous and you need the authoritative spec before coding
-
-Use `@/openspec/AGENTS.md` to learn:
-- How to create and apply change proposals
-- Spec format and conventions
-- Project structure and guidelines
-
-Keep this managed block so 'openspec update' can refresh the instructions.
-
-<!-- OPENSPEC:END -->