kdep 0.3.5 → 0.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2f2546356a99516a639dc29b0d25a6494898c351a2dd40ca58a3510da93aa49d
-  data.tar.gz: ea992fe366d4d6875b1edf6d976d2c8ece688854d76dfd12ab87031c85ffda6d
+  metadata.gz: 8194d84a25eda1737a9bdab8891db08ec092cfc71c86764fac24ff044b977626
+  data.tar.gz: d247a4155dea0105240416bf2af475d5a7e22b71917467f230bc13123d4c79b5
 SHA512:
-  metadata.gz: 122d63cdabc4fda2ff9f7f52f546dc5288d26209ec9f7025ee93cbdd0109e4de094e37af1b5073266b6b5a5d939ca15fcd65004dc79c5eda286709bc4fb059d3
-  data.tar.gz: 2aee7b30512d9102f86bf1150b6ee5054f741497bc4009784dbaf38f2d2f222ae6b8c3a2249090c3a9dad5a31fcdf013c8c753e7f07dd761051ccc189e0450f8
+  metadata.gz: e3fb390e4470e4daf795717de1cac5c32142eb208dc58e529eabccba079bfeb2dd737ee74ad92ea92a675298911091dbd52ea007f9c38cbc8e624ea8d0bbf13d
+  data.tar.gz: 36e1bc46602c74aa2027e0c4377b951d0602ce24ca05470f2f0a989fe6266288da5017f3f45e91d3923efe1e884830709718a7b75aa5db8fa3c3408e20f8e2a4

data/lib/kdep/commands/bump.rb

@@ -44,7 +44,24 @@ module Kdep
 
         config = Kdep::Config.new(deploy_dir, env).load
 
-        # Step 2: Context guard (bump touches the cluster)
+        # Step 2: Local config sanity — read state.yml BEFORE touching the
+        # cluster. A missing/corrupt state.yml is a local config error and
+        # should fail fast without waking kubectl.
+        begin
+          current_tag = Kdep::State.tag(deploy_dir) || handle_missing_state(deploy_dir)
+        rescue Kdep::State::Error => e
+          @ui.error(e.message)
+          exit 1
+        end
+        # to_fix.md #3 — warn if someone has gitignored state.yml
+        require "kdep/doctor/check_state_gitignored"
+        gitignore_result = Kdep::Doctor::CheckStateGitignored.new(deploy_dir).run
+        if gitignore_result.severity == :error
+          @ui.warn(gitignore_result.message)
+          @ui.warn(gitignore_result.hint) if gitignore_result.hint
+        end
+
+        # Step 3: Context guard (bump touches the cluster)
         begin
           Kdep::ContextGuard.new(config["context"]).validate!
         rescue Kdep::Kubectl::Error => e
@@ -64,20 +81,7 @@ module Kdep
         repo_root = File.dirname(kdep_dir)
 
         begin
-          # Step 3: Read current tag from state.yml, increment minor
-          begin
-            current_tag = Kdep::State.tag(deploy_dir) || handle_missing_state(deploy_dir)
-          rescue Kdep::State::Error => e
-            @ui.error(e.message)
-            exit 1
-          end
-          # to_fix.md #3 — warn if someone has gitignored state.yml
-          require "kdep/doctor/check_state_gitignored"
-          gitignore_result = Kdep::Doctor::CheckStateGitignored.new(deploy_dir).run
-          if gitignore_result.severity == :error
-            @ui.warn(gitignore_result.message)
-            @ui.warn(gitignore_result.hint) if gitignore_result.hint
-          end
+          # Step 4: Increment minor version.
           parsed = Kdep::VersionTagger.parse(current_tag)
           next_version = parsed ? "#{parsed[0]}.#{parsed[1] + 1}" : "0.1"
           @ui.info("#{current_tag} -> #{next_version}")

data/lib/kdep/doctor/check_state_gitignored.rb

@@ -8,12 +8,14 @@ module Kdep
 
       def run
         state_path = File.join(deploy_dir, Kdep::State::FILENAME)
-        _, status = Open3.capture2("git", "check-ignore", "-q", state_path)
+        # capture3 swallows stderr so "fatal: not a git repository" noise
+        # never reaches the user when the caller runs outside a repo.
+        _, _, status = Open3.capture3("git", "check-ignore", "-q", state_path)
         if status.success?
           Result.new(
             id: ID, severity: :error,
             message: "#{state_path} is gitignored",
-            hint: "Remove 'state.yml' from .gitignore and 'git add' the file so fresh clones see the last-deployed tag."
+            hint: "Remove 'state.yml' from any .gitignore (local or ancestor) and 'git add' the file so fresh clones see the last-deployed tag."
           )
         else
           Result.ok(ID)

data/lib/kdep/doctor.rb

@@ -5,7 +5,6 @@ require "kdep/doctor/check_state_parseable"
 require "kdep/doctor/check_state_tag_format"
 require "kdep/doctor/check_state_gitignored"
 require "kdep/doctor/check_gitignore_canonical"
-require "kdep/doctor/check_ancestor_ignores_state"
 
 module Kdep
   module Doctor
@@ -15,7 +14,6 @@ module Kdep
       CheckStateTagFormat,
       CheckStateGitignored,
       CheckGitignoreCanonical,
-      CheckAncestorIgnoresState,
     ].freeze
   end
 end

data/lib/kdep/old_format.rb

@@ -261,14 +261,20 @@ module Kdep
     # Extract the image tag from the live deploy (e.g., "0.44" from
     # "ghcr.io/org/app:0.44"). Returns nil if the tag is "latest",
     # empty, or absent. On multi-container deployments, returns the
-    # first usable tag found.
+    # first usable tag found. Uses rpartition so registry URLs with
+    # explicit ports (host:5000/org/app:0.44) aren't misparsed.
     def extracted_tag
       deployed_images.each do |img|
-        parts = img.to_s.split(":", 2)
-        next if parts.length < 2
-        tag = parts[1]
-        next if tag.nil? || tag.empty? || tag == "latest"
-        return tag
+        before, sep, after = img.to_s.rpartition(":")
+        # rpartition returns ["", "", img] when no ":" exists
+        next if sep.empty?
+        # A host:port with no tag (e.g. "host:5000/img") has sep but the
+        # "tag" part contains a "/" — not a real tag.
+        next if after.empty? || after.include?("/")
+        next if after == "latest"
+        # before will include any host:port prefix intact
+        _ = before
+        return after
       end
       nil
     end

data/lib/kdep/version.rb

@@ -1,3 +1,3 @@
 module Kdep
-  VERSION = "0.3.5"
+  VERSION = "0.3.6"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kdep
 version: !ruby/object:Gem::Version
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors:
 - Leadfy
@@ -98,7 +98,6 @@ files:
 - lib/kdep/docker.rb
 - lib/kdep/doctor.rb
 - lib/kdep/doctor/check.rb
-- lib/kdep/doctor/check_ancestor_ignores_state.rb
 - lib/kdep/doctor/check_gitignore_canonical.rb
 - lib/kdep/doctor/check_state_gitignored.rb
 - lib/kdep/doctor/check_state_parseable.rb

data/lib/kdep/doctor/check_ancestor_ignores_state.rb

@@ -1,26 +0,0 @@
-require "open3"
-require "kdep/state"
-
-module Kdep
-  module Doctor
-    class CheckAncestorIgnoresState < Check
-      ID = "ancestor_ignores_state".freeze
-
-      def run
-        state_path = File.join(deploy_dir, Kdep::State::FILENAME)
-        _, status = Open3.capture2("git", "check-ignore", "-v", state_path)
-        if status.success?
-          Result.new(
-            id: ID, severity: :error,
-            message: "An ancestor .gitignore is ignoring #{state_path}",
-            hint: "Run 'git check-ignore -v #{state_path}' to find which file, then remove the pattern."
-          )
-        else
-          Result.ok(ID)
-        end
-      rescue Errno::ENOENT
-        Result.ok(ID)
-      end
-    end
-  end
-end