kaze_client 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f04fc270f92f58f489ff092c78adb05ec7d8d241277d2294e1d7d88ddd47e5ef
-  data.tar.gz: 69a336ea1b82c2a97c6a079a70220a625dfd48da3a3223a637e8c3d4a1e3bde3
+  metadata.gz: 483e914296f78875d5a5eb30e3207f7f99d8db4c7bfddbc8440f3983e99f5605
+  data.tar.gz: ebb0a204c158f59fa6cdde4d04573b1beaeaa94b07f86b8b7815ce59c9e40ca0
 SHA512:
-  metadata.gz: 44e207d6ccb69a208c5273d63e62615d113c0a8b0cf2bcd5020e5b977312ca79125740e29746e2375b18f32c5cdbfe0c70289e3c261e0f5b64c3fefcbd070468
-  data.tar.gz: bb1088a6628adca37f824660306ea5d4053f86df96f453fea12b02893f37c53e229fb3f7de1d0698cc15fd17d0a8ec4788037327315fb4c599e38462b6d874b6
+  metadata.gz: c3006d994cb61c5b180449f58dce770ddb7f12cf3636cb3247b2b669f7ea387b3d4a71085645a1671d0aea0e298ba1f28db984227dbcc5c9d1e39809041ba0b7
+  data.tar.gz: a96e0bcd0089c80c89bed0573ff829d62e727f5b3e4d6de0b87b0a6b3158cb17bb1c5344fbd35bca8a52ced6b9466024365e004dc02fc704005e662a8b34615d

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# CHANGELOG
+
+## [0.3.1] - 2022-11-30
+
+- Update error handling for more clarity.
+
 ## [0.3.0] - 2022-09-28
 
 - Add new requests:

data/lib/kaze_client/request/request.rb

@@ -10,7 +10,7 @@ module KazeClient
     # Those headers are added on all requests by default
     DEFAULT_HEADERS = {
       'Content-Type' => 'application/json',
-      'Accept' => 'application/json'
+      'Accept'       => 'application/json'
     }.freeze
 
     # @return [String, Symbol] The HTTP verb to use for the request
@@ -64,19 +64,12 @@ module KazeClient
     # @param response [HTTParty::Response] The response object from HTTParty call
     # @return [KazeClient::Error::Generic] The adequate error object according to the given response
     def error_for(response)
-      # Not found is handled in a specific way since there is no message key and the error has a
-      # specific format
-      return KazeClient::Error::NotFound.new if response.code == 404
+      error   = response.parsed_response['error']
+      message = response.parsed_response['message']
 
-      # Return the adequate error class for the error code in the response
-      "KazeClient::Error::#{response.parsed_response['error'].camelize}"
-        .constantize.new(response.parsed_response['message'])
-    rescue NameError
-      # This means no error class exists for the error code in the response, we fallback to a
-      # generic error
-      Error::Generic.new(status: response.code,
-                         error: response.parsed_response['error'],
-                         message: response.parsed_response['message'])
+      return non_generic_error(error, message, response) if error != 'generic'
+
+      generic_http_error(error, message, response)
     end
 
     protected
@@ -100,6 +93,8 @@ module KazeClient
         @body
       when Hash
         @body.to_json
+      else
+        @body.to_s
       end
     end
 
@@ -109,5 +104,30 @@ module KazeClient
 
       @query
     end
+
+    def non_generic_error(error, message, response)
+      # Return the adequate error class for the error code in the response
+      "KazeClient::Error::#{error.camelize}".constantize.new(message)
+    rescue NameError
+      # This means no error class exists for the error code in the response, we fallback to a
+      # generic error
+      Error::Generic.new(status: response.code, error: error, message: message)
+    end
+
+    def generic_http_error(error, message, response)
+      case response.code
+      when 401
+        KazeClient::Error::Unauthorized.new(message)
+      when 403
+        KazeClient::Error::Forbidden.new(message)
+      when 404
+        KazeClient::Error::NotFound.new
+      when 500
+        KazeClient::Error::InternalServerError.new(message)
+      else
+        # This means no error class exists for the response code, we fallback to a generic error
+        Error::Generic.new(status: response.code, error: error, message: message)
+      end
+    end
   end
 end

data/lib/kaze_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module KazeClient
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kaze_client
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Matthieu Ciappara
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-09-28 00:00:00.000000000 Z
+date: 2022-11-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty