katello 4.8.0.rc1 → 4.8.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c4b8d6a07335f66fa2aa32144b730a13949137d827c6df5d6418d732f3c16ffb
-  data.tar.gz: 8b38219d487f142d85e53a53f0c839e021b31edfca2b3ba71cd789dee1e1d378
+  metadata.gz: 623f96f2d316d946b9a19bbed0bd70a58c56541dfcde05261848efb7f868881d
+  data.tar.gz: f39b3c6dca68f3b742f6a09fb5a821ab5e9d11128835023f09a5a8df30a27272
 SHA512:
-  metadata.gz: c7a5a28b77b887eafbef71455fa92c9321c031bd986d76b4fa0a70609031aaebea564363463c96b354cbe4efd44c377ee4aa7b564f9b2e4e2a0a099923bff26e
-  data.tar.gz: 7e951a7f6782c464d0cf07f0a7fbdfcfbe8b273680e89cb49bfff44cc7ee136c4c76268c86f316f7e0a80e109011f23b7bc2a5646ac8f3c7997560d9b803516f
+  metadata.gz: 3d4e46aa5cdededbea344d58cc4dd5c43c1fcdd480e5a62594a1bf0892ff80c048e07a3a7460646b2778502849cc58d7ab6f8f22aaeb1ce3fd0ea8aa59f844c7
+  data.tar.gz: 97fa1540ab108458032dc4a4963b9644af0a6c7207079bf2c3ef2cc895cacab6521eec73e4ed4aadc2eaf8428fc3b2d5b7bec489a03f02a2d972310344b7c07f

data/app/controllers/katello/api/registry/registry_proxies_controller.rb

@@ -161,25 +161,9 @@ module Katello
       end
 
       if (manifest_response = redirect_client { Resources::Registry::Proxy.get(@_request.fullpath, headers) })
-        #for some requests, we get a redirect, but for others we get the actual manifest in response
-        results = JSON.parse(manifest_response)
         response.header['Docker-Content-Digest'] = manifest_response.headers[:docker_content_digest]
-        # https://docs.docker.com/registry/spec/manifest-v2-2/
-        # If its v2 schema 2 only the mediaType attribute will be present in the manifest
-        media_type = results['mediaType']
-        if media_type.blank?
-          # so mediaType is not schema2 v2 only set the mediaType based on
-          # https://docs.docker.com/registry/spec/manifest-v2-1/
-          media_type = if results["signatures"].blank?
-                         'application/vnd.docker.distribution.manifest.v1+json'
-                       else
-                         'application/vnd.docker.distribution.manifest.v1+prettyjws'
-                       end
-        end
-        response.headers['Content-Type'] = media_type
-        length = manifest_response.try(:body).try(:size)
-        length ||= 0
-        response.header['Content-Length'] = "#{length}"
+        response.headers['Content-Type'] = manifest_response.headers[:content_type]
+        response.header['Content-Length'] = manifest_response.headers[:content_length]
         render json: manifest_response
       end
     end

data/app/controllers/katello/api/v2/alternate_content_sources_controller.rb

@@ -70,7 +70,6 @@ module Katello
     param_group :acs
     def create
       @alternate_content_source = ::Katello::AlternateContentSource.new(acs_params.except(:smart_proxy_ids, :smart_proxy_names, :product_ids))
-      @alternate_content_source.verify_ssl = nil if @alternate_content_source.simplified?
       sync_task(::Actions::Katello::AlternateContentSource::Create, @alternate_content_source, @smart_proxies, @products)
       @alternate_content_source.reload
       respond_for_create(resource: @alternate_content_source)
@@ -88,7 +87,6 @@ module Katello
       else
         find_smart_proxies
       end
-
       if params[:product_ids].nil?
         @products = @alternate_content_source.products
       elsif params[:product_ids] == []
@@ -96,6 +94,7 @@ module Katello
       else
         find_products
       end
+
       sync_task(::Actions::Katello::AlternateContentSource::Update, @alternate_content_source, @smart_proxies, @products, acs_params.except(:smart_proxy_ids, :smart_proxy_names, :product_ids))
       respond_for_show(:resource => @alternate_content_source)
     end
@@ -117,9 +116,12 @@ module Katello
     protected
 
     def acs_params
-      keys = [:name, :label, :description, {smart_proxy_ids: []}, {smart_proxy_names: []}, :content_type, :alternate_content_source_type, :use_http_proxies]
-      keys += [:base_url, {subpaths: []}, :upstream_username, :upstream_password, :ssl_ca_cert_id, :ssl_client_cert_id, :ssl_client_key_id, :verify_ssl] if params[:action] == 'create' || @alternate_content_source&.custom? || @alternate_content_source&.rhui?
-      keys += [{product_ids: []}] if params[:action] == 'create' || @alternate_content_source&.simplified?
+      keys = [
+        :name, :label, :description, {smart_proxy_ids: []}, {smart_proxy_names: []}, :content_type,
+        :alternate_content_source_type, :use_http_proxies, :base_url, {subpaths: []}, :upstream_username,
+        :upstream_password, :ssl_ca_cert_id, :ssl_client_cert_id, :ssl_client_key_id, :verify_ssl, {product_ids: []}
+      ]
+
       params.require(:alternate_content_source).permit(*keys).to_h.with_indifferent_access
     end
 

data/app/controllers/katello/api/v2/repositories_controller.rb

@@ -7,7 +7,7 @@ module Katello
       generic_repo_wrap_params << option.name
     end
 
-    repo_wrap_params = RootRepository.attribute_names + [:mirror_on_sync] + generic_repo_wrap_params
+    repo_wrap_params = RootRepository.attribute_names + generic_repo_wrap_params
 
     wrap_parameters :repository, :include => repo_wrap_params
 
@@ -55,7 +55,6 @@ module Katello
       param :exclude_tags, Array, :desc => N_("Comma-separated list of tags to exclude when syncing a container image repository. Default: any tag ending in \"-source\"")
       param :download_policy, ["immediate", "on_demand"], :desc => N_("download policy for yum, deb, and docker repos (either 'immediate' or 'on_demand')")
       param :download_concurrency, :number, :desc => N_("Used to determine download concurrency of the repository in pulp3. Use value less than 20. Defaults to 10")
-      param :mirror_on_sync, :bool, :desc => N_("true if this repository when synced has to be mirrored from the source and stale rpms removed (Deprecated)")
       param :mirroring_policy, Katello::RootRepository::MIRRORING_POLICIES, :desc => N_("Policy to set for mirroring content.  Must be one of %s.") % RootRepository::MIRRORING_POLICIES
       param :verify_ssl_on_sync, :bool, :desc => N_("if true, Katello will verify the upstream url's SSL certifcates are signed by a trusted CA")
       param :upstream_username, String, :desc => N_("Username of the upstream repository user used for authentication")
@@ -580,7 +579,7 @@ module Katello
 
     # rubocop:disable Metrics/CyclomaticComplexity
     def repository_params
-      keys = [:download_policy, :mirror_on_sync, :mirroring_policy, :sync_policy, :arch, :verify_ssl_on_sync, :upstream_password,
+      keys = [:download_policy, :mirroring_policy, :sync_policy, :arch, :verify_ssl_on_sync, :upstream_password,
               :upstream_username, :download_concurrency, :upstream_authentication_token,
               {:os_versions => []}, :deb_releases, :deb_components, :deb_architectures, :description,
               :http_proxy_policy, :http_proxy_id, :retain_package_versions_count, {:ignorable_content => []}
@@ -604,8 +603,7 @@ module Katello
         keys += [:url, :gpg_key_id, :ssl_ca_cert_id, :ssl_client_cert_id, :ssl_client_key_id, :unprotected, :name,
                  :checksum_type]
       end
-      to_return = params.require(:repository).permit(*keys).to_h.with_indifferent_access
-      handle_mirror_on_sync(to_return)
+      params.require(:repository).permit(*keys).to_h.with_indifferent_access
     end
 
     def get_content_credential(repo_params, content_type)
@@ -664,19 +662,6 @@ module Katello
     end
     # rubocop:enable Metrics/CyclomaticComplexity,Metrics/MethodLength
 
-    def handle_mirror_on_sync(repo_params)
-      if !repo_params.key?(:mirroring_policy) && repo_params.key?(:mirror_on_sync)
-        ::Foreman::Deprecation.api_deprecation_warning("mirror_on_sync is deprecated in favor of mirroring_policy.  It will be removed in Katello 4.8.")
-        if ::Foreman::Cast.to_bool(repo_params[:mirror_on_sync])
-          repo_params[:mirroring_policy] = Katello::RootRepository::MIRRORING_POLICY_CONTENT
-        else
-          repo_params[:mirroring_policy] = Katello::RootRepository::MIRRORING_POLICY_ADDITIVE
-        end
-      end
-      repo_params.delete(:mirror_on_sync)
-      repo_params
-    end
-
     def error_on_rh_product
       fail HttpErrors::BadRequest, _("Red Hat products cannot be manipulated.") if @product.redhat?
     end

data/app/helpers/katello/hosts_and_hostgroups_helper.rb

@@ -212,10 +212,13 @@ module Katello
           new_host.content_facet = hostgroup_content_facet(host, param_host)
         elsif host.content_facet.present?
           new_host.content_facet = ::Katello::Host::ContentFacet.new(:content_source_id => host.content_source_id)
-          new_host.content_facet.assign_single_environment(
-            :lifecycle_environment => host.content_facet.single_lifecycle_environment,
-            :content_view => host.content_facet.single_content_view
-          )
+          if host.single_content_view_environment?
+            # assign new_host the same CVE as host
+            new_host.content_facet.assign_single_environment(
+              :lifecycle_environment => host.content_facet.single_lifecycle_environment,
+              :content_view => host.content_facet.single_content_view
+            )
+          end
         end
         new_host.operatingsystem.kickstart_repos(new_host).map { |repo| OpenStruct.new(repo) }
       else
@@ -344,10 +347,12 @@ module Katello
       lifecycle_environment_id, content_view_id = inherited_or_own_facet_attributes(param_host, hostgroup)
       content_source_id = inherited_or_own_content_source_id(param_host, hostgroup)
       facet = ::Katello::Host::ContentFacet.new(:content_source_id => content_source_id)
-      facet.assign_single_environment(
-        :lifecycle_environment_id => lifecycle_environment_id,
-        :content_view_id => content_view_id
-      )
+      if content_view_id && lifecycle_environment_id
+        facet.assign_single_environment(
+          :lifecycle_environment_id => lifecycle_environment_id,
+          :content_view_id => content_view_id
+        )
+      end
       facet
     end
   end

data/app/lib/actions/katello/alternate_content_source/create.rb

@@ -7,7 +7,9 @@ module Actions
         def plan(acs, smart_proxies, products = nil)
           acs.save!
           action_subject(acs)
-          acs.products << products if products.present?
+          if products.present?
+            acs.update!(products: products)
+          end
           smart_proxies = smart_proxies.present? ? smart_proxies.uniq : []
           concurrence do
             smart_proxies.each do |smart_proxy|

data/app/lib/actions/katello/alternate_content_source/update.rb

@@ -19,7 +19,7 @@ module Actions
           products_to_associate = []
           products_to_disassociate = []
 
-          if acs.simplified?
+          if products.present? || acs.products.present?
             products = products.uniq
             products_to_associate = products - acs.products
             products_to_disassociate = acs.products - products
@@ -28,6 +28,8 @@ module Actions
             acs.audit_updated_products(old_product_ids) unless products_to_associate.empty? && products_to_disassociate.empty?
           end
 
+          acs.save!
+
           concurrence do
             create_acss(acs, smart_proxies_to_associate)
             delete_acss(acs, smart_proxies_to_disassociate)

data/app/lib/actions/pulp3/orchestration/content_view_version/copy_version_units_to_library.rb

@@ -13,7 +13,7 @@ module Actions
                                                     mirror: content_view_version.content_view.generated?)
                   plan_action(Actions::Pulp3::Repository::SaveVersion, repo.library_instance)
                   plan_action(Katello::Repository::IndexContent, id: repo.library_instance_id)
-                  plan_action(Katello::Repository::MetadataGenerate, repo.library_instance, :force => true)
+                  plan_action(Katello::Repository::MetadataGenerate, repo.library_instance, force_publication: true)
                 end
               end
             end

data/app/lib/actions/pulp3/orchestration/content_view_version/export.rb

@@ -17,12 +17,23 @@ module Actions
             param :exported_file_checksum, Hash
             param :export_path, String
           end
+
           def plan(content_view_version:, destination_server: nil,
                    chunk_size: nil, from_history: nil,
                    validate_incremental: true,
                    fail_on_missing_content: false,
                    format: ::Katello::Pulp3::ContentViewVersion::Export::IMPORTABLE)
             smart_proxy = SmartProxy.pulp_primary!
+            from_content_view_version = from_history&.content_view_version
+            export_service = ::Katello::Pulp3::ContentViewVersion::Export.create(
+                smart_proxy: smart_proxy,
+                content_view_version: content_view_version,
+                destination_server: destination_server,
+                from_content_view_version: from_content_view_version,
+                format: format)
+            export_service.validate!(fail_on_missing_content: fail_on_missing_content,
+                                     validate_incremental: validate_incremental,
+                                     chunk_size: chunk_size)
 
             if format == ::Katello::Pulp3::ContentViewVersion::Export::SYNCABLE
               sequence do
@@ -38,17 +49,6 @@ module Actions
             end
 
             sequence do
-              from_content_view_version = from_history&.content_view_version
-              export_service = ::Katello::Pulp3::ContentViewVersion::Export.create(
-                  smart_proxy: smart_proxy,
-                  content_view_version: content_view_version,
-                  destination_server: destination_server,
-                  from_content_view_version: from_content_view_version,
-                  format: format)
-              export_service.validate!(fail_on_missing_content: fail_on_missing_content,
-                                       validate_incremental: validate_incremental,
-                                       chunk_size: chunk_size)
-
               action_output = plan_action(::Actions::Pulp3::ContentViewVersion::CreateExporter,
                                           content_view_version_id: content_view_version.id,
                                           smart_proxy_id: smart_proxy.id,

data/app/lib/actions/pulp3/orchestration/content_view_version/syncable_export.rb

@@ -18,7 +18,6 @@ module Actions
 
           def plan(content_view_version:,
                    smart_proxy:,
-                   fail_on_missing_content: false,
                    destination_server:,
                    from_content_view_version:)
             format = ::Katello::Pulp3::ContentViewVersion::Export::SYNCABLE
@@ -29,7 +28,6 @@ module Actions
                   from_content_view_version: from_content_view_version,
                   format: format,
                   destination_server: destination_server)
-              export_service.validate!(fail_on_missing_content: fail_on_missing_content)
               base_path = export_service.generate_exporter_path
               export_service.repositories.each do |repository|
                 action_output = plan_action(::Actions::Pulp3::ContentViewVersion::CreateExporter,

data/app/lib/actions/pulp3/repository/reclaim_space.rb

@@ -4,7 +4,7 @@ module Actions
       class ReclaimSpace < Pulp3::AbstractAsyncTask
         def plan(repo, smart_proxy = SmartProxy.pulp_primary)
           action_subject(repo)
-          repository_hrefs = ::Katello::Pulp3::RepositoryReference.default_cv_repository_hrefs([repo], Organization.current || repositories.first.organization)
+          repository_hrefs = ::Katello::Pulp3::RepositoryReference.default_cv_repository_hrefs([repo], repo.organization)
           plan_self(repository_hrefs: repository_hrefs, smart_proxy_id: smart_proxy.id)
         end
 

data/app/lib/katello/api/v2/error_handling.rb

@@ -21,6 +21,7 @@ module Katello
           rescue_from Errors::UnsupportedActionException, :with => :rescue_from_unsupported_action_exception
           rescue_from Errors::MaxHostsReachedException, :with => :rescue_from_max_hosts_reached_exception
           rescue_from Errors::CdnSubstitutionError, :with => :rescue_from_bad_data
+          rescue_from Katello::Pulp3::ContentViewVersion::ExportValidationError, :with => :rescue_from_export_validation_error
           rescue_from Errors::RegistrationError, :with => :rescue_from_bad_data
           rescue_from ActionController::ParameterMissing, :with => :rescue_from_missing_param
           rescue_from ::ForemanTasks::Lock::LockConflict, :with => :rescue_from_bad_data
@@ -85,6 +86,10 @@ module Katello
           respond_for_exception(exception, :status => :conflict, :with_logging => false)
         end
 
+        def rescue_from_export_validation_error(exception)
+          respond_for_exception(exception, :force_json => true, :status => :unprocessable_entity)
+        end
+
         def rescue_from_conflict_exception(exception)
           respond_for_exception(exception, :status => :conflict)
         end
@@ -122,11 +127,16 @@ module Katello
           options[:errors] = exception.try(:record).try(:errors) || [exception.message]
 
           logger.error pp_exception(exception) if options[:with_logging]
-
           respond_to do |format|
             #json has to be displayMessage for older RHEL 5.7 subscription managers
             format.json { render :json => { :displayMessage => options[:display_message], :errors => options[:errors]}, :status => options[:status] }
-            format.all { render :plain => options[:text], :status => options[:status] }
+            format.all do
+              if options[:force_json]
+                render :json => { :displayMessage => options[:display_message], :errors => options[:errors]}, :status => options[:status]
+              else
+                render :plain => options[:text], :status => options[:status]
+              end
+            end
           end
         end
 

data/app/lib/katello/concerns/base_template_scope_extensions.rb

@@ -240,14 +240,17 @@ module Katello
           seen_host_ids &= only_host_ids if only_host_ids
 
           # preload errata in one query for this batch
-          preloaded_errata = Katello::Erratum.where(:errata_id => seen_errata_ids).pluck(:errata_id, :errata_type)
+          preloaded_errata = Katello::Erratum.where(:errata_id => seen_errata_ids).pluck(:errata_id, :errata_type, :issued)
           preloaded_hosts = ::Host.where(:id => seen_host_ids).includes(:reported_data)
 
           batch.each do |task|
             next if skip_task?(task)
-            next unless only_host_ids.nil? || only_host_ids.include?(task.input['host']['id'].to_i)
+            next unless only_host_ids.nil? || only_host_ids.include?(get_task_input(task)['host']['id'].to_i)
             parse_errata(task).each do |erratum_id|
-              current_erratum_errata_type = preloaded_errata.find { |k, _| k == erratum_id }.last
+              current_erratum = preloaded_errata.find { |k, _| k == erratum_id }
+              next if current_erratum.nil?
+              current_erratum_errata_type = current_erratum[1]
+              current_erratum_issued = current_erratum.last
 
               if filter_errata_type != 'all'
                 next unless filter_errata_type == current_erratum_errata_type
@@ -258,6 +261,7 @@ module Katello
                 :hostname => get_task_input(task)['host']['name'],
                 :erratum_id => erratum_id,
                 :erratum_type => current_erratum_errata_type,
+                :issued => current_erratum_issued,
                 :status => task.result
               }
 

data/app/models/katello/alternate_content_source.rb

@@ -19,6 +19,9 @@ module Katello
     belongs_to :ssl_ca_cert, inverse_of: :ssl_ca_alternate_content_sources, class_name: "Katello::ContentCredential"
     belongs_to :ssl_client_cert, inverse_of: :ssl_client_alternate_content_sources, class_name: "Katello::ContentCredential"
     belongs_to :ssl_client_key, inverse_of: :ssl_key_alternate_content_sources, class_name: "Katello::ContentCredential"
+    # We breakout ssl-* validation into a function to allow for us to set
+    # the object name correctly in complex error messages
+    validate :validate_ssl_ids
 
     has_many :alternate_content_source_products, dependent: :delete_all, inverse_of: :alternate_content_source,
              class_name: "Katello::AlternateContentSourceProduct"
@@ -29,13 +32,21 @@ module Katello
              inverse_of: :alternate_content_source
     has_many :smart_proxies, -> { distinct }, through: :smart_proxy_alternate_content_sources
 
-    validates :base_url, :subpaths, :verify_ssl, :upstream_username,
-              :upstream_password, :ssl_ca_cert, :ssl_client_cert, :ssl_client_key, if: :simplified?, absence: true
+    validates :base_url, :subpaths, :upstream_username,
+              :upstream_password, if: :simplified?, absence: true
     validates :base_url, if: -> { custom? || rhui? }, presence: true
     validates :products, if: -> { custom? || rhui? }, absence: true
     validates :label, :uniqueness => true
     validates :name, :uniqueness => true, presence: true
-    validates :verify_ssl, if: :custom?, exclusion: [nil]
+    # verify ssl must be validated this way due to presence: <bool> failing on a value of false
+    validates :verify_ssl, if: -> { custom? || rhui? }, inclusion: {
+      in: [true, false],
+      message: "can't be blank"
+    }
+    validates :verify_ssl, if: :simplified?, inclusion: {
+      in: [nil],
+      message: "must be blank"
+    }
     validates :alternate_content_source_type, inclusion: {
       in: ->(_) { ACS_TYPES },
       allow_blank: false,
@@ -50,6 +61,7 @@ module Katello
       in: [::Katello::Repository::YUM_TYPE],
       message: "'%{value}' is not valid for RHUI ACS"
     }
+    validate :constraint_acs_update, on: :update
     validates_with Validators::AlternateContentSourcePathValidator, :attributes => [:base_url, :subpaths], :if => :custom?
 
     scope :uses_http_proxies, -> { where(use_http_proxies: true) }
@@ -110,8 +122,46 @@ module Katello
       write_audit(action: 'update', comment: _('Products updated.'), audited_changes: { 'product_ids' => [old_product_ids, product_ids] })
     end
 
-    def self.humanize_class_name
+    def self.humanize_class_name(_name = nil)
       "Alternate Content Sources"
     end
+
+    # Disallow static properties from being modified on update
+    def constraint_acs_update
+      if changes.keys.include? "content_type"
+        errors.add(:content_type, "cannot be modified once an ACS is created")
+      end
+      if changes.keys.include? "alternate_content_source_type"
+        errors.add(:alternate_content_source_type, "cannot be modified once an ACS is created")
+      end
+    end
+
+    # Validate ssl-* ids which require complex/custom error messages
+    def validate_ssl_ids
+      # Simplified ACS's should never have ssl-* params populated
+      if simplified?
+        if changes.keys.include? "ssl_ca_cert_id"
+          errors.add(:ssl_ca_cert, "must be blank")
+        end
+        if changes.keys.include? "ssl_client_cert_id"
+          errors.add(:ssl_client_cert, "must be blank")
+        end
+        if changes.keys.include? "ssl_client_key_id"
+          errors.add(:ssl_client_key, "must be blank")
+        end
+
+      # Custom and RHUI ACS's should have valid keys where populated
+      else
+        if ssl_ca_cert_id.present? && ssl_ca_cert.nil?
+          errors.add(:ssl_ca_cert, "with ID '#{ssl_ca_cert_id}' couldn't be found")
+        end
+        if ssl_client_cert_id.present? && ssl_client_cert.nil?
+          errors.add(:ssl_client_cert, "with ID '#{ssl_client_cert_id}' couldn't be found")
+        end
+        if ssl_client_key_id.present? && ssl_client_key.nil?
+          errors.add(:ssl_client_key, "with ID '#{ssl_client_key_id}' couldn't be found")
+        end
+      end
+    end
   end
 end

data/app/models/katello/concerns/host_managed_extensions.rb

@@ -6,6 +6,20 @@ module Katello
       include ForemanTasks::Concerns::ActionSubject
 
       module Overrides
+        def update(attrs)
+          if attrs[:content_facet_attributes]
+            cv_id = attrs[:content_facet_attributes].delete(:content_view_id)
+            lce_id = attrs[:content_facet_attributes].delete(:lifecycle_environment_id)
+            if cv_id && lce_id
+              content_facet.assign_single_environment(content_view_id: cv_id, lifecycle_environment_id: lce_id)
+            end
+            if (cv_id.present? && lce_id.blank?) || (cv_id.blank? && lce_id.present?)
+              fail "content_view_id and lifecycle_environment_id must be provided together"
+            end
+          end
+          super
+        end
+
         def validate_media?
           (content_source_id.blank? || (content_facet && content_facet.kickstart_repository.blank?)) && super
         end

data/app/models/katello/glue/provider.rb

@@ -12,7 +12,7 @@ module Katello
       if product_provider.redhat_provider?
         false
       else
-        Rails.logger.warn "Found orphaned object with id #{cp_id} in Candlepin. Skipping import into Katello; run rake katello:delete_orphaned_custom_products to remove it from Candlepin."
+        Rails.logger.warn "Found orphaned object with id #{cp_id} in Candlepin. Skipping import into Katello; run rake katello:clean_candlepin_orphaned_products to remove it from Candlepin."
         true
       end
     end

data/app/models/katello/host/content_facet.rb

@@ -65,10 +65,12 @@ module Katello
       end
 
       def multi_content_view_environment?
+        # returns false if there are no content view environments
         content_view_environments.size > 1
       end
 
       def single_content_view_environment?
+        # also returns false if there are no content view environments
         content_view_environments.size == 1
       end
 

data/app/services/katello/pulp3/content_view_version/export_validation_error.rb

@@ -1,7 +1,7 @@
 module Katello
   module Pulp3
     module ContentViewVersion
-      class ExportValidationError < HttpErrors::BadRequest; end
+      class ExportValidationError < StandardError; end
     end
   end
 end

data/app/services/katello/pulp3/content_view_version/export_validator.rb

@@ -13,12 +13,28 @@ module Katello
         end
 
         def validate!
+          validate_has_repos!
           validate_repositories_immediate! if @fail_on_missing_content
           validate_incremental_export! if @validate_incremental && !from_content_view_version.blank?
           validate_chunk_size
           validate_export_types! if @fail_on_missing_content
         end
 
+        def validate_has_repos!
+          repos = repositories(fetch_all: true).where(id: ::Katello::Repository.exportable(format: format))
+          if repos.empty?
+            fail ExportValidationError,
+                 _("NOTE: Content view version '%{content_view} %{current}'"\
+                   " does not have any exportable repositories. At least one repository with"\
+                   " any of the following types"\
+                   " is required to be able to export: '%{exportable_types}'." %
+                   { content_view: content_view_version.content_view.name,
+                     current: content_view_version.version,
+                     exportable_types: ::Katello::Repository.exportable_types(format: format).join("', '")
+                   })
+          end
+        end
+
         def validate_chunk_size
           return if @chunk_size.blank?
 

data/app/views/foreman/smart_proxies/_content_sync.html.erb

@@ -19,7 +19,7 @@
   </div>
 
   <br>
-  <div ng-hide="syncStatus.unsyncable_content_types.length == 0">
+  <div ng-hide="syncStatus === undefined || syncStatus.unsyncable_content_types.length == 0">
     <span translate>
       Pulp plugin missing for synchronizable content types: <b>{{ syncStatus.unsyncable_content_types.join(", ") }}.</b><br />
       Repositories containing these content types will not be synced.

data/db/migrate/20230203141353_set_new_acs_verify_ssl_default.rb

@@ -0,0 +1,5 @@
+class SetNewAcsVerifySslDefault < ActiveRecord::Migration[6.1]
+  def change
+    change_column_default(:katello_alternate_content_sources, :verify_ssl, nil)
+  end
+end

data/db/seeds.d/111-upgrade_tasks.rb

@@ -8,6 +8,7 @@ UpgradeTask.define_tasks(:katello) do
     {:name => 'katello:upgrades:4.1:reupdate_content_import_export_perms'},
     {:name => 'katello:upgrades:4.2:remove_checksum_values'},
     {:name => 'katello:upgrades:4.4:publish_import_cvvs'},
-    {:name => 'katello:upgrades:4.8:fix_incorrect_providers'}
+    {:name => 'katello:upgrades:4.8:fix_incorrect_providers'},
+    {:name => 'katello:upgrades:4.8:regenerate_imported_repository_metadata'}
   ]
 end

data/lib/katello/tasks/upgrades/4.8/regenerate_imported_repository_metadata.rake

@@ -0,0 +1,33 @@
+namespace :katello do
+  namespace :upgrades do
+    namespace '4.8' do
+      desc "Regenerates metadata for library repositories that were imported"
+      task :regenerate_imported_repository_metadata => ["dynflow:client", "environment"] do
+        User.current = User.anonymous_admin #set a user for orchestration
+        versions = Katello::ContentViewVersionImportHistory.all.map(&:content_view_version)
+        repos = versions.map do |ver|
+          rps = if ver.default?
+                  ver.repositories
+                else
+                  ver.archived_repos
+                end
+          rps.exportable
+            .map(&:library_instance_or_self)
+            .select(&:using_mirrored_metadata?)
+        end
+        repos.flatten!
+        repos.uniq!
+
+        if repos.any?
+          task = ForemanTasks.async_task(::Actions::BulkAction,
+                                         ::Actions::Katello::Repository::MetadataGenerate,
+                                         repos,
+                                         force_publication: true)
+          puts "Refreshing #{repos.count} repositories. You can monitor these on task id #{task.id}\n"
+        else
+          puts "No repositories found for regeneration."
+        end
+      end
+    end
+  end
+end

data/lib/katello/version.rb

@@ -1,3 +1,3 @@
 module Katello
-  VERSION = "4.8.0.rc1".freeze
+  VERSION = "4.8.0.rc2".freeze
 end