katello 4.4.0.rc1 → 4.4.0.rc2

data/webpack/components/extensions/HostDetails/Tabs/__tests__/packagesTab.test.js

@@ -2,9 +2,10 @@ import React from 'react';
 import { renderWithRedux, patientlyWaitFor, fireEvent } from 'react-testing-lib-wrapper';
 import { nockInstance, assertNockRequest, mockForemanAutocomplete, mockSetting } from '../../../../../test-utils/nockWrapper';
 import { foremanApi } from '../../../../../services/api';
-import { HOST_PACKAGES_KEY } from '../../HostPackages/HostPackagesConstants';
+import { HOST_PACKAGES_KEY, PACKAGES_SEARCH_QUERY } from '../../HostPackages/HostPackagesConstants';
 import { PackagesTab } from '../PackagesTab';
 import mockPackagesData from './packages.fixtures.json';
+import { REX_FEATURES } from '../RemoteExecutionConstants';
 
 const contentFacetAttributes = {
   id: 11,
@@ -13,6 +14,7 @@ const contentFacetAttributes = {
   lifecycle_environment_library: false,
 };
 
+const hostname = 'test-host.example.com';
 const renderOptions = (facetAttributes = contentFacetAttributes) => ({
   apiNamespace: HOST_PACKAGES_KEY,
   initialState: {
@@ -20,7 +22,7 @@ const renderOptions = (facetAttributes = contentFacetAttributes) => ({
       HOST_DETAILS: {
         response: {
           id: 1,
-          name: 'test-host',
+          name: hostname,
           content_facet_attributes: { ...facetAttributes },
         },
         status: 'RESOLVED',
@@ -30,6 +32,7 @@ const renderOptions = (facetAttributes = contentFacetAttributes) => ({
 });
 
 const hostPackages = foremanApi.getApiUrl('/hosts/1/packages');
+const jobInvocations = foremanApi.getApiUrl('/job_invocations');
 const autocompleteUrl = '/hosts/1/packages/auto_complete_search';
 const defaultQueryWithoutSearch = {
   include_latest_upgradable: true,
@@ -38,13 +41,14 @@ const defaultQueryWithoutSearch = {
 };
 const defaultQuery = { ...defaultQueryWithoutSearch, search: '' };
 
-let firstPackages;
+let firstPackage;
+let secondPackage;
 let searchDelayScope;
 let autoSearchScope;
 
 beforeEach(() => {
   const { results } = mockPackagesData;
-  [firstPackages] = results;
+  [firstPackage, secondPackage] = results;
   searchDelayScope = mockSetting(nockInstance, 'autosearch_delay', 0);
   autoSearchScope = mockSetting(nockInstance, 'autosearch_while_typing');
 });
@@ -65,7 +69,7 @@ test('Can call API for packages and show on screen on page load', async (done) =
   const { getAllByText } = renderWithRedux(<PackagesTab />, renderOptions());
 
   // Assert that the packages are now showing on the screen, but wait for them to appear.
-  await patientlyWaitFor(() => expect(getAllByText(firstPackages.name)[0]).toBeInTheDocument());
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope, done); // Pass jest callback to confirm test is done
@@ -107,7 +111,7 @@ test('Can filter by package status', async (done) => {
   const scope2 = nockInstance
     .get(hostPackages)
     .query({ ...defaultQuery, status: 'upgradable' })
-    .reply(200, { ...mockPackagesData, results: [firstPackages] });
+    .reply(200, { ...mockPackagesData, results: [firstPackage] });
 
   const {
     queryByText,
@@ -116,8 +120,7 @@ test('Can filter by package status', async (done) => {
     getByText,
   } = renderWithRedux(<PackagesTab />, renderOptions());
 
-  // Assert that the errata are now showing on the screen, but wait for them to appear.
-  await patientlyWaitFor(() => expect(getAllByText(firstPackages.name)[0]).toBeInTheDocument());
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
   // the Upgradable text in the table is just a text node, while the dropdown is a button
   expect(getByText('Up-to date', { ignore: ['button', 'title'] })).toBeInTheDocument();
   expect(getByText('coreutils', { ignore: ['button', 'title'] })).toBeInTheDocument();
@@ -133,10 +136,257 @@ test('Can filter by package status', async (done) => {
     expect(queryByText('acl')).not.toBeInTheDocument();
   });
 
-
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
   assertNockRequest(searchDelayScope);
   assertNockRequest(autoSearchScope);
   assertNockRequest(scope2, done); // Pass jest callback to confirm test is done
 });
+
+test('Can upgrade a package via remote execution', async (done) => {
+  const autocompleteScope = mockForemanAutocomplete(nockInstance, autocompleteUrl);
+
+  const scope = nockInstance
+    .get(hostPackages)
+    .query(defaultQuery)
+    .reply(200, mockPackagesData);
+
+  const statusScope = nockInstance
+    .get(hostPackages)
+    .query({ ...defaultQuery, status: 'upgradable' })
+    .reply(200, { ...mockPackagesData, results: [firstPackage] });
+
+  const upgradeScope = nockInstance
+    .post(jobInvocations, {
+      job_invocation: {
+        inputs: {
+          package: firstPackage.upgradable_version,
+        },
+        search_query: `name ^ (${hostname})`,
+        feature: REX_FEATURES.KATELLO_PACKAGE_UPDATE,
+      },
+    })
+    .reply(201);
+
+  const {
+    getByRole,
+    getAllByText,
+    getByLabelText,
+    getByText,
+  } = renderWithRedux(<PackagesTab />, renderOptions());
+
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
+
+  const statusDropdown = getByText('Status', { ignore: 'th' });
+  expect(statusDropdown).toBeInTheDocument();
+  fireEvent.click(statusDropdown);
+  const upgradable = getByRole('option', { name: 'select Upgradable' });
+  fireEvent.click(upgradable);
+  await patientlyWaitFor(() => {
+    expect(getByText('coreutils')).toBeInTheDocument();
+  });
+
+  const kebabDropdown = getByLabelText('Actions');
+  kebabDropdown.click();
+
+  const rexAction = getByText('Upgrade via remote execution');
+  await patientlyWaitFor(() => expect(rexAction).toBeInTheDocument());
+  fireEvent.click(rexAction);
+
+  assertNockRequest(autocompleteScope);
+  assertNockRequest(scope);
+  assertNockRequest(statusScope);
+  assertNockRequest(upgradeScope, done);
+});
+
+test('Can upgrade a package via customized remote execution', async (done) => {
+  const autocompleteScope = mockForemanAutocomplete(nockInstance, autocompleteUrl);
+
+  const scope = nockInstance
+    .get(hostPackages)
+    .query(defaultQuery)
+    .reply(200, mockPackagesData);
+
+  const statusScope = nockInstance
+    .get(hostPackages)
+    .query({ ...defaultQuery, status: 'upgradable' })
+    .reply(200, { ...mockPackagesData, results: [firstPackage] });
+
+  const {
+    getByRole,
+    getAllByText,
+    getByLabelText,
+    getByText,
+  } = renderWithRedux(<PackagesTab />, renderOptions());
+
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
+
+  const statusDropdown = getByText('Status', { ignore: 'th' });
+  expect(statusDropdown).toBeInTheDocument();
+  fireEvent.click(statusDropdown);
+  const upgradable = getByRole('option', { name: 'select Upgradable' });
+  fireEvent.click(upgradable);
+  await patientlyWaitFor(() => {
+    expect(getByText('coreutils')).toBeInTheDocument();
+  });
+
+  const kebabDropdown = getByLabelText('Actions');
+  kebabDropdown.click();
+
+  const rexAction = getByText('Upgrade via customized remote execution');
+  const feature = REX_FEATURES.KATELLO_PACKAGE_UPDATE;
+  const packageName = firstPackage.upgradable_version;
+
+  expect(rexAction).toBeInTheDocument();
+  expect(rexAction).toHaveAttribute(
+    'href',
+    `/job_invocations/new?feature=${feature}&host_ids=name%20%5E%20(${hostname})&inputs%5Bpackage%5D=${packageName}`,
+  );
+
+  fireEvent.click(rexAction);
+
+  assertNockRequest(autocompleteScope);
+  assertNockRequest(scope);
+  assertNockRequest(statusScope, done);
+});
+
+test('Can bulk upgrade via remote execution', async (done) => {
+  const autocompleteScope = mockForemanAutocomplete(nockInstance, autocompleteUrl);
+
+  const scope = nockInstance
+    .get(hostPackages)
+    .query(defaultQuery)
+    .reply(200, mockPackagesData);
+
+  const upgradeScope = nockInstance
+    .post(jobInvocations, {
+      job_invocation: {
+        inputs: {
+          [PACKAGES_SEARCH_QUERY]: `id ^ (${firstPackage.id},${secondPackage.id})`,
+        },
+        search_query: `name ^ (${hostname})`,
+        feature: REX_FEATURES.KATELLO_PACKAGES_UPDATE_BY_SEARCH,
+      },
+    })
+    .reply(201);
+
+  const {
+    getAllByRole,
+    getAllByText,
+    getByRole,
+    getByLabelText,
+  } = renderWithRedux(<PackagesTab />, renderOptions());
+
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
+
+  getByRole('checkbox', { name: 'Select row 0' }).click();
+  expect(getByLabelText('Select row 0').checked).toEqual(true);
+  getByRole('checkbox', { name: 'Select row 1' }).click();
+  expect(getByLabelText('Select row 1').checked).toEqual(true);
+
+  const upgradeDropdown = getAllByRole('button', { name: 'Select' })[1];
+  fireEvent.click(upgradeDropdown);
+
+  const rexAction = getByLabelText('bulk_upgrade_rex');
+  expect(rexAction).toBeInTheDocument();
+  fireEvent.click(rexAction);
+
+  assertNockRequest(autocompleteScope);
+  assertNockRequest(scope);
+  assertNockRequest(upgradeScope, done);
+});
+
+test('Can bulk upgrade via customized remote execution', async (done) => {
+  const autocompleteScope = mockForemanAutocomplete(nockInstance, autocompleteUrl);
+
+  const scope = nockInstance
+    .get(hostPackages)
+    .query(defaultQuery)
+    .reply(200, mockPackagesData);
+
+  const {
+    getAllByRole,
+    getAllByText,
+    getByRole,
+    getByLabelText,
+  } = renderWithRedux(<PackagesTab />, renderOptions());
+
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
+
+  const feature = REX_FEATURES.KATELLO_PACKAGES_UPDATE_BY_SEARCH;
+  const packages = `${firstPackage.id},${secondPackage.id}`;
+  const job =
+    `/job_invocations/new?feature=${feature}&host_ids=name%20%5E%20(${hostname})&inputs%5BPackages%20search%20query%5D=id%20%5E%20(${packages})`;
+
+  getByRole('checkbox', { name: 'Select row 0' }).click();
+  expect(getByLabelText('Select row 0').checked).toEqual(true);
+  getByRole('checkbox', { name: 'Select row 1' }).click();
+  expect(getByLabelText('Select row 1').checked).toEqual(true);
+
+  const upgradeDropdown = getAllByRole('button', { name: 'Select' })[1];
+  fireEvent.click(upgradeDropdown);
+  expect(upgradeDropdown).not.toHaveAttribute('disabled');
+
+  const rexAction = getByLabelText('bulk_upgrade_customized_rex');
+  expect(rexAction).toBeInTheDocument();
+  expect(rexAction).toHaveAttribute('href', job);
+
+  assertNockRequest(autocompleteScope);
+  assertNockRequest(scope, done);
+});
+
+test('Upgrade is disabled when there are non-upgradable packages selected', async (done) => {
+  const autocompleteScope = mockForemanAutocomplete(nockInstance, autocompleteUrl);
+
+  const scope = nockInstance
+    .get(hostPackages)
+    .query(defaultQuery)
+    .reply(200, mockPackagesData);
+
+  const {
+    getAllByRole,
+    getAllByText,
+    getByLabelText,
+    getByRole,
+  } = renderWithRedux(<PackagesTab />, renderOptions());
+
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
+
+  // select an upgradable package
+  getByRole('checkbox', { name: 'Select row 0' }).click();
+  // select an up-to-date package
+  getByRole('checkbox', { name: 'Select row 2' }).click();
+  expect(getByLabelText('Select row 2').checked).toEqual(true);
+
+  const upgradeDropdown = getAllByRole('button', { name: 'Select' })[1];
+  expect(upgradeDropdown).toHaveAttribute('disabled');
+
+  assertNockRequest(autocompleteScope);
+  assertNockRequest(scope, done);
+});
+
+test('Remove is disabled when in select all mode', async (done) => {
+  const autocompleteScope = mockForemanAutocomplete(nockInstance, autocompleteUrl);
+  const scope = nockInstance
+    .get(hostPackages)
+    .query(defaultQuery)
+    .reply(200, mockPackagesData);
+
+  const {
+    getAllByText, getByRole,
+  } = renderWithRedux(<PackagesTab />, renderOptions());
+
+  await patientlyWaitFor(() => expect(getAllByText(firstPackage.name)[0]).toBeInTheDocument());
+
+  // find and click the select all checkbox
+  const selectAllCheckbox = getByRole('checkbox', { name: 'Select all' });
+  fireEvent.click(selectAllCheckbox);
+  getByRole('button', { name: 'bulk_actions' }).click();
+
+  const removeButton = getByRole('button', { name: 'bulk_remove' });
+  await patientlyWaitFor(() => expect(removeButton).toBeInTheDocument());
+  expect(removeButton).toHaveAttribute('aria-disabled', 'true');
+
+  assertNockRequest(autocompleteScope);
+  assertNockRequest(scope, done);
+});

data/webpack/components/extensions/HostDetails/Tabs/__tests__/tracesTab.test.js

@@ -40,10 +40,6 @@ const renderOptions = isTracerInstalled => ({ // sets initial Redux state
   },
 });
 
-// Find the checkbox to the left of the trace.
-// (We could also have just found the checkbox by its aria-label "Select row 0",
-// but this is closer to how the user would do it)
-const checkboxToTheLeftOf = node => node.previousElementSibling.firstElementChild;
 const actionMenuToTheRightOf = node => node.nextElementSibling.firstElementChild.firstElementChild;
 
 const hostTraces = foremanApi.getApiUrl('/hosts/1/traces?per_page=20&page=1');
@@ -51,14 +47,13 @@ const autocompleteUrl = '/hosts/1/traces/auto_complete_search';
 const jobInvocations = foremanApi.getApiUrl('/job_invocations');
 
 let firstTrace;
-let secondTrace;
 let searchDelayScope;
 let autoSearchScope;
 
 describe('With tracer installed', () => {
   beforeEach(() => {
     const { results } = mockTraceData;
-    [firstTrace, secondTrace] = results;
+    [firstTrace] = results;
     searchDelayScope = mockSetting(nockInstance, 'autosearch_delay', 0);
     autoSearchScope = mockSetting(nockInstance, 'autosearch_while_typing');
   });
@@ -119,17 +114,17 @@ describe('With tracer installed', () => {
       .reply(201, mockResolveTraceTask);
 
 
-    const { getByText } = renderWithRedux(
+    const { getByText, getByLabelText } = renderWithRedux(
       <TracesTab />,
       renderOptions(true),
     );
+
     let traceCheckbox;
-    // Find the trace.
+    // Find the trace checkbox.
     await patientlyWaitFor(() => {
-      const traceNameNode = getByText(firstTrace.application);
-      traceCheckbox = checkboxToTheLeftOf(traceNameNode);
+      traceCheckbox = getByLabelText('Select row 0');
     });
-    traceCheckbox.click();
+    fireEvent.click(traceCheckbox);
     expect(traceCheckbox.checked).toEqual(true);
 
     const restartAppButton = getByText('Restart app');
@@ -158,16 +153,17 @@ describe('With tracer installed', () => {
       .reply(201, mockResolveTraceTask);
 
 
-    const { getByText, getByLabelText, queryByText } = renderWithRedux(
+    const { getByLabelText, queryByText } = renderWithRedux(
       <TracesTab />,
       renderOptions(true),
     );
     let traceCheckbox;
+
+    // Find the trace.
     await patientlyWaitFor(() => {
-      const traceNameNode = getByText(firstTrace.application);
-      traceCheckbox = checkboxToTheLeftOf(traceNameNode);
+      traceCheckbox = getByLabelText('Select row 0');
     });
-    traceCheckbox.click();
+    fireEvent.click(traceCheckbox);
     expect(traceCheckbox.checked).toEqual(true);
     const actionMenu = getByLabelText('bulk_actions');
     actionMenu.click();
@@ -204,14 +200,16 @@ describe('With tracer installed', () => {
     );
 
     let traceCheckbox;
-    // Assert that the traces are now showing on the screen, but wait for them to appear.
+    // Find the trace.
     await patientlyWaitFor(() => {
-      const traceNameNode = getByText(firstTrace.application);
-      traceCheckbox = checkboxToTheLeftOf(traceNameNode);
+      traceCheckbox = getByLabelText('Select row 0');
     });
+
+
     const selectAllCheckbox = getByLabelText('Select all');
     fireEvent.click(selectAllCheckbox);
     expect(traceCheckbox.checked).toEqual(true);
+
     fireEvent.click(getByLabelText('Select row 0')); // de select
     fireEvent.click(getByLabelText('Select row 2')); // de select
 
@@ -298,16 +296,15 @@ describe('With tracer installed', () => {
       .get(hostTraces)
       .reply(200, mockTraceData);
 
-    const { getByText, getByLabelText, queryByText } = renderWithRedux(
+    const { getByLabelText, queryByText } = renderWithRedux(
       <TracesTab />,
       renderOptions(true),
     );
     let traceCheckbox;
     await patientlyWaitFor(() => {
-      const traceNameNode = getByText(firstTrace.application);
-      traceCheckbox = checkboxToTheLeftOf(traceNameNode);
+      traceCheckbox = getByLabelText('Select row 0');
     });
-    traceCheckbox.click();
+    fireEvent.click(traceCheckbox);
     expect(traceCheckbox.checked).toEqual(true);
 
     const actionMenu = getByLabelText('bulk_actions');
@@ -327,7 +324,7 @@ describe('With tracer installed', () => {
   describe('Remote execution URL helper logic', () => {
     beforeEach(() => {
       const { results } = mockTraceData;
-      [firstTrace, secondTrace] = results;
+      [firstTrace] = results;
     });
 
     afterEach(() => {
@@ -341,14 +338,13 @@ describe('With tracer installed', () => {
         .get(hostTraces)
         .reply(200, mockTraceData);
 
-      const { getByText } = renderWithRedux(
+      const { getByLabelText } = renderWithRedux(
         <TracesTab />,
         renderOptions(true),
       );
       let traceCheckbox;
       await patientlyWaitFor(() => {
-        const traceNameNode = getByText(secondTrace.application);
-        traceCheckbox = checkboxToTheLeftOf(traceNameNode);
+        traceCheckbox = getByLabelText('Select row 1');
       });
       expect(traceCheckbox.disabled).toEqual(true);
 

data/webpack/components/extensions/HostDetails/Tabs/customizedRexUrlHelpers.js

@@ -2,6 +2,7 @@ import { REX_FEATURES } from './RemoteExecutionConstants';
 import { TRACES_SEARCH_QUERY } from './TracesTab/HostTracesConstants';
 import { ERRATA_SEARCH_QUERY } from './ErrataTab/HostErrataConstants';
 import { PACKAGE_SEARCH_QUERY } from '../YumInstallablePackages/YumInstallablePackagesConstants';
+import { PACKAGES_SEARCH_QUERY } from '../HostPackages/HostPackagesConstants';
 
 export const createJob = ({
   hostname, feature, inputs,
@@ -28,6 +29,18 @@ export const katelloPackageInstallBySearchUrl = ({ hostname, search }) => create
   inputs: { [PACKAGE_SEARCH_QUERY]: search },
 });
 
+export const katelloPackageUpdateUrl = ({ hostname, packageName }) => createJob({
+  hostname,
+  feature: REX_FEATURES.KATELLO_PACKAGE_UPDATE,
+  inputs: { package: packageName },
+});
+
+export const packagesUpdateUrl = ({ hostname, search }) => createJob({
+  hostname,
+  feature: REX_FEATURES.KATELLO_PACKAGES_UPDATE_BY_SEARCH,
+  inputs: { [PACKAGES_SEARCH_QUERY]: search },
+});
+
 export const resolveTraceUrl = ({ hostname, search }) => createJob({
   hostname,
   feature: REX_FEATURES.KATELLO_HOST_TRACER_RESOLVE,

data/webpack/components/extensions/RegistrationCommands/__tests__/__snapshots__/ActivationKeys.test.js.snap

@@ -29,12 +29,16 @@ exports[`ActivationKeys renders 1`] = `
     favorites={Array []}
     favoritesLabel="Favorites"
     hasInlineFilter={false}
+    hasPlaceholderStyle={false}
     id="reg_katello_ak"
     inlineFilterPlaceholderText={null}
+    inputAutoComplete="off"
     inputIdPrefix=""
     isCreatable={false}
+    isCreateSelectOptionObject={false}
     isDisabled={true}
     isGrouped={false}
+    isInputFilterPersisted={false}
     isInputValuePersisted={false}
     isOpen={false}
     isPlain={false}

data/webpack/components/extensions/RegistrationCommands/fields/ActivationKeys.js

@@ -81,7 +81,7 @@ ActivationKeys.propTypes = {
   selectedKeys: PropTypes.array,
   hostGroupActivationKeys: PropTypes.oneOfType([PropTypes.string, PropTypes.array]),
   hostGroupId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
-  pluginValues: PropTypes.object,
+  pluginValues: PropTypes.objectOf(PropTypes.shape({})),
   onChange: PropTypes.func.isRequired,
   handleInvalidField: PropTypes.func.isRequired,
   isLoading: PropTypes.bool,

data/webpack/components/extensions/RegistrationCommands/fields/LifecycleEnvironment.js

@@ -31,7 +31,7 @@ const LifecycleEnvironment = ({
       />
       {lifecycleEnvironments.map(lce => (
         <FormSelectOption key={lce.id} value={lce.id} label={lce.name} />
-        ))}
+      ))}
     </FormSelect>
   </FormGroup>
 );

data/webpack/components/extensions/about/SystemStatuses.js

@@ -31,7 +31,7 @@ class SystemStatuses extends Component {
                     <td>{value.status.toUpperCase()}</td>
                     <td> {value.message}</td>
                   </tr>
-            ))}
+                ))}
               </tbody>
             </table>
           </LoadingState>

data/webpack/components/extensions/about/SystemStatusesReducer.js

@@ -12,15 +12,15 @@ const initialState = Immutable({
 
 export default (state = initialState, action) => {
   switch (action.type) {
-    case SYSTEM_STATUSES_REQUEST:
-      return state.set('loaderStatus', 'PENDING');
-    case SYSTEM_STATUSES_SUCCESS:
-      return state
-        .set('services', action.payload.services)
-        .set('loaderStatus', 'RESOLVED');
-    case SYSTEM_STATUSES_FAILURE:
-      return state.set('loaderStatus', 'ERROR');
-    default:
-      return state;
+  case SYSTEM_STATUSES_REQUEST:
+    return state.set('loaderStatus', 'PENDING');
+  case SYSTEM_STATUSES_SUCCESS:
+    return state
+      .set('services', action.payload.services)
+      .set('loaderStatus', 'RESOLVED');
+  case SYSTEM_STATUSES_FAILURE:
+    return state.set('loaderStatus', 'ERROR');
+  default:
+    return state;
   }
 };

data/webpack/components/pf3Table/components/Table.js

@@ -53,8 +53,8 @@ const Table = ({
 };
 
 Table.propTypes = {
-  columns: PropTypes.arrayOf(PropTypes.object).isRequired,
-  rows: PropTypes.arrayOf(PropTypes.object).isRequired,
+  columns: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
+  rows: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   emptyState: PropTypes.object, // eslint-disable-line react/forbid-prop-types
   pagination: PropTypes.object, // eslint-disable-line react/forbid-prop-types
   bodyMessage: PropTypes.node,

data/webpack/components/pf3Table/components/TableBody.js

@@ -15,8 +15,8 @@ const TableBody = ({
 };
 
 TableBody.propTypes = {
-  columns: PropTypes.arrayOf(PropTypes.object).isRequired,
-  rows: PropTypes.arrayOf(PropTypes.object).isRequired,
+  columns: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
+  rows: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   message: PropTypes.string,
 };
 

data/webpack/redux/OrganizationProducts/OrganizationProductsReducer.js

@@ -16,23 +16,23 @@ export default (state = initialState, action) => {
   const { type, payload } = action;
 
   switch (type) {
-    case ORGANIZATION_PRODUCTS_REQUEST:
-      return state.set('loading', true);
+  case ORGANIZATION_PRODUCTS_REQUEST:
+    return state.set('loading', true);
 
-    case ORGANIZATION_PRODUCTS_SUCCESS:
-      return state.merge({
-        ...payload,
-        loading: false,
-      });
+  case ORGANIZATION_PRODUCTS_SUCCESS:
+    return state.merge({
+      ...payload,
+      loading: false,
+    });
 
-    case ORGANIZATION_PRODUCTS_FAILURE:
-      return state.merge({
-        error: payload,
-        loading: false,
-        results: [],
-      });
+  case ORGANIZATION_PRODUCTS_FAILURE:
+    return state.merge({
+      error: payload,
+      loading: false,
+      results: [],
+    });
 
-    default:
-      return state;
+  default:
+    return state;
   }
 };