katello 4.3.0.rc4 → 4.4.0.rc2

data/webpack/components/extensions/HostDetails/YumInstallablePackages/YumInstallablePackagesActions.js

@@ -0,0 +1,18 @@
+import { API_OPERATIONS, get } from 'foremanReact/redux/API';
+import katelloApi from '../../../../services/api';
+import { HOST_YUM_INSTALLABLE_PACKAGES_KEY } from './YumInstallablePackagesConstants';
+
+export const getHostYumInstallablePackages = (hostId, params) => get({
+  type: API_OPERATIONS.GET,
+  key: HOST_YUM_INSTALLABLE_PACKAGES_KEY,
+  url: katelloApi.getApiUrl('/packages'),
+  params: {
+    ...params,
+    host_id: hostId,
+    packages_restrict_not_installed: true,
+    packages_restrict_applicable: false,
+    packages_restrict_latest: true,
+  },
+});
+export default getHostYumInstallablePackages;
+

data/webpack/components/extensions/HostDetails/YumInstallablePackages/YumInstallablePackagesConstants.js

@@ -0,0 +1,3 @@
+export const HOST_YUM_INSTALLABLE_PACKAGES_KEY = 'HOST_YUM_INSTALLABLE_PACKAGES';
+export const PACKAGE_SEARCH_QUERY = 'Package search query';
+export default HOST_YUM_INSTALLABLE_PACKAGES_KEY;

data/webpack/components/extensions/HostDetails/YumInstallablePackages/YumInstallablePackagesSelectors.js

@@ -0,0 +1,16 @@
+import {
+  selectAPIStatus,
+  selectAPIError,
+  selectAPIResponse,
+} from 'foremanReact/redux/API/APISelectors';
+import { STATUS } from 'foremanReact/constants';
+import { HOST_YUM_INSTALLABLE_PACKAGES_KEY } from './YumInstallablePackagesConstants';
+
+export const selectHostYumInstallablePackages = state =>
+  selectAPIResponse(state, HOST_YUM_INSTALLABLE_PACKAGES_KEY) || {};
+
+export const selectHostYumInstallablePackagesStatus = state =>
+  selectAPIStatus(state, HOST_YUM_INSTALLABLE_PACKAGES_KEY) || STATUS.PENDING;
+
+export const selectHostYumInstallablePackagesError = state =>
+  selectAPIError(state, HOST_YUM_INSTALLABLE_PACKAGES_KEY);

data/webpack/components/extensions/HostDetails/hostDetailsHelpers.js

@@ -0,0 +1,19 @@
+import { propsToCamelCase } from 'foremanReact/common/helpers';
+
+export const REMOTE_EXECUTION = 'remoteExecution';
+export const KATELLO_AGENT = 'katelloAgent';
+
+const defaultRemoteActionMethod = ({ hostDetails }) => {
+  const {
+    content_facet_attributes: contentFacetAttributes,
+  } = hostDetails;
+  const contentFacet = propsToCamelCase(contentFacetAttributes ?? {});
+  const katelloAgentAvailable = (contentFacet.katelloAgentInstalled &&
+    contentFacet.katelloAgentEnabled);
+  if (contentFacet.remoteExecutionByDefault || !katelloAgentAvailable) {
+    return REMOTE_EXECUTION;
+  }
+  return KATELLO_AGENT;
+};
+
+export default defaultRemoteActionMethod;

data/webpack/components/extensions/RegistrationCommands/__tests__/__snapshots__/ActivationKeys.test.js.snap

@@ -29,12 +29,16 @@ exports[`ActivationKeys renders 1`] = `
     favorites={Array []}
     favoritesLabel="Favorites"
     hasInlineFilter={false}
+    hasPlaceholderStyle={false}
     id="reg_katello_ak"
     inlineFilterPlaceholderText={null}
+    inputAutoComplete="off"
     inputIdPrefix=""
     isCreatable={false}
+    isCreateSelectOptionObject={false}
     isDisabled={true}
     isGrouped={false}
+    isInputFilterPersisted={false}
     isInputValuePersisted={false}
     isOpen={false}
     isPlain={false}

data/webpack/components/extensions/RegistrationCommands/fields/ActivationKeys.js

@@ -81,7 +81,7 @@ ActivationKeys.propTypes = {
   selectedKeys: PropTypes.array,
   hostGroupActivationKeys: PropTypes.oneOfType([PropTypes.string, PropTypes.array]),
   hostGroupId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]),
-  pluginValues: PropTypes.object,
+  pluginValues: PropTypes.objectOf(PropTypes.shape({})),
   onChange: PropTypes.func.isRequired,
   handleInvalidField: PropTypes.func.isRequired,
   isLoading: PropTypes.bool,

data/webpack/components/extensions/RegistrationCommands/fields/LifecycleEnvironment.js

@@ -31,7 +31,7 @@ const LifecycleEnvironment = ({
       />
       {lifecycleEnvironments.map(lce => (
         <FormSelectOption key={lce.id} value={lce.id} label={lce.name} />
-        ))}
+      ))}
     </FormSelect>
   </FormGroup>
 );

data/webpack/components/extensions/about/SystemStatuses.js

@@ -31,7 +31,7 @@ class SystemStatuses extends Component {
                     <td>{value.status.toUpperCase()}</td>
                     <td> {value.message}</td>
                   </tr>
-            ))}
+                ))}
               </tbody>
             </table>
           </LoadingState>

data/webpack/components/extensions/about/SystemStatusesReducer.js

@@ -12,15 +12,15 @@ const initialState = Immutable({
 
 export default (state = initialState, action) => {
   switch (action.type) {
-    case SYSTEM_STATUSES_REQUEST:
-      return state.set('loaderStatus', 'PENDING');
-    case SYSTEM_STATUSES_SUCCESS:
-      return state
-        .set('services', action.payload.services)
-        .set('loaderStatus', 'RESOLVED');
-    case SYSTEM_STATUSES_FAILURE:
-      return state.set('loaderStatus', 'ERROR');
-    default:
-      return state;
+  case SYSTEM_STATUSES_REQUEST:
+    return state.set('loaderStatus', 'PENDING');
+  case SYSTEM_STATUSES_SUCCESS:
+    return state
+      .set('services', action.payload.services)
+      .set('loaderStatus', 'RESOLVED');
+  case SYSTEM_STATUSES_FAILURE:
+    return state.set('loaderStatus', 'ERROR');
+  default:
+    return state;
   }
 };

data/webpack/components/pf3Table/components/Table.js

@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import { Table as PfTable } from 'patternfly-react';
 import { noop } from 'foremanReact/common/helpers';
 import EmptyState from 'foremanReact/components/common/EmptyState';
-import Pagination from 'foremanReact/components/Pagination/PaginationWrapper';
+import Pagination from 'foremanReact/components/Pagination';
 
 import TableBody from './TableBody';
 
@@ -43,10 +43,9 @@ const Table = ({
       </PfTable.PfProvider>
       {shouldRenderPagination && (
         <Pagination
-          viewType="table"
           itemCount={itemCount}
-          pagination={pagination}
           onChange={onPaginationChange}
+          {...pagination}
         />
       )}
     </div>
@@ -54,8 +53,8 @@ const Table = ({
 };
 
 Table.propTypes = {
-  columns: PropTypes.arrayOf(PropTypes.object).isRequired,
-  rows: PropTypes.arrayOf(PropTypes.object).isRequired,
+  columns: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
+  rows: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   emptyState: PropTypes.object, // eslint-disable-line react/forbid-prop-types
   pagination: PropTypes.object, // eslint-disable-line react/forbid-prop-types
   bodyMessage: PropTypes.node,

data/webpack/components/pf3Table/components/Table.test.js

@@ -1,10 +1,7 @@
 import { testComponentSnapshotsWithFixtures } from 'react-redux-test-utils';
-
 import Table from './Table';
 import { columnsFixtures, rowsFixtures } from './TableFixtures';
 
-jest.mock('foremanReact/components/Pagination/PaginationWrapper');
-
 const fixtures = {
   'renders Table with emptyState': {
     columns: columnsFixtures,

data/webpack/components/pf3Table/components/TableBody.js

@@ -15,8 +15,8 @@ const TableBody = ({
 };
 
 TableBody.propTypes = {
-  columns: PropTypes.arrayOf(PropTypes.object).isRequired,
-  rows: PropTypes.arrayOf(PropTypes.object).isRequired,
+  columns: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
+  rows: PropTypes.arrayOf(PropTypes.shape({})).isRequired,
   message: PropTypes.string,
 };
 

data/webpack/components/pf3Table/components/__snapshots__/Table.test.js.snap

@@ -137,16 +137,17 @@ exports[`Table renders Table with pagination 1`] = `
   >
     some children
   </TablePfProvider>
-  <PaginationWrapper
+  <Pagination
+    className={null}
     itemCount={2}
+    noSidePadding={false}
     onChange={[Function]}
-    pagination={
-      Object {
-        "page": 1,
-        "perPage": 20,
-      }
-    }
-    viewType="table"
+    onPerPageSelect={null}
+    onSetPage={null}
+    page={1}
+    perPage={20}
+    updateParamsByUrl={true}
+    variant="bottom"
   />
 </div>
 `;

data/webpack/containers/Application/config.js

@@ -14,6 +14,7 @@ import ContentViewDetails from '../../scenes/ContentViews/Details';
 import Content from '../../scenes/Content';
 import ContentDetails from '../../scenes/Content/Details';
 import withHeader from './withHeaders';
+import ChangeContentSource from '../../scenes/Hosts/ChangeContentSource';
 
 // eslint-disable-next-line import/prefer-default-export
 export const links = [
@@ -56,7 +57,7 @@ export const links = [
   },
   {
     path: 'content_views',
-    component: WithOrganization(withHeader(ContentViews, { title: __('Content Views') })),
+    component: WithOrganization(withHeader(ContentViews, { title: __('Content views') })),
   },
   {
     path: 'content_views/:id([0-9]+)',
@@ -75,4 +76,8 @@ export const links = [
     path: 'content/:content_type([a-z_]+)/:id([0-9]+)',
     component: WithOrganization(withHeader(ContentDetails, { title: __('Content Details') })),
   },
+  {
+    path: 'change_host_content_source',
+    component: WithOrganization(withHeader(ChangeContentSource, { title: __('Change host content source') })),
+  },
 ];

data/webpack/containers/Application/overrides.scss

@@ -40,9 +40,62 @@ html .pagination-pf-pagesize.btn-group {
   }
 }
 
-// Patternfly 4's Grid doesn't add margin at the top and bottom
-.grid-with-margin {
-  margin: 20px 4px;
+// Removes inherited container padding on view
+.container-fluid.container-pf-nav-pf-vertical.nav-pf-persistent-secondary {
+  padding: 0;
+}
+
+// Margin shortcuts
+.margin-24 {
+  margin: 24px;
+}
+
+.margin-16 {
+  margin: 16px;
+}
+
+.margin-8 {
+  margin: 8px;
+}
+
+.margin-16-24 {
+  margin: 16px 24px;
+}
+
+.margin-24-0 {
+  margin: 24px 0;
+}
+
+.margin-16-0 {
+  margin: 16px 0;
+}
+
+.margin-0-24 {
+  margin: 0 24px;
+}
+
+.margin-right-16 {
+  margin: 0 16px 0 0;
+}
+
+.gap-16 {
+  grid-gap: 16px;
+}
+
+.margin-bottom-24 {
+  margin-bottom: 24px;
+}
+
+.margin-top-24 {
+  margin-top: 24px;
+}
+
+.margin-top-16 {
+  margin-top: 16px;
+}
+
+.margin-top-8 {
+  margin-top: 8px;
 }
 
 // needed to ensure correct spacing between buttons and the button
@@ -68,10 +121,6 @@ html .pagination-pf-pagesize.btn-group {
   outline: none;
 }
 
-.tab-body-with-spacing {
-  margin: 24px 0px;
-}
-
 // Modal sizing fix
 .pf-l-bullseye .pf-c-modal-box {
   margin-top: 76px;

data/webpack/global_index.js

@@ -7,10 +7,11 @@ import SystemStatuses from './components/extensions/about';
 import RegistrationCommands from './components/extensions/RegistrationCommands';
 import ContentTab from './components/extensions/HostDetails/Tabs/ContentTab';
 import ContentViewDetailsCard from './components/extensions/HostDetails/Cards/ContentViewDetailsCard';
+import ErrataOverviewCard from './components/extensions/HostDetails/Cards/ErrataOverviewCard';
 
 // import SubscriptionTab from './components/extensions/HostDetails/Tabs/SubscriptionTab';
 import RepositorySetsTab from './components/extensions/HostDetails/Tabs/RepositorySetsTab/RepositorySetsTab';
-import TracesTab from './components/extensions/HostDetails/Tabs/TracesTab';
+import TracesTab from './components/extensions/HostDetails/Tabs/TracesTab/TracesTab.js';
 import extendReducer from './components/extensions/reducers';
 import rootReducer from './redux/reducers';
 
@@ -29,4 +30,6 @@ addGlobalFill(
   'details-cards',
   'Content View Details',
   <ContentViewDetailsCard key="content-view-details" />,
+  2000,
 );
+addGlobalFill('details-cards', 'Installable errata', <ErrataOverviewCard key="errata-overview" />, 1900);

data/webpack/global_test_setup.js

@@ -8,7 +8,7 @@ global.console.error = (error, stack) => {
 };
 
 // Increase jest timeout as some tests using multiple http mocks can time out on CI systems.
-jest.setTimeout(300000);
+jest.setTimeout(process.env.JEST_TIMEOUT || 15000);
 
 afterAll(() => {
   jest.resetModules();

data/webpack/index.js

@@ -6,6 +6,8 @@
 import componentRegistry from 'foremanReact/components/componentRegistry';
 import Application from './containers/Application/index';
 import Content from './scenes/SmartProxy/Content';
+import ChangeContentSource from './scenes/Hosts/ChangeContentSource';
+
 import './redux';
 // Not currently mocking anything
 // import './services/api/setupMocks';
@@ -19,3 +21,8 @@ componentRegistry.register({
   name: 'Content',
   type: Content,
 });
+
+componentRegistry.register({
+  name: 'ChangeContentSource',
+  type: ChangeContentSource,
+});

data/webpack/redux/OrganizationProducts/OrganizationProductsReducer.js

@@ -16,23 +16,23 @@ export default (state = initialState, action) => {
   const { type, payload } = action;
 
   switch (type) {
-    case ORGANIZATION_PRODUCTS_REQUEST:
-      return state.set('loading', true);
+  case ORGANIZATION_PRODUCTS_REQUEST:
+    return state.set('loading', true);
 
-    case ORGANIZATION_PRODUCTS_SUCCESS:
-      return state.merge({
-        ...payload,
-        loading: false,
-      });
+  case ORGANIZATION_PRODUCTS_SUCCESS:
+    return state.merge({
+      ...payload,
+      loading: false,
+    });
 
-    case ORGANIZATION_PRODUCTS_FAILURE:
-      return state.merge({
-        error: payload,
-        loading: false,
-        results: [],
-      });
+  case ORGANIZATION_PRODUCTS_FAILURE:
+    return state.merge({
+      error: payload,
+      loading: false,
+      results: [],
+    });
 
-    default:
-      return state;
+  default:
+    return state;
   }
 };

data/webpack/redux/reducers/RedHatRepositories/enabled.js

@@ -60,49 +60,49 @@ const changeRepoState = (state, repoToChange, stateDiff) => (
 
 export default (state = initialState, action) => {
   switch (action.type) {
-    case DISABLE_REPOSITORY_REQUEST:
-      return changeRepoState(state, action.repository, { loading: true });
-    case DISABLE_REPOSITORY_FAILURE:
-      return changeRepoState(state, action.payload.repository, { loading: false });
-    case ENABLED_REPOSITORIES_REQUEST:
-      if (!action.silent) {
-        return state.set(['loading'], true);
-      }
-      return state;
-    case ENABLED_REPOSITORIES_SUCCESS: {
-      const {
-        page,
-        per_page, // eslint-disable-line camelcase
-        subtotal,
-        results,
-      } = action.response;
-      return Immutable({
-        repositories: mapRepositories(results),
-        pagination: {
-          page: Number(page) || 1,
-          // server can return per_page: null when there's error in the search query,
-          // don't store it in such case
-          // eslint-disable-next-line camelcase
-          perPage: (per_page || state.pagination.perPage)
-          // eslint-disable-next-line camelcase
-            && Number(per_page || state.pagination.perPage),
-        },
-        itemCount: Number(subtotal),
-        loading: false,
-        searchIsActive: !isEmpty(action.search),
-        search: action.search,
-      });
-    }
-    case ENABLED_REPOSITORIES_FAILURE: {
-      const { error, missingPermissions } = action;
-      return Immutable({
-        repositories: [],
-        loading: false,
-        error,
-        missingPermissions,
-      });
+  case DISABLE_REPOSITORY_REQUEST:
+    return changeRepoState(state, action.repository, { loading: true });
+  case DISABLE_REPOSITORY_FAILURE:
+    return changeRepoState(state, action.payload.repository, { loading: false });
+  case ENABLED_REPOSITORIES_REQUEST:
+    if (!action.silent) {
+      return state.set(['loading'], true);
     }
-    default:
-      return state;
+    return state;
+  case ENABLED_REPOSITORIES_SUCCESS: {
+    const {
+      page,
+      per_page, // eslint-disable-line camelcase
+      subtotal,
+      results,
+    } = action.response;
+    return Immutable({
+      repositories: mapRepositories(results),
+      pagination: {
+        page: Number(page) || 1,
+        // server can return per_page: null when there's error in the search query,
+        // don't store it in such case
+        // eslint-disable-next-line camelcase
+        perPage: (per_page || state.pagination.perPage)
+        // eslint-disable-next-line camelcase
+            && Number(per_page || state.pagination.perPage),
+      },
+      itemCount: Number(subtotal),
+      loading: false,
+      searchIsActive: !isEmpty(action.search),
+      search: action.search,
+    });
+  }
+  case ENABLED_REPOSITORIES_FAILURE: {
+    const { error, missingPermissions } = action;
+    return Immutable({
+      repositories: [],
+      loading: false,
+      error,
+      missingPermissions,
+    });
+  }
+  default:
+    return state;
   }
 };

data/webpack/redux/reducers/RedHatRepositories/repositorySetRepositories.js

@@ -56,48 +56,48 @@ const initialState = Immutable({});
 
 export default (state = initialState, action) => {
   switch (action.type) {
-    case ENABLE_REPOSITORY_REQUEST:
-      return changeRepoState(state, action.repository, { loading: true });
-
-    case ENABLE_REPOSITORY_FAILURE:
-      return changeRepoState(state, action.payload.repository, { loading: false, error: true });
-
-    case REPOSITORY_SET_REPOSITORIES_REQUEST:
-      return state.set(action.contentId, {
-        loading: true,
-        repositories: [],
-        error: null,
-      });
-
-    case REPOSITORY_SET_REPOSITORIES_SUCCESS:
-      return state.set(action.contentId, {
-        loading: false,
-        repositories: normalizeContentSetRepositories(
-          action.results,
-          action.contentId,
-          action.productId,
-        ),
-        error: null,
-      });
-
-    case REPOSITORY_SET_REPOSITORIES_FAILURE:
-      return state.set(action.contentId, {
-        loading: false,
-        repositories: [],
-        error: action.error,
-      });
-
-    case REPOSITORY_ENABLED:
-      return changeRepoState(state, action.repository, {
-        enabled: true,
-        loading: false,
-        error: false,
-      });
-
-    case REPOSITORY_DISABLED:
-      return changeRepoState(state, action.repository, { enabled: false });
-
-    default:
-      return state;
+  case ENABLE_REPOSITORY_REQUEST:
+    return changeRepoState(state, action.repository, { loading: true });
+
+  case ENABLE_REPOSITORY_FAILURE:
+    return changeRepoState(state, action.payload.repository, { loading: false, error: true });
+
+  case REPOSITORY_SET_REPOSITORIES_REQUEST:
+    return state.set(action.contentId, {
+      loading: true,
+      repositories: [],
+      error: null,
+    });
+
+  case REPOSITORY_SET_REPOSITORIES_SUCCESS:
+    return state.set(action.contentId, {
+      loading: false,
+      repositories: normalizeContentSetRepositories(
+        action.results,
+        action.contentId,
+        action.productId,
+      ),
+      error: null,
+    });
+
+  case REPOSITORY_SET_REPOSITORIES_FAILURE:
+    return state.set(action.contentId, {
+      loading: false,
+      repositories: [],
+      error: action.error,
+    });
+
+  case REPOSITORY_ENABLED:
+    return changeRepoState(state, action.repository, {
+      enabled: true,
+      loading: false,
+      error: false,
+    });
+
+  case REPOSITORY_DISABLED:
+    return changeRepoState(state, action.repository, { enabled: false });
+
+  default:
+    return state;
   }
 };

data/webpack/redux/reducers/RedHatRepositories/sets.js

@@ -14,36 +14,36 @@ export default (state = initialState, action) => {
   const { payload } = action;
 
   switch (action.type) {
-    case REPOSITORY_SETS_REQUEST:
-      return state.set('loading', true);
-
-    case REPOSITORY_SETS_UPDATE_RECOMMENDED:
-      return state
-        .set('recommended', payload);
-
-    case REPOSITORY_SETS_SUCCESS:
-      return state
-        .set('results', payload.response.results)
-        .set('pagination', {
-          page: Number(payload.response.page),
-          // server can return per_page: null when there's error in the search query,
-          // don't store it in such case
-          // eslint-disable-next-line camelcase
-          perPage: Number(payload.response.per_page || state.pagination.perPage),
-        })
-        .set('itemCount', Number(payload.response.subtotal))
-        .set('loading', false)
-        .set('searchIsActive', !isEmpty(payload.search))
-        .set('search', payload.search);
-
-    case REPOSITORY_SETS_FAILURE:
-      return Immutable({
-        error: payload,
-        loading: false,
-        missingPermissions: get(payload, ['response', 'data', 'error', 'missing_permissions']),
-      });
-
-    default:
-      return state;
+  case REPOSITORY_SETS_REQUEST:
+    return state.set('loading', true);
+
+  case REPOSITORY_SETS_UPDATE_RECOMMENDED:
+    return state
+      .set('recommended', payload);
+
+  case REPOSITORY_SETS_SUCCESS:
+    return state
+      .set('results', payload.response.results)
+      .set('pagination', {
+        page: Number(payload.response.page),
+        // server can return per_page: null when there's error in the search query,
+        // don't store it in such case
+        // eslint-disable-next-line camelcase
+        perPage: Number(payload.response.per_page || state.pagination.perPage),
+      })
+      .set('itemCount', Number(payload.response.subtotal))
+      .set('loading', false)
+      .set('searchIsActive', !isEmpty(payload.search))
+      .set('search', payload.search);
+
+  case REPOSITORY_SETS_FAILURE:
+    return Immutable({
+      error: payload,
+      loading: false,
+      missingPermissions: get(payload, ['response', 'data', 'error', 'missing_permissions']),
+    });
+
+  default:
+    return state;
   }
 };