katello 4.16.1 → 4.17.0.rc1

data/webpack/components/extensions/HostDetails/Tabs/__tests__/errataTab.test.js

@@ -1,5 +1,5 @@
 import React from 'react';
-import { renderWithRedux, patientlyWaitFor, within, fireEvent } from 'react-testing-lib-wrapper';
+import { renderWithRedux, patientlyWaitFor, within, fireEvent, act } from 'react-testing-lib-wrapper';
 import { nockInstance, assertNockRequest, mockForemanAutocomplete } from '../../../../../test-utils/nockWrapper';
 import { foremanApi } from '../../../../../services/api';
 import { HOST_ERRATA_KEY, ERRATA_SEARCH_QUERY } from '../ErrataTab/HostErrataConstants';
@@ -20,6 +20,9 @@ const contentFacetAttributes = {
   id: 11,
   uuid: 'e5761ea3-4117-4ecf-83d0-b694f99b389e',
   content_view_default: false,
+  contentView: {
+    rolling: false,
+  },
   lifecycle_environment_library: false,
   errata_counts: {
     total: 3,
@@ -123,7 +126,8 @@ test('Can call API for errata and show on screen on page load', async (done) =>
   await patientlyWaitFor(() => expect(getAllByText(firstErrata.severity)[0]).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can handle no errata being present', async (done) => {
@@ -149,7 +153,8 @@ test('Can handle no errata being present', async (done) => {
   await patientlyWaitFor(() => expect(queryByText('This host has errata that are applicable, but not installable. Adjust your filters and try again.')).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can display expanded errata details', async (done) => {
@@ -192,7 +197,8 @@ test('Can display expanded errata details', async (done) => {
   expect(queryByText(firstErrata.summary)).not.toBeInTheDocument();
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can select one errata', async (done) => {
@@ -225,7 +231,8 @@ test('Can select one errata', async (done) => {
   expect(queryByText('1 selected')).toBeInTheDocument();
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can select all errata across pages through checkbox', async (done) => {
@@ -265,8 +272,10 @@ test('Can select all errata across pages through checkbox', async (done) => {
   expect(getByLabelText('Select row 0').checked).toEqual(true);
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
-  assertNockRequest(scope2, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done();
+  assertNockRequest(scope2);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can deselect all errata across pages through checkbox', async (done) => {
@@ -310,8 +319,10 @@ test('Can deselect all errata across pages through checkbox', async (done) => {
   expect(getByLabelText('Select row 0').checked).toEqual(false);
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
-  assertNockRequest(scope2, done);
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
+  assertNockRequest(scope2);
+  done();
 });
 
 
@@ -352,8 +363,10 @@ test('Can select & deselect errata across pages', async (done) => {
   expect(queryByText('4 selected')).toBeInTheDocument();
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
-  assertNockRequest(scope2, done);
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
+  assertNockRequest(scope2);
+  done();
 });
 
 test('Can select & de-select all errata through selectDropDown', async (done) => {
@@ -394,7 +407,8 @@ test('Can select & de-select all errata through selectDropDown', async (done) =>
   expect(getByLabelText('Select row 0').checked).toEqual(false);
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can de-select items in select all mode across pages', async (done) => {
@@ -460,9 +474,12 @@ test('Can de-select items in select all mode across pages', async (done) => {
   expect(getByLabelText('Select row 1').checked).toEqual(false);
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
-  assertNockRequest(scope2, done);
-  assertNockRequest(scope3, done);
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
+  assertNockRequest(scope2);
+  done();
+  assertNockRequest(scope3);
+  done();
 });
 
 test('Can select page and select only items on the page', async (done) => {
@@ -496,7 +513,8 @@ test('Can select page and select only items on the page', async (done) => {
   expect(getByLabelText('Select row 0').checked).toEqual(true);
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Select all is disabled if all rows are selected', async (done) => {
@@ -550,7 +568,8 @@ test('Select all is disabled if all rows are selected', async (done) => {
   expect(getByText('Select none (0)')).toHaveAttribute('aria-disabled', 'false');
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group shows if it\'s not the default content view or library enviroment', async (done) => {
@@ -572,7 +591,8 @@ test('Toggle Group shows if it\'s not the default content view or library enviro
   await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
   expect(queryByLabelText('Installable Errata')).toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group shows if it\'s the default content view but non-library environment', async (done) => {
@@ -598,7 +618,8 @@ test('Toggle Group shows if it\'s the default content view but non-library envir
   await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
   expect(queryByLabelText('Installable Errata')).toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group shows if it\'s the library environment but non-default content view', async (done) => {
@@ -625,7 +646,8 @@ test('Toggle Group shows if it\'s the library environment but non-default conten
   await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
   expect(queryByLabelText('Installable Errata')).toBeInTheDocument();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Toggle Group does not show if it\'s the default content view and library environment', async (done) => {
@@ -648,6 +670,36 @@ test('Toggle Group does not show if it\'s the default content view and library e
     getAllByText,
   } = renderWithRedux(<ErrataTab />, options);
 
+  // Assert that the errata are now showing on the screen, but wait for them to appear.
+  await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
+  expect(queryByLabelText('Installable Errata')).not.toBeInTheDocument();
+  assertNockRequest(autocompleteScope);
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
+});
+
+test('Toggle Group does not show if it\'s a rolling content view and library environment', async (done) => {
+  // Setup autocomplete with mockForemanAutoComplete since we aren't adding /katello
+  const autocompleteScope = mockForemanAutocomplete(nockInstance, autocompleteUrl);
+  const mockErrata = makeMockErrata({});
+  const options = renderOptions({
+    ...cfWithErrataTotal(mockErrata.total),
+    contentView: {
+      rolling: true,
+    },
+    lifecycle_environment_library: true,
+  });
+  // return errata data results when we look for errata
+  const scope = nockInstance
+    .get(hostErrata)
+    .query(defaultQuery)
+    .reply(200, mockErrata);
+
+  const {
+    queryByLabelText,
+    getAllByText,
+  } = renderWithRedux(<ErrataTab />, options);
+
   // Assert that the errata are now showing on the screen, but wait for them to appear.
   await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
   expect(queryByLabelText('Installable Errata')).not.toBeInTheDocument();
@@ -676,7 +728,8 @@ test('Selection is disabled for errata which are applicable but not installable'
   expect(getByLabelText('Select row 1')).not.toBeDisabled();
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can select only installable errata across pages through checkbox', async (done) => {
@@ -719,8 +772,10 @@ test('Can select only installable errata across pages through checkbox', async (
   expect(getByLabelText('Select row 0').checked).toEqual(true);
 
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
-  assertNockRequest(scope2, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done();
+  assertNockRequest(scope2);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can toggle with the Toggle Group ', async (done) => {
@@ -746,7 +801,8 @@ test('Can toggle with the Toggle Group ', async (done) => {
   expect(getByText('Applicable').parentElement).toHaveAttribute('aria-pressed', 'false');
   expect(getAllByText('Installable')[0].parentElement).toHaveAttribute('aria-pressed', 'true');
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can filter by errata type', async (done) => {
@@ -788,7 +844,8 @@ test('Can filter by errata type', async (done) => {
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope2);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can filter by severity', async (done) => {
@@ -815,7 +872,7 @@ test('Can filter by severity', async (done) => {
   await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
   // the Bugfix text in the table is just a text node, while the dropdown is a button
   expect(getByText('Moderate', { ignore: ['button', 'title'] })).toBeInTheDocument();
-  expect(getByText('Important', { ignore: ['.pf-c-select__toggle-text', 'title'] })).toBeInTheDocument();
+  expect(getByText('Important', { ignore: ['.pf-v5-c-select__toggle-text', 'title'] })).toBeInTheDocument();
   expect(getByText('Critical', { ignore: ['button', 'title'] })).toBeInTheDocument();
   const severityContainer = queryByLabelText('select Severity container', { ignore: 'th' });
   const severityDropdown = within(severityContainer).queryByText('Severity');
@@ -824,17 +881,18 @@ test('Can filter by severity', async (done) => {
   const important = getByRole('option', { name: 'select Important' });
   fireEvent.click(important);
   await patientlyWaitFor(() => {
-    expect(queryByText('Moderate', { ignore: ['.pf-c-select__toggle-text'] })).not.toBeInTheDocument();
-    expect(queryByText('Critical', { ignore: ['.pf-c-select__toggle-text'] })).not.toBeInTheDocument();
+    expect(queryByText('Moderate', { ignore: ['.pf-v5-c-select__toggle-text'] })).not.toBeInTheDocument();
+    expect(queryByText('Critical', { ignore: ['.pf-v5-c-select__toggle-text'] })).not.toBeInTheDocument();
   });
   await patientlyWaitFor(() => {
-    expect(getByText('Important', { ignore: ['.pf-c-select__toggle-text', 'title'] })).toBeInTheDocument();
+    expect(getByText('Important', { ignore: ['.pf-v5-c-select__toggle-text', 'title'] })).toBeInTheDocument();
   });
 
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope2);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can bulk apply via remote execution', async (done) => {
@@ -871,11 +929,14 @@ test('Can bulk apply via remote execution', async (done) => {
   actionMenu.click();
   const viaRexAction = queryByText('Apply via remote execution');
   expect(viaRexAction).toBeInTheDocument();
-  viaRexAction.click();
+  await act(async () => {
+    viaRexAction.click();
+  });
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(resolveErrataScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Can select all, exclude and bulk apply via remote execution', async (done) => {
@@ -911,11 +972,14 @@ test('Can select all, exclude and bulk apply via remote execution', async (done)
   actionMenu.click();
   const viaRexAction = queryByText('Apply via remote execution');
   expect(viaRexAction).toBeInTheDocument();
-  viaRexAction.click();
+  await act(async () => {
+    viaRexAction.click();
+  });
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(resolveErrataScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Can apply errata in bulk via customized remote execution', async (done) => {
@@ -947,9 +1011,12 @@ test('Can apply errata in bulk via customized remote execution', async (done) =>
     `/job_invocations/new?feature=${feature}&search=name%20%5E%20(${hostName})&inputs%5BErrata%20search%20query%5D=errata_id%20%5E%20(${errata})`,
   );
 
-  viaRexAction.click();
+  await act(async () => {
+    viaRexAction.click();
+  });
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Can apply a single erratum to the host via remote execution', async (done) => {
@@ -973,20 +1040,25 @@ test('Can apply a single erratum to the host via remote execution', async (done)
     renderOptions(cfWithErrataTotal(mockErrata.total)),
   );
   await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
-  const erratumActionMenu = within(getByLabelText('Select row 0').closest('tr')).getByLabelText('Actions');
-  expect(erratumActionMenu).toHaveAttribute('aria-label', 'Actions');
-  erratumActionMenu.click();
+  const erratumActionMenu = within(getByLabelText('Select row 0').closest('tr')).getByLabelText('Kebab toggle');
+  expect(erratumActionMenu).toHaveAttribute('aria-label', 'Kebab toggle');
+  await act(async () => {
+    erratumActionMenu.click();
+  });
 
   let viaRexAction;
   await patientlyWaitFor(() => {
     viaRexAction = getByText('Apply via remote execution');
     expect(viaRexAction).toBeInTheDocument();
   });
-  viaRexAction.click();
+  await act(async () => {
+    viaRexAction.click();
+  });
 
   assertNockRequest(autocompleteScope);
   assertNockRequest(resolveErrataScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Can apply a single erratum to the host via customized remote execution', async (done) => {
@@ -1005,20 +1077,24 @@ test('Can apply a single erratum to the host via customized remote execution', a
     renderOptions(cfWithErrataTotal(mockErrata.total)),
   );
   await patientlyWaitFor(() => expect(getAllByText('Important')[0]).toBeInTheDocument());
-  const erratumActionMenu = within(getByLabelText('Select row 0').closest('tr')).getByLabelText('Actions');
-  expect(erratumActionMenu).toHaveAttribute('aria-label', 'Actions');
-  erratumActionMenu.click();
-
+  const erratumActionMenu = within(getByLabelText('Select row 0').closest('tr')).getByLabelText('Kebab toggle');
+  expect(erratumActionMenu).toHaveAttribute('aria-label', 'Kebab toggle');
+  await act(async () => {
+    erratumActionMenu.click();
+  });
   let viaRexAction;
   await patientlyWaitFor(() => {
     viaRexAction = getByText('Apply via customized remote execution');
     expect(viaRexAction).toBeInTheDocument();
   });
-  viaRexAction.click();
+  await act(async () => {
+    viaRexAction.click();
+  });
   expect(viaRexAction).toHaveAttribute(
     'href',
     `/job_invocations/new?feature=${feature}&search=name%20%5E%20(${hostName})&inputs%5BErrata%20search%20query%5D=errata_id%20=%20${errataId}`,
   );
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });

data/webpack/components/extensions/HostDetails/Tabs/__tests__/moduleStreamsTab.test.js

@@ -62,7 +62,8 @@ test('Can call API for Module streams and show on screen on page load', async (d
     expect(getAllByText(firstModuleStreams.name)[0]).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
   act(done);
 });
 
@@ -89,7 +90,8 @@ test('Can handle no Module streams being present', async (done) => {
   await patientlyWaitFor(() => expect(queryByText('This host does not have any Module streams.')).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
   act(done);
 });
 
@@ -166,7 +168,8 @@ test('When there are no search results, can display an empty state with a clear
   assertNockRequest(badAutoCompleteScope);
   assertNockRequest(badSearchScope);
   assertNockRequest(scopeWithoutSearch);
-  assertNockRequest(autocompleteScope, done);
+  assertNockRequest(autocompleteScope);
+  done();
 });
 
 test('Can filter results based on status', async (done) => {
@@ -198,7 +201,8 @@ test('Can filter results based on status', async (done) => {
   fireEvent.click(installed);
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done);
+  assertNockRequest(scope2);
+  done();
   act(done);
 });
 
@@ -231,7 +235,8 @@ test('Can filter results based on Installation status', async (done) => {
   fireEvent.click(installed);
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(scope2, done);
+  assertNockRequest(scope2);
+  done();
   act(done);
 });
 
@@ -260,7 +265,8 @@ test('Can provide dropdown actions with redirects on Module Streams with customi
   expect(getByText('Enable')).toHaveAttribute('href', '/job_invocations/new?feature=katello_module_stream_action&search=name%20%5E%20(test-host)&inputs%5Baction%5D=enable&inputs%5Bmodule_spec%5D=walrus:2.4');
   expect(getByText('Install')).toHaveAttribute('href', '/job_invocations/new?feature=katello_module_stream_action&search=name%20%5E%20(test-host)&inputs%5Baction%5D=install&inputs%5Bmodule_spec%5D=walrus:2.4');
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
   act(done);
 });
 
@@ -305,6 +311,7 @@ test('Can perform actions on Module Streams', async (done) => {
   fireEvent.click(getByLabelText('confirm-module-action'));
   assertNockRequest(autocompleteScope);
   assertNockRequest(scope);
-  assertNockRequest(jobScope, done);
+  assertNockRequest(jobScope);
+  done();
   act(done);
 });

data/webpack/components/extensions/HostDetails/Tabs/__tests__/packageInstallModal.test.js

@@ -79,7 +79,8 @@ test('Can call API for installable packages and show on screen on page load', as
   await patientlyWaitFor(() => expect(getAllByText(firstPackages.name)[0]).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 test('Can handle no installable packages being present', async (done) => {
@@ -111,7 +112,8 @@ test('Can handle no installable packages being present', async (done) => {
   await patientlyWaitFor(() => expect(queryByText('No packages available to install')).toBeInTheDocument());
   // Assert request was made and completed, see helper function
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done); // Pass jest callback to confirm test is done
+  assertNockRequest(scope);
+  done(); // Pass jest callback to confirm test is done
 });
 
 
@@ -148,7 +150,8 @@ test('Can install a package via remote execution', async (done) => {
 
   expect(triggerPackageInstall).toHaveBeenCalled();
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Can install a package via customized remote execution', async (done) => {
@@ -185,7 +188,8 @@ test('Can install a package via customized remote execution', async (done) => {
     `/job_invocations/new?feature=${REX_FEATURES.KATELLO_PACKAGE_INSTALL}&search=name%20%5E%20(test-host)&inputs%5Bpackage%5D=duck,cheetah`,
   );
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });
 
 test('Uses package_install_by_search_query template when in select all mode', async (done) => {
@@ -223,6 +227,7 @@ test('Uses package_install_by_search_query template when in select all mode', as
     `/job_invocations/new?feature=${REX_FEATURES.KATELLO_PACKAGE_INSTALL_BY_SEARCH}&search=name%20%5E%20(test-host)&inputs%5BPackage%20search%20query%5D=id%20!%5E%20(32376)`,
   );
   assertNockRequest(autocompleteScope);
-  assertNockRequest(scope, done);
+  assertNockRequest(scope);
+  done();
 });