katello 4.15.1 → 4.16.0.rc1

data/db/migrate/20200213184848_create_evr_type.rb

@@ -4,7 +4,132 @@ class CreateEvrType < ActiveRecord::Migration[5.2]
   def up
     unless connection.adapter_name.downcase.include?('sqlite')
 
-      enable_extension "evr"
+      execute <<~SQL
+              create type evr_array_item as (
+          n       NUMERIC,
+          s       TEXT
+        );
+
+        create type evr_t as (
+          epoch INT,
+          version evr_array_item[],
+          release evr_array_item[]
+        );
+
+        CREATE FUNCTION evr_trigger() RETURNS trigger AS $$
+          BEGIN
+            NEW.evr = (select ROW(coalesce(NEW.epoch::numeric,0),
+                                  rpmver_array(coalesce(NEW.version,'empty'))::evr_array_item[],
+                                  rpmver_array(coalesce(NEW.release,'empty'))::evr_array_item[])::evr_t);
+            RETURN NEW;
+          END;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION empty(t TEXT)
+        	RETURNS BOOLEAN as $$
+        	BEGIN
+        		return t ~ '^[[:space:]]*$';
+        	END;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION isalpha(ch CHAR)
+          RETURNS BOOLEAN as $$
+          BEGIN
+            if ascii(ch) between ascii('a') and ascii('z') or
+                ascii(ch) between ascii('A') and ascii('Z')
+            then
+              return TRUE;
+            end if;
+            return FALSE;
+          END;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION isalphanum(ch CHAR)
+        	RETURNS BOOLEAN as $$
+        	BEGIN
+        		if ascii(ch) between ascii('a') and ascii('z') or
+        			ascii(ch) between ascii('A') and ascii('Z') or
+        			ascii(ch) between ascii('0') and ascii('9')
+        		then
+        			return TRUE;
+        		end if;
+        		return FALSE;
+        	END;
+        $$ language 'plpgsql';
+
+        create or replace function isdigit(ch CHAR)
+        	RETURNS BOOLEAN as $$
+        	BEGIN
+        	  if ascii(ch) between ascii('0') and ascii('9')
+        	  then
+        		return TRUE;
+        	  end if;
+        	  return FALSE;
+        	END ;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION rpmver_array (string1 IN VARCHAR)
+        	RETURNS evr_array_item[] as $$
+        	declare
+        		str1 VARCHAR := string1;
+        		digits VARCHAR(10) := '0123456789';
+        		lc_alpha VARCHAR(27) := 'abcdefghijklmnopqrstuvwxyz';
+        		uc_alpha VARCHAR(27) := 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
+        		alpha VARCHAR(54) := lc_alpha || uc_alpha;
+        		one VARCHAR;
+        		isnum BOOLEAN;
+        		ver_array evr_array_item[] := ARRAY[]::evr_array_item[];
+        	BEGIN
+        		if str1 is NULL
+        		then
+        			RAISE EXCEPTION 'VALUE_ERROR.';
+        		end if;
+
+        		one := str1;
+        		<<segment_loop>>
+        		while one <> ''
+        		loop
+        			declare
+        				segm1 VARCHAR;
+        				segm1_n NUMERIC := 0;
+        			begin
+        				-- Throw out all non-alphanum characters
+        				while one <> '' and not isalphanum(one)
+        				loop
+        					one := substr(one, 2);
+        				end loop;
+        				str1 := one;
+        				if str1 <> '' and isdigit(str1)
+        				then
+        					str1 := ltrim(str1, digits);
+        					isnum := true;
+        				else
+        					str1 := ltrim(str1, alpha);
+        					isnum := false;
+        				end if;
+        				if str1 <> ''
+        				then segm1 := substr(one, 1, length(one) - length(str1));
+        				else segm1 := one;
+        				end if;
+
+        				if segm1 = '' then return ver_array; end if; /* arbitrary */
+        				if isnum
+        				then
+        					segm1 := ltrim(segm1, '0');
+        					if segm1 <> '' then segm1_n := segm1::numeric; end if;
+        					segm1 := NULL;
+        				else
+        				end if;
+        				ver_array := array_append(ver_array, (segm1_n, segm1)::evr_array_item);
+        				one := str1;
+        			end;
+        		end loop segment_loop;
+
+        		return ver_array;
+        	END ;
+        $$ language 'plpgsql';
+
+      SQL
 
       add_column :katello_rpms, :evr, :evr_t
       add_column :katello_installed_packages, :evr, :evr_t

data/db/migrate/20200818192230_update_system_purpose_status.rb

@@ -2,7 +2,6 @@ class UpdateSystemPurposeStatus < ActiveRecord::Migration[6.0]
   def change
     purpose_types = [
       "Katello::PurposeStatus",
-      "Katello::PurposeAddonsStatus",
       "Katello::PurposeRoleStatus",
       "Katello::PurposeSlaStatus",
       "Katello::PurposeUsageStatus",

data/db/migrate/20240207191223_remove_entitlement_mode_host_statuses.rb

@@ -8,7 +8,6 @@ class RemoveEntitlementModeHostStatuses < ActiveRecord::Migration[6.1]
     obsolete_statuses = [
       "Katello::SubscriptionStatus",
       "Katello::PurposeStatus",
-      "Katello::PurposeAddonsStatus",
       "Katello::PurposeRoleStatus",
       "Katello::PurposeSlaStatus",
       "Katello::PurposeUsageStatus",

data/db/migrate/20240924161240_katello_recreate_evr_constructs.rb

@@ -0,0 +1,160 @@
+class KatelloRecreateEvrConstructs < ActiveRecord::Migration[6.1]
+  def up
+    if !extension_enabled?('evr')
+      return
+    else
+      execute <<~SQL
+        DROP EXTENSION evr CASCADE;
+      SQL
+
+      execute <<~SQL
+              create type evr_array_item as (
+          n       NUMERIC,
+          s       TEXT
+        );
+
+        create type evr_t as (
+          epoch INT,
+          version evr_array_item[],
+          release evr_array_item[]
+        );
+
+        CREATE FUNCTION evr_trigger() RETURNS trigger AS $$
+          BEGIN
+            NEW.evr = (select ROW(coalesce(NEW.epoch::numeric,0),
+                                  rpmver_array(coalesce(NEW.version,'empty'))::evr_array_item[],
+                                  rpmver_array(coalesce(NEW.release,'empty'))::evr_array_item[])::evr_t);
+            RETURN NEW;
+          END;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION empty(t TEXT)
+        	RETURNS BOOLEAN as $$
+        	BEGIN
+        		return t ~ '^[[:space:]]*$';
+        	END;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION isalpha(ch CHAR)
+          RETURNS BOOLEAN as $$
+          BEGIN
+            if ascii(ch) between ascii('a') and ascii('z') or
+                ascii(ch) between ascii('A') and ascii('Z')
+            then
+              return TRUE;
+            end if;
+            return FALSE;
+          END;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION isalphanum(ch CHAR)
+        	RETURNS BOOLEAN as $$
+        	BEGIN
+        		if ascii(ch) between ascii('a') and ascii('z') or
+        			ascii(ch) between ascii('A') and ascii('Z') or
+        			ascii(ch) between ascii('0') and ascii('9')
+        		then
+        			return TRUE;
+        		end if;
+        		return FALSE;
+        	END;
+        $$ language 'plpgsql';
+
+        create or replace function isdigit(ch CHAR)
+        	RETURNS BOOLEAN as $$
+        	BEGIN
+        	  if ascii(ch) between ascii('0') and ascii('9')
+        	  then
+        		return TRUE;
+        	  end if;
+        	  return FALSE;
+        	END ;
+        $$ language 'plpgsql';
+
+        create or replace FUNCTION rpmver_array (string1 IN VARCHAR)
+        	RETURNS evr_array_item[] as $$
+        	declare
+        		str1 VARCHAR := string1;
+        		digits VARCHAR(10) := '0123456789';
+        		lc_alpha VARCHAR(27) := 'abcdefghijklmnopqrstuvwxyz';
+        		uc_alpha VARCHAR(27) := 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
+        		alpha VARCHAR(54) := lc_alpha || uc_alpha;
+        		one VARCHAR;
+        		isnum BOOLEAN;
+        		ver_array evr_array_item[] := ARRAY[]::evr_array_item[];
+        	BEGIN
+        		if str1 is NULL
+        		then
+        			RAISE EXCEPTION 'VALUE_ERROR.';
+        		end if;
+
+        		one := str1;
+        		<<segment_loop>>
+        		while one <> ''
+        		loop
+        			declare
+        				segm1 VARCHAR;
+        				segm1_n NUMERIC := 0;
+        			begin
+        				-- Throw out all non-alphanum characters
+        				while one <> '' and not isalphanum(one)
+        				loop
+        					one := substr(one, 2);
+        				end loop;
+        				str1 := one;
+        				if str1 <> '' and isdigit(str1)
+        				then
+        					str1 := ltrim(str1, digits);
+        					isnum := true;
+        				else
+        					str1 := ltrim(str1, alpha);
+        					isnum := false;
+        				end if;
+        				if str1 <> ''
+        				then segm1 := substr(one, 1, length(one) - length(str1));
+        				else segm1 := one;
+        				end if;
+
+        				if segm1 = '' then return ver_array; end if; /* arbitrary */
+        				if isnum
+        				then
+        					segm1 := ltrim(segm1, '0');
+        					if segm1 <> '' then segm1_n := segm1::numeric; end if;
+        					segm1 := NULL;
+        				else
+        				end if;
+        				ver_array := array_append(ver_array, (segm1_n, segm1)::evr_array_item);
+        				one := str1;
+        			end;
+        		end loop segment_loop;
+
+        		return ver_array;
+        	END ;
+        $$ language 'plpgsql';
+
+      SQL
+
+      add_column :katello_rpms, :evr, :evr_t
+      add_column :katello_installed_packages, :evr, :evr_t
+
+      execute <<-SQL
+        update katello_rpms SET evr = (ROW(coalesce(epoch::numeric,0),
+                                           rpmver_array(coalesce(version,'empty'))::evr_array_item[],
+                                           rpmver_array(coalesce(release,'empty'))::evr_array_item[])::evr_t);
+
+        update katello_installed_packages SET evr = (ROW(coalesce(epoch::numeric,0),
+                                                         rpmver_array(coalesce(version,'empty'))::evr_array_item[],
+                                                         rpmver_array(coalesce(release,'empty'))::evr_array_item[])::evr_t);
+      SQL
+
+      create_trigger :evr_insert_trigger_katello_rpms, on: :katello_rpms
+      create_trigger :evr_update_trigger_katello_rpms, on: :katello_rpms
+      create_trigger :evr_insert_trigger_katello_installed_packages, on: :katello_installed_packages
+      create_trigger :evr_update_trigger_katello_installed_packages, on: :katello_installed_packages
+    end
+  end
+
+  def down
+    fail ActiveRecord::IrreversibleMigration
+  end
+end

data/db/migrate/20241022121706_add_sync_dependencies_option.rb

@@ -0,0 +1,5 @@
+class AddSyncDependenciesOption < ActiveRecord::Migration[6.1]
+  def change
+    add_column :katello_root_repositories, :sync_dependencies, :boolean, :default => true
+  end
+end

data/db/migrate/20241101144625_remove_system_purpose_addons.rb

@@ -0,0 +1,9 @@
+class RemoveSystemPurposeAddons < ActiveRecord::Migration[6.1]
+  def change
+    remove_foreign_key :katello_subscription_facet_purpose_addons, :katello_purpose_addons, column: :purpose_addon_id
+
+    drop_table :katello_activation_key_purpose_addons
+    drop_table :katello_purpose_addons
+    drop_table :katello_subscription_facet_purpose_addons
+  end
+end

data/db/migrate/20241107002541_add_registry_url_to_katello_flatpak_remotes.rb

@@ -0,0 +1,5 @@
+class AddRegistryURLToKatelloFlatpakRemotes < ActiveRecord::Migration[6.1]
+  def change
+    add_column :katello_flatpak_remotes, :registry_url, :string
+  end
+end

data/db/migrate/20241112145802_add_manifest_entity_to_content_facets.rb

@@ -0,0 +1,7 @@
+class AddManifestEntityToContentFacets < ActiveRecord::Migration[6.1]
+  def change
+    add_reference :katello_content_facets, :manifest_entity, polymorphic: true, index: true
+    change_column_null :katello_content_facets, :manifest_entity_type, true
+    change_column_null :katello_content_facets, :manifest_entity_id, true
+  end
+end

data/db/migrate/20241120213713_add_allow_other_types_to_content_view_erratum_filter_rules.rb

@@ -0,0 +1,6 @@
+class AddAllowOtherTypesToContentViewErratumFilterRules < ActiveRecord::Migration[6.1]
+  def change
+    add_column :katello_content_view_erratum_filter_rules, :allow_other_types, :boolean,
+      :default => false, :null => false
+  end
+end

data/db/migrate/20241206183052_add_content_type_to_container_manifests_and_lists.rb

@@ -0,0 +1,9 @@
+class AddContentTypeToContainerManifestsAndLists < ActiveRecord::Migration[6.1]
+  def change
+    add_column :katello_docker_manifests, :content_type, :string, :limit => 255
+    add_column :katello_docker_manifest_lists, :content_type, :string, :limit => 255
+
+    add_index :katello_docker_manifests, :content_type
+    add_index :katello_docker_manifest_lists, :content_type
+  end
+end

data/db/seeds.d/75-job_templates.rb

@@ -1,8 +1,12 @@
 User.as_anonymous_admin do
   JobTemplate.without_auditing do
+    # let's name root template as *_action.erb
+    root_action_files = Dir[File.join("#{Katello::Engine.root}/app/views/foreman/job_templates/**/*_action.erb")]
     template_files = Dir[File.join("#{Katello::Engine.root}/app/views/foreman/job_templates/**/*.erb")]
     template_files.reject! { |file| file.end_with?('_ansible_default.erb') } unless Katello.with_ansible?
-    template_files.each do |template|
+
+    # root templates need to be imported first
+    (root_action_files + (template_files - root_action_files)).each do |template|
       sync = !Rails.env.test? && Setting[:remote_execution_sync_templates]
       template = JobTemplate.import_raw!(File.read(template), :default => true, :lock => true, :update => sync)
 

data/engines/bastion/vendor/assets/javascripts/bastion/angular/angular.js

@@ -9593,7 +9593,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
 
         if (writeAttr !== false) {
           if (value === null || isUndefined(value)) {
-            this.$$element.removeAttr(attrName);
+            this.$$element.prop(attrName, false);
           } else {
             if (SIMPLE_ATTR_NAME.test(attrName)) {
               // jQuery skips special boolean attrs treatment in XML nodes for
@@ -9602,7 +9602,7 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
               // in XHTML, call `removeAttr` in such cases instead.
               // See https://github.com/jquery/jquery/issues/4249
               if (booleanKey && value === false) {
-                this.$$element.removeAttr(attrName);
+                this.$$element.prop(attrName, false);
               } else {
                 this.$$element.attr(attrName, value);
               }

data/engines/bastion/vendor/assets/javascripts/bastion/angular-bootstrap/ui-bootstrap-tpls.js

@@ -6083,7 +6083,7 @@ angular.module('ui.bootstrap.timepicker', [])
     padHours = angular.isDefined($attrs.padHours) ? $scope.$parent.$eval($attrs.padHours) : true;
 
   $scope.tabindex = angular.isDefined($attrs.tabindex) ? $attrs.tabindex : 0;
-  $element.removeAttr('tabindex');
+  $element.prop('tabIndex', false);
 
   this.init = function(ngModelCtrl_, inputs) {
     ngModelCtrl = ngModelCtrl_;
@@ -6806,7 +6806,7 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap
       });
 
       if (hintInputElem.attr('id')) {
-        hintInputElem.removeAttr('id'); // remove duplicate id if present.
+        hintInputElem.prop('id', false); // remove duplicate id if present.
       }
       inputsContainer.append(hintInputElem);
       hintInputElem.after(element);
@@ -6855,7 +6855,7 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap
     // This attribute is added or removed automatically when the `activeIdx` changes.
     scope.$watch('activeIdx', function(index) {
       if (index < 0) {
-        element.removeAttr('aria-activedescendant');
+        element.prop('aria-activedescendant', false);
       } else {
         element.attr('aria-activedescendant', getMatchId(index));
       }

data/engines/bastion/vendor/assets/javascripts/bastion/angular-bootstrap/ui-bootstrap.js

@@ -6082,7 +6082,7 @@ angular.module('ui.bootstrap.timepicker', [])
     padHours = angular.isDefined($attrs.padHours) ? $scope.$parent.$eval($attrs.padHours) : true;
 
   $scope.tabindex = angular.isDefined($attrs.tabindex) ? $attrs.tabindex : 0;
-  $element.removeAttr('tabindex');
+  $element.prop('tabindex', false);
 
   this.init = function(ngModelCtrl_, inputs) {
     ngModelCtrl = ngModelCtrl_;
@@ -6805,7 +6805,7 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap
       });
 
       if (hintInputElem.attr('id')) {
-        hintInputElem.removeAttr('id'); // remove duplicate id if present.
+        hintInputElem.prop('id', false); // remove duplicate id if present.
       }
       inputsContainer.append(hintInputElem);
       hintInputElem.after(element);
@@ -6854,7 +6854,7 @@ angular.module('ui.bootstrap.typeahead', ['ui.bootstrap.debounce', 'ui.bootstrap
     // This attribute is added or removed automatically when the `activeIdx` changes.
     scope.$watch('activeIdx', function(index) {
       if (index < 0) {
-        element.removeAttr('aria-activedescendant');
+        element.prop('aria-activedescendant', '');
       } else {
         element.attr('aria-activedescendant', getMatchId(index));
       }

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/activation-keys/details/activation-key-details-info.controller.js

@@ -117,11 +117,6 @@ angular.module('Bastion.activation-keys').controller('ActivationKeyDetailsInfoCo
             $scope.save($scope.activationKey);
         };
 
-        $scope.clearAddOns = function () {
-            $scope.activationKey['purpose_addons'] = [];
-            $scope.save($scope.activationKey);
-        };
-
         $scope.contentViews = function () {
             var deferred = $q.defer();
 

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/activation-keys/details/activation-key-details.controller.js

@@ -22,11 +22,9 @@ angular.module('Bastion.activation-keys').controller('ActivationKeyDetailsContro
         $scope.defaultRoles = ['Red Hat Enterprise Linux Server', 'Red Hat Enterprise Linux Workstation', 'Red Hat Enterprise Linux Compute Node'];
         $scope.defaultUsages = ['Production', 'Development/Test', 'Disaster Recovery'];
 
-        $scope.purposeAddonsCount = 0;
         $scope.simpleContentAccessEnabled = simpleContentAccessEnabled;
 
-        $scope.organization = Organization.get({id: CurrentOrganization}, function(org) {
-            $scope.purposeAddonsCount += org.system_purposes.addons.length;
+        $scope.organization = Organization.get({id: CurrentOrganization}, function() {
         });
 
         $scope.panel = {
@@ -113,43 +111,5 @@ angular.module('Bastion.activation-keys').controller('ActivationKeyDetailsContro
                 return _.union(roles, $scope.defaultRoles);
             });
         };
-
-
-        $scope.savePurposeAddons = function (key) {
-
-            if ($scope.purposeAddonsList) {
-                key['purpose_addons'] = _.chain($scope.purposeAddonsList).filter(function(addOn) {
-                    return addOn.selected;
-                }).map(function(addOn) {
-                    return addOn.name;
-                }).value();
-            }
-
-            return $scope.save(key);
-        };
-
-
-        $scope.purposeAddons = function () {
-            var purposeAddons;
-            var addOns;
-
-            return $scope.organization.$promise.then(function(org) {
-                $scope.purposeAddonsList = [];
-                addOns = org.system_purposes.addons;
-
-                purposeAddons = $scope.activationKey.purpose_addons;
-                angular.forEach(purposeAddons, function(addOn) {
-                    if (addOn && !_.includes(addOns, addOn)) {
-                        addOns.push(addOn);
-                    }
-                });
-
-                angular.forEach(addOns, function (addOn) {
-                    $scope.purposeAddonsList.push({"name": addOn, "selected": purposeAddons.indexOf(addOn) > -1});
-                });
-
-                return $scope.purposeAddonsList;
-            });
-        };
     }]
 );

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/activation-keys/details/views/activation-key-info.html

@@ -93,18 +93,6 @@
           on-delete="clearRole()"
           on-save="save(activationKey)">
       </dd>
-
-      <dt translate>Add ons</dt>
-      <dd bst-edit-multiselect="activationKey.purpose_addons"
-          readonly="denied('edit_activation_keys', activationKey) || purposeAddonsCount === 0"
-          options="purposeAddons()"
-          formatter="arrayToString"
-          deletable="true"
-          on-delete="clearAddOns()"
-          selector="activationKey.purpose_addons"
-          on-save="savePurposeAddons(activationKey)">
-      </dd>
-
     </dl>
   </div>
 

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/common/views/subscription-add-or-remove.html

@@ -40,7 +40,7 @@
        </td>
        <td bst-table-cell><div subscription-type="subscription"></div></td>
        <td bst-table-cell><div subscription-start-date="subscription"></div></td>
-       <td bst-table-cell><date date="subscription.end_date" /></td>
+       <td bst-table-cell><date date="subscription.end_date" ></date></td>
        <td bst-table-cell>{{ subscription.support_level }}</td>
        <td bst-table-cell>{{ subscription.contract_number }}</td>
        <td bst-table-cell>{{ subscription.account_number }}</td>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/content-hosts-bulk-system-purpose-modal.controller.js

@@ -19,14 +19,6 @@ angular.module('Bastion.content-hosts').controller('ContentHostsBulkSystemPurpos
 
         $scope.organization = Organization.get({id: CurrentOrganization});
 
-        $scope.purposeAddonsList = function () {
-            var defaultOptions = ['No Change', 'None (Clear)'];
-            if ($scope.organization.system_purposes && $scope.organization.system_purposes.addons) {
-                return defaultOptions.concat($scope.organization.system_purposes.addons);
-            }
-            return [];
-        };
-
         $scope.defaultUsages = ['No change', 'None (Clear)', 'Production', 'Development/Test', 'Disaster Recovery'];
         $scope.defaultRoles = ['No change', 'None (Clear)', 'Red Hat Enterprise Linux Server', 'Red Hat Enterprise Linux Workstation', 'Red Hat Enterprise Linux Compute Node'];
         $scope.defaultServiceLevels = ['No change', 'None (Clear)', 'Self-Support', 'Standard', 'Premium'];
@@ -37,54 +29,22 @@ angular.module('Bastion.content-hosts').controller('ContentHostsBulkSystemPurpos
         $scope.selectedRoles = $scope.defaultRoles[0];
         $scope.selectedServiceLevels = $scope.defaultServiceLevels[0];
 
-        $scope.selected = {
-           addons: undefined
-        };
-
         $scope.selectedItemToParam = function (item) {
             var mapping = {
                 "None (Clear)": "",
-                "No change": null,
-                "": []
+                "No change": null
             };
-            if (Array.isArray(item)) {
-                return $scope.selectedAddonsToParam(item);
-            }
             if (mapping.hasOwnProperty(item)) {
                 return mapping[item];
             }
             return item;
         };
 
-        $scope.selectedAddonsToParam = function (addons) {
-            var intentOptions = ['No Change', 'None (Clear)'];
-
-            var userIntent = intentOptions.filter(function(val) {
-                return addons.indexOf(val) !== -1;
-            });
-
-            if (userIntent.length === 0) {
-                return addons;
-            }
-
-            if (userIntent.includes('No Change')) {
-                return null;
-            }
-
-            if (userIntent.includes('None (Clear)') && addons.length === 1) {
-                return [];
-            } if (userIntent.includes('None (Clear)') && addons.length > 1) {
-                addons.shift();
-                return addons;
-            }
-        };
-
         function actionParams() {
             var params = hostIds;
 
             params['purpose_usage'] = $scope.selectedItemToParam($scope.selectedUsages);
             params['purpose_role'] = $scope.selectedItemToParam($scope.selectedRoles);
-            params['purpose_addons'] = $scope.selectedItemToParam($scope.selectedAddons);
             params['service_level'] = $scope.selectedItemToParam($scope.selectedServiceLevels);
 
             return params;

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/content-hosts-bulk-traces-modal.controller.js

@@ -34,7 +34,7 @@ angular.module('Bastion.content-hosts').controller('ContentHostsBulkTracesContro
                 Notification.setSuccessMessage(message, {
                     link: {
                         children: translate("View job invocations."),
-                        href: translate("/job_invocations")
+                        href: "/job_invocations"
                     }});
                 $scope.ok();
             };

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/views/content-hosts-bulk-errata-modal.html

@@ -102,11 +102,11 @@
               <span ng-switch="newHostDetailsUI">
                 <a ng-switch-when="true" target="_blank" href="{{ '/hosts?search=installable_errata%3D' + erratum.errata_id }}">
                   {{ erratum.affected_hosts_count }}
-                <span class="fa fa-external-link"/>
+                  <span class="fa fa-external-link"></span>
                 </a>
                 <a ng-switch-when="false" target="_blank" href="{{ '/content_hosts?search=installable_errata%3D' + erratum.errata_id }}">
                 {{ erratum.affected_hosts_count }}
-                <span class="fa fa-external-link"/>
+                  <span class="fa fa-external-link"></span>
               </a>
               </span>
              </td>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/views/content-hosts-bulk-subscriptions-modal.html

@@ -16,7 +16,7 @@
         </p>
 
         <p>
-        <div content-access-mode-banner/>
+        <div content-access-mode-banner></div>
         </p>
 
         <p class="help-text" translate ng-show="table.numSelected > 0 && !simpleContentAccessEnabled">
@@ -106,7 +106,7 @@
               <td bst-table-cell>{{ subscription | subscriptionConsumedFilter }}</td>
               <td bst-table-cell><div subscription-type="subscription"></div></td>
               <td bst-table-cell><div subscription-start-date="subscription"></div></td>
-              <td bst-table-cell><date date="subscription.end_date" /></td>
+              <td bst-table-cell><date date="subscription.end_date" ></date></td>
               <td bst-table-cell>{{ subscription.support_level }}</td>
               <td bst-table-cell>{{ subscription.contract_number }}</td>
               <td bst-table-cell>{{ subscription.account_number }}</td>