katello 4.0.0 → 4.1.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a68ac9c26daead6a548c835d225d8dbebe0ce33ca5b6315b6505ef64660d9ee6
-  data.tar.gz: '09d66a70cef13109aff1e38a9e409862c5cae6263c5c7aea415399c7cd0e08b0'
+  metadata.gz: cc20921c082e7725e89028befc8b8e9469b5088304795b5cbeb4cfc9bc343866
+  data.tar.gz: aee4945d14f0e66a96d516eb3e47ee0e93fc02d9bb7384e28f5d360646a73a88
 SHA512:
-  metadata.gz: cd9715ea64ef37bf05df3ae49a209e15f0ffe0c51d8f69d4b3fcba119909349fea1fe1ab4f464240515057e1529304850176ec5a48cbbfb25cd04fb1ee788137
-  data.tar.gz: 6ab0c5c117c51017b37ca1366fc05f64efcc7a17375e2bb4ac9ee3633990baedf68ba505cc29292295f5a01e31ac6fd4bef209d9272e2f5cfce0f3f9c7f29a65
+  metadata.gz: b868b400fb3a0be4e7db0755700b45b5388e4c433a447dfe335c7bc156f40b5dc557fce7553aa79fa2eaa61bb83e0ceae3c27cbb7deb2458efb15f7ac890df22
+  data.tar.gz: 550c55ae8bec58857cfa5b75d33579f9c9de56013a58f273487fdccdf9378890f2d47ac257fdf8b2b29a89fd648cdd8e668725358b169dcf35f0277d7758e0a3

data/app/assets/javascripts/katello/hosts/host_and_hostgroup_edit.js

@@ -9,12 +9,6 @@ $(document).on('ContentLoad', function(){
     $("#hostgroup_lifecycle_environment_id").change(KT.hosts.environmentChanged);
     $("#host_lifecycle_environment_id").change(KT.hosts.environmentChanged);
 
-    $("#hostgroup_content_view_id").change(KT.hosts.contentViewSelected);
-    $("#host_content_view_id").change(KT.hosts.contentViewSelected);
-    $("#reset_puppet_environment").click(function() {
-        KT.hosts.getPuppetEnvironmentSelect().data('content_puppet_match', 'true');
-        KT.hosts.setDefaultPuppetEnvironment(KT.hosts.getSelectedContentView(), KT.hosts.getSelectedEnvironment());
-    });
     KT.hosts.update_media_enablement();
     KT.hosts.set_media_selection_bindings();
 });
@@ -68,33 +62,6 @@ KT.hosts.signalContentViewFetch = function(fetching) {
     }
 };
 
-
-KT.hosts.contentViewSelected = function() {
-    if (KT.hosts.getPuppetEnvironmentSelect().data('content_puppet_match')) {
-        KT.hosts.setDefaultPuppetEnvironment(KT.hosts.getSelectedContentView(), KT.hosts.getSelectedEnvironment());
-    }
-};
-
-KT.hosts.setDefaultPuppetEnvironment = function(view_id, env_id) {
-    if (view_id && env_id) {
-        $.get('/hosts/puppet_environment_for_content_view', {content_view_id: view_id, lifecycle_environment_id: env_id}, function (data) {
-            var select = KT.hosts.getPuppetEnvironmentSelect();
-            if (data !== null) {
-                select.val(data.id);
-                select.trigger('change');
-            }
-        })
-    }
-};
-
-KT.hosts.getPuppetEnvironmentSelect = function() {
-    var select = $("#host_environment_id").first();
-    if(select.length === 0) {
-        select = $("#hostgroup_environment_id").first();
-    }
-    return select;
-};
-
 KT.hosts.getContentViewSelect2 = function() {
     var select = $("#s2id_host_content_view_id").first();
     if(select.length === 0) {

data/app/assets/stylesheets/katello/contents.scss

@@ -322,7 +322,7 @@ $container_width: ($static_width/2) - 36;
         position: relative;
         text-align: left;
         bottom: 18px;
-        left: 30px;
+        left: 10px;
       }
       .progress {
         display: inline-block;

data/app/controllers/katello/api/registry/registry_proxies_controller.rb

@@ -93,27 +93,21 @@ module Katello
       true
     end
 
-    # Reduce visible repos to include lifecycle env permissions
-    # http://projects.theforeman.org/issues/22914
-    # Also include repositories in lifecycle environments with registry_unauthenticated_pull=true
-    def readable_repositories
-      table_name = Repository.table_name
-      in_unauth_environments = Repository.joins(:environment).where("#{Katello::KTEnvironment.table_name}.registry_unauthenticated_pull" => true).select(:id)
-      Repository.readable.or(Repository.joins(:root).where("#{table_name}.id in (?)", in_unauth_environments))
-    end
-
     def find_readable_repository
       return nil unless params[:repository]
       repository = Repository.docker_type.find_by(container_repository_name: params[:repository])
       if require_user_authorization?(repository)
-        repository = readable_repositories.docker_type.find_by(container_repository_name: params[:repository])
+        repository = Repository.readable_docker_catalog.find_by(container_repository_name: params[:repository])
       end
       repository
     end
 
     def require_user_authorization?(repository = @repository)
       !(params['action'] == 'token' && params['scope'].blank? && params['account'].blank?) &&
-        (!repository || (!repository.environment.registry_unauthenticated_pull && !ssl_client_authorized?(repository.organization.label)))
+        (!repository ||
+          (!repository.archive? &&
+            !repository.environment.registry_unauthenticated_pull &&
+            !ssl_client_authorized?(repository.organization.label)))
     end
 
     def ssl_client_authorized?(org_label)
@@ -167,11 +161,9 @@ module Katello
       end
 
       if (manifest_response = redirect_client { Resources::Registry::Proxy.get(@_request.fullpath, headers) })
-        #when pulp 2 is removed, this should no longer be needed, and all clients should be redirected
-        logger.debug filter_sensitive_data(manifest_response)
+        #for some requests, we get a redirect, but for others we get the actual manifest in response
         results = JSON.parse(manifest_response)
-
-        response.header['Docker-Content-Digest'] = "sha256:#{Digest::SHA256.hexdigest(manifest_response)}"
+        response.header['Docker-Content-Digest'] = manifest_response.headers[:docker_content_digest]
         # https://docs.docker.com/registry/spec/manifest-v2-2/
         # If its v2 schema 2 only the mediaType attribute will be present in the manifest
         media_type = results['mediaType']
@@ -333,7 +325,7 @@ module Katello
       params[:per_page] = params[:n] || 25
       params[:search] = params[:q]
 
-      search_results = scoped_search(readable_repositories.docker_type.distinct,
+      search_results = scoped_search(Repository.readable_docker_catalog.distinct,
                                      :container_repository_name, :asc, options)
 
       results = {
@@ -347,7 +339,7 @@ module Katello
     end
 
     def catalog
-      repositories = readable_repositories.docker_type.collect do |repository|
+      repositories = Repository.readable_docker_catalog.collect do |repository|
         repository.container_repository_name
       end
       render json: { repositories: repositories }
@@ -485,7 +477,7 @@ module Katello
       return nil unless scope
 
       scopes = scope.split(':')
-      scopes[2] == 'pull' ? Repository.docker_type.find_by_container_repository_name(scopes[1]) : nil
+      scopes[2] == 'pull' ? Repository.docker_type.non_archived.find_by_container_repository_name(scopes[1]) : nil
     end
 
     def disable_strong_params

data/app/controllers/katello/api/rhsm/candlepin_proxies_controller.rb

@@ -242,15 +242,8 @@ module Katello
     #description N_("This service is available for unauthenticated users")
     def server_status
       candlepin_response = Resources::Candlepin::CandlepinPing.ping
-      status = { :managerCapabilities => candlepin_response['managerCapabilities'] + ["combined_reporting"],
-                 :result => candlepin_response['result'],
-                 :rulesSource => candlepin_response['rulesSource'],
-                 :rulesVersion => candlepin_response['rulesVersion'],
-                 :standalone => candlepin_response['standalone'],
-                 :timeUTC => Time.now.getutc,
-                 :version => Katello::VERSION }
-
-      render :json => status
+      candlepin_response[:managerCapabilities] << 'combined_reporting'
+      render :json => candlepin_response
     end
 
     #api :PUT, "/consumers/:id", N_("Update consumer information")

data/app/controllers/katello/api/v2/activation_keys_controller.rb

@@ -6,7 +6,7 @@ module Katello
     before_action :find_environment, :only => [:index, :create, :update]
     before_action :find_optional_organization, :only => [:index, :create, :show]
     before_action :find_content_view, :only => [:index]
-    before_action :find_authorized_katello_resource, :only => [:show, :update, :destroy, :available_releases, :product_content,
+    before_action :find_authorized_katello_resource, :only => [:show, :update, :destroy, :available_releases,
                                                                :available_host_collections, :add_host_collections, :remove_host_collections,
                                                                :content_override, :add_subscriptions, :remove_subscriptions,
                                                                :subscriptions]
@@ -141,29 +141,6 @@ module Katello
       respond_for_index :collection => response
     end
 
-    api :GET, "/activation_keys/:id/product_content", N_("Show content available for an activation key")
-    param :id, String, :desc => N_("ID of the activation key"), :required => true
-    param :content_access_mode_all, :bool, :desc => N_("Get all content available, not just that provided by subscriptions")
-    param :content_access_mode_env, :bool, :desc => N_("Limit content to just that available in the activation key's content view version")
-    def product_content
-      content_access_mode_all = ::Foreman::Cast.to_bool(params[:content_access_mode_all])
-      content_access_mode_env = ::Foreman::Cast.to_bool(params[:content_access_mode_env])
-
-      content_finder = ProductContentFinder.new(
-          :match_subscription => !content_access_mode_all,
-          :match_environment => content_access_mode_env,
-          :consumable => @activation_key
-      )
-
-      content = content_finder.presenter_with_overrides(@activation_key.content_overrides)
-      response = {
-        :results => content,
-        :total => content.size,
-        :subtotal => content.size
-      }
-      respond_for_index :collection => response
-    end
-
     api :POST, "/activation_keys/:id/host_collections"
     param :id, :number, :desc => N_("ID of the activation key"), :required => true
     param :host_collection_ids, Array, :required => true, :desc => N_("List of host collection IDs to associate with activation key")
@@ -248,6 +225,15 @@ module Katello
       respond_for_show(:resource => @activation_key)
     end
 
+    api :GET, "/activation_keys/:id/product_content", N_("Show content available for an activation key")
+    param :id, String, :desc => N_("ID of the activation key"), :required => true
+    param :content_access_mode_all, :bool, :desc => N_("Get all content available, not just that provided by subscriptions")
+    param :content_access_mode_env, :bool, :desc => N_("Limit content to just that available in the activation key's content view version")
+    def product_content
+      # note this is just there as a place holder for apipie.
+      # The routing would automatically redirect it to repository_sets#index
+    end
+
     def index_relation
       activation_keys = ActivationKey.readable
       activation_keys = activation_keys.where(:name => params[:name]) if params[:name]

data/app/controllers/katello/api/v2/api_controller.rb

@@ -39,7 +39,18 @@ module Katello
     end
 
     def deprecate_katello_agent
-      ::Foreman::Deprecation.api_deprecation_warning("Katello-agent is deprecated and will be removed in a future release.")
+      check_katello_agent_not_disabled
+      ::Foreman::Deprecation.api_deprecation_warning("This action uses katello-agent, which is deprecated and will be removed in #{katello_agent_removal_release}.")
+    end
+
+    def check_katello_agent_not_disabled
+      unless ::Katello.with_katello_agent?
+        fail HttpErrors::BadRequest, _("This action uses katello-agent, which is currently disabled. Use remote execution instead.")
+      end
+    end
+
+    def katello_agent_removal_release
+      self.class.katello_agent_removal_release
     end
 
     def full_result_response(collection)
@@ -75,7 +86,8 @@ module Katello
       end
 
       total = scoped_search_total(query, group)
-
+      # If you get an ArgumentError here (wrong number of arguments given)
+      # it's probably because query is an array and not an ActiveRecord::Relation
       query = query.select(:id) if query.respond_to?(:select)
       query = resource.search_for(*search_options).where("#{resource.table_name}.id" => query)
 
@@ -207,7 +219,7 @@ module Katello
     end
 
     def find_host_with_subscriptions(id, permission)
-      @host = resource_finder(::Host::Managed.authorized(permission, ::Host::Managed), id)
+      @host = resource_finder(::Host::Managed.authorized(permission, ::Host::Managed), id&.to_i)
       fail HttpErrors::BadRequest, _("Host has not been registered with subscription-manager") if @host.subscription_facet.nil?
     end
 

data/app/controllers/katello/api/v2/content_credentials_controller.rb

@@ -49,7 +49,7 @@ module Katello
 
       content = nil
       if filepath
-        content = File.open(filepath, 'rb') { |file| file.read }
+        content = File.read(filepath, mode: 'rb')
       else
         content = params[:content]
       end

data/app/controllers/katello/api/v2/content_export_incrementals_controller.rb

@@ -1,6 +1,5 @@
 module Katello
   class Api::V2::ContentExportIncrementalsController < Api::V2::ApiController
-    before_action :fail_if_not_pulp3, :only => [:version, :library]
     before_action :find_exportable_organization, :only => [:library]
     before_action :find_exportable_content_view_version, :only => [:version]
     before_action :find_library_export_view, :only => [:library]
@@ -16,7 +15,7 @@ module Katello
     param :fail_on_missing_content, :bool, :desc => N_("Fails if any of the repositories belonging to this version"\
                                                          " are unexportable. False by default."), :required => false
     def version
-      tasks = async_task(::Actions::Pulp3::Orchestration::ContentViewVersion::Export,
+      tasks = async_task(Actions::Katello::ContentViewVersion::Export,
                           content_view_version: @version,
                           destination_server: params[:destination_server],
                           chunk_size: params[:chunk_size_mb],
@@ -88,11 +87,5 @@ module Katello
         throw_resource_not_found(name: 'organization', id: params[:organization_id])
       end
     end
-
-    def fail_if_not_pulp3
-      unless SmartProxy.pulp_primary.pulp3_repository_type_support?(Katello::Repository::YUM_TYPE)
-        fail HttpErrors::BadRequest, _("Invalid usage for Pulp 2 repositories. Use export for Yum repositories")
-      end
-    end
   end
 end

data/app/controllers/katello/api/v2/content_exports_controller.rb

@@ -1,6 +1,5 @@
 module Katello
   class Api::V2::ContentExportsController < Api::V2::ApiController
-    before_action :fail_if_not_pulp3, :only => [:version, :library]
     before_action :find_exportable_organization, :only => [:library]
     before_action :find_exportable_content_view_version, :only => [:version]
 
@@ -27,12 +26,6 @@ module Katello
                                        :collection => scoped_search(history, 'id', 'asc', resource_class: ContentViewVersionExportHistory))
     end
 
-    api :GET, "/content_exports/api_status", N_("true if the export api is pulp3 ready and usable. This API is intended for use by hammer-cli only.")
-    def api_status
-      ::Foreman::Deprecation.api_deprecation_warning("/content_exports/api_status is being deprecated and will be removed in Katello 4.1.")
-      render json: { api_usable: SmartProxy.pulp_primary.pulp3_repository_type_support?(Katello::Repository::YUM_TYPE) }, status: :ok
-    end
-
     api :POST, "/content_exports/version", N_("Performs a full-export of a content view version.")
     param :id, :number, :desc => N_("Content view version identifier"), :required => true
     param :destination_server, String, :desc => N_("Destination Server name"), :required => false
@@ -41,7 +34,7 @@ module Katello
     param :fail_on_missing_content, :bool, :desc => N_("Fails if any of the repositories belonging to this version"\
                                                          " are unexportable. False by default."), :required => false
     def version
-      tasks = async_task(::Actions::Pulp3::Orchestration::ContentViewVersion::Export,
+      tasks = async_task(::Actions::Katello::ContentViewVersion::Export,
                           content_view_version: @version,
                           destination_server: params[:destination_server],
                           chunk_size: params[:chunk_size_mb],
@@ -78,11 +71,5 @@ module Katello
         throw_resource_not_found(name: 'organization', id: params[:organization_id])
       end
     end
-
-    def fail_if_not_pulp3
-      unless SmartProxy.pulp_primary.pulp3_repository_type_support?(Katello::Repository::YUM_TYPE)
-        fail HttpErrors::BadRequest, _("Invalid usage for Pulp 2 repositories. Use export for Yum repositories")
-      end
-    end
   end
 end

data/app/controllers/katello/api/v2/content_imports_controller.rb

@@ -1,20 +1,39 @@
 module Katello
   class Api::V2::ContentImportsController < Api::V2::ApiController
-    before_action :find_publishable_content_view, :only => [:version]
+    before_action :find_organization, :only => [:version]
+    before_action :check_authorized, :only => [:version]
+
     before_action :find_importable_organization, :only => [:library]
     before_action :find_default_content_view, :only => [:library]
 
+    api :GET, "/content_imports", N_("List import histories")
+    param :content_view_version_id, :number, :desc => N_("Content view version identifier"), :required => false
+    param :content_view_id, :number, :desc => N_("Content view identifier"), :required => false
+    param :organization_id, :number, :desc => N_("Organization identifier"), :required => false
+    param :id, :number, :desc => N_("Content view version import history identifier"), :required => false
+    param :type, ::Katello::ContentViewVersionExportHistory::EXPORT_TYPES,
+                                  :desc => N_("Import Types"),
+                                  :required => false
+    param_group :search, Api::V2::ApiController
+    add_scoped_search_description_for(ContentViewVersionImportHistory)
+    def index
+      history = ContentViewVersionImportHistory.readable
+      history = history.where(:id => params[:id]) unless params[:id].blank?
+      history = history.where(:content_view_version_id => params[:content_view_version_id]) unless params[:content_view_version_id].blank?
+      history = history.with_organization_id(params[:organization_id]) unless params[:organization_id].blank?
+      history = history.with_content_view_id(params[:content_view_id]) unless params[:content_view_id].blank?
+      history = history.where(:import_type => params[:type]) unless params[:type].blank?
+      respond_with_template_collection("index", 'content_view_version_import_histories',
+                                       :collection => scoped_search(history, 'id', 'asc', resource_class: ContentViewVersionImportHistory))
+    end
+
     api :POST, "/content_imports/version", N_("Import a content view version")
-    param :content_view_id, :number, :desc => N_("Content view identifier"), :required => true
+    param :organization_id, :number, :desc => N_("Organization identifier"), :required => true
     param :path, String, :desc => N_("Directory containing the exported Content View Version"), :required => true
     param :metadata, Hash, :desc => N_("Metadata taken from the upstream export history for this Content View Version"), :required => true
     def version
-      if @view.default?
-        fail HttpErrors::BadRequest, _("Cannot use this end point for importing to library. "\
-                                       "If you intented to upload to library, use the library endpoint.")
-      end
-
-      task = async_task(::Actions::Katello::ContentViewVersion::Import, @view, path: params[:path], metadata: metadata_params.to_h)
+      task = async_task(::Actions::Katello::ContentViewVersion::Import, organization: @organization,
+                                                  path: params[:path], metadata: metadata_params.to_h)
       respond_for_async :resource => task
     end
 
@@ -29,9 +48,8 @@ module Katello
 
     private
 
-    def find_publishable_content_view
-      @view = ContentView.publishable.find(params[:content_view_id])
-      throw_resource_not_found(name: 'content_view', id: params[:content_view_id]) if @view.blank?
+    def check_authorized
+      fail HttpErrors::Forbidden, _("Action unauthorized to be performed in this organization.") unless ContentView.importable?
     end
 
     def find_default_content_view
@@ -47,12 +65,17 @@ module Katello
     def metadata_params
       params.require(:metadata).permit(
         :organization,
-        :content_view,
-        :repository_mapping,
+        :repositories,
+        :products,
         :toc,
-        content_view_version: [:major, :minor]
+        :incremental,
+        gpg_keys: {},
+        content_view: [:name, :label, :description],
+        content_view_version: [:major, :minor, :description],
+        from_content_view_version: [:major, :minor]
       ).tap do |nested|
-        nested[:repository_mapping] = params[:metadata].require(:repository_mapping).permit!
+        nested[:repositories] = params[:metadata].require(:repositories).permit!
+        nested[:products] = params[:metadata].require(:products).permit!
       end
     end
   end

data/app/controllers/katello/api/v2/content_uploads_controller.rb

@@ -10,7 +10,7 @@ module Katello
     param :repository_id, :number, :required => true, :desc => N_("repository id")
     param :size, :number, :required => true, :desc => N_("Size of file to upload")
     param :checksum, String, :required => false, :desc => N_("Checksum of file to upload")
-    param :content_type, RepositoryTypeManager.uploadable_content_types.map(&:label), :required => false, :desc => N_("content type ('deb', 'docker_manifest', 'file', 'ostree', 'puppet_module', 'rpm', 'srpm')")
+    param :content_type, RepositoryTypeManager.uploadable_content_types.map(&:label), :required => false, :desc => N_("content type ('deb', 'docker_manifest', 'file', 'ostree', 'rpm', 'srpm')")
     def create
       content_type = params[:content_type] || ::Katello::RepositoryTypeManager.find(@repository.content_type).default_managed_content_type.label
       unit_type_id = SmartProxy.pulp_primary.content_service(content_type).content_type

data/app/controllers/katello/api/v2/content_view_components_controller.rb

@@ -1,5 +1,6 @@
 module Katello
   class Api::V2::ContentViewComponentsController < Api::V2::ApiController
+    include Katello::Concerns::FilteredAutoCompleteSearch
     before_action :find_composite_content_view, :only => [:show, :index]
     before_action :find_composite_content_view_for_edit, :only => [:add_components, :remove_components, :update]
     before_action :find_authorized_katello_resource, :only => [:show, :update]
@@ -10,7 +11,12 @@ module Katello
         N_("List components attached to this content view")
     param :composite_content_view_id, :number, :desc => N_("composite content view identifier"), :required => true
     def index
-      respond :collection => index_response
+      sort_by, sort_order, options = sort_options
+      respond(:collection => scoped_search(index_relation, sort_by, sort_order, options))
+    end
+
+    def index_relation
+      @view.content_view_components.readable
     end
 
     def index_response
@@ -114,5 +120,20 @@ module Katello
       attrs = [:latest, :content_view_version_id, :content_view_id]
       params.require(:content_view_component).permit(*attrs)
     end
+
+    def default_sort
+      %w(label asc)
+    end
+
+    def sort_options
+      case default_sort
+      when Array
+        [default_sort[0], default_sort[1], {}]
+      when Proc
+        [nil, nil, { :custom_sort => default_sort }]
+      else
+        fail "Unsupported default_sort type"
+      end
+    end
   end
 end