katello 3.8.0.rc1 → 3.8.0.rc2

data/webpack/scenes/Subscriptions/UpstreamSubscriptions/__tests__/UpstreamSubscriptionsActions.test.js

@@ -1,5 +1,3 @@
-import axios from 'axios';
-import MockAdapter from 'axios-mock-adapter';
 import configureMockStore from 'redux-mock-store';
 import thunk from 'redux-thunk';
 import Immutable from 'seamless-immutable';
@@ -13,10 +11,10 @@ import {
 import { getTaskSuccessResponse } from '../../../Tasks/__tests__/task.fixtures';
 
 import { loadUpstreamSubscriptions, saveUpstreamSubscriptions } from '../UpstreamSubscriptionsActions';
+import { mock as mockApi, mockErrorRequest } from '../../../../mockRequest';
 
 const mockStore = configureMockStore([thunk]);
 const store = mockStore({ subscriptions: Immutable({}) });
-const mockApi = new MockAdapter(axios);
 
 afterEach(() => {
   store.clearActions();
@@ -28,7 +26,10 @@ describe('upstream subscription actions', () => {
 
   describe('creates UPSTREAM_SUBSCRIPTIONS_REQUEST', () => {
     it('and then fails with 422', () => {
-      mockApi.onGet(url).reply(422);
+      mockErrorRequest({
+        url,
+        status: 422,
+      });
 
       return store.dispatch(loadUpstreamSubscriptions())
         .then(() => expect(store.getActions()).toEqual(getFailureActions));
@@ -48,7 +49,11 @@ describe('upstream subscription actions', () => {
     };
 
     it('and then fails with 422', () => {
-      mockApi.onPost(url).reply(422);
+      mockErrorRequest({
+        url,
+        status: 422,
+        method: 'POST',
+      });
 
       return store.dispatch(saveUpstreamSubscriptions(subscriptionData))
         .then(() => expect(store.getActions()).toEqual(saveFailureActions));

data/webpack/scenes/Subscriptions/UpstreamSubscriptions/__tests__/UpstreamSubscriptionsPage.test.js

@@ -6,17 +6,62 @@ import { successState } from './upstreamSubscriptions.fixtures';
 import { loadUpstreamSubscriptions, saveUpstreamSubscriptions } from '../UpstreamSubscriptionsActions';
 
 jest.mock('../../../../move_to_foreman/foreman_toast_notifications');
+jest.mock('foremanReact/components/BreadcrumbBar');
 
 describe('upstream subscriptions page', () => {
-  const mockHistory = { push: () => {} };
-
-  it('should render', async () => {
-    const page = shallow(<UpstreamSubscriptionsPage
+  let shallowWrapper;
+  beforeEach(() => {
+    shallowWrapper = shallow(<UpstreamSubscriptionsPage
       upstreamSubscriptions={successState}
       loadUpstreamSubscriptions={loadUpstreamSubscriptions}
       saveUpstreamSubscriptions={saveUpstreamSubscriptions}
       history={mockHistory}
     />);
-    expect(toJson(page)).toMatchSnapshot();
+  });
+  const mockHistory = { push: () => {} };
+
+  it('should render', async () => {
+    expect(toJson(shallowWrapper)).toMatchSnapshot();
+  });
+
+  it('should validate correct subscription quantities', async () => {
+    const validPools = [
+      { available: 10, updatedQuantity: 5 },
+      { available: 10, updatedQuantity: '5' },
+      { available: 10, updatedQuantity: '10' },
+      { available: 10, updatedQuantity: '1' },
+      { available: -1, updatedQuantity: '1000' },
+    ];
+    validPools.forEach((pool, i) => {
+      // using object with index attribute to print out index on failure,
+      // jest doesn't support messages on failure :(
+      const result = shallowWrapper.instance().quantityValidation(pool)[0];
+      expect({ index: i, result }).toEqual({ index: i, result: true });
+    });
+  });
+
+  it('should invalidate incorrect subscription quantities', async () => {
+    const invalidPools = [
+      { available: 10, updatedQuantity: 11 },
+      { available: 10, updatedQuantity: 'foo' },
+      { available: 10, updatedQuantity: 0 },
+      { available: 10, updatedQuantity: '0' },
+      { available: 10, updatedQuantity: '11' },
+      { available: 10, updatedQuantity: '2.0' },
+      { available: 10, updatedQuantity: '2/3' },
+      { available: -1, updatedQuantity: '-1' },
+      { available: -1, updatedQuantity: '0' },
+      { available: -1, updatedQuantity: 'foo' },
+      { available: -1, updatedQuantity: '2/3' },
+      { available: -1, updatedQuantity: '2.0' },
+      { available: -1, updatedQuantity: '99999999999' },
+    ];
+
+    invalidPools.forEach((pool, i) => {
+      // using object with index attribute to print out index on failure,
+      // jest doesn't support messages on failure :(
+      const result = shallowWrapper.instance().quantityValidation(pool)[0];
+      expect({ index: i, result }).toEqual({ index: i, result: false });
+    });
   });
 });

data/webpack/scenes/Subscriptions/UpstreamSubscriptions/__tests__/UpstreamSubscriptionsReducer.test.js

@@ -37,7 +37,9 @@ describe('upstream subscriptions reducer', () => {
   it('should have error on UPSTREAM_SUBSCRIPTIONS_FAILURE', () => {
     expect(reducer(initialState, {
       type: types.UPSTREAM_SUBSCRIPTIONS_FAILURE,
-      error: 'Unable to process request.',
+      payload: {
+        message: 'Unable to process request.',
+      },
     })).toEqual(errorState);
   });
 
@@ -48,10 +50,13 @@ describe('upstream subscriptions reducer', () => {
     })).toEqual(saveSuccessState);
   });
 
-  it('should have error on SAVE_UPSTREAM_SUBSCRIPTIONS_SUCCESS', () => {
+  it('should have error on SAVE_UPSTREAM_SUBSCRIPTIONS_FAILURE', () => {
     expect(reducer(initialSaveState, {
       type: types.SAVE_UPSTREAM_SUBSCRIPTIONS_FAILURE,
-      result: errorResult,
+      payload: {
+        message: 'Unable to process request.',
+        result: errorResult,
+      },
     })).toEqual(saveErrorState);
   });
 });

data/webpack/scenes/Subscriptions/UpstreamSubscriptions/__tests__/__snapshots__/UpstreamSubscriptionsPage.test.js.snap

@@ -6,12 +6,26 @@ exports[`upstream subscriptions page should render 1`] = `
   componentClass="div"
   fluid={false}
 >
-  <h1>
-    Add Subscriptions
-  </h1>
+  <BreadcrumbsBar
+    data={
+      Object {
+        "breadcrumbItems": Array [
+          Object {
+            "caption": "Subscriptions",
+            "onClick": [Function],
+          },
+          Object {
+            "caption": "Add Subscriptions",
+          },
+        ],
+        "isSwitchable": false,
+      }
+    }
+  />
   <LoadingState
     loading={false}
     loadingText="Loading"
+    timeout={300}
   >
     <Row
       bsClass="row"
@@ -107,7 +121,7 @@ exports[`upstream subscriptions page should render 1`] = `
                   ],
                   "label": "Available Entitlements",
                 },
-                "property": "quantity",
+                "property": "available",
               },
               Object {
                 "cell": Object {
@@ -128,15 +142,11 @@ exports[`upstream subscriptions page should render 1`] = `
           emptyState={
             Object {
               "action": Object {
-                "title": "New Subscription Allocation",
-                "url": "http://redhat.com",
+                "title": "Import a Manifest to Begin",
+                "url": "/subscriptions",
               },
               "description": "Subscription Allocations allow you to export subscriptions from the Red Hat Customer Portal to an on-premise subscription management application such as Red Hat Satellite.",
               "docUrl": "http://redhat.com",
-              "documentation": Object {
-                "title": "Learn more about Subscription Allocations",
-                "url": "http://redhat.com",
-              },
               "header": "There are no Subscription Allocations to display",
             }
           }
@@ -193,7 +203,7 @@ exports[`upstream subscriptions page should render 1`] = `
           block={false}
           bsClass="btn"
           bsStyle="primary"
-          disabled={false}
+          disabled={true}
           onClick={[Function]}
           type="submit"
         >

data/webpack/scenes/Subscriptions/UpstreamSubscriptions/__tests__/upstreamSubscriptions.fixtures.js

@@ -1,5 +1,6 @@
 import Immutable from 'seamless-immutable';
 import { getTaskSuccessResponse } from '../../../Tasks/__tests__/task.fixtures';
+import { toastErrorAction, failureAction } from '../../../../services/api/testHelpers';
 
 export const initialState = Immutable({
   loading: true,
@@ -135,10 +136,8 @@ export const getFailureActions = [
   {
     type: 'UPSTREAM_SUBSCRIPTIONS_REQUEST',
   },
-  {
-    result: new Error('Request failed with status code 422'),
-    type: 'UPSTREAM_SUBSCRIPTIONS_FAILURE',
-  },
+  failureAction('UPSTREAM_SUBSCRIPTIONS_FAILURE'),
+  toastErrorAction(),
 ];
 
 export const saveSuccessActions = [
@@ -155,8 +154,6 @@ export const saveFailureActions = [
   {
     type: 'SAVE_UPSTREAM_SUBSCRIPTIONS_REQUEST',
   },
-  {
-    result: new Error('Request failed with status code 422'),
-    type: 'SAVE_UPSTREAM_SUBSCRIPTIONS_FAILURE',
-  },
+  failureAction('SAVE_UPSTREAM_SUBSCRIPTIONS_FAILURE'),
+  toastErrorAction(),
 ];

data/webpack/scenes/Subscriptions/__tests__/SubscriptionsPage.test.js

@@ -10,9 +10,11 @@ jest.mock('../../../move_to_foreman/foreman_toast_notifications');
 
 describe('subscriptions page', () => {
   const noop = () => {};
+  const organization = { owner_details: { upstreamConsumer: 'blah' } };
 
   it('should render', async () => {
     const page = shallow(<SubscriptionsPage
+      organization={organization}
       subscriptions={successState}
       loadSetting={loadSetting}
       loadSubscriptions={loadSubscriptions}

data/webpack/scenes/Subscriptions/__tests__/SubscriptionsReducer.test.js

@@ -34,14 +34,18 @@ describe('subscriptions reducer', () => {
   it('should have error on SUBSCRIPTIONS_FAILURE', () => {
     expect(reducer(initialState, {
       type: types.SUBSCRIPTIONS_FAILURE,
-      error: 'Unable to process request.',
+      payload: {
+        message: 'Unable to process request.',
+      },
     })).toEqual(errorState);
   });
 
   it('should have error on UPDATE_QUANTITY_FAILURE', () => {
     expect(reducer(initialState, {
       type: types.UPDATE_QUANTITY_FAILURE,
-      error: 'Unable to process request.',
+      payload: {
+        message: 'Unable to process request.',
+      },
     })).toEqual(errorState);
   });
 
@@ -61,7 +65,9 @@ describe('subscriptions reducer', () => {
   it('should have error on SUBSCRIPTIONS_QUANTITIES_FAILURE', () => {
     expect(reducer(successState, {
       type: types.SUBSCRIPTIONS_QUANTITIES_FAILURE,
-      error: 'Unable to process request.',
+      payload: {
+        message: 'Unable to process request.',
+      },
     })).toEqual(quantitiesErrorState);
   });
 });

data/webpack/scenes/Subscriptions/__tests__/__snapshots__/SubscriptionsPage.test.js.snap

@@ -53,6 +53,7 @@ exports[`subscriptions page should render 1`] = `
               >
                 <LinkContainer
                   activeClassName="active"
+                  disabled={false}
                   exact={false}
                   replace={false}
                   strict={false}
@@ -93,7 +94,7 @@ exports[`subscriptions page should render 1`] = `
                   title="Delete"
                   tooltipId="delete-subscriptions-button-tooltip"
                   tooltipPlacement="top"
-                  tooltipText="This is disabled because no subscriptions are selected"
+                  tooltipText="This is disabled because no subscriptions are selected."
                 />
               </FormGroup>
             </div>
@@ -111,13 +112,23 @@ exports[`subscriptions page should render 1`] = `
         id="subscriptions-table"
       >
         <SubscriptionsTable
+          emptyState={
+            Object {
+              "action": Object {
+                "onClick": [Function],
+                "title": "Import a Manifest",
+              },
+              "description": "Import a Manifest to manage your Entitlements.",
+              "header": "There are no Subscriptions to display",
+            }
+          }
           loadSubscriptions={[Function]}
           onDeleteSubscriptions={[Function]}
           onSubscriptionDeleteModalClose={[Function]}
           subscriptionDeleteModalOpen={false}
           subscriptions={
             Object {
-              "availableQuantities": Object {},
+              "availableQuantities": null,
               "itemCount": 81,
               "loading": false,
               "pagination": Object {
@@ -184,6 +195,7 @@ exports[`subscriptions page should render 1`] = `
               "tasks": Array [],
             }
           }
+          task={null}
           toggleDeleteButton={[Function]}
           updateQuantity={[Function]}
         />

data/webpack/scenes/Subscriptions/__tests__/subscriptions.fixtures.js

@@ -1,4 +1,5 @@
 import Immutable from 'seamless-immutable';
+import { toastErrorAction, failureAction } from '../../../services/api/testHelpers';
 
 export const initialState = Immutable({
   loading: true,
@@ -9,7 +10,7 @@ export const initialState = Immutable({
   },
   itemCount: 0,
   quantitiesLoading: false,
-  availableQuantities: {},
+  availableQuantities: null,
   tasks: [],
 });
 
@@ -242,13 +243,12 @@ export const successState = Immutable({
   },
   itemCount: 81,
   quantitiesLoading: false,
-  availableQuantities: {},
+  availableQuantities: null,
   tasks: [],
 });
 
 export const errorState = Immutable({
   loading: false,
-  error: 'Unable to process request.',
   pagination: {
     page: 0,
     perPage: 20,
@@ -256,7 +256,7 @@ export const errorState = Immutable({
   itemCount: 0,
   results: [],
   quantitiesLoading: false,
-  availableQuantities: {},
+  availableQuantities: null,
   tasks: [],
 });
 
@@ -278,7 +278,7 @@ export const loadingQuantitiesState = Immutable({
 export const quantitiesErrorState = Immutable({
   ...successState,
   quantitiesLoading: false,
-  quantitiesError: 'Unable to process request.',
+  availableQuantities: {},
 });
 
 export const successActions = [
@@ -310,10 +310,8 @@ export const failureActions = [
   {
     type: 'SUBSCRIPTIONS_REQUEST',
   },
-  {
-    error: 'Request failed with status code 422',
-    type: 'SUBSCRIPTIONS_FAILURE',
-  },
+  failureAction('SUBSCRIPTIONS_FAILURE'),
+  toastErrorAction(),
 ];
 
 export const poolsUpdate = [{
@@ -340,20 +338,16 @@ export const updateQuantityFailureActions = [
     type: 'UPDATE_QUANTITY_REQUEST',
     quantities: poolsUpdate,
   },
-  {
-    error: 'Request failed with status code 422',
-    type: 'UPDATE_QUANTITY_FAILURE',
-  },
+  failureAction('UPDATE_QUANTITY_FAILURE'),
+  toastErrorAction(),
 ];
 
 export const loadQuantitiesFailureActions = [
   {
     type: 'SUBSCRIPTIONS_QUANTITIES_REQUEST',
   },
-  {
-    error: 'Request failed with status code 500',
-    type: 'SUBSCRIPTIONS_QUANTITIES_FAILURE',
-  },
+  failureAction('SUBSCRIPTIONS_QUANTITIES_FAILURE', 'Request failed with status code 500'),
+  toastErrorAction('Request failed with status code 500'),
 ];
 
 export const loadQuantitiesSuccessActions = [

data/webpack/scenes/Subscriptions/components/SubscriptionsTable/EntitlementsInlineEditFormatter.js

@@ -34,15 +34,18 @@ export const entitlementsInlineEditFormatter =
       );
     },
     renderEdit: (value, additionalData) => {
-      const { availableQuantity } = additionalData.rowData;
+      const { availableQuantity, availableQuantityLoaded } = additionalData.rowData;
 
       const className = inlineEditController.hasChanged(additionalData)
         ? 'editable editing changed'
         : 'editable editing';
 
-      const maxMessage = (availableQuantity < 1)
-        ? __('Unlimited')
-        : sprintf(__('Max %(availableQuantity)s'), { availableQuantity });
+      let maxMessage;
+      if (availableQuantityLoaded && (availableQuantity !== undefined)) {
+        maxMessage = (availableQuantity < 1)
+          ? __('Unlimited')
+          : sprintf(__('Max %(availableQuantity)s'), { availableQuantity });
+      }
 
       const validation = validateQuantity(value, availableQuantity);
 
@@ -55,7 +58,7 @@ export const entitlementsInlineEditFormatter =
         // The same issue prevents from correct switching inputs on TAB.
         // See the reactabular code for details:
         // https://github.com/reactabular/reactabular/blob/master/packages/reactabular-table/src/body-row.js#L58
-        <Spinner loading={availableQuantity === undefined} size="xs">
+        <Spinner loading={!availableQuantityLoaded} size="xs">
           <FormGroup
             validationState={validation.state}
           >

data/webpack/scenes/Subscriptions/components/SubscriptionsTable/SubscriptionsTable.js

@@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
 import classNames from 'classnames';
 import { sprintf } from 'jed';
 import { cloneDeep, findIndex, isEqual } from 'lodash';
-import { Table, Alert } from 'patternfly-react';
+import { Table } from 'patternfly-react';
 import { LoadingState } from '../../../../move_to_pf/LoadingState';
 import { Table as ForemanTable, TableBody as ForemanTableBody } from '../../../../move_to_foreman/components/common/table';
 import ConfirmDialog from '../../../../move_to_foreman/components/common/ConfirmDialog';
@@ -11,36 +11,11 @@ import Dialog from '../../../../move_to_foreman/components/common/Dialog';
 import { recordsValid } from '../../SubscriptionValidations';
 import { createSubscriptionsTableSchema } from './SubscriptionsTableSchema';
 import { buildTableRows, groupSubscriptionsByProductId, buildPools } from './SubscriptionsTableHelpers';
-
-const emptyStateData = {
-  header: __('There are no Subscriptions to display'),
-  description: __('Add Subscriptions to this Allocation to manage your Entitlements.'),
-  documentation: {
-    title: __('Learn more about adding Subscriptions to Allocations'),
-    url: 'http://redhat.com',
-  },
-  action: {
-    title: __('Add Subscriptions'),
-    url: 'subscriptions/add',
-  },
-};
-
-const ErrorAlerts = ({ errors }) => {
-  const alerts = errors.filter(Boolean).map(e => (
-    <Alert type={Alert.ALERT_TYPE_ERROR} key={e}>
-      <span>{e}</span>
-    </Alert>
-  ));
-
-  return (
-    <div>
-      {alerts}
-    </div>
-  );
-};
-ErrorAlerts.propTypes = {
-  errors: PropTypes.arrayOf(PropTypes.string).isRequired,
-};
+import { renderTaskStartedToast } from '../../../Tasks/helpers';
+import {
+  BLOCKING_FOREMAN_TASK_TYPES,
+  MANIFEST_TASKS_BULK_SEARCH_ID,
+} from '../../SubscriptionConstants';
 
 class SubscriptionsTable extends Component {
   constructor(props) {
@@ -49,7 +24,7 @@ class SubscriptionsTable extends Component {
     this.state = {
       rows: undefined,
       subscriptions: undefined,
-      groupdSubscriptions: undefined,
+      groupedSubscriptions: undefined,
       updatedQuantity: {},
       editing: false,
       showUpdateConfirmDialog: false,
@@ -64,14 +39,14 @@ class SubscriptionsTable extends Component {
       nextProps.subscriptions !== undefined &&
       !isEqual(nextProps.subscriptions, prevState.subscriptions)
     ) {
-      const groupdSubscriptions = groupSubscriptionsByProductId(nextProps.subscriptions);
+      const groupedSubscriptions = groupSubscriptionsByProductId(nextProps.subscriptions);
       const rows = buildTableRows(
-        groupdSubscriptions,
+        groupedSubscriptions,
         nextProps.subscriptions.availableQuantities,
         prevState.updatedQuantity,
       );
 
-      return { rows, groupdSubscriptions, subscriptions: nextProps.subscriptions };
+      return { rows, groupedSubscriptions, subscriptions: nextProps.subscriptions };
     }
 
     return null;
@@ -79,19 +54,19 @@ class SubscriptionsTable extends Component {
 
   toggleSubscriptionGroup(groupId) {
     const { subscriptions } = this.props;
-    const { groupdSubscriptions, updatedQuantity } = this.state;
-    const { open } = groupdSubscriptions[groupId];
+    const { groupedSubscriptions, updatedQuantity } = this.state;
+    const { open } = groupedSubscriptions[groupId];
 
-    groupdSubscriptions[groupId].open = !open;
+    groupedSubscriptions[groupId].open = !open;
 
 
     const rows = buildTableRows(
-      groupdSubscriptions,
+      groupedSubscriptions,
       subscriptions.availableQuantities,
       updatedQuantity,
     );
 
-    this.setState({ rows, groupdSubscriptions });
+    this.setState({ rows, groupedSubscriptions });
   }
 
   enableEditing(editingState) {
@@ -102,11 +77,11 @@ class SubscriptionsTable extends Component {
   }
 
   updateRows(updatedQuantity) {
-    const { groupdSubscriptions } = this.state;
+    const { groupedSubscriptions } = this.state;
     const { subscriptions } = this.props;
 
     const rows = buildTableRows(
-      groupdSubscriptions,
+      groupedSubscriptions,
       subscriptions.availableQuantities,
       updatedQuantity,
     );
@@ -134,7 +109,15 @@ class SubscriptionsTable extends Component {
   confirmEdit() {
     this.showUpdateConfirm(false);
     if (Object.keys(this.state.updatedQuantity).length > 0) {
-      this.props.updateQuantity(buildPools(this.state.updatedQuantity));
+      this.props.updateQuantity(buildPools(this.state.updatedQuantity))
+        .then(() =>
+          this.props.bulkSearch({
+            search_id: MANIFEST_TASKS_BULK_SEARCH_ID,
+            type: 'all',
+            active_only: true,
+            action_types: BLOCKING_FOREMAN_TASK_TYPES,
+          }))
+        .then(() => renderTaskStartedToast(this.props.task));
     }
     this.enableEditing(false);
   }
@@ -157,16 +140,17 @@ class SubscriptionsTable extends Component {
   }
 
   render() {
-    const { subscriptions } = this.props;
-    const { groupdSubscriptions } = this.state;
+    const { subscriptions, emptyState } = this.props;
+    const { groupedSubscriptions } = this.state;
+    const allSubscriptionResults = subscriptions.results;
 
     const groupingController = {
       isCollapseable: ({ rowData }) =>
         // it is the first subscription in the group
-        rowData.id === groupdSubscriptions[rowData.product_id].subscriptions[0].id &&
+        rowData.id === groupedSubscriptions[rowData.product_id].subscriptions[0].id &&
         // the group contains more then one subscription
-        groupdSubscriptions[rowData.product_id].subscriptions.length > 1,
-      isCollapsed: ({ rowData }) => !groupdSubscriptions[rowData.product_id].open,
+        groupedSubscriptions[rowData.product_id].subscriptions.length > 1,
+      isCollapsed: ({ rowData }) => !groupedSubscriptions[rowData.product_id].open,
       toggle: ({ rowData }) => this.toggleSubscriptionGroup(rowData.product_id),
     };
 
@@ -202,7 +186,8 @@ class SubscriptionsTable extends Component {
       },
     };
 
-    const checkAllRowsSelected = () => this.state.rows.length === this.state.selectedRows.length;
+    const checkAllRowsSelected = () =>
+      allSubscriptionResults.length === this.state.selectedRows.length;
 
     const updateDeleteButton = () => {
       this.props.toggleDeleteButton(this.state.selectedRows.length > 0);
@@ -218,7 +203,7 @@ class SubscriptionsTable extends Component {
           );
         } else {
           this.setState(
-            { selectedRows: this.state.rows.map(row => row.id) },
+            { selectedRows: allSubscriptionResults.map(row => row.id) },
             updateDeleteButton,
           );
         }
@@ -246,7 +231,7 @@ class SubscriptionsTable extends Component {
     };
 
     let bodyMessage;
-    if (subscriptions.results.length === 0 && subscriptions.searchIsActive) {
+    if (allSubscriptionResults.length === 0 && subscriptions.searchIsActive) {
       bodyMessage = __('No subscriptions match your search criteria.');
     }
 
@@ -258,15 +243,9 @@ class SubscriptionsTable extends Component {
 
     return (
       <LoadingState loading={subscriptions.loading} loadingText={__('Loading')}>
-        <ErrorAlerts
-          errors={[
-            subscriptions.error,
-            subscriptions.quantitiesError,
-          ]}
-        />
         <ForemanTable
           columns={columnsDefinition}
-          emptyState={emptyStateData}
+          emptyState={emptyState}
           bodyMessage={bodyMessage}
           rows={this.state.rows}
           components={{
@@ -352,6 +331,7 @@ class SubscriptionsTable extends Component {
 SubscriptionsTable.propTypes = {
   loadSubscriptions: PropTypes.func.isRequired,
   updateQuantity: PropTypes.func.isRequired,
+  emptyState: PropTypes.shape({}).isRequired,
   subscriptions: PropTypes.shape({
     results: PropTypes.array,
   }).isRequired,
@@ -359,6 +339,13 @@ SubscriptionsTable.propTypes = {
   onDeleteSubscriptions: PropTypes.func.isRequired,
   onSubscriptionDeleteModalClose: PropTypes.func.isRequired,
   toggleDeleteButton: PropTypes.func.isRequired,
+  task: PropTypes.shape({}),
+  bulkSearch: PropTypes.func,
+};
+
+SubscriptionsTable.defaultProps = {
+  task: { humanized: {} },
+  bulkSearch: undefined,
 };
 
 export default SubscriptionsTable;