katello 3.5.0.rc1 → 3.5.0.rc2

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/content-view-versions.controller.js

@@ -8,7 +8,7 @@
  * @requires ContentViewVersion
  * @requires AggregateTask
  * @requires ApiErrorHandler
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Provides the functionality specific to ContentViews for use with the table view UI pattern.
@@ -16,8 +16,8 @@
  *   within the table.
  */
 angular.module('Bastion.content-views').controller('ContentViewVersionsController',
-    ['$scope', 'translate', 'Nutupane', 'ContentViewVersion', 'AggregateTask', 'ApiErrorHandler', 'GlobalNotification',
-    function ($scope, translate, Nutupane, ContentViewVersion, AggregateTask, ApiErrorHandler, GlobalNotification) {
+    ['$scope', 'translate', 'Nutupane', 'ContentViewVersion', 'AggregateTask', 'ApiErrorHandler', 'Notification',
+    function ($scope, translate, Nutupane, ContentViewVersion, AggregateTask, ApiErrorHandler, Notification) {
         var nutupane;
 
         function pluralSafe(count, strings) {
@@ -104,11 +104,11 @@ angular.module('Bastion.content-views').controller('ContentViewVersionsControlle
 
                 if (task.result === 'success') {
                     if (task.label === taskTypes.promotion) {
-                        GlobalNotification.setSuccessMessage(promotionCompleteMessage(version, task));
+                        Notification.setSuccessMessage(promotionCompleteMessage(version, task));
                     } else if (task.label === taskTypes.publish) {
-                        GlobalNotification.setSuccessMessage(publishCompleteMessage(version));
+                        Notification.setSuccessMessage(publishCompleteMessage(version));
                     } else if (task.label === taskTypes.deletion) {
-                        GlobalNotification.setSuccessMessage(deletionCompleteMessage(version, task));
+                        Notification.setSuccessMessage(deletionCompleteMessage(version, task));
                         $scope.reloadVersions();
                     }
                 }

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/available-errata-filter.controller.js

@@ -7,15 +7,15 @@
  * @requires Nutupane
  * @requires Filter
  * @requires Rule
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles loading of errata that is available to be added to a filter and provides
  *   functionality to create filter rules based off selected errata.
  */
 angular.module('Bastion.content-views').controller('AvailableErrataFilterController',
-    ['$scope', 'translate', 'Nutupane', 'Erratum', 'Rule', 'GlobalNotification',
-    function ($scope, translate, Nutupane, Erratum, Rule, GlobalNotification) {
+    ['$scope', 'translate', 'Nutupane', 'Erratum', 'Rule', 'Notification',
+    function ($scope, translate, Nutupane, Erratum, Rule, Notification) {
 
         var nutupane, filterByDate;
 
@@ -29,13 +29,13 @@ angular.module('Bastion.content-views').controller('AvailableErrataFilterControl
             }
 
             $scope.filter.rules = _.union($scope.filter.rules, rules);
-            GlobalNotification.setSuccessMessage(translate('Errata successfully added.'));
+            Notification.setSuccessMessage(translate('Errata successfully added.'));
             nutupane.table.selectAllResults(false);
             nutupane.refresh();
         }
 
         function failure(response) {
-            GlobalNotification.setErrorMessage(response.data.displayMessage);
+            Notification.setErrorMessage(response.data.displayMessage);
         }
 
         function saveRules(rules, filter) {

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/available-package-group-filter.controller.js

@@ -7,15 +7,15 @@
  * @requires Filter
  * @requires Rule
  * @requires Nutupane
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles fetching package groups that are available to add to a filter and saving
  *   each selected package group as a filter rule.
  */
 angular.module('Bastion.content-views').controller('AvailablePackageGroupFilterController',
-    ['$scope', 'translate', 'PackageGroup', 'Rule', 'Nutupane', 'GlobalNotification',
-    function ($scope, translate, PackageGroup, Rule, Nutupane, GlobalNotification) {
+    ['$scope', 'translate', 'PackageGroup', 'Rule', 'Nutupane', 'Notification',
+    function ($scope, translate, PackageGroup, Rule, Nutupane, Notification) {
         var nutupane;
 
         nutupane = new Nutupane(
@@ -34,12 +34,12 @@ angular.module('Bastion.content-views').controller('AvailablePackageGroupFilterC
         function success(rule) {
             nutupane.removeRow(rule.uuid, 'uuid');
             $scope.filter.rules.push(rule);
-            GlobalNotification.setSuccessMessage(translate('Package Group successfully added.'));
+            Notification.setSuccessMessage(translate('Package Group successfully added.'));
         }
 
         function failure(response) {
             angular.forEach(response.data.displayMessage, function (error) {
-                GlobalNotification.setErrorMessage(error);
+                Notification.setErrorMessage(error);
             });
         }
 

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/date-type-errata-filter.controller.js

@@ -5,14 +5,14 @@
  * @requires $scope
  * @requires translate
  * @requires Rule
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles creating an errata filter that allows specification of a start date, end date and/or
  *   set of errata types by which to dynamically filter.
  */
 angular.module('Bastion.content-views').controller('DateTypeErrataFilterController',
-    ['$scope', 'translate', 'Rule', 'GlobalNotification', function ($scope, translate, Rule, GlobalNotification) {
+    ['$scope', 'translate', 'Rule', 'Notification', function ($scope, translate, Rule, Notification) {
 
         function convertRuleStringsToDates() {
             $scope.rule['start_date'] = new Date($scope.rule['start_date']);
@@ -21,13 +21,13 @@ angular.module('Bastion.content-views').controller('DateTypeErrataFilterControll
 
         function success() {
             convertRuleStringsToDates();
-            GlobalNotification.setSuccessMessage(translate('Updated errata filter - ' + $scope.filter.name));
+            Notification.setSuccessMessage(translate('Updated errata filter - ' + $scope.filter.name));
         }
 
         function failure(response) {
             $scope.rule.working = false;
             angular.forEach(response.data.errors, function (error) {
-                GlobalNotification.setErrorMessage(error);
+                Notification.setErrorMessage(error);
             });
         }
 
@@ -63,7 +63,13 @@ angular.module('Bastion.content-views').controller('DateTypeErrataFilterControll
         };
 
         $scope.save = function (rule, filter) {
-            var params = {filterId: filter.id, ruleId: rule.id};
+            var params;
+
+            // Remove any hours from the dates
+            rule['start_date'].setHours(0, 0, 0, 0);
+            rule['end_date'].setHours(0, 0, 0, 0);
+
+            params = {filterId: filter.id, ruleId: rule.id};
             rule.$update(params, success, failure);
             $scope.filter.rules[0] = rule;
         };

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/docker-tag-filter.controller.js

@@ -10,17 +10,17 @@
  * @requires Filter
  * @requires Rule
  * @requires DockerTag
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles docker tag filter rules for a content view.
  */
 angular.module('Bastion.content-views').controller('DockerTagFilterController',
-    ['$scope', '$location', 'translate', 'Nutupane', 'CurrentOrganization', 'Filter', 'Rule', 'DockerTag', 'GlobalNotification', function ($scope, $location, translate, Nutupane, CurrentOrganization, Filter, Rule, DockerTag, GlobalNotification) {
+    ['$scope', '$location', 'translate', 'Nutupane', 'CurrentOrganization', 'Filter', 'Rule', 'DockerTag', 'Notification', function ($scope, $location, translate, Nutupane, CurrentOrganization, Filter, Rule, DockerTag, Notification) {
         var nutupane, params;
 
         function failure(response) {
-            GlobalNotification.setErrorMessage(response.data.displayMessage);
+            Notification.setErrorMessage(response.data.displayMessage);
         }
 
         function createRule(rule) {
@@ -31,7 +31,7 @@ angular.module('Bastion.content-views').controller('DockerTagFilterController',
                 rule.editMode = false;
                 rule.working = false;
 
-                GlobalNotification.setSuccessMessage(translate('Package successfully added.'));
+                Notification.setSuccessMessage(translate('Package successfully added.'));
             };
 
             if ($scope.valid(rule)) {
@@ -48,7 +48,7 @@ angular.module('Bastion.content-views').controller('DockerTagFilterController',
                 rule.previous = {};
                 rule.editMode = false;
                 rule.working = false;
-                GlobalNotification.setSuccessMessage(translate('Filter rule successfully updated.'));
+                Notification.setSuccessMessage(translate('Filter rule successfully updated.'));
             };
 
             error = function () {
@@ -63,7 +63,7 @@ angular.module('Bastion.content-views').controller('DockerTagFilterController',
 
             success = function () {
                 nutupane.removeRow(ruleId);
-                GlobalNotification.setSuccessMessage(translate('Filter rule successfully removed.'));
+                Notification.setSuccessMessage(translate('Filter rule successfully removed.'));
             };
 
             Rule.delete({filterId: $scope.$stateParams.filterId, ruleId: ruleId}, success, failure);

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/edit-filter.controller.js

@@ -5,27 +5,27 @@
  * @requires $scope
  * @requires $q
  * @requires translate
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Provides functionality for editing name and description of content view filters.
  */
 angular.module('Bastion.content-views').controller('FilterEditController',
-    ['$scope', '$q', 'translate', 'GlobalNotification', function ($scope, $q, translate, GlobalNotification) {
+    ['$scope', '$q', 'translate', 'Notification', function ($scope, $q, translate, Notification) {
     $scope.save = function (filter) {
         var deferred = $q.defer();
         var success;
         var failure = function (response) {
             deferred.reject(response);
             angular.forEach(response.data.errors, function (errorMessage) {
-                GlobalNotification.setErrorMessage(translate("An error occurred saving the Filter: ") + errorMessage);
+                Notification.setErrorMessage(translate("An error occurred saving the Filter: ") + errorMessage);
             });
             $scope.working = false;
         };
 
         success = function (response) {
             deferred.resolve(response);
-            GlobalNotification.setSuccessMessage(translate('Filter Saved'));
+            Notification.setSuccessMessage(translate('Filter Saved'));
             $scope.working = false;
             $scope.$emit('filter.updated');
         };

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/errata-filter-list.controller.js

@@ -7,15 +7,15 @@
  * @requires Nutupane
  * @requires Filter
  * @requires Rule
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles displaying a list of errata currently added to the filter and the ability
  *   to remove errata from the filter.
  */
 angular.module('Bastion.content-views').controller('ErrataFilterListController',
-    ['$scope', 'translate', 'Nutupane', 'Erratum', 'Rule', 'GlobalNotification',
-    function ($scope, translate, Nutupane, Erratum, Rule, GlobalNotification) {
+    ['$scope', 'translate', 'Nutupane', 'Erratum', 'Rule', 'Notification',
+    function ($scope, translate, Nutupane, Erratum, Rule, Notification) {
         var nutupane;
 
         function findRules(errataIds) {
@@ -41,11 +41,11 @@ angular.module('Bastion.content-views').controller('ErrataFilterListController',
             $scope.filter.rules = _.reject($scope.filter.rules, function (filterRule) {
                 return rule.id === filterRule.id;
             });
-            GlobalNotification.setSuccessMessage(translate('Errata successfully removed.'));
+            Notification.setSuccessMessage(translate('Errata successfully removed.'));
         }
 
         function failure(response) {
-            GlobalNotification.setErrorMessage(response.data.displayMessage);
+            Notification.setErrorMessage(response.data.displayMessage);
         }
 
         $scope.nutupane = nutupane = new Nutupane(Erratum, {

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/filter-repositories.controller.js

@@ -6,14 +6,14 @@
  * @requires translate
  * @requires Filter
  * @requires ContentViewRepositoriesUtl
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Provides a way for users to select which repositories the filter applies to.
  */
 angular.module('Bastion.content-views').controller('FilterRepositoriesController',
-    ['$scope', 'translate', 'Filter', 'ContentViewRepositoriesUtil', 'GlobalNotification',
-    function ($scope, translate, Filter, ContentViewRepositoriesUtil, GlobalNotification) {
+    ['$scope', 'translate', 'Filter', 'ContentViewRepositoriesUtil', 'Notification',
+    function ($scope, translate, Filter, ContentViewRepositoriesUtil, Notification) {
         var refreshTable, success, error;
 
         ContentViewRepositoriesUtil($scope);
@@ -51,12 +51,12 @@ angular.module('Bastion.content-views').controller('FilterRepositoriesController
 
         success = function (filter) {
             refreshTable(filter);
-            GlobalNotification.setSuccessMessage(translate('Affected repositories have been updated.'));
+            Notification.setSuccessMessage(translate('Affected repositories have been updated.'));
         };
 
         error = function (response) {
             angular.forEach(response.errors, function (responseError) {
-                GlobalNotification.setErrorMessage(responseError);
+                Notification.setErrorMessage(responseError);
             });
         };
 
@@ -69,7 +69,7 @@ angular.module('Bastion.content-views').controller('FilterRepositoriesController
             var repositoryIds = _.map($scope.table.getSelected(), 'id');
 
             if (repositoryIds.length === 0) {
-                GlobalNotification.setErrorMessage(translate('You must select at least one repository.'));
+                Notification.setErrorMessage(translate('You must select at least one repository.'));
             } else {
                 Filter.update({id: $scope.filter.id, 'repository_ids': repositoryIds}, success, error);
             }

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/filter.factory.js

@@ -10,7 +10,7 @@
 angular.module('Bastion.content-views').factory('Filter',
     ['BastionResource', function (BastionResource) {
 
-        return BastionResource('/katello/api/v2/content_view_filters/:filterId/:action',
+        return BastionResource('katello/api/v2/content_view_filters/:filterId/:action',
             {filterId: '@id', 'content_view_id': '@content_view.id'},
             {
                 autocomplete: {method: 'GET', isArray: true, params: {filterId: 'auto_complete_search'}},

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/filters.controller.js

@@ -6,13 +6,13 @@
  * @requires translate
  * @requires Filter
  * @requires Nutupane
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles loading all filters for a content view.
  */
 angular.module('Bastion.content-views').controller('FiltersController',
-    ['$scope', 'translate', 'Filter', 'Nutupane', 'GlobalNotification', function ($scope, translate, Filter, Nutupane, GlobalNotification) {
+    ['$scope', 'translate', 'Filter', 'Nutupane', 'Notification', function ($scope, translate, Filter, Nutupane, Notification) {
         var nutupane, filterTypes;
 
         function removeFilter(id) {
@@ -20,11 +20,11 @@ angular.module('Bastion.content-views').controller('FiltersController',
 
             success = function () {
                 nutupane.removeRow(id);
-                GlobalNotification.setSuccessMessage(translate('Filters successfully removed.'));
+                Notification.setSuccessMessage(translate('Filters successfully removed.'));
             };
 
             failure = function (response) {
-                GlobalNotification.setErrorMessage(response.data.displayMessage);
+                Notification.setErrorMessage(response.data.displayMessage);
             };
 
             Filter.delete({filterId: id}, success, failure);

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/new-filter.controller.js

@@ -6,12 +6,12 @@
  * @requires translate
  * @requires Filter
  * @requires Rule
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  */
 angular.module('Bastion.content-views').controller('NewFilterController',
-    ['$scope', 'translate', 'Filter', 'Rule', 'GlobalNotification', function ($scope, translate, Filter, Rule, GlobalNotification) {
+    ['$scope', 'translate', 'Filter', 'Rule', 'Notification', function ($scope, translate, Filter, Rule, Notification) {
         var filterType;
 
         function transitionToDetails(filter) {
@@ -44,7 +44,7 @@ angular.module('Bastion.content-views').controller('NewFilterController',
             };
 
             error = function (response) {
-                GlobalNotification.setErrorMessage(response.data.displayMessage);
+                Notification.setErrorMessage(response.data.displayMessage);
             };
 
             rule.$save({filterId: filter.id}, addSuccess, error);

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/package-filter.controller.js

@@ -10,17 +10,17 @@
  * @requires Filter
  * @requires Rule
  * @requires Package
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles package filter rules for a content view.
  */
 angular.module('Bastion.content-views').controller('PackageFilterController',
-    ['$scope', '$location', 'translate', 'Nutupane', 'CurrentOrganization', 'Filter', 'Rule', 'Package', 'GlobalNotification', function ($scope, $location, translate, Nutupane, CurrentOrganization, Filter, Rule, Package, GlobalNotification) {
+    ['$scope', '$location', 'translate', 'Nutupane', 'CurrentOrganization', 'Filter', 'Rule', 'Package', 'Notification', function ($scope, $location, translate, Nutupane, CurrentOrganization, Filter, Rule, Package, Notification) {
         var nutupane, params;
 
         function failure(response) {
-            GlobalNotification.setErrorMessage(response.data.displayMessage);
+            Notification.setErrorMessage(response.data.displayMessage);
         }
 
         function createRule(rule) {
@@ -31,7 +31,7 @@ angular.module('Bastion.content-views').controller('PackageFilterController',
                 rule.editMode = false;
                 rule.working = false;
 
-                GlobalNotification.setSuccessMessage(translate('Package successfully added.'));
+                Notification.setSuccessMessage(translate('Package successfully added.'));
             };
 
             if ($scope.valid(rule)) {
@@ -48,7 +48,7 @@ angular.module('Bastion.content-views').controller('PackageFilterController',
                 rule.previous = {};
                 rule.editMode = false;
                 rule.working = false;
-                GlobalNotification.setSuccessMessage(translate('Package successfully updated.'));
+                Notification.setSuccessMessage(translate('Package successfully updated.'));
             };
 
             error = function () {
@@ -63,7 +63,7 @@ angular.module('Bastion.content-views').controller('PackageFilterController',
 
             success = function () {
                 nutupane.removeRow(ruleId);
-                GlobalNotification.setSuccessMessage(translate('Package successfully removed.'));
+                Notification.setSuccessMessage(translate('Package successfully removed.'));
             };
 
             Rule.delete({filterId: $scope.$stateParams.filterId, ruleId: ruleId}, success, failure);

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-views/details/filters/package-group-list-filter.controller.js

@@ -7,15 +7,15 @@
  * @requires Filter
  * @requires Rule
  * @requires Nutupane
- * @requires GlobalNotification
+ * @requires Notification
  *
  * @description
  *   Handles loading package groups that have been added to the filter via filter rules
  *   and provides a method to remove them.
  */
 angular.module('Bastion.content-views').controller('PackageGroupFilterListController',
-    ['$scope', 'translate', 'PackageGroup', 'Rule', 'Nutupane', 'GlobalNotification',
-    function ($scope, translate, PackageGroup, Rule, Nutupane, GlobalNotification) {
+    ['$scope', 'translate', 'PackageGroup', 'Rule', 'Nutupane', 'Notification',
+    function ($scope, translate, PackageGroup, Rule, Nutupane, Notification) {
         var nutupane;
 
         function success(rule) {
@@ -23,11 +23,11 @@ angular.module('Bastion.content-views').controller('PackageGroupFilterListContro
             $scope.filter.rules = _.reject($scope.filter.rules, function (filterRule) {
                 return rule.id === filterRule.id;
             });
-            GlobalNotification.setSuccessMessage(translate('Package Group successfully removed.'));
+            Notification.setSuccessMessage(translate('Package Group successfully removed.'));
         }
 
         function failure(response) {
-            GlobalNotification.setErrorMessage(response.data.displayMessage);
+            Notification.setErrorMessage(response.data.displayMessage);
         }
 
         function findRules(packageGroupIds) {