katello 3.18.0.rc2.1 → 4.0.0.rc2

data/db/migrate/20150930183738_migrate_content_hosts.rb

@@ -329,7 +329,7 @@ class MigrateContentHosts < ActiveRecord::Migration[4.2]
   # rubocop:disable Metrics/MethodLength
   # rubocop:disable Metrics/AbcSize
   def up
-    if User.where(:login => User::ANONYMOUS_API_ADMIN).first.nil?
+    unless User.unscoped.where(:login => User::ANONYMOUS_API_ADMIN).exists?
       logger.warn("Foreman anonymous admin does not exist, skipping content host migration.")
       return
     end

data/db/migrate/20191204214919_add_content_view_version_counts.rb

@@ -2,6 +2,5 @@ class AddContentViewVersionCounts < ActiveRecord::Migration[5.2]
   def change
     add_column :katello_content_view_versions, :content_counts, :text
     Katello::ContentViewVersion.reset_column_information
-    Katello::ContentViewVersion.all.each(&:update_content_counts!)
   end
 end

data/db/migrate/20200514092553_move_katello_fields_from_hostgroups.katello.rb

@@ -1,6 +1,6 @@
 class MoveKatelloFieldsFromHostgroups < ActiveRecord::Migration[6.0]
   def up
-    if User.where(login: User::ANONYMOUS_ADMIN).exists?
+    if User.unscoped.where(login: User::ANONYMOUS_ADMIN).exists?
       User.as_anonymous_admin do
         copy_data_from_hostgroup
       end
@@ -46,7 +46,10 @@ class MoveKatelloFieldsFromHostgroups < ActiveRecord::Migration[6.0]
         content_facet.kickstart_repository_id = kickstart_repository_id
         content_facet.content_view_id = content_view_id
         content_facet.lifecycle_environment_id = lifecycle_environment_id
-        content_facet.save!
+        unless content_facet.save
+          Rails.logger.warn("Unable to save content facet hostgroup for #{content_facet.inspect} ")
+          Rails.logger.warn(content_facet.errors.full_messages.join("\n"))
+        end
       end
     end
   end

data/db/migrate/20201119211133_pulp3_migration_progress.rb

@@ -0,0 +1,9 @@
+class Pulp3MigrationProgress < ActiveRecord::Migration[6.0]
+  def change
+    create_table :katello_content_migration_progresses do |t|
+      t.string :progress_message
+      t.boolean :canceled, null: false, default: false
+      t.string :task_id, null: false, index: {name: 'katello_content_migration_progress_task_id', unique: true }
+    end
+  end
+end

data/db/migrate/20210119162528_delete_puppet_and_ostree_repos.rb

@@ -0,0 +1,56 @@
+class DeletePuppetAndOstreeRepos < ActiveRecord::Migration[6.0]
+  class FakeContentViewPuppetModule < Katello::Model
+    self.table_name = 'katello_content_view_puppet_modules'
+  end
+
+  class FakeContentViewPuppetEnvironmentPuppetModule < Katello::Model
+    self.table_name = 'katello_content_view_puppet_environment_puppet_modules'
+  end
+
+  class FakeRepositoryPuppetModule < Katello::Model
+    self.table_name = 'katello_repository_puppet_modules'
+  end
+
+  class FakeContentViewPuppetEnvironment < Katello::Model
+    self.table_name = 'katello_content_view_puppet_environments'
+  end
+  class FakePuppetModule < Katello::Model
+    self.table_name = 'katello_puppet_modules'
+  end
+  class FakeRepositoryOstreeBranch < Katello::Model
+    self.table_name = 'katello_repository_ostree_branches'
+  end
+  class FakeOstreeBranch < Katello::Model
+    self.table_name = 'katello_ostree_branches'
+  end
+
+  def up
+    if Katello::Repository.ostree_type.any? || Katello::Repository.puppet_type.any?
+      User.as_anonymous_admin do
+        FakeContentViewPuppetModule.delete_all
+        FakeContentViewPuppetEnvironmentPuppetModule.delete_all
+        FakeRepositoryPuppetModule.delete_all
+
+        FakeContentViewPuppetEnvironment.delete_all
+        FakePuppetModule.delete_all
+
+        Katello::Repository.puppet_type.delete_all
+
+        FakeRepositoryOstreeBranch.delete_all
+        FakeOstreeBranch.delete_all
+        Katello::Repository.ostree_type.where.not(:library_instance_id => nil, :environment_id => nil).destroy_all #CV LCE repos
+        Katello::Repository.ostree_type.where.not(:library_instance_id => nil).destroy_all # archive repos
+        Katello::Repository.ostree_type.destroy_all #all the rest (should just be library repos)
+
+        Katello::ContentViewVersion.where.not(:content_counts => nil).each do |version|
+          version.content_counts.except!('ostree', 'puppet_module')
+          version.save
+        end
+      end
+    end
+  end
+
+  def down
+    fail ActiveRecord::IrreversibleMigration
+  end
+end

data/db/migrate/20210122200618_create_katello_agent_dispatch_history.rb

@@ -0,0 +1,11 @@
+class CreateKatelloAgentDispatchHistory < ActiveRecord::Migration[6.0]
+  def change
+    create_table :katello_agent_dispatch_histories do |t|
+      t.integer :host_id, null: false, foreign_key: true
+      t.datetime :accepted_at
+      t.string :dynflow_execution_plan_id
+      t.integer :dynflow_step_id
+      t.text :result
+    end
+  end
+end

data/db/migrate/20210125161911_delete_erratum_install_batch_size_setting.rb

@@ -0,0 +1,5 @@
+class DeleteErratumInstallBatchSizeSetting < ActiveRecord::Migration[6.0]
+  def change
+    Setting.where(name: 'erratum_install_batch_size').delete_all
+  end
+end

data/db/migrate/20210128231228_add_type_and_from_cvv_to_cvv_export_history.rb

@@ -0,0 +1,14 @@
+class AddTypeAndFromCvvToCvvExportHistory < ActiveRecord::Migration[6.0]
+  def change
+    add_column :katello_content_view_version_export_histories,
+               :export_type, :string,
+               :default => ::Katello::ContentViewVersionExportHistory::COMPLETE, :null => false
+    add_index :katello_content_view_version_export_histories, :export_type, name: 'katello_cvveh_export_type'
+
+    ::Katello::ContentViewVersionExportHistory.reset_column_information
+    ::Katello::ContentViewVersionExportHistory.all.each do |cvve|
+      next if cvve.export_type == cvve.export_type_from_metadata
+      cvve.update!(export_type: cvve.export_type_from_metadata)
+    end
+  end
+end

data/db/migrate/20210201163238_migrate_background_download_policy_to_migrate.rb

@@ -0,0 +1,7 @@
+class MigrateBackgroundDownloadPolicyToMigrate < ActiveRecord::Migration[6.0]
+  def change
+    Katello::RootRepository.where(:download_policy => ::Runcible::Models::YumImporter::DOWNLOAD_BACKGROUND).each do |root_repo|
+      root_repo.update_column(:download_policy, ::Runcible::Models::YumImporter::DOWNLOAD_IMMEDIATE)
+    end
+  end
+end

data/db/migrate/20210208213920_add_available_module_stream_context.rb

@@ -0,0 +1,8 @@
+class AddAvailableModuleStreamContext < ActiveRecord::Migration[6.0]
+  def change
+    add_column :katello_available_module_streams, :context, :string, :null => true, :default => nil
+
+    remove_index :katello_available_module_streams, name: :katello_available_module_streams_name_stream
+    add_index :katello_available_module_streams, [:name, :stream, :context], :unique => true, :name => :katello_available_module_streams_name_stream_context
+  end
+end

data/db/seeds.d/104-proxy.rb

@@ -16,7 +16,7 @@ User.as(::User.anonymous_api_admin.login) do
     fail "Unable to create proxy feature: #{format_errors feature}"
   end
 
-  ["Pulp", "Pulp Node", "Pulpcore"].each do |input|
+  ["Pulp", "Pulp Node", "Pulpcore", "Container_Gateway"].each do |input|
     f = Feature.where(:name => input).first_or_create
     fail "Unable to create proxy feature: #{format_errors f}" if f.nil? || f.errors.any?
   end

data/db/seeds.d/111-upgrade_tasks.rb

@@ -14,6 +14,7 @@ UpgradeTask.define_tasks(:katello) do
     {:name => 'katello:upgrades:3.15:set_sub_facet_dmi_uuid'},
     {:name => 'katello:upgrades:3.15:reindex_rpm_modular'},
     {:name => 'katello:upgrades:3.16:update_applicable_el8_hosts'},
-    {:name => 'katello:upgrades:3.18:add_cvv_export_history_metadata'}
+    {:name => 'katello:upgrades:3.18:add_cvv_export_history_metadata'},
+    {:name => 'katello:upgrades:4.0:remove_ostree_puppet_content'}
   ]
 end

data/engines/bastion/app/assets/javascripts/bastion/auth/authorization.service.js

@@ -20,7 +20,7 @@ angular.module('Bastion.auth').service('Authorization', ['CurrentUser', 'Permiss
                 allowedTo = model.permissions[permissionName];
             } else {
                 angular.forEach(Permissions, function (permission) {
-                    if (permission.permission.name === permissionName) {
+                    if (permission.name === permissionName) {
                         allowedTo = true;
                     }
                 });

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/capsule-content/capsule-content.controller.js

@@ -116,7 +116,7 @@ angular.module('Bastion.capsule-content').controller('CapsuleContentController',
         };
 
         $scope.syncState = syncState;
-
+        $scope.smartProxyId = capsuleId;
         $scope.expandEnvironments = {};
 
         refreshSyncStatus();

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/common/views/katello-agent-notice.html

@@ -1,7 +1,7 @@
 <section>
   <p bst-alert="warning" >
     <span translate>
-      Katello-agent is deprecated and will be removed in Katello 4.0.  Consider migrating to Remote Execution.
+      Katello-agent is deprecated and will be removed in a future release.
     </span>
   </p>
 </section>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/bulk/views/content-hosts-bulk-system-purpose-modal.html

@@ -1,8 +1,7 @@
 <div data-extend-template="components/views/bst-modal.html">
-  <h4 data-block="modal-header" translate>Content Host System Purpose</h4>
+  <h2 data-block="modal-header" translate>Assign System Purpose</h2>
 
   <div data-block="modal-body">
-    <h4 translate>Assign System Purpose:</h4>
 
     <div class="row">
       <div class="col-sm-12">
@@ -10,67 +9,63 @@
       </div>
     </div>
 
+    <div bst-alert="info">
+      <span translate>
+        This change will be applied to <b>{{ hostCount }} systems.</b>
+      </span>
+    </div>
+    <br />
+
     <form name="contentHostContentForm" class="form" ng-hide="content.workingMode">
-      <div>
-        <label translate>Service Level:</label>
+      <div><b>
+        <dl class="dl-horizontal dl-horizontal-left">
+        <dt><label translate>Service Level (SLA):</label></dt>
 
-        <select type="select"
-                ng-options="item for item in defaultServiceLevels"
-                ng-model="selectedServiceLevels">
-        </select>
-      <br /><br />
+        <dd><select type="select"
+                    ng-options="item for item in defaultServiceLevels"
+                    ng-model="selectedServiceLevels">
+        </select></dd>
+        <br /><br />
 
-        <label translate>Usage Type:</label>
+        <dt style="margin-left: -50px;"><label translate>Usage Type:</label></dt>
 
-        <select type="select"
+        <dd><select type="select"
                 ng-options="item for item in defaultUsages"
                 ng-model="selectedRoles">
-        </select>
+        </select></dd>
         <br /><br />
 
-        <label translate>Role:</label>
+        <dt style="margin-left: -98px;"><label translate>Role:</label></dt>
 
-        <select type="select"
+        <dd><select type="select"
                 ng-options="item for item in defaultRoles"
                 ng-model="selectedUsages">
-        </select>
+        </select></dd>
         <br /><br />
 
-        <label ng-hide="!purposeAddonsList().length" translate>Add ons:</label>
-        <div class="help-block" style="text-align:left;">
-          <p translate>ctrl-click or shift-click to select multiple Add ons</p>
-        </div>
+        <dt style="margin-left: -75px;"><label ng-hide="!purposeAddonsList().length" translate>Add ons:</label></dt>
 
-        <select multiple ng-multiple="true"
+        <dd><select multiple ng-multiple="true"
                 ng-hide="!purposeAddonsList().length"
                 ng-options="item for item in purposeAddonsList()"
                 ng-model="selectedAddons">
-        </select>
-        <br /><br />
-
-      </div>
-
-      <div bst-alert="info" ng-show="showConfirm">
-        <span translate>
-          Set System Purpose values on {{ hostCount }} selected content hosts?
-        </span>
-        <div>
-          <br />
-          <button type="button" class="btn btn-primary" ng-click="showConfirm = false; performAction()" translate>Assign</button>
+        </select></dd>
+        <div class="help-block" style="text-align:center; margin-left: -180px;">
+          <p translate>ctrl-click or shift-click to select multiple Add ons</p>
         </div>
+        <br /><br />
+        </dl></b>
       </div>
-
-      <button class="btn btn-primary"
-              type="button"
-              ng-hide="showConfirm"
-              ng-click="showConfirm = true;">
-        <span translate>Assign</span>
-      </button>
-
     </form>
   </div>
 
   <div data-block="modal-footer">
+    <button class="btn btn-primary"
+            type="button"
+            ng-click="performAction()">
+      <span translate>Assign</span>
+    </button>
+
     <button type="button" class="btn btn-default" ng-click="cancel()" translate>
       Cancel
     </button>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/content-host-register-os-client.directive.js

@@ -0,0 +1,17 @@
+angular.module('Bastion.content-hosts').directive('registerOsClient', function () {
+    return {
+    restrict: 'E',
+    scope: {
+      userOs: '='
+    },
+    link: function($scope) {
+        $scope.$watch('userOs', function(userOs) {
+            if (userOs && userOs.length) {
+                $scope.dynamicTemplateUrl = 'content-hosts/views/register-' + userOs + '.html';
+            }
+        });
+    },
+
+    template: '<ng-include src="dynamicTemplateUrl"></ng-include>'
+  };
+});

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/details/views/content-host-info.html

@@ -323,7 +323,7 @@
 
       <dl class="dl-horizontal dl-horizontal-left">
         <dt translate>Registered</dt>
-        <dd><short-date-time date="host.created_at" /></dd>
+        <dd><long-date-time date="host.created_at" /></dd>
 
         <dt translate> Registered By</dt>
         <dd>
@@ -350,7 +350,7 @@
         </dd>
 
         <dt translate>Last Checkin</dt>
-        <dd><short-date-time date="host.subscription_facet_attributes.last_checkin" default="'Never checked in' | translate" /></dd>
+        <dd><long-date-time date="host.subscription_facet_attributes.last_checkin" default="'Never checked in' | translate" /></dd>
       </dl>
 
       <div class="divider"></div>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/views/content-hosts.html

@@ -131,8 +131,8 @@
           <td bst-table-cell>{{ host.operatingsystem_name }}</td>
           <td bst-table-cell>{{ host.content_facet_attributes.lifecycle_environment.name }}</td>
           <td bst-table-cell>{{ host.content_facet_attributes.content_view.name || "" }}</td>
-          <td bst-table-cell><short-date-time date="host.subscription_facet_attributes.registered_at" default="'Never registered' | translate" /></td>
-          <td bst-table-cell><short-date-time date="host.subscription_facet_attributes.last_checkin" default="'Never checked in' | translate" /></td>
+          <td bst-table-cell><long-date-time date="host.subscription_facet_attributes.registered_at" default="'Never registered' | translate" /></td>
+          <td bst-table-cell><long-date-time date="host.subscription_facet_attributes.last_checkin" default="'Never checked in' | translate" /></td>
         </tr>
       </tbody>
     </table>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/views/register-client.html

@@ -1,3 +1,10 @@
+<div ng-controller="ContentHostRegisterController"><li>
+        <p translate>Register using subscription-manager:</p>
+        <p translate>Using an Activation Key:</p>
+        <pre><code>subscription-manager register --org="{{ organization.label }}" --activationkey="&ltActivation Key Name&gt"</code></pre>
+        <p translate>Using a username and password:</p>
+        <pre><code>subscription-manager register --org="{{ organization.label }}" --environment="Library"</code></pre>
+      </li>
 <li>
   <p translate>Install client package:</p>
 
@@ -7,15 +14,15 @@
   <p translate>Tracer helps administrators identify applications that need to be restarted after a system is patched. To optionally report tracer information:</p>
   <pre><code>yum -y install katello-host-tools-tracer</code></pre>
 
-  <p translate>For remote actions via katello-agent:</p>
-  <pre><code>yum -y install katello-agent</code></pre>
-  <section>
+  <p  ng-hide="remoteExecutionByDefault" translate>For remote actions via katello-agent:</p>
+  <pre ng-hide="remoteExecutionByDefault" ><code>yum -y install katello-agent</code></pre>
+  <section ng-hide="remoteExecutionByDefault" >
     <p bst-alert="warning" >
     <span translate>
-      Katello-agent is deprecated and will be removed in Katello 4.0.  Consider migrating to Remote Execution.
+      Katello-agent is deprecated and will be removed in a future release.
     </span>
     </p>
   </section>
 
   <p translate>Learn more about these packages in the <a href="https://theforeman.org/plugins/katello/">Documentation</a> </p>
-</li>
+</li></div>

data/engines/bastion_katello/app/assets/javascripts/bastion_katello/content-hosts/views/register-deb-client.html

@@ -0,0 +1,38 @@
+<div ng-controller="ContentHostRegisterController">
+<li ng-hide="noCapsulesFound">
+    <p translate>Select a Content Source:</p>
+    <p><select ng-model="selectedCapsule" ng-options="capsule.name for capsule in capsules.results"></select></p>
+</li>
+
+<li>
+  <p>Add the GPG public key used to sign DEB packages from your system to download the Debian/Ubuntu client from your system:</p>
+
+<pre><code>apt-get -y install gnupg
+mkdir -p /etc/apt/trusted.gpg.d
+wget "https://{{ noCapsulesFound ? katelloHostname : hostname(selectedCapsule.url) }}/pub/pulp_deb_signing.key" -O - | apt-key add -</code></pre>
+</li>
+
+<li>
+Create a new repository file which contains the Debian/Ubuntu client. This example chooses Ubuntu 20.04:
+
+<pre><code>mkdir -p /etc/apt/sources.list.d
+cat &lt /etc/apt/sources.list &lt&lt'EOF'
+deb http://{{  noCapsulesFound ? katelloHostname : hostname(selectedCapsule.url) }}/pulp/deb/{{ organization.label }}/Library/custom/Ubuntu_Client/Ubuntu_Client_20_04/ default all
+EOF</code></pre>
+<p>Here Ubuntu_Client is a product name, Ubuntu_Client_20_04 is the repository inside the product, and Library is a lifecycle environment.</p>
+</li>
+<li>
+Install apt-transport-katello and katello-upload-profile. This depends on and automatically installs the subscription-manager for Debian/Ubuntu:
+
+<pre><code>apt-get update && apt-get -y install apt-transport-katello katello-upload-profile</code></pre></li>
+<li>
+Download and execute a script from your system to install all necessary certificates:
+
+<pre><code>wget --no-check-certificate -O katello-rhsm-consumer https://{{ noCapsulesFound ? katelloHostname : hostname(selectedCapsule.url) }}/pub/katello-rhsm-consumer
+/bin/bash -x katello-rhsm-consumer 2&lt /root/katello-rhsm-consumer.log</code></pre></li>
+<li>
+Register your host with an appropriate activation key:
+
+<pre><code>subscription-manager register --org="{{ organization.label }}" --name="&ltHost Name&gt" --activationkey="&ltActivation Key Name&gt"</code></pre>
+
+</li></div>