katello 3.15.1 → 3.16.0.rc2.1

data/db/functions/isalpha_v01.sql

@@ -0,0 +1,11 @@
+create or replace FUNCTION isalpha(ch CHAR)
+  RETURNS BOOLEAN as $$
+  BEGIN
+    if ascii(ch) between ascii('a') and ascii('z') or
+        ascii(ch) between ascii('A') and ascii('Z')
+    then
+      return TRUE;
+    end if;
+    return FALSE;
+  END;
+$$ language 'plpgsql';

data/db/functions/isalphanum_v01.sql

@@ -0,0 +1,12 @@
+create or replace FUNCTION isalphanum(ch CHAR)
+	RETURNS BOOLEAN as $$
+	BEGIN
+		if ascii(ch) between ascii('a') and ascii('z') or
+			ascii(ch) between ascii('A') and ascii('Z') or
+			ascii(ch) between ascii('0') and ascii('9')
+		then
+			return TRUE;
+		end if;
+		return FALSE;
+	END;
+$$ language 'plpgsql';

data/db/functions/isdigit_v01.sql

@@ -0,0 +1,10 @@
+create or replace function isdigit(ch CHAR)
+	RETURNS BOOLEAN as $$
+	BEGIN
+	  if ascii(ch) between ascii('0') and ascii('9')
+	  then
+		return TRUE;
+	  end if;
+	  return FALSE;
+	END ;
+$$ language 'plpgsql';

data/db/functions/rpmver_array_v01.sql

@@ -0,0 +1,60 @@
+create or replace FUNCTION rpmver_array (string1 IN VARCHAR)
+	RETURNS evr_array_item[] as $$
+	declare
+		str1 VARCHAR := string1;
+		digits VARCHAR(10) := '0123456789';
+		lc_alpha VARCHAR(27) := 'abcdefghijklmnopqrstuvwxyz';
+		uc_alpha VARCHAR(27) := 'ABCDEFGHIJKLMNOPQRSTUVWXYZ';
+		alpha VARCHAR(54) := lc_alpha || uc_alpha;
+		one VARCHAR;
+		isnum BOOLEAN;
+		ver_array evr_array_item[] := ARRAY[]::evr_array_item[];
+	BEGIN
+		if str1 is NULL
+		then
+			RAISE EXCEPTION 'VALUE_ERROR.';
+		end if;
+
+		one := str1;
+		<<segment_loop>>
+		while one <> ''
+		loop
+			declare
+				segm1 VARCHAR;
+				segm1_n NUMERIC := 0;
+			begin
+				-- Throw out all non-alphanum characters
+				while one <> '' and not isalphanum(one)
+				loop
+					one := substr(one, 2);
+				end loop;
+				str1 := one;
+				if str1 <> '' and isdigit(str1)
+				then
+					str1 := ltrim(str1, digits);
+					isnum := true;
+				else
+					str1 := ltrim(str1, alpha);
+					isnum := false;
+				end if;
+				if str1 <> ''
+				then segm1 := substr(one, 1, length(one) - length(str1));
+				else segm1 := one;
+				end if;
+
+				if segm1 = '' then return ver_array; end if; /* arbitrary */
+				if isnum
+				then
+					segm1 := ltrim(segm1, '0');
+					if segm1 <> '' then segm1_n := segm1::numeric; end if;
+					segm1 := NULL;
+				else
+				end if;
+				ver_array := array_append(ver_array, (segm1_n, segm1)::evr_array_item);
+				one := str1;
+			end;
+		end loop segment_loop;
+
+		return ver_array;
+	END ;
+$$ language 'plpgsql';

data/db/migrate/20131016124255_add_foreign_keys_engine.rb

@@ -1,5 +1,5 @@
 class AddForeignKeysEngine < ActiveRecord::Migration[4.2]
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   def change
     add_foreign_key "katello_activation_keys", "katello_content_views", :column => 'content_view_id', :name => "activation_keys_content_view_id_fk"
     add_foreign_key "katello_activation_keys", "katello_environments", :column => 'environment_id', :name => "activation_keys_environment_id_fk"

data/db/migrate/20140117160939_refactor_content_views.rb

@@ -1,5 +1,5 @@
 class RefactorContentViews < ActiveRecord::Migration[4.2]
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   def up
     remove_foreign_key "katello_component_content_views", :name => "component_content_views_content_view_definition_id_fk"
     remove_foreign_key "katello_content_view_definition_bases", :name => "content_view_definition_bases_source_id_fk"

data/db/migrate/20140626204657_add_unlimited_to_activation_keys.rb

@@ -10,16 +10,16 @@ class AddUnlimitedToActivationKeys < ActiveRecord::Migration[4.2]
     Katello::ActivationKeys.reset_column_information
     Katello::ActivationKeys.all.each do |coll|
       if coll.max_content_hosts == -1
-        coll.update_attributes(:unlimited_content_hosts => true, :max_content_hosts => nil)
+        coll.update(:unlimited_content_hosts => true, :max_content_hosts => nil)
       elsif coll.max_content_hosts > 0
-        coll.update_attributes(:unlimited_content_hosts => false)
+        coll.update(:unlimited_content_hosts => false)
       end
     end
   end
 
   def down
     Katello::ActivationKeys.all.each do |key|
-      key.update_attributes(:max_content_hosts => -1) if key.unlimited_content_hosts
+      key.update(:max_content_hosts => -1) if key.unlimited_content_hosts
     end
 
     remove_column :katello_activation_keys, :unlimited_content_hosts

data/db/migrate/20140626204902_add_unlimited_to_host_collection.rb

@@ -9,16 +9,16 @@ class AddUnlimitedToHostCollection < ActiveRecord::Migration[4.2]
     Katello::HostCollections.reset_column_information
     Katello::HostCollections.all.each do |coll|
       if coll.max_content_hosts == -1
-        coll.update_attributes(:unlimited_content_hosts => true, :max_content_hosts => nil)
+        coll.update(:unlimited_content_hosts => true, :max_content_hosts => nil)
       elsif coll.max_content_hosts > 0
-        coll.update_attributes(:unlimited_content_hosts => false)
+        coll.update(:unlimited_content_hosts => false)
       end
     end
   end
 
   def down
     Katello::HostCollections.all.each do |coll|
-      coll.update_attributes(:max_content_hosts => -1) if coll.unlimited_content_hosts
+      coll.update(:max_content_hosts => -1) if coll.unlimited_content_hosts
     end
 
     remove_column :katello_host_collections, :unlimited_content_hosts

data/db/migrate/20140930170628_add_errata.rb

@@ -1,5 +1,5 @@
 class AddErrata < ActiveRecord::Migration[4.2]
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   def up
     create_table "katello_errata" do |t|
       t.string "uuid", :null => false, :limit => 255

data/db/migrate/20150119153452_update_promote_errata_email_description.rb

@@ -2,16 +2,12 @@ class UpdatePromoteErrataEmailDescription < ActiveRecord::Migration[4.2]
   def up
     notification = MailNotification.find_by(:name => :katello_promote_errata)
 
-    if notification
-      notification.update_attribute :description,  "A post-promotion summary of hosts with installable errata"
-    end
+    notification&.update_attribute :description,  "A post-promotion summary of hosts with installable errata"
   end
 
   def down
     notification = MailNotification.find_by(:name => :katello_promote_errata)
 
-    if notification
-      notification.update_attribute :description,  "A post-promotion summary of hosts with installable errata"
-    end
+    notification&.update_attribute :description,  "A post-promotion summary of hosts with installable errata"
   end
 end

data/db/migrate/20150606021722_create_puppet_modules.rb

@@ -1,5 +1,5 @@
 class CreatePuppetModules < ActiveRecord::Migration[4.2]
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   def up
     create_table 'katello_puppet_modules' do |t|
       t.timestamps

data/db/migrate/20150813185339_create_subscriptions.rb

@@ -1,5 +1,5 @@
 class CreateSubscriptions < ActiveRecord::Migration[4.2]
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   def change
     create_table "katello_subscriptions" do |t|
       t.string  :name, :limit => 255

data/db/migrate/20150826170004_add_content_facet.rb

@@ -1,5 +1,5 @@
 class AddContentFacet < ActiveRecord::Migration[4.2]
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   def change
     create_table "katello_content_facets" do |t|
       t.references 'host', :null => false

data/db/migrate/20150930183738_migrate_content_hosts.rb

@@ -210,14 +210,12 @@ class MigrateContentHosts < ActiveRecord::Migration[4.2]
     systems = systems.to_a
 
     systems.each do |system|
-      begin
-        facts = system.facts
-        unless facts
-          systems_to_remove.push(system)
-        end
-      rescue RestClient::Exception
+      facts = system.facts
+      unless facts
         systems_to_remove.push(system)
       end
+    rescue RestClient::Exception
+      systems_to_remove.push(system)
     end
 
     systems_to_remove.each do |system|
@@ -328,8 +326,8 @@ class MigrateContentHosts < ActiveRecord::Migration[4.2]
     ::Katello::Resources::Candlepin::Consumer.update(hypervisor.uuid, 'environment' => {'id' => candlepin_environment_id})
   end
 
-  # rubocop:disable MethodLength
-  # rubocop:disable AbcSize
+  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable Metrics/AbcSize
   def up
     if User.where(:login => User::ANONYMOUS_API_ADMIN).first.nil?
       logger.warn("Foreman anonymous admin does not exist, skipping content host migration.")

data/db/migrate/20160908234510_add_rpm_nvra.rb

@@ -1,7 +1,7 @@
 class AddRpmNvra < ActiveRecord::Migration[4.2]
   def up
     add_column :katello_rpms, :nvra, :string, :limit => 1020
-    Katello::Rpm.find_each { |r| r.update_attributes!(:nvra => r.build_nvra) }
+    Katello::Rpm.find_each { |r| r.update!(:nvra => r.build_nvra) }
   end
 
   def down

data/db/migrate/20160930150810_add_smart_proxy_download_policy.rb

@@ -4,7 +4,7 @@ class AddSmartProxyDownloadPolicy < ActiveRecord::Migration[4.2]
     add_column :smart_proxies, :download_policy, :string, :null => true
     SmartProxy.reset_column_information
     SmartProxy.all.each do |proxy|
-      proxy.update_attributes(:download_policy => SmartProxy::DOWNLOAD_INHERIT)
+      proxy.update(:download_policy => SmartProxy::DOWNLOAD_INHERIT)
     end
   end
 

data/db/migrate/20161014133811_move_content_view_version_description_to_histories.rb

@@ -29,7 +29,7 @@ class MoveContentViewVersionDescriptionToHistories < ActiveRecord::Migration[4.2
                                             created_at: version.created_at
                                            )
 
-      publish_history.update_attributes!(notes: version[:description])
+      publish_history.update!(notes: version[:description])
     end
 
     remove_column :katello_content_view_versions, :description, :text

data/db/migrate/20161026191118_fix_invalid_interfaces.rb

@@ -9,7 +9,7 @@ class FixInvalidInterfaces < ActiveRecord::Migration[4.2]
 
   def up
     FakeNic.where(:ip => "Unknown").each do |nic|
-      nic.update_attributes(:ip => nil)
+      nic.update(:ip => nil)
     end
   end
 end

data/db/migrate/20180103230812_set_errata_updated_date.rb

@@ -1,7 +1,7 @@
 class SetErrataUpdatedDate < ActiveRecord::Migration[5.0]
   def up
     Katello::Erratum.where(:updated => nil).find_each do |erratum|
-      erratum.update_attributes(:updated => erratum.issued)
+      erratum.update(:updated => erratum.issued)
     end
   end
 end

data/db/migrate/20180410140909_add_organization_id_to_pool.rb

@@ -6,7 +6,7 @@ class AddOrganizationIdToPool < ActiveRecord::Migration[5.1]
 
     ::Katello::Pool.reset_column_information
     ::Katello::Pool.find_each do |pool|
-      pool.update_attributes(:organization_id => pool.subscription.organization_id) if pool.subscription
+      pool.update(:organization_id => pool.subscription.organization_id) if pool.subscription
     end
   end
 

data/db/migrate/20180920214134_create_repository_root.rb

@@ -33,7 +33,6 @@ class CreateRepositoryRoot < ActiveRecord::Migration[5.1]
     self.table_name = 'katello_repositories'
 
     REPO_ASSOCIATIONS.each do |association|
-      # rubocop:disable Rails/ReflectionClassName
       has_many association.underscore.pluralize.to_sym, :class_name => "CreateRepositoryConfiguration::Fake#{association}", :dependent => :delete_all, :inverse_of => :repository
     end
 
@@ -64,7 +63,7 @@ class CreateRepositoryRoot < ActiveRecord::Migration[5.1]
       clones = FakeRepository.where(:library_instance_id => library_instance.id).to_a
       root = create_root(library_instance)
       (clones + [library_instance]).each do |repo|
-        repo.update_attributes!(:root_id => root.id)
+        repo.update!(:root_id => root.id)
       end
     end
   end
@@ -84,7 +83,7 @@ class CreateRepositoryRoot < ActiveRecord::Migration[5.1]
     FakeRootRepository.create!(attributes)
   end
 
-  # rubocop:disable MethodLength
+  # rubocop:disable Metrics/MethodLength
   def create_root_table
     create_table 'katello_root_repositories' do |t|
       t.string 'name', limit: 255

data/db/migrate/20190730183518_add_docker_tag_join_table.rb

@@ -17,7 +17,7 @@ class AddDockerTagJoinTable < ActiveRecord::Migration[5.2]
     add_column :katello_docker_tags, :repository_id, :integer
 
     ::Katello::DockerTag.all.each do |tag|
-      tag.update_attributes(repository_id: tag.repositories.first.id)
+      tag.update(repository_id: tag.repositories.first.id)
     end
 
     drop_table :katello_repository_docker_tags

data/db/migrate/20190730203334_add_docker_meta_tag_join_table.rb

@@ -17,7 +17,7 @@ class AddDockerMetaTagJoinTable < ActiveRecord::Migration[5.2]
     add_column :katello_docker_meta_tags, :repository_id, :integer
 
     ::Katello::DockerMetaTag.all.each do |meta_tag|
-      meta_tag.update_attributes(repository_id: meta_tag.repositories.first.id)
+      meta_tag.update(repository_id: meta_tag.repositories.first.id)
     end
 
     drop_table :katello_repository_docker_meta_tags

data/db/migrate/20200204034123_add_pulp3_href_to_repository_erratum.rb

@@ -0,0 +1,6 @@
+class AddPulp3HrefToRepositoryErratum < ActiveRecord::Migration[5.2]
+  def change
+    add_column :katello_repository_errata, :erratum_pulp3_href, :string
+    add_index :katello_repository_errata, :erratum_pulp3_href
+  end
+end

data/db/migrate/20200213184848_create_evr_type.rb

@@ -0,0 +1,49 @@
+require 'fx'
+
+class CreateEvrType < ActiveRecord::Migration[5.2]
+  def up
+    unless connection.adapter_name.downcase.include?('sqlite')
+
+      enable_extension "evr"
+
+      add_column :katello_rpms, :evr, :evr_t
+      add_column :katello_installed_packages, :evr, :evr_t
+
+      create_trigger :evr_insert_trigger_katello_rpms, on: :katello_rpms
+      create_trigger :evr_update_trigger_katello_rpms, on: :katello_rpms
+      create_trigger :evr_insert_trigger_katello_installed_packages, on: :katello_installed_packages
+      create_trigger :evr_update_trigger_katello_installed_packages, on: :katello_installed_packages
+
+      execute <<-SQL
+        update katello_rpms SET evr = (ROW(coalesce(epoch::numeric,0),
+                                           rpmver_array(coalesce(version,'empty'))::evr_array_item[],
+                                           rpmver_array(coalesce(release,'empty'))::evr_array_item[])::evr_t);
+
+        update katello_installed_packages SET evr = (ROW(coalesce(epoch::numeric,0),
+                                                         rpmver_array(coalesce(version,'empty'))::evr_array_item[],
+                                                         rpmver_array(coalesce(release,'empty'))::evr_array_item[])::evr_t);
+      SQL
+
+      add_index :katello_rpms, [:name, :arch, :evr]
+      add_index :katello_erratum_packages, [:erratum_id, :nvrea]
+    end
+  end
+
+  def down
+    # fx doesn't seem to have support for dropping functions with parameters
+    unless connection.adapter_name.downcase.include?('sqlite')
+      remove_index :katello_rpms, column: [:name, :arch, :evr]
+      remove_index :katello_erratum_packages, column: [:erratum_id, :nvrea]
+
+      drop_trigger :evr_insert_trigger_katello_rpms, on: :katello_rpms
+      drop_trigger :evr_update_trigger_katello_rpms, on: :katello_rpms
+      drop_trigger :evr_insert_trigger_katello_installed_packages, on: :katello_installed_packages
+      drop_trigger :evr_update_trigger_katello_installed_packages, on: :katello_installed_packages
+
+      remove_column :katello_rpms, :evr
+      remove_column :katello_installed_packages, :evr
+
+      disable_extension "evr"
+    end
+  end
+end

data/db/migrate/20200304201026_create_katello_module_stream_rpms.rb

@@ -0,0 +1,15 @@
+class CreateKatelloModuleStreamRpms < ActiveRecord::Migration[5.2]
+  def change
+    create_table :katello_module_stream_rpms do |t|
+      t.references :module_stream, :null => false, index: { :name => 'katello_msrpm_module_stream_idx' }
+      t.references :rpm, null: false, index: { :name => 'katello_msrpm_rpm_idx' }
+      t.timestamps
+    end
+
+    add_index :katello_module_stream_rpms, [:module_stream_id, :rpm_id],
+              unique: true, name: :katello_msrpm_module_stream_rpms_uniq
+
+    add_foreign_key "katello_module_stream_rpms", "katello_module_streams", :column => "module_stream_id", name: :katello_msrpm_mod_stream_id_fk
+    add_foreign_key "katello_module_stream_rpms", "katello_rpms", :column => "rpm_id", name: :katello_msrpm_rpm_id_fk
+  end
+end

data/db/migrate/20200407171926_create_content_guard.rb

@@ -0,0 +1,10 @@
+class CreateContentGuard < ActiveRecord::Migration[5.2]
+  def change
+    create_table :katello_content_guards do |t|
+      t.string :pulp_href, :null => false
+      t.string :name, :null => false, :unique => true
+    end
+
+    add_column :katello_distribution_references, :content_guard_href, :string
+  end
+end

data/db/migrate/20200506163345_add_applicability_indicesto_katello_host_available_module_streams.rb

@@ -0,0 +1,12 @@
+class AddApplicabilityIndicestoKatelloHostAvailableModuleStreams < ActiveRecord::Migration[6.0]
+  def up
+    add_index :katello_host_available_module_streams,
+      [:host_id, :available_module_stream_id, :status],
+      :name => 'rpm_and_module_applicability_related_indices'
+  end
+
+  def down
+    remove_index :katello_host_available_module_streams,
+      :name => 'rpm_and_module_applicability_related_indices'
+  end
+end

data/db/migrate/20200511204005_create_katello_host_queue_elements.rb

@@ -0,0 +1,12 @@
+class CreateKatelloHostQueueElements < ActiveRecord::Migration[6.0]
+  def up
+    create_table :katello_host_queue_elements do |t|
+      t.integer :host_id
+      t.column :created_at, :datetime
+    end
+  end
+
+  def down
+    drop_table :katello_host_queue_elements
+  end
+end