katapult 0.2.0 → 0.3.0

data/lib/generators/katapult/basics/templates/app/webpack/assets/javascripts/macros/content_link.js

@@ -0,0 +1,17 @@
+const DEFAULT_TARGET = '.content'
+
+up.macro('[content-link]', ($link) => {
+  let target = $link.attr('content-link') || DEFAULT_TARGET
+  let attrs = {
+    'up-target': target,
+    'up-preload': '',
+    'up-instant': '',
+  }
+
+  // It feels wrong for a button
+  if ($link.is('.btn:not(.btn-link)')) {
+    delete attrs['up-instant']
+  }
+
+  $link.attr(attrs)
+})

data/lib/generators/katapult/basics/templates/app/webpack/assets/javascripts/macros/modal_link.js

@@ -0,0 +1,17 @@
+const DEFAULT_TARGET = '.content'
+
+up.macro('[modal-link]', function($link) {
+  let target = $link.attr('modal-link') || DEFAULT_TARGET
+  let attrs = {
+    'up-modal': target,
+    'up-preload': '',
+    'up-instant': '',
+  }
+
+  // It feels wrong for a button
+  if ($link.is('.btn:not(.btn-link)')) {
+    delete attrs['up-instant']
+  }
+
+  $link.attr(attrs)
+})

data/lib/generators/katapult/basics/templates/app/webpack/assets/javascripts/unpoly.js

@@ -0,0 +1,9 @@
+$(() => {
+  if ($(document.body).data('environment') === 'test') {
+    // Disable animations in tests
+    up.motion.config.enabled = false
+
+    // When revealing elements, don't animate the scrolling
+    up.layout.config.duration = 0
+  }
+})

data/lib/generators/katapult/basics/templates/app/webpack/assets/stylesheets/_definitions.sass

@@ -0,0 +1,25 @@
+// Colors
+$theme-blue: #4682B4
+
+$white: #fff
+
+// Transitions
+$transition-distinct: .21s
+$transition-quick: .14s
+$transition-subtle: .07s
+
+// Spacing
+$space-xs: 10px
+$space-sm: 20px
+$space-md: 30px
+$space-lg: 40px
+
+// Bootstrap configuration /////////////////////////////////////////////////////
+$brand-primary: $theme-blue
+
+$font-family-sans-serif: 'Open Sans', 'Segoe UI', sans-serif
+
+$input-border-focus: $brand-primary
+$border-radius-base: 3px
+
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/variables

data/lib/generators/katapult/basics/templates/app/webpack/assets/stylesheets/_environment.sass

@@ -0,0 +1,2 @@
+@import definitions
+@import mixins

data/lib/generators/katapult/basics/templates/app/webpack/assets/stylesheets/_mixins.sass

@@ -0,0 +1,3 @@
+=within-modal
+  .modal-content &
+    @content

data/lib/generators/katapult/basics/templates/app/webpack/assets/stylesheets/custom_bootstrap.sass

@@ -0,0 +1,50 @@
+@import environment
+
+// Core variables and mixins
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/variables
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/mixins
+
+// Reset and dependencies
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/normalize
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/print
+
+// Core CSS
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/scaffolding
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/type
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/code
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/grid
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/tables
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/forms
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/buttons
+
+// Components
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/component-animations
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/dropdowns
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/button-groups
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/input-groups
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/navs
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/navbar
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/breadcrumbs
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/pagination
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/pager
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/labels
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/badges
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/jumbotron
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/thumbnails
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/alerts
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/progress-bars
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/media
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/list-group
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/responsive-embed
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/wells
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/close
+
+// Components w/ JavaScript
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/modal
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/tooltip
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/popover
+//@import ~bootstrap-sass/assets/stylesheets/bootstrap/carousel
+
+// Utility classes
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/utilities
+@import ~bootstrap-sass/assets/stylesheets/bootstrap/responsive-utilities

data/lib/generators/katapult/basics/templates/app/webpack/assets/stylesheets/ext/bootstrap/navbar.sass

@@ -0,0 +1,83 @@
+@import ../../environment
+
+.navbar-default .navbar-nav
+  & > li > a
+    transition: background-color $transition-subtle
+    &:hover
+      background-color: lighten($brand-primary, 5%)
+
+  .navbar-logout
+    &:hover
+      background-color: $btn-danger-bg
+      color: white
+
+// Generated navbar ////////////////////////////////////////////////////////////
+// Source: http://work.smarchal.com/twbscolor/sass/0066b3035ea3ffffffffffff0
+$bgDefault: $brand-primary
+$bgHighlight: darken($brand-primary, 5%)
+$colDefault: $white
+$colHighlight: $white
+$dropDown: false
+
+.navbar-default
+  background-color: $bgDefault
+  border-color: $bgHighlight
+  .navbar-brand
+    color: $colDefault
+    &:hover, &:focus
+      color: $colHighlight
+  .navbar-text
+    color: $colDefault
+  .navbar-nav
+    > li
+      > a
+        color: $colDefault
+        &:hover, &:focus
+          color: $colHighlight
+      @if $dropDown
+        > .dropdown-menu
+          background-color: $bgDefault
+          > li
+            > a
+              color: $colDefault
+              &:hover, &:focus
+                color: $colHighlight
+                background-color: $bgHighlight
+            > .divider
+              background-color: $bgHighlight
+    @if $dropDown
+      .open .dropdown-menu > .active
+        > a, > a:hover, > a:focus
+          color: $colHighlight
+          background-color: $bgHighlight
+    > .active
+      > a, > a:hover, > a:focus
+        color: $colHighlight
+        background-color: $bgHighlight
+    > .open
+      > a, > a:hover, > a:focus
+        color: $colHighlight
+        background-color: $bgHighlight
+  .navbar-toggle
+    border-color: $bgHighlight
+    &:hover, &:focus
+      background-color: $bgHighlight
+    .icon-bar
+      background-color: $colDefault
+  .navbar-collapse,
+  .navbar-form
+    border-color: $colDefault
+  .navbar-link
+    color: $colDefault
+    &:hover
+      color: $colHighlight
+@media (max-width: 767px)
+  .navbar-default .navbar-nav .open .dropdown-menu
+    > li > a
+      color: $colDefault
+      &:hover, &:focus
+        color: $colHighlight
+    > .active
+      > a, > a:hover, > a:focus
+        color: $colHighlight
+        background-color: $bgHighlight

data/lib/generators/katapult/basics/templates/app/webpack/assets/stylesheets/theme.sass

@@ -0,0 +1,11 @@
+@import environment
+@import url('https://fonts.googleapis.com/css?family=Open+Sans:400,700&subset=latin-ext')
+
+html
+  -webkit-text-size-adjust: 100% // Prevent iOS font scaling in landscape
+
+body
+  -webkit-font-smoothing: antialiased
+  -moz-osx-font-smoothing: grayscale
+
+  padding: $space-sm 0

data/lib/generators/katapult/basics/templates/app/webpack/assets/stylesheets/unpoly.sass

@@ -0,0 +1,2 @@
+@import ~unpoly/dist/unpoly
+@import ~unpoly/dist/unpoly-bootstrap3

data/lib/generators/katapult/basics/templates/app/webpack/packs/application.js

@@ -0,0 +1,13 @@
+/* eslint no-console:0 */
+import 'babel-polyfill' // ES6 for browsers like IE
+
+import 'unpoly/dist/unpoly'
+import 'unpoly/dist/unpoly-bootstrap3'
+import 'jquery-ujs' // Rails goodies
+
+import 'assets'
+
+// Expose jQuery to developers
+import jQuery from 'jquery'
+window.$ = jQuery
+window.jQuery = jQuery

data/lib/generators/katapult/basics/templates/config/database.sample.yml

@@ -2,7 +2,7 @@ common: &common
   adapter: postgresql
   encoding: unicode
   host: localhost
-  username: root
+  username:
   password:
 
 development:

data/lib/generators/katapult/basics/templates/config/deploy.rb

@@ -1,7 +1,7 @@
 abort 'You must run this using "bundle exec ..."' unless ENV['BUNDLE_BIN_PATH'] || ENV['BUNDLE_GEMFILE']
 
 # config valid only for current version of Capistrano
-lock '3.4.0'
+lock '<%= @version %>'
 
 # Default value for :format is :pretty
 # set :format, :pretty
@@ -13,11 +13,11 @@ set :log_level, :info # %i(debug info error), default: :debug
 
 # Default value for :linked_files is []
 # set :linked_files, fetch(:linked_files, []).push('config/database.yml', 'config/secrets.yml')
-set :linked_files, %w(config/database.yml)
+set :linked_files, %w(config/database.yml config/secrets.yml)
 
 # Default value for linked_dirs is []
 # set :linked_dirs, fetch(:linked_dirs, []).push('log', 'tmp/pids', 'tmp/cache', 'tmp/sockets', 'vendor/bundle', 'public/system')
-set :linked_dirs, %w(log public/system)
+set :linked_dirs, %w(log public/system tmp/pids)
 
 # Default value for default_env is {}
 # set :default_env, { path: "/opt/ruby/bin:$PATH" }
@@ -27,7 +27,6 @@ set :keep_releases, 10
 set :ssh_options, {
   forward_agent: true
 }
-set :scm, :git
 set :repo_url, 'git@code.makandra.de:makandra/<%= app_name %>.git'
 
 # set :whenever_roles, :cron

data/lib/generators/katapult/basics/templates/config/environments/staging.rb

@@ -0,0 +1,5 @@
+require_relative 'production'
+
+Rails.application.configure do
+
+end

data/lib/generators/katapult/basics/templates/config/initializers/better_errors.rb

@@ -0,0 +1,23 @@
+# Avoid better_errors taking forever to render by ignoring variables larger than
+# 10 Kilobytes. Based on https://github.com/charliesome/better_errors/issues/334
+
+if defined?(BetterErrors) && Rails.env.development?
+  module BetterErrorsHugeInspectWarning
+
+    def inspect_value(obj)
+      inspected = obj.inspect
+      if inspected.size > 20_000
+        inspected = "Object was too large to inspect (#{inspected.size} bytes)."
+      end
+      CGI.escapeHTML(inspected)
+    rescue NoMethodError
+      "<span class='unsupported'>(object doesn't support inspect)</span>"
+    rescue Exception
+      "<span class='unsupported'>(exception was raised in inspect)</span>"
+    end
+
+  end
+
+  BetterErrors.ignored_instance_variables += [:@_request, :@_assigns, :@_controller, :@view_renderer]
+  BetterErrors::ErrorPage.prepend(BetterErrorsHugeInspectWarning)
+end

data/lib/generators/katapult/basics/templates/config/initializers/exception_notification.rb.tt

@@ -5,7 +5,7 @@ ExceptionNotification.configure do |config|
   config.add_notifier :email, {
     email_prefix: '[<%= app_name %>] ',
     exception_recipients: %w[fail@makandra.de],
-    sender_address: 'fail@makandra.de',
+    sender_address: Rails.configuration.system_email,
     sections: %w[request backtrace],
     background_sections: %w[backtrace],
   }

data/lib/generators/katapult/basics/templates/config/initializers/ext.rb

@@ -1,3 +1,3 @@
-Dir.glob(Rails.root.join('lib/ext/**/*.rb')).each do |filename|
+Dir.glob(Rails.root.join('lib/ext/**/*.rb')).sort.each do |filename|
   require filename
 end

data/lib/generators/katapult/basics/templates/config/webpack/loaders/unpoly.js

@@ -0,0 +1,4 @@
+module.exports = {
+  test: require.resolve('unpoly'),
+  use: 'imports-loader?this=>window'
+}

data/lib/generators/katapult/basics/templates/features/support/capybara_screenshot.rb

@@ -2,3 +2,10 @@ require 'capybara-screenshot/cucumber'
 
 # Keep up to the number of screenshots specified in the hash
 Capybara::Screenshot.prune_strategy = { keep: 10 }
+
+# This asset host will become a `<base>` tag in the HTML's `<head>` and allow
+# resolving test assets via the development Rails server. This makes HTML
+# screenshots prettier.
+# Note that *you won't be using development assets* but the compiled files from
+# `RAILS_ROOT/public/packs-test/`.
+Capybara.asset_host = 'http://localhost:3000/'

data/lib/generators/katapult/basics/templates/features/support/factory_bot.rb

@@ -0,0 +1 @@
+World(FactoryBot::Syntax::Methods)

data/lib/generators/katapult/basics/templates/features/support/paths.rb

@@ -14,7 +14,7 @@ module NavigationHelpers
     when /^the (page|form) for the (.*?) above$/
       action_prose, model_prose = $1, $2
       route = "#{action_prose == 'form' ? 'edit_' : ''}#{model_prose_to_route_segment(model_prose)}_path"
-      model = model_prose.classify.constantize
+      model = model_prose_to_class(model_prose)
       send(route, model.last)
 
     when /^the (page|form) for the (.*?) "(.*?)"$/
@@ -39,12 +39,17 @@ module NavigationHelpers
   private
 
   def path_to_show_or_edit(action_prose, model_prose, identifier)
-    model = model_prose.classify.constantize
+    model = model_prose_to_class(model_prose)
     route = "#{action_prose == 'form' ? 'edit_' : ''}#{model_prose_to_route_segment(model_prose)}_path"
     send(route, model.find_by_anything!(identifier))
   end
 
+  def model_prose_to_class(model_prose)
+    model_prose.gsub(' ', '_').classify.constantize
+  end
+
   def model_prose_to_route_segment(model_prose)
+    model_prose = model_prose.downcase
     model_prose.gsub(/[\ \/]/, '_')
   end
 

data/lib/generators/katapult/basics/templates/features/support/rspec_doubles.rb

@@ -0,0 +1 @@
+require 'cucumber/rspec/doubles'

data/lib/generators/katapult/basics/templates/features/support/selectors.rb

@@ -13,12 +13,12 @@ module HtmlSelectorsHelpers
     # Usage examples:
     #   the main menu -> '.main-menu'
     #   the item box's header -> '.item-box--header'
-    #   the slider's item that is current -> '.slider--item.is-current'
-    when /^the (.+?)(?:'s (.+?))?(?: that (.+))?$/
+    #   the slider's item (current) -> '.slider--item.-current'
+    when /^the (.+?)(?:'s (.+?))?(?: \((.+)\))?$/
       selector = '.'
       selector << selectorify($1)
       selector << '--' << selectorify($2) if $2
-      selector << '.' << selectorify($3) if $3
+      selector << '.-' << selectorify($3) if $3
       selector
 
     # Add more mappings here.

data/lib/generators/katapult/basics/templates/features/support/selenium.rb

@@ -0,0 +1,13 @@
+chrome_args = %w[--mute-audio --disable-infobars]
+no_password_bubble = {
+  'credentials_enable_service' => false,
+  'profile.password_manager_enabled' => false
+}
+
+Capybara.register_driver :selenium do |app|
+  Capybara::Selenium::Driver.new(app,
+    browser: :chrome,
+    args: chrome_args,
+    prefs: no_password_bubble
+  )
+end

data/lib/generators/katapult/basics/templates/features/support/webpacker.rb

@@ -0,0 +1,35 @@
+module WebpackerHelper
+
+  module_function def compile_once
+    digest_file = Rails.root.join("tmp/webpacker_#{Rails.env}_digest")
+
+    packable_contents = Dir[Webpacker.config.source_path.join('**/*')]
+      .sort
+      .map { |filename| File.read(filename) if File.file?(filename) }
+      .join
+    digest = Digest::SHA256.hexdigest(packable_contents)
+
+    return if digest_file.exist? && digest_file.read == digest
+
+    # Base process compiles
+    if ENV['TEST_ENV_NUMBER'].to_i < 1
+      output_path = Webpacker.config.public_output_path
+      FileUtils.rm_r(output_path) if File.exist?(output_path)
+      puts "Removed Webpack output directory #{output_path}"
+
+      Webpacker.compile or raise 'Compilation failed'
+
+      digest_file.write(digest)
+
+    # Parallel processes wait for compilation
+    else
+      loop do
+        break if digest_file.exist? && digest_file.read == digest
+        sleep 0.1
+      end
+    end
+  end
+
+end
+
+WebpackerHelper.compile_once

data/lib/generators/katapult/basics/templates/lib/ext/action_view/form_for_with_development_errors.rb

@@ -1,43 +1,43 @@
-if Rails.env == 'development'
-
-  ActionView::Helpers::FormHelper.class_eval do
+if Rails.env.development?
 
+  ActionView::Helpers::FormHelper.module_eval do
     def form_for_with_development_errors(*args, &block)
       form_for_without_development_errors(*args) do |form|
         html = ''.html_safe
-        if form.object && form.object.respond_to?(:errors) && form.object.errors.any?
-          html << content_tag(:div, form.object.errors.full_messages.collect { |m| h m }.join('<br />').html_safe, :class => 'development_errors', :onclick => 'this.parentNode.removeChild(this);')
-          html << '<style type="text/css"><!--'.html_safe
-          css = <<-EOF
-            .development_errors {
-              position: fixed;
-              bottom: 0;
-              right: 0;
-              z-index: 999999;
-              font-size: 11px;
-              line-height: 15px;
-              background-color: #fed;
-              border-top: 1px solid #cba;
-              border-left: 1px solid #cba;
-              color: #821;
-              padding: 10px;
-              cursor: pointer;
-              filter:alpha(opacity=80);
-              -moz-opacity:0.8;
-              -khtml-opacity: 0.8;
-              opacity: 0.8;
-
-            }
-          EOF
-          html << css.html_safe
-          html << '</style>'.html_safe
-        end
+        html << form_development_errors(form.object)
         html << capture(form, &block)
       end
     end
 
-    alias_method_chain :form_for, :development_errors
+    alias_method :form_for_without_development_errors, :form_for
+    alias_method :form_for, :form_for_with_development_errors
+
+    private
+
+    def form_development_errors(object)
+      return unless object
+      return unless object.respond_to?(:errors)
+      return unless object.errors.any?
 
+      safe_messages = object.errors.full_messages.map { |message| h(message) }.join('<br />').html_safe
+
+      styles = <<~CSS
+        position: fixed;
+        bottom: 0;
+        right: 0;
+        z-index: 999999;
+        font-size: 0.8rem;
+        background-color: #fed;
+        border-top: 1px solid #cba;
+        border-left: 1px solid #cba;
+        color: #821;
+        padding: 0.5em 1em;
+        cursor: pointer;
+        opacity: 0.8;
+      CSS
+
+      content_tag(:div, safe_messages, style: styles.squish, onclick: 'this.parentNode.removeChild(this)')
+    end
   end
 
 end

data/lib/generators/katapult/basics/templates/lib/ext/active_record/find_by_anything.rb

@@ -4,16 +4,17 @@ ActiveRecord::Base.class_eval do
     matchable_columns = columns.reject { |column| [:binary, :boolean].include?(column.type) }
     query_clauses = matchable_columns.collect do |column|
       qualified_column_name = "#{table_name}.#{column.name}"
-      column_as_string = "CAST(#{qualified_column_name} AS CHAR)"
+      is_mysql = connection.class.name =~ /mysql/i
+      target_type = is_mysql ? 'CHAR' : 'TEXT' # CHAR is only 1 character in PostgreSQL
+      column_as_string = "CAST(#{qualified_column_name} AS #{target_type})"
       "#{column_as_string} = ?"
     end
     bindings = [identifier] * query_clauses.size
     where([query_clauses.join(' OR '), *bindings]).first
   end
-  
+
   def self.find_by_anything!(identifier)
     find_by_anything(identifier) or raise ActiveRecord::RecordNotFound, "No column equals \"#{identifier}\""
   end
 
 end
-

data/lib/generators/katapult/basics/templates/public/robots.txt

@@ -0,0 +1,5 @@
+# This empty file allows all robots, see http://www.robotstxt.org/robotstxt.html
+#
+# To exclude all robots from the entire domain, uncomment this:
+# User-agent: *
+# Disallow: /

data/lib/generators/katapult/basics/templates/spec/factories/factories.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
 
   factory :EXAMPLE do
     status 'pending'

data/lib/generators/katapult/basics/templates/spec/support/database_cleaner.rb

@@ -0,0 +1,20 @@
+RSpec.configure do |config|
+  config.before(:suite) do
+    DatabaseCleaner.clean_with(:deletion)
+  end
+
+  config.around do |example|
+    DatabaseCleaner.strategy = case
+    when example.metadata[:transaction] == false
+      :deletion
+    when example.metadata[:js] == true
+      :deletion
+    else
+      :transaction
+    end
+
+    DatabaseCleaner.start
+    example.run
+    DatabaseCleaner.clean
+  end
+end

data/lib/generators/katapult/basics/templates/spec/support/factory_bot.rb

@@ -0,0 +1,3 @@
+RSpec.configure do |config|
+  config.include FactoryBot::Syntax::Methods
+end

data/lib/generators/katapult/basics/templates/spec/support/fixture_file.rb

@@ -0,0 +1,6 @@
+include ActionDispatch::TestProcess
+
+def fixture_file(file_name)
+  file_path = Rails.root.join('spec/assets', file_name)
+  File.open(file_path)
+end

data/lib/generators/katapult/basics/templates/spec/support/postgresql_sequences.rb

@@ -0,0 +1,15 @@
+# We initialize all Postgres sequences with high values so that tests setting
+# specific ids will not accidentally reuse the same ids
+
+RSpec.configure do |config|
+  config.before(:suite) do
+
+    connection = ActiveRecord::Base.connection
+    sequences = connection.select_values("SELECT relname FROM pg_class WHERE pg_class.relkind = 'S'")
+
+    sequences.each do |sequence|
+      connection.execute("SELECT setval('#{sequence}', 1000000)")
+    end
+
+  end
+end

data/lib/generators/katapult/basics/templates/spec/support/timecop.rb

@@ -0,0 +1,3 @@
+RSpec.configure do |config|
+  config.after { Timecop.return }
+end