katalyst-navigation 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e358271c4b2a255cba861c6eac1f432e906c5d56f37f703646ff1dd504e582a
-  data.tar.gz: a5c36789357921c48b42fd708f6289df7adb9c1bec7b6be1d6a39e7a608be468
+  metadata.gz: 94cc7f739764b2d65865d91d0d6f1431671bee909e285b51238f4343dd15883e
+  data.tar.gz: 51a2493050682848606784167c351865776daa9cc403e59e096e269b55afc208
 SHA512:
-  metadata.gz: 400edfaf424e0cf2edf1867e8897961b911c1c64bed4839a30fd89d3d353af5639d6b3dc4dc943f4ec1c06efd64ff1bc7f1b55516c0d1440aa02210120e6004e
-  data.tar.gz: 05c8cb35db579809acc4f68c2359ac2f11103e1f8c3255dc5a606ff12fe3e975a71738d9c760007efbd80fe505d948d49031c8cf5283edad05ac6bf58f21420e
+  metadata.gz: 51127826086e93bdc9d6796f8eab5096c0d4a1d6af14a0623f3387a6c567263b6f28351507f5bcb683cce7f88f0a5832ac7583e2a28d59b31463eeeba8b09710
+  data.tar.gz: 1b7b2e4b291da7ae044b6c5de3c5df0a0d56b5ba111d7fbf454648916baf2a8634cfbc2c94216a3f327ad5ffba51440b00ca5d052bcf0d55b070b345de2a72ea

data/app/assets/javascripts/controllers/navigation/editor/menu_controller.js

@@ -6,6 +6,9 @@ import RulesEngine from "utils/navigation/editor/rules-engine";
 
 export default class MenuController extends Controller {
   static targets = ["menu"];
+  static values = {
+    maxDepth: Number,
+  };
 
   connect() {
     this.state = this.menu.state;
@@ -85,7 +88,7 @@ export default class MenuController extends Controller {
       if (!this.updateRequested) return;
 
       this.updateRequested = false;
-      const engine = new RulesEngine();
+      const engine = new RulesEngine(this.maxDepthValue);
       this.menu.items.forEach((item) => engine.update(item));
 
       this.#notifyChange();

data/app/assets/javascripts/utils/navigation/editor/menu.js

@@ -1,4 +1,4 @@
-import Item from "./item";
+import Item from "utils/navigation/editor/item";
 
 /**
  * @param nodes {NodeList}

data/app/assets/javascripts/utils/navigation/editor/rules-engine.js

@@ -7,9 +7,12 @@ export default class RulesEngine {
     "denyRemove",
     "denyDrag",
     "denyEdit",
-    "invalidDepth",
   ];
 
+  constructor(maxDepth = null) {
+    this.maxDepth = maxDepth;
+  }
+
   /**
    * Apply rules to the given item by computing a ruleset then merging it
    * with the item's current state.
@@ -19,16 +22,21 @@ export default class RulesEngine {
   update(item) {
     this.rules = {};
 
+    // structural rules enforce a valid tree structure
     this.firstItemDepthZero(item);
     this.depthMustBeSet(item);
+    this.itemCannotHaveInvalidDepth(item);
+    this.itemCannotExceedDepthLimit(item);
+
+    // behavioural rules define what the user is allowed to do
     this.parentsCannotDeNest(item);
     this.rootsCannotDeNest(item);
     this.nestingNeedsParent(item);
+    this.nestingCannotExceedMaxDepth(item);
     this.leavesCannotCollapse(item);
     this.needHiddenItemsToExpand(item);
     this.parentsCannotBeDeleted(item);
     this.parentsCannotBeDragged(item);
-    this.itemCannotHaveInvalidDepth(item);
 
     RulesEngine.rules.forEach((rule) => {
       item.toggleRule(rule, !!this.rules[rule]);
@@ -55,6 +63,34 @@ export default class RulesEngine {
     }
   }
 
+  /**
+   * Depth must increase stepwise.
+   *
+   * @param {Item} item
+   */
+  itemCannotHaveInvalidDepth(item) {
+    const previous = item.previousItem;
+    if (previous && previous.depth < item.depth - 1) {
+      item.depth = previous.depth + 1;
+    }
+  }
+
+  /**
+   * Depth must not exceed menu's depth limit.
+   *
+   * @param {Item} item
+   */
+  itemCannotExceedDepthLimit(item) {
+    if (this.maxDepth > 0 && this.maxDepth <= item.depth) {
+      // Note: this change can cause an issue where the previous item is treated
+      // like a parent even though it no longer has children. This is because
+      // items are processed in order. This issue does not seem worth solving
+      // as it only occurs if the max depth is altered. The issue can be worked
+      // around by saving the menu.
+      item.depth = this.maxDepth - 1;
+    }
+  }
+
   /**
    * De-nesting an item would create a gap of 2 between itself and its children
    *
@@ -102,31 +138,32 @@ export default class RulesEngine {
   }
 
   /**
-   * An item can't be deleted if it has visible children.
+   * An item can't be nested (indented) if doing so would exceed the max depth.
    *
    * @param {Item} item
    */
-  parentsCannotBeDeleted(item) {
-    if (item.hasExpandedDescendants()) this.#deny("denyRemove");
+  nestingCannotExceedMaxDepth(item) {
+    if (this.maxDepth > 0 && this.maxDepth >= item.depth + 1) {
+      this.#deny("denyNest");
+    }
   }
 
   /**
-   * Items cannot be dragged if they have visible children.
+   * An item can't be deleted if it has visible children.
    *
    * @param {Item} item
    */
-  parentsCannotBeDragged(item) {
-    if (item.hasExpandedDescendants()) this.#deny("denyDrag");
+  parentsCannotBeDeleted(item) {
+    if (item.hasExpandedDescendants()) this.#deny("denyRemove");
   }
 
   /**
-   * Depth must increase stepwise.
+   * Items cannot be dragged if they have visible children.
    *
    * @param {Item} item
    */
-  itemCannotHaveInvalidDepth(item) {
-    const previous = item.previousItem;
-    if (previous && previous.depth < item.depth - 1) this.#deny("invalidDepth");
+  parentsCannotBeDragged(item) {
+    if (item.hasExpandedDescendants()) this.#deny("denyDrag");
   }
 
   /**

data/app/assets/stylesheets/katalyst/navigation/editor/_index.scss

@@ -80,7 +80,7 @@ $status-dirty-color: #aaa !default;
 
     // Dragged visuals
     &[data-dragging] {
-      border: 2px dashed;
+      box-shadow: inset 0 0 0 2px var(--icon-passive-color);
 
       > * {
         visibility: hidden;

data/app/assets/stylesheets/katalyst/navigation/editor/_item-rules.scss

@@ -16,9 +16,4 @@
     display: none !important;
     pointer-events: none;
   }
-
-  [data-invalid-depth] {
-    border-color: red;
-    background-color: indianred;
-  }
 }

data/app/controllers/concerns/katalyst/navigation/has_navigation.rb

@@ -0,0 +1,95 @@
+# frozen_string_literal: true
+
+module Katalyst
+  module Navigation
+    # Preloads navigation menus before content is rendered.
+    module HasNavigation
+      extend ActiveSupport::Concern
+
+      # Override the default navigation builder for all views rendered by this
+      # controller and any of its descendants. Accepts a subclass of
+      # Katalyst::Navigation::Frontend::Builder.
+      #
+      # For example, given a form builder:
+      #
+      #   class AdminNavBuilder < Katalyst::Navigation::Frontend::Builder
+      #     def render_item(item)
+      #     end
+      #   end
+      #
+      # The controller specifies a form builder as its default:
+      #
+      #   class AdminAreaController < ApplicationController
+      #     default_navigation_builder AdminNavBuilder
+      #   end
+      #
+      # Then in the view any form using +navigation_menu_with+ will be an instance of the
+      # specified navigation builder:
+      #
+      #   <%= navigation_menu_with(menu: @menu) %>
+      module NavigationBuilder
+        extend ActiveSupport::Concern
+
+        included do
+          class_attribute :_default_navigation_builder, instance_accessor: false
+        end
+
+        class_methods do
+          # Set the navigation builder to be used as the default for all navs
+          # in the views rendered by this controller and its subclasses.
+          #
+          # @param builder {Katalyst::Navigation::Frontend::Builder}
+          def default_navigation_builder(builder)
+            self._default_navigation_builder = builder
+          end
+        end
+
+        # Default navigation builder for the controller
+        #
+        # @return {Katalyst::Navigation::Frontend::Builder}
+        def default_navigation_builder
+          self.class._default_navigation_builder
+        end
+      end
+
+      # Provide an accessor for navigation menus
+      module NavigationHelper
+        # Retrieves the preloaded menu that matches the given slug.
+        #
+        # @return {Katalyst::Navigation::Menu} menu with the given slug
+        def navigation_menu_for(slug)
+          @navigation_menus[slug.to_s]
+        end
+
+        # @see ActionView::Helpers::ControllerHelper#assign_controller
+        def assign_controller(controller)
+          super
+
+          if controller.respond_to?(:default_navigation_builder)
+            @_default_navigation_builder = controller.default_navigation_builder
+          end
+        end
+      end
+
+      included do
+        include NavigationBuilder
+
+        helper Katalyst::Navigation::FrontendHelper
+        helper NavigationHelper
+
+        # @see ActionController::Rendering#render
+        def render(*args)
+          set_navigation_menus
+
+          super
+        end
+      end
+
+      protected
+
+      def set_navigation_menus
+        @navigation_menus = Katalyst::Navigation::Menu.includes(:published_version).index_by(&:slug)
+      end
+    end
+  end
+end

data/app/controllers/katalyst/navigation/menus_controller.rb

@@ -39,7 +39,7 @@ module Katalyst
       def update
         menu = Menu.find(params[:id])
 
-        menu.attributes = navigation_params
+        menu.attributes = menu_params
 
         unless menu.valid?
           return render :show, locals: { menu: menu }, status: :unprocessable_entity
@@ -62,20 +62,15 @@ module Katalyst
 
         menu.destroy!
 
-        redirect_to action: :index
+        redirect_to action: :index, status: :see_other
       end
 
       private
 
       def menu_params
-        params.require(:menu).permit(:title, :slug)
-      end
-
-      def navigation_params
         return {} if params[:menu].blank?
 
-        params.require(:menu)
-          .permit(:title, :slug, items_attributes: %i[id index depth])
+        params.require(:menu).permit(:title, :slug, :depth, items_attributes: %i[id index depth])
       end
     end
   end

data/app/helpers/katalyst/navigation/editor/item.rb

@@ -8,7 +8,7 @@ module Katalyst
 
         def build(item, **options, &block)
           self.item = item
-          content_tag(:div, default_options(id: dom_id(item), **options)) do
+          tag.div **default_options(id: dom_id(item), **options) do
             concat(capture { yield self }) if block
             concat fields(item)
           end

data/app/helpers/katalyst/navigation/editor/list.rb

@@ -14,7 +14,7 @@ module Katalyst
         ACTIONS
 
         def build(options, &_block)
-          content_tag :ol, default_options(id: menu_form_id, **options) do
+          tag.ol **default_options(id: menu_form_id, **options) do
             yield self
           end
         end

data/app/helpers/katalyst/navigation/editor/menu.rb

@@ -29,6 +29,10 @@ module Katalyst
           add_option(options, :data, :controller, MENU_CONTROLLER)
           add_option(options, :data, :action, ACTIONS)
 
+          depth = options.delete(:depth) || menu.depth
+
+          add_option(options, :data, :"#{MENU_CONTROLLER}-max-depth-value", depth) if depth
+
           options
         end
       end

data/app/helpers/katalyst/navigation/editor/new_item.rb

@@ -10,7 +10,7 @@ module Katalyst
 
         def build(item, **options, &block)
           capture do
-            concat(content_tag(:div, **default_options(options)) do
+            concat(tag.div(**default_options(options)) do
               concat capture(&block)
               concat item_template(item)
             end)
@@ -31,7 +31,7 @@ module Katalyst
         # events when the user initiates drag so that it can be copied into the
         # editor list on drop.
         def item_template(item)
-          content_tag(:template, data: { "#{NEW_ITEM_CONTROLLER}-target" => "template" }) do
+          tag.template data: { "#{NEW_ITEM_CONTROLLER}-target" => "template" } do
             navigation_editor_items(item: item)
           end
         end

data/app/helpers/katalyst/navigation/editor/status_bar.rb

@@ -9,7 +9,7 @@ module Katalyst
         ACTIONS
 
         def build(**options)
-          content_tag(:div, default_options(**options)) do
+          tag.div **default_options(**options) do
             concat status(:published, last_update: l(menu.updated_at, format: :short))
             concat status(:draft)
             concat status(:dirty)
@@ -24,7 +24,7 @@ module Katalyst
         end
 
         def actions
-          content_tag(:menu) do
+          tag.menu do
             concat action(:discard, class: "button button--text")
             concat action(:revert, class: "button button--text") if menu.state == :draft
             concat action(:save, class: "button button--secondary")

data/app/helpers/katalyst/navigation/frontend/builder.rb

@@ -8,15 +8,15 @@ module Katalyst
 
         delegate_missing_to :@template
 
-        def initialize(template, menu: {}, list: {}, item: {})
+        def initialize(template, list: {}, item: {}, **menu_options)
           self.template     = template
-          self.menu_options = menu
+          self.menu_options = menu_options
           self.list_options = list
           self.item_options = item
         end
 
         def render(tree)
-          content_tag(:ul, menu_options) do
+          tag.ul **menu_options do
             tree.each do |item|
               concat render_item(item)
             end
@@ -26,14 +26,14 @@ module Katalyst
         def render_item(item)
           return unless item.visible?
 
-          content_tag :li, item_options do
+          tag.li **item_options do
             concat public_send("render_#{item.model_name.param_key}", item)
             concat render_list(item.children) if item.children.any?
           end
         end
 
         def render_list(items)
-          content_tag :ul, list_options do
+          tag.ul **list_options do
             items.each do |child|
               concat render_item(child)
             end

data/app/helpers/katalyst/navigation/frontend_helper.rb

@@ -5,15 +5,19 @@ module Katalyst
     module FrontendHelper
       mattr_accessor :navigation_builder
 
+      attr_internal :default_navigation_builder
+
       # Render a navigation menu. Caches based on the published version's id.
       #
       # @param(menu: Katalyst::Navigation::Menu)
       # @return Structured HTML containing top level + nested navigation links
-      def render_navigation_menu(menu, item: {}, list: {}, **options)
+      def navigation_menu_with(menu:, **options)
+        builder = navigation_builder(**options)
+        menu    = menu.is_a?(Symbol) ? navigation_menu_for(menu) : menu
+
         return unless menu&.published_version&.present?
 
         cache menu.published_version do
-          builder = default_navigation_builder_class.new(self, menu: options, item: item, list: list)
           concat builder.render(menu.published_tree)
         end
       end
@@ -22,8 +26,9 @@ module Katalyst
       #
       # @param(items: [Katalyst::Navigation::Item])
       # @return Structured HTML containing top level + nested navigation links
-      def render_navigation_items(items, list: {}, **options)
-        builder = default_navigation_builder_class.new(self, item: options, list: list)
+      def navigation_items_with(items:, **options)
+        builder = navigation_builder(**options)
+
         capture do
           items.each do |item|
             concat builder.render_item(item)
@@ -33,8 +38,13 @@ module Katalyst
 
       private
 
+      def navigation_builder(**options)
+        builder = options.delete(:builder) || default_navigation_builder_class
+        builder.new(self, **options)
+      end
+
       def default_navigation_builder_class
-        builder = controller.try(:default_navigation_builder) || Frontend::Builder
+        builder = default_navigation_builder || Frontend::Builder
         builder.respond_to?(:constantize) ? builder.constantize : builder
       end
     end

data/app/models/katalyst/navigation/menu.rb

@@ -45,6 +45,7 @@ module Katalyst
 
       validates :title, :slug, presence: true
       validates :slug, uniqueness: true
+      validates :depth, numericality: { greater_than: 0, only_integer: true, allow_nil: true }
 
       # A menu is in draft mode if it has an unpublished draft or it has no published version.
       # @return the current state of the menu, either `published` or `draft`

data/app/views/katalyst/navigation/menus/_item.html.erb

@@ -8,7 +8,7 @@
   </div>
 
   <div class="url">
-    <%= link_to item.url || "", item.url || "" %>
+    <%= link_to item.url || "", item.url || "", data: { turbo: false } %>
   </div>
 
   <%= builder.item_actions %>

data/app/views/katalyst/navigation/menus/edit.html.erb

@@ -1,15 +1,25 @@
 <% content_for :title, "Edit navigation" %>
 
 <%= form_with model: menu do |form| %>
-  <div class="field">
+  <div class="field required">
     <%= form.label :title %>
     <%= form.text_field :title %>
   </div>
 
-  <div class="field">
+  <div class="field required">
     <%= form.label :slug %>
     <%= form.text_field :slug %>
   </div>
 
-  <%= form.submit :save %>
+  <div class="field optional">
+    <%= form.label :depth %>
+    <%= form.text_field :depth %>
+  </div>
+
+  <div class="button-row">
+    <%= form.submit :save %>
+    <%= link_to "Delete", url_for(action: :show),
+                class: "button button-secondary",
+                data: { turbo_method: :delete, turbo_confirm: "Are you sure?" } %>
+  </div>
 <% end %>

data/app/views/katalyst/navigation/menus/index.html.erb

@@ -11,7 +11,4 @@
     <%= link_to cell.value, menu %>
   <% end %>
   <%= row.cell :slug %>
-  <%= row.cell :actions do |cell| %>
-    <%= button_to "Delete", menu, method: :delete, class: "button button--text" %>
-  <% end %>
 <% end %>

data/app/views/katalyst/navigation/menus/new.html.erb

@@ -1,15 +1,20 @@
 <% content_for :title, "New navigation" %>
 
 <%= form_with model: menu do |form| %>
-  <div class="field">
+  <div class="field required">
     <%= form.label :title %>
     <%= form.text_field :title %>
   </div>
 
-  <div class="field">
+  <div class="field required">
     <%= form.label :slug %>
     <%= form.text_field :slug %>
   </div>
 
+  <div class="field optional">
+    <%= form.label :depth %>
+    <%= form.text_field :depth %>
+  </div>
+
   <%= form.submit %>
 <% end %>

data/db/migrate/20220908044500_add_depth_limit_to_menus.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+class AddDepthLimitToMenus < ActiveRecord::Migration[7.0]
+  def change
+    add_column :katalyst_navigation_menus, :depth, :integer
+  end
+end

data/lib/katalyst/navigation/version.rb

@@ -2,6 +2,6 @@
 
 module Katalyst
   module Navigation
-    VERSION = "1.0.1"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: katalyst-navigation
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Katalyst Interactive
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-09-05 00:00:00.000000000 Z
+date: 2022-09-09 00:00:00.000000000 Z
 dependencies: []
 description:
 email:
@@ -17,7 +17,6 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- CHANGELOG.md
 - LICENSE.txt
 - README.md
 - app/assets/config/katalyst-navigation.js
@@ -35,6 +34,7 @@ files:
 - app/assets/stylesheets/katalyst/navigation/editor/_item-rules.scss
 - app/assets/stylesheets/katalyst/navigation/editor/_new-items.scss
 - app/assets/stylesheets/katalyst/navigation/editor/_status-bar.scss
+- app/controllers/concerns/katalyst/navigation/has_navigation.rb
 - app/controllers/katalyst/navigation/base_controller.rb
 - app/controllers/katalyst/navigation/items_controller.rb
 - app/controllers/katalyst/navigation/menus_controller.rb
@@ -73,6 +73,7 @@ files:
 - config/routes.rb
 - db/migrate/20220826034057_create_katalyst_navigation_menus.rb
 - db/migrate/20220826034507_create_katalyst_navigation_items.rb
+- db/migrate/20220908044500_add_depth_limit_to_menus.rb
 - lib/katalyst/navigation.rb
 - lib/katalyst/navigation/engine.rb
 - lib/katalyst/navigation/version.rb
@@ -83,9 +84,6 @@ homepage: https://github.com/katalyst/navigation
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/katalyst/navigation
-  source_code_uri: https://github.com/katalyst/navigation
-  changelog_uri: https://github.com/katalyst/navigation/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: []

data/CHANGELOG.md

@@ -1,10 +0,0 @@
-## [Unreleased]
-
-## [1.0.1]
-
-- Update - Draggable "new" menu items are now styled
-- Bugfix - leading indicator would shrink on narrow screens, or on heavily indented menus
-
-## [1.0.0] - 2022-09-05
-
-- Initial release