katalyst-kpop 2.0.3 → 2.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4fea6bd4f91a8836cd4638c347bae989d987ae089e4616145c63e5fa2f04c07c
-  data.tar.gz: dbfbca078875746b8c567cc56b16a9ea9105aaf813a274e156488ae6a72cf8f4
+  metadata.gz: 132ccf15922a7201b808f5e05d0ebfa5294a80fb52fbffd9394b17620ef7e841
+  data.tar.gz: ab016bd132de1ad7e039e4eca8e0e5aeb5668442a26d08be233625b864d34754
 SHA512:
-  metadata.gz: 73bd64094326ecf8e6dc58eeeca5ad0088da4b8ae7198d26262110dcdc7d238222fea1d50949a56633d1b4dd82f3d2ca070f22921f6660753050f754b52a261f
-  data.tar.gz: 36f36cbbdedcaa7abf2dc4dda39bbcaf0af2d4586efd00d5f940ea5ad28aea5cd842808c27bc89e52e057ef6cf91b7af886663ce7b25cd48ecb6ef62647d262c
+  metadata.gz: e46ae5a99a83e236123445f6273a0d5aa44a7e7d42676ed775d2fe523629f6ba7dcde29ceec1a8c650e7ec77d1d6460fa62abdf296e342335270f79aeb2b4a4e
+  data.tar.gz: 63e704500714934863e32822335956c3896bea1670ff141ddfb32679369c4087e028077fbb487f24b9639cca30ec89099c44f76b8b4a507c9e3d77bd00332227

data/README.md

@@ -96,7 +96,7 @@ frame. The targeted action will need to generate content in a `kpop_frame_tag`,
 ```
 
 Note that, because kpop modals render in a turbo frame, if you want to navigate the parent frame you will need to use
-`target: "_top"` on your links and forms.
+`target: "_top"` on your links and forms, or add `target: "_top"` to the `kpop_frame_tag` call in your body.
 
 ## Development
 

data/app/helpers/kpop_helper.rb

@@ -13,10 +13,13 @@ module KpopHelper
   end
 
   # Render a turbo frame tag that can be targeted for rendering kpop modals.
-  def kpop_frame_tag(&block)
-    turbo_frame_tag "kpop",
-                    class: "kpop-container",
-                    data:  { controller: "kpop", action: "scrim:hide@window->kpop#dismiss" } do
+  def kpop_frame_tag(**html_attributes, &block)
+    html_attributes[:class]             ||= "kpop-container"
+    html_attributes[:data]              ||= {}
+    html_attributes[:data][:controller] = "kpop"
+    html_attributes[:data][:action]     = "scrim:hide@window->kpop#dismiss"
+
+    turbo_frame_tag("kpop", **html_attributes) do
       capture(&block) if block
     end
   end

data/lib/katalyst/kpop/version.rb

@@ -2,6 +2,6 @@
 
 module Katalyst
   module Kpop
-    VERSION = "2.0.3"
+    VERSION = "2.0.5"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: katalyst-kpop
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.5
 platform: ruby
 authors:
 - Katalyst Interactive
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-04-20 00:00:00.000000000 Z
+date: 2023-07-28 00:00:00.000000000 Z
 dependencies: []
 description:
 email:
@@ -38,7 +38,6 @@ files:
 - lib/katalyst/kpop.rb
 - lib/katalyst/kpop/engine.rb
 - lib/katalyst/kpop/version.rb
-- lib/tasks/yarn.rake
 homepage: https://github.com/katalyst/kpop
 licenses:
 - MIT

data/lib/tasks/yarn.rake

@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-namespace :yarn do
-  desc "Install npm packages with yarn"
-  task install: :environment do
-    sh "yarn install"
-  end
-
-  desc "Lint JS/SCSS files using yarn (prettier)"
-  task lint: :install do
-    sh "yarn lint"
-  end
-
-  desc "Autoformat JS/SCSS files using yarn (prettier)"
-  task format: :install do
-    sh "yarn format"
-  end
-
-  desc "Compile js/css"
-  task build: :install do
-    sh "yarn build && yarn build:css"
-  end
-end