kartograph 0.2.3 → 0.2.8

data/spec/lib/kartograph/artist_spec.rb

@@ -6,12 +6,10 @@ describe Kartograph::Artist do
 
   describe '#initialize' do
     it 'initializes with an object and a map' do
-      object     = double('object', name: 'hello')
       properties << Kartograph::Property.new(:name)
 
-      artist = Kartograph::Artist.new(object, map)
+      artist = Kartograph::Artist.new(map)
 
-      expect(artist.object).to be(object)
       expect(artist.map).to be(map)
     end
   end
@@ -21,18 +19,19 @@ describe Kartograph::Artist do
       object     = double('object', hello: 'world')
       properties << Kartograph::Property.new(:hello)
 
-      artist = Kartograph::Artist.new(object, map)
-      masterpiece = artist.draw
+      artist = Kartograph::Artist.new(map)
+      masterpiece = artist.draw(object)
 
       expect(masterpiece).to include('hello' => 'world')
     end
 
     it 'raises for a property that the object does not have' do
-      object = double('object')
+      class TestArtistNoMethod; end
+      object = TestArtistNoMethod.new
       properties << Kartograph::Property.new(:bunk)
-      artist = Kartograph::Artist.new(object, map)
+      artist = Kartograph::Artist.new(map)
 
-      expect { artist.draw }.to raise_error(ArgumentError).with_message("#{object} does not respond to bunk, so we can't map it")
+      expect { artist.draw(object) }.to raise_error(ArgumentError).with_message("#{object} does not respond to bunk, so we can't map it")
     end
 
     context 'for a property with a key set on it' do
@@ -40,8 +39,8 @@ describe Kartograph::Artist do
         object     = double('object', hello: 'world')
         properties << Kartograph::Property.new(:hello, key: :hola)
 
-        artist = Kartograph::Artist.new(object, map)
-        masterpiece = artist.draw
+        artist = Kartograph::Artist.new(map)
+        masterpiece = artist.draw(object)
 
         expect(masterpiece).to include('hola' => 'world')
       end
@@ -53,8 +52,8 @@ describe Kartograph::Artist do
         properties << Kartograph::Property.new(:hello, scopes: [:create, :read])
         properties << Kartograph::Property.new(:foo, scopes: [:create])
 
-        artist = Kartograph::Artist.new(object, map)
-        masterpiece = artist.draw(:read)
+        artist = Kartograph::Artist.new(map)
+        masterpiece = artist.draw(object, :read)
 
         expect(masterpiece).to eq('hello' => 'world')
       end
@@ -71,8 +70,8 @@ describe Kartograph::Artist do
 
           properties << root_property
 
-          artist = Kartograph::Artist.new(object, map)
-          masterpiece = artist.draw(:read)
+          artist = Kartograph::Artist.new(map)
+          masterpiece = artist.draw(object, :read)
 
           expect(masterpiece).to eq('child' => { 'foo' => child.foo })
         end
@@ -88,8 +87,8 @@ describe Kartograph::Artist do
         map.cache_key { |obj, scope| obj.cache_key }
         map.property :foo
 
-        artist = Kartograph::Artist.new(object, map)
-        masterpiece = artist.draw
+        artist = Kartograph::Artist.new(map)
+        masterpiece = artist.draw(object)
 
         expect(masterpiece).to eq(cacher.fetch)
 
@@ -104,8 +103,8 @@ describe Kartograph::Artist do
 
         map.property :foo, scopes: [:read]
 
-        artist = Kartograph::Artist.new(object, map)
-        masterpiece = artist.draw(:read)
+        artist = Kartograph::Artist.new(map)
+        masterpiece = artist.draw(object, :read)
 
         expect(called).to have_received(:call).with(object, :read)
       end

data/spec/lib/kartograph/property_spec.rb

@@ -231,5 +231,21 @@ describe Kartograph::Property do
       expect(duped.options).to_not be(instance.options)
       expect(duped.options).to eq(instance.options)
     end
+
+    context 'setting the map after duping' do
+      it 'draws a value' do
+        # NOTE: This test is a regression test introduced by caching of Artist instance.
+        dummy_class = Struct.new(:id, :name)
+        dummy = dummy_class.new
+        dummy.id = 123
+
+        instance = Kartograph::Property.new(:id, scopes: [:read])
+        duped = instance.dup
+        duped.map = Kartograph::Map.new
+        val = duped.value_for(dummy)
+
+        expect(val).to_not be_nil
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kartograph
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.8
 platform: ruby
 authors:
-- Robert Ross
+- DigitalOcean API Engineering team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-03 00:00:00.000000000 Z
+date: 2020-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,28 +30,34 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 13.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 13.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -69,9 +75,7 @@ dependencies:
 description: Kartograph makes it easy to generate and convert JSON. It's intention
   is to be used for API clients.
 email:
-- engineering@digitalocean.com
-- rross@digitalocean.com
-- ivan@digitalocean.com
+- api-engineering@digitalocean.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -96,6 +100,8 @@ files:
 - lib/kartograph/root_key.rb
 - lib/kartograph/sculptor.rb
 - lib/kartograph/version.rb
+- spec/integration/allocations_spec.rb
+- spec/integration/testdata/sample.json
 - spec/lib/kartograph/artist_spec.rb
 - spec/lib/kartograph/dsl_spec.rb
 - spec/lib/kartograph/map_spec.rb
@@ -107,7 +113,7 @@ files:
 - spec/support/dsl_contexts.rb
 - spec/support/dummy_comment.rb
 - spec/support/dummy_user.rb
-homepage: https://github.com/digitaloceancloud/kartograph
+homepage: https://github.com/digitalocean/kartograph
 licenses:
 - MIT
 metadata: {}
@@ -126,13 +132,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Kartograph makes it easy to generate and convert JSON. It's intention is
   to be used for API clients.
 test_files:
+- spec/integration/allocations_spec.rb
+- spec/integration/testdata/sample.json
 - spec/lib/kartograph/artist_spec.rb
 - spec/lib/kartograph/dsl_spec.rb
 - spec/lib/kartograph/map_spec.rb