karst 0.1.0 → 0.2.0

data/lib/karst/web/panel.rb

@@ -2,6 +2,7 @@
 
 require "cgi"
 require "rack/utils"
+require "active_support"
 require "active_support/number_helper"
 require "base64"
 require "digest"
@@ -80,13 +81,9 @@ module Karst
         .usable-principal button[type=submit]{background:#0f5132;border-color:#0f5132;color:#fff;font-weight:600}
         .usable-principal button[type=submit]:hover{background:#0a3d25}
         .usable-principal p{margin:.5rem 0 0;color:#444;font-size:.92rem}
-        .related-state{margin:.75rem 0 0;padding:.6rem .75rem;border-left:3px solid #ccc;background:#fafafa;font-size:.9rem}
-        .related-state ul{margin:.25rem 0 0;padding-left:1.1rem}
         details{border:1px solid #e2e2e2;border-radius:.4rem;padding:.6rem .8rem;margin:.75rem 0}
         details summary{cursor:pointer;font-weight:600}
         details[open]>summary{margin-bottom:.5rem}
-        .scenario{border:1px solid #ddd;border-radius:.4rem;padding:.75rem;margin:.6rem 0}
-        .scenario h4{margin:.1rem 0}
         .evidence{display:flex;gap:1rem;flex-wrap:wrap;font-size:.9rem}
         .label{font-size:.72rem;font-weight:700;text-transform:uppercase;color:#666}
         .failed,.pending{border-left:4px solid #b3261e}
@@ -97,6 +94,7 @@ module Karst
         .population-attempt.hit .name{color:#0f5132}
         .population-attempt.untried{color:#777}
         .candidate-review{font-size:.9rem;color:#444;margin:.5rem 0 0}
+        .candidate-review label{display:flex;flex-direction:row;align-items:center;font-size:.9rem;margin:.35rem 0}
         .ordinary-sample{border:1px solid #ddd;border-radius:.5rem;padding:.8rem 1rem;margin:1rem 0}
         .ordinary-sample h2{margin:0 0 .45rem}
         .ordinary-sample details{margin:.55rem 0}
@@ -123,9 +121,7 @@ module Karst
           .population-attempt.hit .name{color:#7fd8a4}
           .population-attempt.untried{color:#8a8a90}
           .usable-principal button[type=submit]{background:#2e7d52;border-color:#2e7d52;color:#0b1a12}
-          .related-state{background:#1c1d20;border-color:#3a3b3e}
           details{border-color:#2c2d31}
-          .scenario{border-color:#33343a}
           .testing-banner{background:#3a2f0d;border-color:#6b5423;color:#f0e4c0}
           .hint{color:#d8a63d}
           .failed,.pending{border-left-color:#e5534b}
@@ -149,11 +145,12 @@ module Karst
       class << self
         # rubocop:disable Metrics/ParameterLists
         def render(params: {}, access_result: nil, csrf_token: nil, browser_identity_active: false,
-                   route_lookup_limitation: nil, unapproved_candidate_count: nil,
+                   route_lookup_limitation: nil, unapproved_candidates: [], population_approval_error: nil,
                    principal_source_selection_saved: false, principal_source_selection_error: nil)
           state = { csrf_token: csrf_token, browser_identity_active: browser_identity_active,
                     route_lookup_limitation: route_lookup_limitation,
-                    unapproved_candidate_count: unapproved_candidate_count,
+                    unapproved_candidates: unapproved_candidates,
+                    population_approval_error: population_approval_error,
                     principal_source_selection_saved: principal_source_selection_saved,
                     principal_source_selection_error: principal_source_selection_error }
           [200, HEADERS.dup, [document(params, access_result, state)]]
@@ -198,9 +195,8 @@ module Karst
           fields = hidden("operation", "stop_test_as") + hidden("csrf_token", csrf_token) + hidden("path", path)
           <<~HTML
             <div class="testing-banner" role="status">
-            <p><strong>Currently testing as an assumed browser identity.</strong></p>
-            <p><small>Stopping clears to whatever identity your configured clear_browser_identity hook defines
-            (commonly signed out) -- Karst does not restore a previous session.</small></p>
+            <p><strong>Currently testing as an assumed user.</strong></p>
+            <p><small>Stopping signs this browser out; Karst does not restore your previous session.</small></p>
             <form action="/karst" method="post">#{fields}<button type="submit">Stop testing as</button></form>
             </div>
           HTML
@@ -284,8 +280,7 @@ module Karst
 
         def analyze_form(context, state)
           sources = principal_sources
-          kind = sources && any_representative?(sources) ? "representative " : ""
-          label = "Who can use this? (test #{Karst.config.access_sweep_limit} #{kind}users)"
+          label = "Who can use this? (test #{Karst.config.access_sweep_limit} users)"
           operation = "<input type=\"hidden\" name=\"operation\" value=\"access_sweep\">"
           button = "<button class=\"primary\" type=\"submit\">#{escape(label)}</button>"
           form = "<form action=\"/karst\" method=\"post\">#{context}#{operation}#{button}</form>"
@@ -297,20 +292,12 @@ module Karst
           "#{principal_source_selection_notice(state)}#{form}#{principal_source_hint(sources)}"
         end
 
-        # Only ever type-checks each configured source's evaluated records
-        # (see Access::PrincipalSampler.representative_capable?); it never
-        # queries or enumerates any of them, so this is safe to compute on
-        # every panel render.
         def principal_sources
           Identity.principal_sources
         rescue Identity::Error
           nil
         end
 
-        def any_representative?(sources)
-          sources.values.any? { |source| Access::PrincipalSampler.representative_capable?(source.evaluate) }
-        end
-
         def principal_source_hint(sources)
           return "" if sources
 
@@ -406,8 +393,8 @@ module Karst
         # Every approved population appears here, including the ones
         # deliberately not run -- "not tried" is reported honestly rather
         # than left to look like a failure. Only configured populations ever
-        # reach this list; a name merely discovered at /karst/populations is
-        # never executed automatically.
+        # reach this list; a name merely discovered after a failed analysis
+        # is never executed automatically.
         def populations_section(result, csrf_token)
           return "" if result.attempts.empty?
 
@@ -454,14 +441,6 @@ module Karst
           "could not be resolved#{detail}"
         end
 
-        def dominant_halted_callback(outcomes)
-          tally = Hash.new(0)
-          outcomes.filter_map(&:halted_callback).each { |callback| tally[callback] += 1 }
-          return nil if tally.empty?
-
-          tally.max_by { |_callback, count| count }.first
-        end
-
         def users(count)
           count == 1 ? "user" : "users"
         end
@@ -470,7 +449,7 @@ module Karst
           initial = result.initial.outcomes.size
           population = result.population_request_count
           total = initial + population
-          "<p class=\"meta\"><strong>Request accounting:</strong> #{escape(initial)} initial · " \
+          "<p class=\"meta\"><strong>Tested:</strong> #{escape(initial)} initial · " \
             "#{escape(population)} candidate population · #{escape(total)} total " \
             "#{users(total)}/requests · #{escape(total_seconds(result))}s elapsed.</p>"
         end
@@ -501,16 +480,6 @@ module Karst
           " from up to #{escape(size)} recent users"
         end
 
-        # A bounded candidate pool is reported explicitly rather than left
-        # implicit, so this never reads as "every user was searched."
-        def candidate_pool_note(result)
-          size = result.candidate_pool_size
-          return "" unless size
-
-          delimited = ActiveSupport::NumberHelper.number_to_delimited(size)
-          " · candidate pool: up to #{escape(delimited)} most recent users"
-        end
-
         def write_evidence(count)
           return "<p class=\"meta\">Database writes observed: 0</p>" if count.zero?
 
@@ -530,7 +499,7 @@ module Karst
         def usable_outcomes(outcomes, result, state)
           csrf_token = state[:csrf_token]
           body = if outcomes.empty?
-                   candidate_review(state[:unapproved_candidate_count])
+                   candidate_review(state, result)
                  else
                    usable_cards(outcomes,
                                 result, csrf_token)
@@ -544,14 +513,34 @@ module Karst
         # contextual action, shown only when the analysis found nothing
         # usable and unapproved application-defined groups actually exist on
         # a configured user source. Deliberately not a configuration
-        # workflow -- it says what Karst found and offers to show it, and
-        # names nothing it has not been approved to run.
-        def candidate_review(count)
-          return "" unless count&.positive?
+        # workflow -- it names only the candidates which may be explicitly
+        # approved in this result, and never executes them merely by rendering.
+        def candidate_review(state, result)
+          candidates = state[:unapproved_candidates]
+          return "" if candidates.empty? || !state[:csrf_token]
 
-          "<p class=\"candidate-review\">Karst found #{escape(count)} application-defined user " \
-            "#{count == 1 ? 'group' : 'groups'} that could be tried. " \
-            "<a href=\"/karst/populations\">Review candidate groups</a></p>"
+          fields = candidates.map { |candidate| candidate_checkbox(candidate) }.join
+          "<form class=\"candidate-review\" method=\"post\" action=\"/karst\">#{approval_alert(state)}" \
+            "<p>Karst found application-defined user groups in your app. " \
+            "Select only the populations Karst may try, then rerun this analysis:</p>#{fields}" \
+            "#{candidate_form_fields(state, result)}" \
+            "<button type=\"submit\">Approve selected and retry</button></form>"
+        end
+
+        def candidate_form_fields(state, result)
+          hidden("operation", "approve_populations") + hidden("csrf_token", state[:csrf_token]) +
+            hidden("path", result.path) + hidden("method", result.http_method)
+        end
+
+        def approval_alert(state)
+          error = state[:population_approval_error]
+          "<p class=\"hint\" role=\"alert\">#{escape(error)}</p>" if error
+        end
+
+        def candidate_checkbox(candidate)
+          key = [candidate.principal_source, candidate.model_name, candidate.method_name].join("::")
+          "<label><input type=\"checkbox\" name=\"population[]\" value=\"#{escape(key)}\">" \
+            "#{escape(candidate.method_name)} <small>(#{escape(candidate.model_name)})</small></label>"
         end
 
         def usable_cards(outcomes, result, csrf_token)
@@ -570,17 +559,15 @@ module Karst
         def usable_principal(outcome, result, csrf_token)
           writes = outcome.writes_observed ? " — ⚠ #{escape(outcome.write_count)} database writes observed" : ""
           action = test_as_form(outcome.principal, result.path, csrf_token)
-          evidence = resource_evidence(outcome, result)
           "<article class=\"usable-principal\"><h4><span>#{principal_label(outcome.principal)}#{writes}</span>" \
             "#{action}</h4><p>#{outcome_title(outcome, prefix: 'Observed ')} · " \
-            "#{escape(outcome.elapsed_ms)}ms</p>#{sampled_for(outcome)}#{evidence}</article>"
+            "#{escape(outcome.elapsed_ms)}ms</p>#{sampled_for(outcome)}</article>"
         end
 
-        # A compact, secondary line -- deliberately below the observed
-        # outcome and above any resource evidence, never a card of its own --
-        # so it augments a usable principal without competing with Test as,
-        # the observed outcome, or resource evidence for attention. Sampling
-        # evidence, not an authorization claim: see PrincipalSampler.
+        # A compact, secondary line below the observed outcome, never a card
+        # of its own, so it augments a usable principal without competing with
+        # Test as or the observed outcome for attention. Sampling evidence,
+        # not an authorization claim: see PrincipalSampler.
         def sampled_for(outcome)
           reasons = outcome.sampling_reasons
           return "" if reasons.nil? || reasons.empty?
@@ -588,30 +575,6 @@ module Karst
           "<p class=\"meta\">Sampled for: #{escape(reasons.join(' · '))}</p>"
         end
 
-        def resource_evidence(outcome, result)
-          evidence = Access::ResourceEvidence.for_outcome(outcome: outcome, path: result.path,
-                                                          http_method: result.http_method)
-          return "" if evidence.limitation || evidence.relationships.empty?
-
-          "<div class=\"related-state\"><strong>Related state</strong>" \
-            "#{relationship_groups(evidence.relationships)}</div>"
-        rescue StandardError
-          ""
-        end
-
-        def relationship_groups(relationships)
-          relationships.group_by { |item| [item.from_model, item.from_id] }.map do |key, items|
-            model, id = key
-            "<p><strong>#{escape(model)} ##{escape(id)}</strong></p><ul>#{relationship_rows(items)}</ul>"
-          end.join
-        end
-
-        def relationship_rows(relationships)
-          relationships.map do |item|
-            "<li>#{escape(item.column)} → #{escape(item.to_model)} ##{escape(item.to_id)}</li>"
-          end.join
-        end
-
         # -- Other observed outcomes (collapsed) ---------------------------------
 
         def observed_groups(outcomes, path, csrf_token)