karafka 2.5.1 → 2.5.3

data/lib/karafka/cli/help.rb

@@ -10,7 +10,7 @@ module Karafka
       # Print available commands
       def call
         # Find the longest command for alignment purposes
-        max_command_length = self.class.commands.map(&:name).map(&:size).max
+        max_command_length = self.class.commands.map { |command| command.name.size }.max
 
         puts 'Karafka commands:'
 

data/lib/karafka/cli/install.rb

@@ -24,6 +24,7 @@ module Karafka
         'example_consumer.rb.erb' => 'app/consumers/example_consumer.rb'
       }.freeze
 
+      # Initializes the install command
       def initialize
         super
 
@@ -52,9 +53,9 @@ module Karafka
           FileUtils.mkdir_p File.dirname(pathed_target)
 
           template = File.read(Karafka.core_root.join("templates/#{source}"))
-          render = ::ERB.new(template, trim_mode: '-').result(binding)
+          render = ERB.new(template, trim_mode: '-').result(binding)
 
-          File.open(pathed_target, 'w') { |file| file.write(render) }
+          File.write(pathed_target, render)
 
           puts "#{green('Created')} #{target}"
         end

data/lib/karafka/cli/server.rb

@@ -10,7 +10,7 @@ module Karafka
       )
 
       # Types of things we can include / exclude from the routing via the CLI options
-      SUPPORTED_TYPES = ::Karafka::Routing::ActivityManager::SUPPORTED_TYPES
+      SUPPORTED_TYPES = Karafka::Routing::ActivityManager::SUPPORTED_TYPES
 
       private_constant :SUPPORTED_TYPES
 

data/lib/karafka/cli/swarm.rb

@@ -13,7 +13,7 @@ module Karafka
 
       # Starts the swarm
       def call
-        ::Karafka::Swarm.ensure_supported!
+        Karafka::Swarm.ensure_supported!
 
         # Print our banner and info in the dev mode
         print_marketing_info if Karafka::App.env.development?

data/lib/karafka/cli/topics/align.rb

@@ -95,7 +95,7 @@ module Karafka
               names = config.synonyms.map(&:name) << config.name
 
               # We move forward only if given topic config is for altering
-              next if (desired_configs.keys & names).empty?
+              next unless desired_configs.keys.intersect?(names)
 
               desired_config = nil
 

data/lib/karafka/cli/topics/repartition.rb

@@ -10,9 +10,9 @@ module Karafka
         def call
           any_repartitioned = false
 
-          existing_partitions = existing_topics.map do |topic|
+          existing_partitions = existing_topics.to_h do |topic|
             [topic.fetch(:topic_name), topic.fetch(:partition_count)]
-          end.to_h
+          end
 
           declaratives_routing_topics.each do |topic|
             name = topic.name

data/lib/karafka/connection/client.rb

@@ -8,7 +8,7 @@ module Karafka
     # It is threadsafe and provides some security measures so we won't end up operating on a
     # closed consumer instance as it causes Ruby VM process to crash.
     class Client
-      include ::Karafka::Core::Helpers::Time
+      include Karafka::Core::Helpers::Time
       include Helpers::ConfigImporter.new(
         logger: %i[logger],
         tick_interval: %i[internal tick_interval],
@@ -37,7 +37,7 @@ module Karafka
       COOP_UNSUBSCRIBE_FACTOR = 0.5
 
       # Errors upon which we early report that something is off without retrying prior to the
-      # report
+      # report. Aside from those we ALWAYS early report on any fatal error.
       EARLY_REPORT_ERRORS = [
         :inconsistent_group_protocol, # 23
         :max_poll_exceeded, # -147
@@ -48,10 +48,9 @@ module Karafka
         :cluster_authorization_failed, # 31
         :illegal_generation,
         # this will not recover as fencing is permanent
-        :fenced, # -144
         :auto_offset_reset, # -140
-        # This can happen for many reasons, including issues with static membership being fenced
-        :fatal # -150
+        # This can happen with new rebalance protocol and same group.instance.id in use
+        :unreleased_instance_id # 111
       ].freeze
 
       private_constant :MAX_POLL_RETRIES, :COOP_UNSUBSCRIBE_FACTOR, :EARLY_REPORT_ERRORS
@@ -407,6 +406,14 @@ module Karafka
       #   2ms when no callbacks are triggered.
       def events_poll(timeout = 0)
         kafka.events_poll(timeout)
+
+        # Emit event for monitoring - happens once per tick_interval (default 5s)
+        # Listeners can check assignment_lost?, track polling health, etc.
+        Karafka.monitor.instrument(
+          'client.events_poll',
+          caller: self,
+          subscription_group: @subscription_group
+        )
       end
 
       # Returns pointer to the consumer group metadata. It is used only in the context of
@@ -479,7 +486,7 @@ module Karafka
         # If the seek message offset is in a time format, we need to find the closest "real"
         # offset matching before we seek
         if message.offset.is_a?(Time)
-          tpl = ::Rdkafka::Consumer::TopicPartitionList.new
+          tpl = Rdkafka::Consumer::TopicPartitionList.new
           tpl.add_topic_and_partitions_with_offsets(
             message.topic,
             message.partition => message.offset
@@ -536,9 +543,9 @@ module Karafka
         sg_id = @subscription_group.id
 
         # Remove callbacks runners that were registered
-        ::Karafka::Core::Instrumentation.statistics_callbacks.delete(sg_id)
-        ::Karafka::Core::Instrumentation.error_callbacks.delete(sg_id)
-        ::Karafka::Core::Instrumentation.oauthbearer_token_refresh_callbacks.delete(sg_id)
+        Karafka::Core::Instrumentation.statistics_callbacks.delete(sg_id)
+        Karafka::Core::Instrumentation.error_callbacks.delete(sg_id)
+        Karafka::Core::Instrumentation.oauthbearer_token_refresh_callbacks.delete(sg_id)
 
         kafka.close
         @kafka = nil
@@ -554,7 +561,7 @@ module Karafka
       #   ignored. We do however want to instrument on it
       def unsubscribe
         kafka.unsubscribe
-      rescue ::Rdkafka::RdkafkaError => e
+      rescue Rdkafka::RdkafkaError => e
         Karafka.monitor.instrument(
           'error.occurred',
           caller: self,
@@ -583,8 +590,8 @@ module Karafka
       #   established. It may be `-1` in case we lost the assignment or we did not yet fetch data
       #   for this topic partition
       def topic_partition_position(topic, partition)
-        rd_partition = ::Rdkafka::Consumer::Partition.new(partition, nil, 0)
-        tpl = ::Rdkafka::Consumer::TopicPartitionList.new(topic => [rd_partition])
+        rd_partition = Rdkafka::Consumer::Partition.new(partition, nil, 0)
+        tpl = Rdkafka::Consumer::TopicPartitionList.new(topic => [rd_partition])
 
         kafka.position(tpl).to_h.fetch(topic).first.offset || -1
       end
@@ -612,7 +619,7 @@ module Karafka
         # We should not run a single poll longer than the tick frequency. Otherwise during a single
         # `#batch_poll` we would not be able to run `#events_poll` often enough effectively
         # blocking events from being handled.
-        poll_tick = timeout > tick_interval ? tick_interval : timeout
+        poll_tick = [timeout, tick_interval].min
 
         result = kafka.poll(poll_tick)
 
@@ -635,7 +642,7 @@ module Karafka
         # If we did not exceed total time allocated, it means that we finished because of the
         # tick interval time limitations and not because time run out without any data
         time_poll.exceeded? ? nil : :tick_time
-      rescue ::Rdkafka::RdkafkaError => e
+      rescue Rdkafka::RdkafkaError => e
         early_report = false
 
         retryable = time_poll.attempts <= MAX_POLL_RETRIES && time_poll.retryable?
@@ -645,6 +652,7 @@ module Karafka
         # Those are mainly network issues and exceeding the max poll interval
         # We want to report early on max poll interval exceeding because it may mean that the
         # underlying processing is taking too much time and it is not LRJ
+
         case e.code
         when *EARLY_REPORT_ERRORS
           early_report = true
@@ -668,6 +676,9 @@ module Karafka
           return e.details
         end
 
+        # Any fatal error should always cause early report
+        early_report = true if e.fatal?
+
         if early_report || !retryable
           Karafka.monitor.instrument(
             'error.occurred',
@@ -694,7 +705,7 @@ module Karafka
       # Builds a new rdkafka consumer instance based on the subscription group configuration
       # @return [Rdkafka::Consumer]
       def build_consumer
-        ::Rdkafka::Config.logger = logger
+        Rdkafka::Config.logger = logger
 
         # We need to refresh the setup of this subscription group in case we started running in a
         # swarm. The initial configuration for validation comes from the parent node, but it needs
@@ -702,7 +713,7 @@ module Karafka
         # group instance id.
         @subscription_group.refresh
 
-        config = ::Rdkafka::Config.new(@subscription_group.kafka)
+        config = Rdkafka::Config.new(@subscription_group.kafka)
         config.consumer_rebalance_listener = @rebalance_callback
         # We want to manage the events queue independently from the messages queue. Thanks to that
         # we can ensure, that we get statistics and errors often enough even when not polling
@@ -714,7 +725,7 @@ module Karafka
         @name = consumer.name
 
         # Register statistics runner for this particular type of callbacks
-        ::Karafka::Core::Instrumentation.statistics_callbacks.add(
+        Karafka::Core::Instrumentation.statistics_callbacks.add(
           @subscription_group.id,
           Instrumentation::Callbacks::Statistics.new(
             @subscription_group.id,
@@ -724,7 +735,7 @@ module Karafka
         )
 
         # Register error tracking callback
-        ::Karafka::Core::Instrumentation.error_callbacks.add(
+        Karafka::Core::Instrumentation.error_callbacks.add(
           @subscription_group.id,
           Instrumentation::Callbacks::Error.new(
             @subscription_group.id,
@@ -733,7 +744,7 @@ module Karafka
           )
         )
 
-        ::Karafka::Core::Instrumentation.oauthbearer_token_refresh_callbacks.add(
+        Karafka::Core::Instrumentation.oauthbearer_token_refresh_callbacks.add(
           @subscription_group.id,
           Instrumentation::Callbacks::OauthbearerTokenRefresh.new(
             consumer

data/lib/karafka/connection/listeners_batch.rb

@@ -25,9 +25,8 @@ module Karafka
       end
 
       # Iterates over available listeners and yields each listener
-      # @param block [Proc] block we want to run
-      def each(&block)
-        @batch.each(&block)
+      def each(&)
+        @batch.each(&)
       end
 
       # @return [Array<Listener>] active listeners

data/lib/karafka/connection/manager.rb

@@ -8,6 +8,7 @@ module Karafka
     # In the OSS version it starts listeners as they are without any connection management or
     # resources utilization supervision and shuts them down or quiets  when time has come
     class Manager
+      # Initializes the connection manager
       def initialize
         @once_executions = Set.new
       end

data/lib/karafka/connection/proxy.rb

@@ -10,6 +10,10 @@ module Karafka
     # do still want to be able to alter some functionalities. This wrapper helps us do it when
     # it would be needed
     class Proxy < SimpleDelegator
+      include Helpers::ConfigImporter.new(
+        proxy_config: %i[internal connection proxy]
+      )
+
       # Errors on which we want to retry
       # Includes temporary errors related to node not being (or not yet being) coordinator or a
       # leader to a given set of partitions. Usually goes away after a retry
@@ -21,6 +25,7 @@ module Karafka
         not_coordinator
         not_leader_for_partition
         coordinator_load_in_progress
+        stale_member_epoch
       ].freeze
 
       private_constant :RETRYABLE_DEFAULT_ERRORS
@@ -36,7 +41,6 @@ module Karafka
         # wrap an already wrapped object with another proxy level. Simplifies passing consumers
         # and makes it safe to wrap without type checking
         @wrapped = obj.is_a?(self.class) ? obj.wrapped : obj
-        @config = ::Karafka::App.config.internal.connection.proxy
       end
 
       # Proxies the `#query_watermark_offsets` with extra recovery from timeout problems.
@@ -47,7 +51,7 @@ module Karafka
       # @param partition [Integer] partition number
       # @return [Array<Integer, Integer>] watermark offsets
       def query_watermark_offsets(topic, partition)
-        l_config = @config.query_watermark_offsets
+        l_config = proxy_config.query_watermark_offsets
 
         # For newly created topics or in cases where we're trying to get them but there is no
         # leader, this can fail. It happens more often for new topics under KRaft, however we
@@ -67,7 +71,7 @@ module Karafka
       # @param tpl [Rdkafka::Consumer::TopicPartitionList] tpl to get time offsets
       # @return [Rdkafka::Consumer::TopicPartitionList] tpl with time offsets
       def offsets_for_times(tpl)
-        l_config = @config.offsets_for_times
+        l_config = proxy_config.offsets_for_times
 
         with_broker_errors_retry(
           # required to be in seconds, not ms
@@ -84,7 +88,7 @@ module Karafka
       #   assignment tpl usage
       # @return [Rdkafka::Consumer::TopicPartitionList] tpl with committed offsets and metadata
       def committed(tpl = nil)
-        c_config = @config.committed
+        c_config = proxy_config.committed
 
         with_broker_errors_retry(
           # required to be in seconds, not ms
@@ -121,7 +125,7 @@ module Karafka
       #   even when no stored, because with sync commit, it refreshes the ownership state of the
       #   consumer in a sync way.
       def commit_offsets(tpl = nil, async: true)
-        c_config = @config.commit
+        c_config = proxy_config.commit
 
         with_broker_errors_retry(
           wait_time: c_config.wait_time / 1_000.to_f,
@@ -151,9 +155,9 @@ module Karafka
 
       # @param tpl [Rdkafka::Consumer::TopicPartitionList] list of topics and partitions for which
       #   we want to get the lag on the defined CG
-      # @return [Hash<String, Hash>] hash with topics and their partitions lags
+      # @return [Hash{String => Hash}] hash with topics and their partitions lags
       def lag(tpl)
-        l_config = @config.committed
+        l_config = proxy_config.committed
 
         with_broker_errors_retry(
           # required to be in seconds, not ms
@@ -168,7 +172,7 @@ module Karafka
       #   get info on all topics
       # @return [Rdkafka::Metadata] rdkafka metadata object with the requested details
       def metadata(topic_name = nil)
-        m_config = @config.metadata
+        m_config = proxy_config.metadata
 
         with_broker_errors_retry(
           # required to be in seconds, not ms

data/lib/karafka/connection/rebalance_manager.rb

@@ -43,7 +43,7 @@ module Karafka
         @buffer = buffer
 
         # Connects itself to the instrumentation pipeline so rebalances can be tracked
-        ::Karafka.monitor.subscribe(self)
+        Karafka.monitor.subscribe(self)
       end
 
       # Resets the rebalance manager state

data/lib/karafka/connection/status.rb

@@ -46,6 +46,7 @@ module Karafka
         RUBY
       end
 
+      # Initializes the connection status and sets it to pending
       def initialize
         @mutex = Mutex.new
         pending!

data/lib/karafka/constraints.rb

@@ -42,7 +42,7 @@ module Karafka
       # @param string [String]
       # @return [::Gem::Version]
       def version(string)
-        ::Gem::Version.new(string)
+        Gem::Version.new(string)
       end
     end
   end

data/lib/karafka/contracts/base.rb

@@ -3,7 +3,7 @@
 module Karafka
   module Contracts
     # Base contract for all Karafka contracts
-    class Base < ::Karafka::Core::Contractable::Contract
+    class Base < Karafka::Core::Contractable::Contract
       # @param data [Hash] data for validation
       # @param scope [Array<String>] nested scope if in use
       # @return [Boolean] true if all good

data/lib/karafka/deserializers/payload.rb

@@ -9,7 +9,7 @@ module Karafka
       # @return [Hash] hash with deserialized JSON data
       def call(message)
         # nil payload can be present for example for tombstone messages
-        message.raw_payload.nil? ? nil : ::JSON.parse(message.raw_payload)
+        message.raw_payload.nil? ? nil : JSON.parse(message.raw_payload)
       end
     end
   end

data/lib/karafka/env.rb

@@ -21,8 +21,7 @@ module Karafka
       super('')
 
       LOOKUP_ENV_KEYS
-        .map { |key| ENV[key] }
-        .compact
+        .filter_map { |key| ENV.fetch(key, nil) }
         .first
         .then { |env| env || DEFAULT_ENV }
         .then { |env| replace(env) }

data/lib/karafka/helpers/async.rb

@@ -20,7 +20,7 @@ module Karafka
         #
         # @param base [Class] class we're including this module in
         def included(base)
-          base.extend ::Forwardable
+          base.extend Forwardable
 
           base.def_delegators :@thread, :join, :terminate, :name
         end

data/lib/karafka/helpers/config_importer.rb

@@ -5,7 +5,7 @@ module Karafka
     # Module allowing for configuration injections. By default injects whole app config
     # Allows for granular config injection
     class ConfigImporter < Module
-      # @param attributes [Hash<Symbol, Array<Symbol>>] map defining what we want to inject.
+      # @param attributes [Hash{Symbol => Array<Symbol>}] map defining what we want to inject.
       #   The key is the name under which attribute will be visible and the value is the full
       #   path to the attribute
       def initialize(attributes = { config: %i[itself] })
@@ -20,7 +20,7 @@ module Karafka
         @attributes.each do |name, path|
           model.class_eval <<~RUBY, __FILE__, __LINE__ + 1
             def #{name}
-              @#{name} ||= ::Karafka::App.config.#{path.join('.')}
+              @#{name} ||= Karafka::App.config.#{path.join('.')}
             end
           RUBY
         end
@@ -33,7 +33,7 @@ module Karafka
         @attributes.each do |name, path|
           model.class_eval <<~RUBY, __FILE__, __LINE__ + 1
             def self.#{name}
-              @#{name} ||= ::Karafka::App.config.#{path.join('.')}
+              @#{name} ||= Karafka::App.config.#{path.join('.')}
             end
           RUBY
         end

data/lib/karafka/helpers/interval_runner.rb

@@ -11,11 +11,14 @@ module Karafka
     # or other places but would only slow things down if would run with each tick.
     class IntervalRunner
       include Karafka::Core::Helpers::Time
+      include Helpers::ConfigImporter.new(
+        tick_interval: %i[internal tick_interval]
+      )
 
       # @param interval [Integer] interval in ms for running the provided code. Defaults to the
       #   `internal.tick_interval` value
       # @param block [Proc] block of code we want to run once in a while
-      def initialize(interval: ::Karafka::App.config.internal.tick_interval, &block)
+      def initialize(interval: tick_interval, &block)
         @block = block
         @interval = interval
         @last_called_at = monotonic_now - @interval

data/lib/karafka/helpers/multi_delegator.rb

@@ -25,6 +25,9 @@ module Karafka
           self
         end
 
+        # Creates an alias `to` for the `new` method to enable nice chaining API
+        # @return [MultiDelegator] new instance of the multi delegator
+        # @see #delegate
         alias to new
       end
     end

data/lib/karafka/instrumentation/assignments_tracker.rb

@@ -14,6 +14,7 @@ module Karafka
     class AssignmentsTracker
       include Singleton
 
+      # Initializes the assignments tracker with empty assignments
       def initialize
         @mutex = Mutex.new
         @assignments = Hash.new { |hash, key| hash[key] = [] }
@@ -21,7 +22,7 @@ module Karafka
 
       # Returns all the active/current assignments of this given process
       #
-      # @return [Hash<Karafka::Routing::Topic, Array<Integer>>]
+      # @return [Hash{Karafka::Routing::Topic => Array<Integer>}]
       #
       # @note Keep in mind, that those assignments can change any time, especially when working
       #   with multiple consumer groups or subscription groups.
@@ -79,6 +80,23 @@ module Karafka
         end
       end
 
+      # Handles events_poll notification to detect assignment loss
+      # This is called regularly (every tick_interval) so we check if assignment was lost
+      #
+      # @param event [Karafka::Core::Monitoring::Event]
+      # @note We can run the `#assignment_lost?` on each events poll because they happen once every
+      #   5 seconds during processing plus prior to each messages poll. It takes
+      #   0.6 microseconds per call.
+      def on_client_events_poll(event)
+        client = event[:caller]
+
+        # Only clear assignments if they were actually lost
+        return unless client.assignment_lost?
+
+        # Cleaning happens the same way as with the consumer reset
+        on_client_reset(event)
+      end
+
       # Removes partitions from the current assignments hash
       #
       # @param event [Karafka::Core::Monitoring::Event]

data/lib/karafka/instrumentation/callbacks/error.rb

@@ -10,8 +10,8 @@ module Karafka
           monitor: %i[monitor]
         )
 
-        # @param subscription_group_id [String] id of the current subscription group instance
-        # @param consumer_group_id [String] id of the current consumer group
+        # @param subscription_group_id [String]
+        # @param consumer_group_id [String]
         # @param client_name [String] rdkafka client name
         def initialize(subscription_group_id, consumer_group_id, client_name)
           @subscription_group_id = subscription_group_id

data/lib/karafka/instrumentation/callbacks/statistics.rb

@@ -11,14 +11,14 @@ module Karafka
           monitor: %i[monitor]
         )
 
-        # @param subscription_group_id [String] id of the current subscription group
-        # @param consumer_group_id [String] id of the current consumer group
+        # @param subscription_group_id [String]
+        # @param consumer_group_id [String]
         # @param client_name [String] rdkafka client name
         def initialize(subscription_group_id, consumer_group_id, client_name)
           @subscription_group_id = subscription_group_id
           @consumer_group_id = consumer_group_id
           @client_name = client_name
-          @statistics_decorator = ::Karafka::Core::Monitoring::StatisticsDecorator.new
+          @statistics_decorator = Karafka::Core::Monitoring::StatisticsDecorator.new
         end
 
         # Emits decorated statistics to the monitor

data/lib/karafka/instrumentation/logger.rb

@@ -3,15 +3,15 @@
 module Karafka
   module Instrumentation
     # Default logger for Event Delegator
-    # @note It uses ::Logger features - providing basic logging
+    # @note It uses Logger features - providing basic logging
     class Logger < ::Logger
       # Map containing information about log level for given environment
       ENV_MAP = {
-        'production' => ::Logger::ERROR,
-        'test' => ::Logger::ERROR,
-        'development' => ::Logger::INFO,
-        'debug' => ::Logger::DEBUG,
-        'default' => ::Logger::INFO
+        'production' => Logger::ERROR,
+        'test' => Logger::ERROR,
+        'development' => Logger::INFO,
+        'debug' => Logger::DEBUG,
+        'default' => Logger::INFO
       }.freeze
 
       private_constant :ENV_MAP

data/lib/karafka/instrumentation/monitor.rb

@@ -5,17 +5,17 @@ module Karafka
     # Karafka instrumentation monitor that we use to publish events
     # By default uses our internal notifications bus but can be used with
     # `ActiveSupport::Notifications` as well
-    class Monitor < ::Karafka::Core::Monitoring::Monitor
+    class Monitor < Karafka::Core::Monitoring::Monitor
       attr_reader :notifications_bus
 
       # @param notifications_bus [Object] either our internal notifications bus or
       #   `ActiveSupport::Notifications`
       # @param namespace [String, nil] namespace for events or nil if no namespace
       def initialize(
-        notifications_bus = ::Karafka::Instrumentation::Notifications.new,
+        notifications_bus = Karafka::Instrumentation::Notifications.new,
         namespace = nil
       )
-        super(notifications_bus, namespace)
+        super
       end
     end
   end

data/lib/karafka/instrumentation/notifications.rb

@@ -34,6 +34,7 @@ module Karafka
         client.pause
         client.resume
         client.reset
+        client.events_poll
 
         connection.listener.before_fetch_loop
         connection.listener.fetch_loop

data/lib/karafka/instrumentation/vendors/appsignal/base.rb

@@ -9,7 +9,7 @@ module Karafka
       module Appsignal
         # Base for all the instrumentation listeners
         class Base
-          include ::Karafka::Core::Configurable
+          include Karafka::Core::Configurable
           extend Forwardable
 
           # @param block [Proc] configuration block
@@ -18,10 +18,9 @@ module Karafka
             setup(&block) if block
           end
 
-          # @param block [Proc] configuration block
           # @note We define this alias to be consistent with `Karafka#setup`
-          def setup(&block)
-            configure(&block)
+          def setup(&)
+            configure(&)
           end
         end
       end

data/lib/karafka/instrumentation/vendors/datadog/logger_listener.rb

@@ -9,7 +9,7 @@ module Karafka
         # A karafka's logger listener for Datadog
         # It depends on the 'ddtrace' gem
         class LoggerListener
-          include ::Karafka::Core::Configurable
+          include Karafka::Core::Configurable
           extend Forwardable
 
           def_delegators :config, :client, :service_name
@@ -38,10 +38,9 @@ module Karafka
             @job_types_cache = {}
           end
 
-          # @param block [Proc] configuration block
           # @note We define this alias to be consistent with `WaterDrop#setup`
-          def setup(&block)
-            configure(&block)
+          def setup(&)
+            configure(&)
           end
 
           # Prints info about the fact that a given job has started