karafka 2.0.22 → 2.0.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a096a44a1a2988ff394215b8d63f6f2e33b2a3e5100f68f75fcf33eeda4b490
-  data.tar.gz: 2af0875b550f37ef9ea47b2a3011a3ed3e535adc3f6632ab10510d91bc69590c
+  metadata.gz: 84d8130c528081b283889f9f1ebe89b8829b800a2c5d1f4ca99f6d6ce9b4c9df
+  data.tar.gz: 3cc30f65586226bcb6d8ed4fdac912a72c1a4a7eb5691862b378629d9de1347f
 SHA512:
-  metadata.gz: a81cf3305482e0e925f3a5aa48d978585766826e0990081d74f5f56bc535ae0a8a6be3a4ec986e6a7702d70d0d207ca9acc71b7aeb3909557b44518413ff9bc6
-  data.tar.gz: 6c66140b258135367a120a5dac4eb8a08f4dc94e24fb3a714b32ec6ad909bc9f85bf5e160aefe5f5d307c9d554c6ecab61cbdebf315ce6953476303e9783122c
+  metadata.gz: 8e1f3fc0a3c73035fdb38093eb0594c999d0a715752f41ed95079b1d8f2e89a5a0fa0abdf054272891e89ffa4dd8d010dd2225540d4480067d8bc0359bf2b7b8
+  data.tar.gz: 7c1f3f958ef52682e46efb11e8a3ddcbe641ba85c62956fefb84ec6eacadbe9d28ee509bdfd61fcd73ea8f52b1ab867de4909990503024cc5c603788931264ca

data/.ruby-version

@@ -1 +1 @@
-3.1.2
+3.1.3

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Karafka framework changelog
 
+## 2.0.23 (2022-12-07)
+- [Maintenance] Align with `waterdrop` and `karafka-core`
+- [Improvement] Provide `Admin#read_topic` API to get topic data without subscribing.
+- [Improvement] Upon an end user `#pause`, do not commit the offset in automatic offset management mode. This will prevent from a scenario where pause is needed but during it a rebalance occurs and a different assigned process starts not from the pause location but from the automatic offset that may be different. This still allows for using the `#mark_as_consumed`.
+- [Fix] Fix a scenario where manual `#pause` would be overwritten by a resume initiated by the strategy.
+- [Fix] Fix a scenario where manual `#pause` in LRJ would cause infinite pause.
+
 ## 2.0.22 (2022-12-02)
 - [Improvement] Load Pro components upon Karafka require so they can be altered prior to setup.
 - [Improvement] Do not run LRJ jobs that were added to the jobs queue but were revoked meanwhile.

data/Gemfile.lock

@@ -1,11 +1,10 @@
 PATH
   remote: .
   specs:
-    karafka (2.0.22)
-      karafka-core (>= 2.0.4, < 3.0.0)
-      rdkafka (>= 0.12)
+    karafka (2.0.23)
+      karafka-core (>= 2.0.6, < 3.0.0)
       thor (>= 0.20)
-      waterdrop (>= 2.4.1, < 3.0.0)
+      waterdrop (>= 2.4.3, < 3.0.0)
       zeitwerk (~> 2.3)
 
 GEM
@@ -30,8 +29,9 @@ GEM
       activesupport (>= 5.0)
     i18n (1.12.0)
       concurrent-ruby (~> 1.0)
-    karafka-core (2.0.4)
+    karafka-core (2.0.6)
       concurrent-ruby (>= 1.1)
+      rdkafka (>= 0.12)
     mini_portile2 (2.8.0)
     minitest (5.16.3)
     rake (13.0.6)
@@ -61,9 +61,8 @@ GEM
     thor (1.2.1)
     tzinfo (2.0.5)
       concurrent-ruby (~> 1.0)
-    waterdrop (2.4.2)
-      karafka-core (>= 2.0.2, < 3.0.0)
-      rdkafka (>= 0.10)
+    waterdrop (2.4.3)
+      karafka-core (>= 2.0.6, < 3.0.0)
       zeitwerk (~> 2.3)
     zeitwerk (2.6.6)
 

data/karafka.gemspec

@@ -21,10 +21,9 @@ Gem::Specification.new do |spec|
     without having to focus on things that are not your business domain.
   DESC
 
-  spec.add_dependency 'karafka-core', '>= 2.0.4', '< 3.0.0'
-  spec.add_dependency 'rdkafka', '>= 0.12'
+  spec.add_dependency 'karafka-core', '>= 2.0.6', '< 3.0.0'
   spec.add_dependency 'thor', '>= 0.20'
-  spec.add_dependency 'waterdrop', '>= 2.4.1', '< 3.0.0'
+  spec.add_dependency 'waterdrop', '>= 2.4.3', '< 3.0.0'
   spec.add_dependency 'zeitwerk', '~> 2.3'
 
   spec.required_ruby_version = '>= 2.7.0'

data/lib/karafka/admin.rb

@@ -9,7 +9,70 @@ module Karafka
   # @note It always uses the primary defined cluster and does not support multi-cluster work.
   #   If you need this, just replace the cluster info for the time you use this
   module Admin
+    # A fake admin topic representation that we use for messages fetched using this API
+    # We cannot use the topics directly because we may want to request data from topics that we
+    # do not have in the routing
+    Topic = Struct.new(:name, :deserializer)
+
+    # Defaults for config
+    CONFIG_DEFAULTS = {
+      'group.id': 'karafka_admin',
+      # We want to know when there is no more data not to end up with an endless loop
+      'enable.partition.eof': true,
+      'statistics.interval.ms': 0
+    }.freeze
+
+    private_constant :Topic, :CONFIG_DEFAULTS
+
     class << self
+      # Allows us to read messages from the topic
+      #
+      # @param name [String, Symbol] topic name
+      # @param partition [Integer] partition
+      # @param count [Integer] how many messages we want to get at most
+      # @param offset [Integer] offset from which we should start. If -1 is provided (default) we
+      #   will start from the latest offset
+      #
+      # @return [Array<Karafka::Messages::Message>] array with messages
+      def read_topic(name, partition, count, offset = -1)
+        messages = []
+        tpl = Rdkafka::Consumer::TopicPartitionList.new
+
+        with_consumer do |consumer|
+          if offset.negative?
+            offsets = consumer.query_watermark_offsets(name, partition)
+            offset = offsets.last - count
+          end
+
+          offset = offset.negative? ? 0 : offset
+
+          tpl.add_topic_and_partitions_with_offsets(name, partition => offset)
+          consumer.assign(tpl)
+
+          # We should poll as long as we don't have all the messages that we need or as long as
+          # we do not read all the messages from the topic
+          loop do
+            break if messages.size >= count
+
+            message = consumer.poll(200)
+            messages << message if message
+          rescue Rdkafka::RdkafkaError => e
+            # End of partition
+            break if e.code == :partition_eof
+
+            raise e
+          end
+        end
+
+        messages.map do |message|
+          Messages::Builders::Message.call(
+            message,
+            Topic.new(name, Karafka::App.config.deserializer),
+            Time.now
+          )
+        end
+      end
+
       # Creates Kafka topic with given settings
       #
       # @param name [String] topic name
@@ -52,15 +115,32 @@ module Karafka
 
       # Creates admin instance and yields it. After usage it closes the admin instance
       def with_admin
-        # Admin needs a producer config
-        config = Karafka::Setup::AttributesMap.producer(Karafka::App.config.kafka.dup)
-
-        admin = ::Rdkafka::Config.new(config).admin
+        admin = config(:producer).admin
         result = yield(admin)
         result
       ensure
         admin&.close
       end
+
+      # Creates consumer instance and yields it. After usage it closes the consumer instance
+      def with_consumer
+        consumer = config(:consumer).consumer
+        result = yield(consumer)
+        result
+      ensure
+        consumer&.close
+      end
+
+      # @param type [Symbol] type of config we want
+      # @return [::Rdkafka::Config] rdkafka config
+      def config(type)
+        config_hash = Karafka::Setup::AttributesMap.public_send(
+          type,
+          Karafka::App.config.kafka.dup.merge(CONFIG_DEFAULTS)
+        )
+
+        ::Rdkafka::Config.new(config_hash)
+      end
     end
   end
 end

data/lib/karafka/base_consumer.rb

@@ -190,7 +190,10 @@ module Karafka
     # @param offset [Integer] offset from which we want to restart the processing
     # @param timeout [Integer, nil] how long in milliseconds do we want to pause or nil to use the
     #   default exponential pausing strategy defined for retries
-    def pause(offset, timeout = nil)
+    # @param manual_pause [Boolean] Flag to differentiate between user pause and system/strategy
+    #   based pause. While they both pause in exactly the same way, the strategy application
+    #   may need to differentiate between them.
+    def pause(offset, timeout = nil, manual_pause = true)
       timeout ? coordinator.pause_tracker.pause(timeout) : coordinator.pause_tracker.pause
 
       client.pause(
@@ -198,6 +201,9 @@ module Karafka
         messages.metadata.partition,
         offset
       )
+
+      # Indicate, that user took a manual action of pausing
+      coordinator.manual_pause if manual_pause
     end
 
     # Resumes processing of the current topic partition

data/lib/karafka/connection/client.rb

@@ -308,8 +308,8 @@ module Karafka
             @closed = true
 
             # Remove callbacks runners that were registered
-            ::Karafka::Instrumentation.statistics_callbacks.delete(@subscription_group.id)
-            ::Karafka::Instrumentation.error_callbacks.delete(@subscription_group.id)
+            ::Karafka::Core::Instrumentation.statistics_callbacks.delete(@subscription_group.id)
+            ::Karafka::Core::Instrumentation.error_callbacks.delete(@subscription_group.id)
 
             @kafka.close
             @buffer.clear
@@ -397,7 +397,7 @@ module Karafka
         @name = consumer.name
 
         # Register statistics runner for this particular type of callbacks
-        ::Karafka::Instrumentation.statistics_callbacks.add(
+        ::Karafka::Core::Instrumentation.statistics_callbacks.add(
           @subscription_group.id,
           Instrumentation::Callbacks::Statistics.new(
             @subscription_group.id,
@@ -408,7 +408,7 @@ module Karafka
         )
 
         # Register error tracking callback
-        ::Karafka::Instrumentation.error_callbacks.add(
+        ::Karafka::Core::Instrumentation.error_callbacks.add(
           @subscription_group.id,
           Instrumentation::Callbacks::Error.new(
             @subscription_group.id,

data/lib/karafka/pro/loader.rb

@@ -53,7 +53,7 @@ module Karafka
         private
 
         # Sets proper config options to use pro components
-        # @param config [WaterDrop::Configurable::Node] root config node
+        # @param config [::Karafka::Core::Configurable::Node] root config node
         def reconfigure(config)
           icfg = config.internal
 

data/lib/karafka/pro/processing/strategies/aj_dlq_mom.rb

@@ -42,7 +42,7 @@ module Karafka
                 # Do NOT commit offsets, they are comitted after each job in the AJ consumer.
                 coordinator.pause_tracker.reset
               elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               else
                 coordinator.pause_tracker.reset
                 skippable_message = find_skippable_message
@@ -51,7 +51,7 @@ module Karafka
                 # since AJ consumer commits the offset after each job, we also know that the
                 # previous job was successful
                 mark_as_consumed(skippable_message)
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/aj_lrj_mom_vp.rb

@@ -33,7 +33,7 @@ module Karafka
           # No actions needed for the standard flow here
           def handle_before_enqueue
             coordinator.on_enqueued do
-              pause(coordinator.seek_offset, Lrj::MAX_PAUSE_TIME)
+              pause(coordinator.seek_offset, Lrj::MAX_PAUSE_TIME, false)
             end
           end
 
@@ -51,7 +51,7 @@ module Karafka
                 # If processing failed, we need to pause
                 # For long running job this will overwrite the default never-ending pause and will
                 # cause the processing to keep going after the error backoff
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/aj_mom_vp.rb

@@ -47,7 +47,7 @@ module Karafka
 
                 mark_as_consumed(last_group_message)
               else
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/default.rb

@@ -73,9 +73,13 @@ module Karafka
               if coordinator.success?
                 coordinator.pause_tracker.reset
 
+                # Do not mark last message if pause happened. This prevents a scenario where pause
+                # is overridden upon rebalance by marking
+                return if coordinator.manual_pause?
+
                 mark_as_consumed(last_group_message)
               else
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/dlq.rb

@@ -32,9 +32,11 @@ module Karafka
               if coordinator.success?
                 coordinator.pause_tracker.reset
 
+                return if coordinator.manual_pause?
+
                 mark_as_consumed(messages.last)
               elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               # If we've reached number of retries that we could, we need to skip the first message
               # that was not marked as consumed, pause and continue, while also moving this message
               # to the dead topic
@@ -44,7 +46,7 @@ module Karafka
                 skippable_message = find_skippable_message
                 dispatch_to_dlq(skippable_message) if dispatch_to_dlq?
                 mark_as_consumed(skippable_message)
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/dlq_lrj.rb

@@ -34,12 +34,14 @@ module Karafka
               if coordinator.success?
                 coordinator.pause_tracker.reset
 
+                return if coordinator.manual_pause?
+
                 mark_as_consumed(last_group_message) unless revoked?
                 seek(coordinator.seek_offset) unless revoked?
 
                 resume
               elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               else
                 coordinator.pause_tracker.reset
 

data/lib/karafka/pro/processing/strategies/dlq_lrj_mom.rb

@@ -38,7 +38,7 @@ module Karafka
 
                 resume
               elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               else
                 coordinator.pause_tracker.reset
 

data/lib/karafka/pro/processing/strategies/dlq_mom.rb

@@ -35,7 +35,7 @@ module Karafka
               if coordinator.success?
                 coordinator.pause_tracker.reset
               elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               # If we've reached number of retries that we could, we need to skip the first message
               # that was not marked as consumed, pause and continue, while also moving this message
               # to the dead topic.
@@ -51,7 +51,7 @@ module Karafka
                   dispatch_to_dlq(skippable_message)
                 end
 
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/lrj.rb

@@ -37,7 +37,7 @@ module Karafka
               #
               # For VP it applies the same way and since VP cannot be used with MOM we should not
               # have any edge cases here.
-              pause(coordinator.seek_offset, MAX_PAUSE_TIME)
+              pause(coordinator.seek_offset, MAX_PAUSE_TIME, false)
             end
           end
 
@@ -47,6 +47,8 @@ module Karafka
               if coordinator.success?
                 coordinator.pause_tracker.reset
 
+                return if coordinator.manual_pause?
+
                 mark_as_consumed(last_group_message) unless revoked?
                 seek(coordinator.seek_offset) unless revoked?
 
@@ -55,7 +57,7 @@ module Karafka
                 # If processing failed, we need to pause
                 # For long running job this will overwrite the default never-ending pause and will
                 # cause the processing to keep going after the error backoff
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/lrj_mom.rb

@@ -36,7 +36,7 @@ module Karafka
               #
               # For VP it applies the same way and since VP cannot be used with MOM we should not
               # have any edge cases here.
-              pause(coordinator.seek_offset, Lrj::MAX_PAUSE_TIME)
+              pause(coordinator.seek_offset, Lrj::MAX_PAUSE_TIME, false)
             end
           end
 
@@ -50,7 +50,7 @@ module Karafka
 
                 resume
               else
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, false)
               end
             end
           end

data/lib/karafka/pro/processing/strategies/mom.rb

@@ -32,7 +32,7 @@ module Karafka
               if coordinator.success?
                 coordinator.pause_tracker.reset
               else
-                pause(coordinator.seek_offset)
+                pause(coordinator.seek_offset, nil, false)
               end
             end
           end

data/lib/karafka/processing/coordinator.rb

@@ -21,6 +21,7 @@ module Karafka
         @revoked = false
         @consumptions = {}
         @running_jobs = 0
+        @manual_pause = false
         @mutex = Mutex.new
       end
 
@@ -34,6 +35,9 @@ module Karafka
           # consumption results of consumer instances we no longer control
           @consumptions.clear
 
+          # When starting to run, no pause is expected and no manual pause as well
+          @manual_pause = false
+
           # We set it on the first encounter and never again, because then the offset setting
           # should be up to the consumers logic (our or the end user)
           # Seek offset needs to be always initialized as for case where manual offset management
@@ -98,6 +102,17 @@ module Karafka
       def revoked?
         @revoked
       end
+
+      # Store in the coordinator info, that this pause was done manually by the end user and not
+      # by the system itself
+      def manual_pause
+        @mutex.synchronize { @manual_pause = true }
+      end
+
+      # @return [Boolean] are we in a pause that was initiated by the user
+      def manual_pause?
+        @pause_tracker.paused? && @manual_pause
+      end
     end
   end
 end

data/lib/karafka/processing/strategies/aj_dlq_mom.rb

@@ -26,7 +26,7 @@ module Karafka
             # Do NOT commit offsets, they are comitted after each job in the AJ consumer.
             coordinator.pause_tracker.reset
           elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           else
             coordinator.pause_tracker.reset
             skippable_message = find_skippable_message
@@ -35,7 +35,7 @@ module Karafka
             # since AJ consumer commits the offset after each job, we also know that the
             # previous job was successful
             mark_as_consumed(skippable_message)
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           end
         end
       end

data/lib/karafka/processing/strategies/default.rb

@@ -51,9 +51,15 @@ module Karafka
           if coordinator.success?
             coordinator.pause_tracker.reset
 
+            # We should not move the offset automatically when the partition was paused
+            # If we would not do this upon a revocation during the pause time, a different process
+            # would pick not from the place where we paused but from the offset that would be
+            # automatically committed here
+            return if coordinator.manual_pause?
+
             mark_as_consumed(messages.last)
           else
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           end
         end
 

data/lib/karafka/processing/strategies/dlq.rb

@@ -22,9 +22,11 @@ module Karafka
           if coordinator.success?
             coordinator.pause_tracker.reset
 
+            return if coordinator.manual_pause?
+
             mark_as_consumed(messages.last)
           elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           # If we've reached number of retries that we could, we need to skip the first message
           # that was not marked as consumed, pause and continue, while also moving this message
           # to the dead topic
@@ -43,7 +45,7 @@ module Karafka
             return if revoked?
 
             # We pause to backoff once just in case.
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           end
         end
 

data/lib/karafka/processing/strategies/dlq_mom.rb

@@ -21,7 +21,7 @@ module Karafka
           if coordinator.success?
             coordinator.pause_tracker.reset
           elsif coordinator.pause_tracker.attempt <= topic.dead_letter_queue.max_retries
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           # If we've reached number of retries that we could, we need to skip the first message
           # that was not marked as consumed, pause and continue, while also moving this message
           # to the dead topic
@@ -33,7 +33,7 @@ module Karafka
             dispatch_to_dlq(skippable_message)
 
             # We pause to backoff once just in case.
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           end
         end
       end

data/lib/karafka/processing/strategies/mom.rb

@@ -20,7 +20,7 @@ module Karafka
           if coordinator.success?
             coordinator.pause_tracker.reset
           else
-            pause(coordinator.seek_offset)
+            pause(coordinator.seek_offset, nil, false)
           end
         end
       end

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '2.0.22'
+  VERSION = '2.0.23'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 2.0.22
+  version: 2.0.23
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -35,7 +35,7 @@ cert_chain:
   Qf04B9ceLUaC4fPVEz10FyobjaFoY4i32xRto3XnrzeAgfEe4swLq8bQsR3w/EF3
   MGU0FeSV2Yj7Xc2x/7BzLK8xQn5l7Yy75iPF+KP3vVmDHnNl
   -----END CERTIFICATE-----
-date: 2022-12-02 00:00:00.000000000 Z
+date: 2022-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: karafka-core
@@ -43,7 +43,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.4
+        version: 2.0.6
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -53,24 +53,10 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.4
+        version: 2.0.6
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
-- !ruby/object:Gem::Dependency
-  name: rdkafka
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.12'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -91,7 +77,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.1
+        version: 2.4.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -101,7 +87,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.4.1
+        version: 2.4.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -200,7 +186,6 @@ files:
 - lib/karafka/helpers/async.rb
 - lib/karafka/helpers/colorize.rb
 - lib/karafka/helpers/multi_delegator.rb
-- lib/karafka/instrumentation.rb
 - lib/karafka/instrumentation/callbacks/error.rb
 - lib/karafka/instrumentation/callbacks/statistics.rb
 - lib/karafka/instrumentation/logger.rb
@@ -355,7 +340,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.3.26
 signing_key: 
 specification_version: 4
 summary: Karafka is Ruby and Rails efficient Kafka processing framework.

data/lib/karafka/instrumentation.rb

@@ -1,21 +0,0 @@
-# frozen_string_literal: true
-
-module Karafka
-  # @note Since we can only have one statistics callbacks manager and one error callbacks manager
-  # we use WaterDrops one that is already configured.
-  module Instrumentation
-    class << self
-      # Returns a manager for statistics callbacks
-      # @return [::WaterDrop::CallbacksManager]
-      def statistics_callbacks
-        ::WaterDrop::Instrumentation.statistics_callbacks
-      end
-
-      # Returns a manager for error callbacks
-      # @return [::WaterDrop::CallbacksManager]
-      def error_callbacks
-        ::WaterDrop::Instrumentation.error_callbacks
-      end
-    end
-  end
-end