karafka 2.0.16 → 2.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8cc0ac8b318d7c40e8974e2e26753c68cc5f611bbcd0e4fbea94e3eb275002dd
-  data.tar.gz: db638edaecc662ac8a0f7d627f4bcae6e1e1e83500a49c4dfa4a4f32ee8f78c9
+  metadata.gz: 8d15d4c803dc84a009e4a1ab02e90a9f034a396f718f742060c545f00422ffd5
+  data.tar.gz: fd69d2a4dcb11a9ea94b8a9f7a4dbb505034a304e94b1bd5e9a0a9fe44a666f0
 SHA512:
-  metadata.gz: 6875e7e152b4150f397f3830c828412e0477409483c81e714525161e5263cff686c0cb9b46a6c11cb5b914dc51087e4bac95d5dcdc0e25c7233825b363ed7e6c
-  data.tar.gz: 1f35d410350dc3fbe97462e979f3df832484df1f1f5119e16fe2c28210d01a05e1d3e086c73e1a3b70ba3c6cae9a25dd50e0907ca454b68c9166efcabd22f972
+  metadata.gz: fe75bb62fecbca6b541d1c1737a596b0a937a02a294ec62a13220915194807568be84c0ebb338de6de8a124714164ed7f7f060cdb573f5606357cce861ba364f
+  data.tar.gz: 6c622f4d2ce80b86807e0e05b3108f7fab66ba2696cd2b662a3412986bc98ba954d03bf70141c3a5526e8e4954495efa34c846a0ec594e2e05b05ef2fa01291a

data/.github/workflows/ci.yml

@@ -109,6 +109,7 @@ jobs:
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{matrix.ruby}}
+          bundler-cache: true
 
       - name: Install latest Bundler
         run: |

data/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Karafka framework changelog
 
+## 2.0.17 (2022-11-10)
+- [Fix] Few typos around DLQ and Pro DLQ Dispatch original metadata naming.
+- [Fix] Narrow the components lookup to the appropriate scope (#1114)
+
+### Upgrade notes
+
+1. Replace `original-*` references from DLQ dispatched metadata with `original_*`
+
+```ruby
+# DLQ topic consumption
+def consume
+  messages.each do |broken_message|
+    topic = broken_message.metadata['original_topic'] # was original-topic
+    partition = broken_message.metadata['original_partition'] # was original-partition
+    offset = broken_message.metadata['original_offset'] # was original-offset
+
+    Rails.logger.error "This message is broken: #{topic}/#{partition}/#{offset}"
+  end
+end
+```
+
 ## 2.0.16 (2022-11-09)
 - **[Breaking]** Disable the root `manual_offset_management` setting and require it to be configured per topic. This is part of "topic features" configuration extraction for better code organization.
 - **[Feature]** Introduce **Dead Letter Queue** feature and Pro **Enhanced Dead Letter Queue** feature
@@ -26,7 +47,6 @@
 - [Specs] Split specs into regular and pro to simplify how resources are loaded
 - [Specs] Add specs to ensure, that all the Pro components have a proper per-file license (#1099)
 
-
 ### Upgrade notes
 
 1. Remove the `manual_offset_management` setting from the main config if you use it:

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka (2.0.16)
+    karafka (2.0.17)
       karafka-core (>= 2.0.2, < 3.0.0)
       rdkafka (>= 0.12)
       thor (>= 0.20)

data/README.md

@@ -4,6 +4,8 @@
 [![Gem Version](https://badge.fury.io/rb/karafka.svg)](http://badge.fury.io/rb/karafka)
 [![Join the chat at https://slack.karafka.io](https://raw.githubusercontent.com/karafka/misc/master/slack.svg)](https://slack.karafka.io)
 
+**Note**: Upgrade notes for migration from Karafka `1.4` to Karafka `2.0` can be found [here](https://karafka.io/docs/Upgrades-2.0/).
+
 ## About Karafka
 
 Karafka is a Ruby and Rails multi-threaded efficient Kafka processing framework that:

data/lib/karafka/instrumentation/logger_listener.rb

@@ -123,7 +123,7 @@ module Karafka
         dlq_topic = event[:caller].topic.dead_letter_queue.topic
         partition = message.partition
 
-        info "Dispatched message #{offset} from #{topic}/#{partition} to DQL topic: #{dlq_topic}"
+        info "Dispatched message #{offset} from #{topic}/#{partition} to DLQ topic: #{dlq_topic}"
       end
 
       # There are many types of errors that can occur in many places, but we provide a single

data/lib/karafka/pro/processing/strategies/dlq.rb

@@ -68,9 +68,9 @@ module Karafka
               payload: skippable_message.raw_payload,
               key: skippable_message.partition.to_s,
               headers: skippable_message.headers.merge(
-                'original-topic' => topic.name,
-                'original-partition' => skippable_message.partition.to_s,
-                'original-offset' => skippable_message.offset.to_s
+                'original_topic' => topic.name,
+                'original_partition' => skippable_message.partition.to_s,
+                'original_offset' => skippable_message.offset.to_s
               )
             )
 

data/lib/karafka/routing/features/base.rb

@@ -13,10 +13,10 @@ module Karafka
         class << self
           # Extends topic and builder with given feature API
           def activate
-            Topic.prepend(self::Topic) if const_defined?('Topic')
-            Proxy.prepend(self::Builder) if const_defined?('Builder')
-            Builder.prepend(self::Builder) if const_defined?('Builder')
-            Builder.prepend(Base::Expander.new(self)) if const_defined?('Contract')
+            Topic.prepend(self::Topic) if const_defined?('Topic', false)
+            Proxy.prepend(self::Builder) if const_defined?('Builder', false)
+            Builder.prepend(self::Builder) if const_defined?('Builder', false)
+            Builder.prepend(Base::Expander.new(self)) if const_defined?('Contract', false)
           end
 
           # Loads all the features and activates them

data/lib/karafka/routing/features/dead_letter_queue/topic.rb

@@ -4,7 +4,7 @@ module Karafka
   module Routing
     module Features
       class DeadLetterQueue < Base
-        # DQL topic extensions
+        # DLQ topic extensions
         module Topic
           # After how many retries should be move data to DLQ
           DEFAULT_MAX_RETRIES = 3

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '2.0.16'
+  VERSION = '2.0.17'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 2.0.16
+  version: 2.0.17
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -35,7 +35,7 @@ cert_chain:
   Qf04B9ceLUaC4fPVEz10FyobjaFoY4i32xRto3XnrzeAgfEe4swLq8bQsR3w/EF3
   MGU0FeSV2Yj7Xc2x/7BzLK8xQn5l7Yy75iPF+KP3vVmDHnNl
   -----END CERTIFICATE-----
-date: 2022-11-09 00:00:00.000000000 Z
+date: 2022-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: karafka-core