karafka 1.3.0 → 1.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ffe10d1ca48b0b218191231ec6969f3a767f5a1a4010dca0ef00fa44c2eaab67
-  data.tar.gz: 27d1b52ba3782b562176b7a6de73563bdd48c250bc0576a1821c55bfcec07bff
+  metadata.gz: b4de7fea7ee892f9c83db91dea9e3d16d48d423985477d3f40440bea77907906
+  data.tar.gz: ccfe4744b3bb2c19b31032e8f904716116faa50f96a9be19a4e3cdc79364ebe6
 SHA512:
-  metadata.gz: 85bdedfe0791c7d17abbc54ed49df83e2c9cbfb048124107d403559e72b2884909bcc5974c98a738744f80184315b2ee31cc8bd1048cc5a10230e6b6f0184e3d
-  data.tar.gz: 382074bee041ed27776571816a982fbd7f0af6b6f9cfa8fa393113acf1c2d4cbfb0a7573d2bcd16f2662667d1b8175546e281deb5a7b66ce30b5d9c4c19d005d
+  metadata.gz: 74dbf97aec22f4e0f5f9a07ac9b0457c09846332c65f548d30e2b0342a2adec4b8542004aa1937012892f3374b39f83f557ef5adecacc40ae538290842165150
+  data.tar.gz: fa2072670fe7c17720e593373a4d8222163f4e789c68ec72e4e1f58f4a08688839a0c01e98115db4dfbc5c57d633b0251fe481fc9838362203961c1e4e236159

data/.ruby-version

@@ -1 +1 @@
-2.6.3
+2.7.1

data/.travis.yml

@@ -12,25 +12,25 @@ test: &test
   stage: Test
   language: ruby
   before_install:
-    - gem install bundler
-    - gem update --system
+    - yes | gem update --system
   script: bundle exec rspec
 
 jobs:
   include:
     - <<: *test
-      rvm: 2.6.3
+      rvm: 2.7.1
     - <<: *test
-      rvm: 2.5.5
+      rvm: 2.6.6
+    - <<: *test
+      rvm: 2.5.8
 
     - stage: coditsu
       language: ruby
-      rvm: 2.6.3
+      rvm: 2.7.1
       before_install:
-        - gem update --system
-        - gem install bundler
+        - yes | gem update --system
       script: \curl -sSL https://api.coditsu.io/run/ci | bash
 
 stages:
-  - coditsu
   - test
+  - coditsu

data/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Karafka framework changelog
 
+## 1.3.6 (2020-04-24)
+- #583 - Use Karafka.logger for CLI messages (prikha)
+- #582 - Cannot only define seed brokers in consumer groups
+
+## 1.3.5 (2020-04-02)
+- #578 - ThreadError: can't be called from trap context patch
+
+## 1.3.4 (2020-02-17)
+- `dry-configurable` upgrade (solnic)
+- Remove temporary `thor` patches that are no longer needed
+
+## 1.3.3 (2019-12-23)
+- Require `delegate` to fix missing dependency in `ruby-kafka`
+
+## 1.3.2 (2019-12-23)
+- #561 - Allow `thor` 1.0.x usage in Karafka
+- #567 - Ruby 2.7.0 support + unfreeze of a frozen string fix
+
+## 1.3.1 (2019-11-11)
+- #545 - Makes sure the log directory exists when is possible (robertomiranda)
+- Ruby 2.6.5 support
+- #551 - add support for DSA keys
+- #549 - Missing directories after `karafka install` (nijikon)
+
 ## 1.3.0 (2019-09-09)
 - Drop support for Ruby 2.4
 - YARD docs tags cleanup
@@ -92,7 +116,7 @@
 ## 1.2.3
 - #313 - support PLAINTEXT and SSL for scheme
 - #288 - drop activesupport callbacks in favor of notifications
-- #320 - Pausing indefinetely with nil pause timeout doesn't work
+- #320 - Pausing indefinitely with nil pause timeout doesn't work
 - #318 - Partition pausing doesn't work with custom topic mappers
 - Rename ConfigAdapter to ApiAdapter to better reflect what it does
 - #317 - Manual offset committing doesn't work with custom topic mappers
@@ -221,7 +245,7 @@
 - Switch to multi json so everyone can use their favourite JSON parser
 - Added jruby support in general and in Travis
 - #196 - Topic mapper does not map topics when subscribing thanks to @webandtech
-- #96 - Karafka server - possiblity to run it only for a certain topics
+- #96 - Karafka server - possibility to run it only for a certain topics
 - ~~karafka worker cli option is removed (please use sidekiq directly)~~ - restored, bad idea
 - (optional) pausing upon processing failures ```pause_timeout```
 - Karafka console main process no longer intercepts irb errors
@@ -229,7 +253,7 @@
 - #204 - Long running controllers
 - Better internal API to handle multiple usage cases using ```Karafka::Controllers::Includer```
 - #207 - Rename before_enqueued to after_received
-- #147 - Deattach Karafka from Sidekiq by extracting Sidekiq backend
+- #147 - De-attach Karafka from Sidekiq by extracting Sidekiq backend
 
 ### New features and improvements
 
@@ -314,7 +338,7 @@
 - Waterdrop 0.3.2.1 with kafka.hosts instead of kafka_hosts
 - #105 - Karafka::Monitor#caller_label not working with inherited monitors
 - #99 - Standalone mode (without Sidekiq)
-- #97 - Buffer responders single topics before send (prevalidation)
+- #97 - Buffer responders single topics before send (pre-validation)
 - Better control over consumer thanks to additional config options
 - #111 - Dynamic worker assignment based on the income params
 - Long shutdown time fix
@@ -322,7 +346,7 @@
 ## 0.5.0
 - Removed Zookeeper totally as dependency
 - Better group and partition rebalancing
-- Automatic thread management (no need for tunning) - each topic is a separate actor/thread
+- Automatic thread management (no need for tuning) - each topic is a separate actor/thread
 - Moved from Poseidon into Ruby-Kafka
 - No more max_concurrency setting
 - After you define your App class and routes (and everything else) you need to add execute App.boot!
@@ -338,14 +362,14 @@
 - Ruby 2.2.* support dropped
 - Using App name as a Kafka client_id
 - Automatic Capistrano integration
-- Responders support for handling better responses pipelining and better responses flow description and design (see README for more details)
+- Responders support for handling better responses pipe-lining and better responses flow description and design (see README for more details)
 - Gem bump
 - Readme updates
 - karafka flow CLI command for printing the application flow
-- Some internal refactorings
+- Some internal refactoring
 
 ## 0.4.2
-- #87 - Reconsume mode with crone for better Rails/Rack integration
+- #87 - Re-consume mode with crone for better Rails/Rack integration
 - Moved Karafka server related stuff into separate Karafka::Server class
 - Renamed Karafka::Runner into Karafka::Fetcher
 - Gem bump
@@ -357,7 +381,7 @@
 
 ## 0.4.1
 - Explicit throw(:abort) required to halt before_enqueue (like in Rails 5)
-- #61 - Autodiscover Kafka brokers based on Zookeeper data
+- #61 - autodiscovery of Kafka brokers based on Zookeeper data
 - #63 - Graceful shutdown with current offset state during data processing
 - #65 - Example of NewRelic monitor is outdated
 - #71 - Setup should be executed after user code is loaded
@@ -413,7 +437,7 @@
 - Added Karafka::Monitoring that allows to add custom logging and monitoring with external libraries and systems
 - Moved logging functionality into Karafka::Monitoring default monitoring
 - Added possibility to provide own monitoring as long as in responds to #notice and #notice_error
-- Standarized logging format for all logs
+- Standardized logging format for all logs
 
 ## 0.3.0
 - Switched from custom ParserError for each parser to general catching of Karafka::Errors::ParseError and its descendants
@@ -430,7 +454,7 @@
 
 ## 0.1.19
 - Internal call - schedule naming change
-- Enqueue to perform_async naming in controller to follow Sidekiqs naming convention
+- Enqueue to perform_async naming in controller to follow Sidekiq naming convention
 - Gem bump
 
 ## 0.1.18
@@ -441,7 +465,7 @@
 - Changed Karafka::Connection::Cluster tp Karafka::Connection::ActorCluster to distinguish between a single thread actor cluster for multiple topic connection and a future feature that will allow process clusterization.
 - Add an ability to use user-defined parsers for a messages
 - Lazy load params for before callbacks
-- Automatic loading/initializng all workers classes during startup (so Sidekiq won't fail with unknown workers exception)
+- Automatic loading/initializing all workers classes during startup (so Sidekiq won't fail with unknown workers exception)
 - Params are now private to controller
 - Added bootstrap method to app.rb
 
@@ -482,7 +506,7 @@
 - Added worker logger
 
 ## 0.1.8
-- Droped local env suppot in favour of [Envlogic](https://github.com/karafka/envlogic) - no changes in API
+- Dropped local env support in favour of [Envlogic](https://github.com/karafka/envlogic) - no changes in API
 
 ## 0.1.7
 - Karafka option for Redis hosts (not localhost only)
@@ -512,7 +536,7 @@
 
 ## 0.1.1
 - README updates
-- Raketasks updates
+- Rake tasks updates
 - Rake installation task
 - Changelog file added
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka (1.3.0)
+    karafka (1.3.6)
       dry-configurable (~> 0.8)
       dry-inflector (~> 0.1)
       dry-monitor (~> 0.3)
@@ -11,117 +11,120 @@ PATH
       multi_json (>= 1.12)
       rake (>= 11.3)
       ruby-kafka (>= 0.7.8)
-      thor (~> 0.20)
+      thor (>= 0.20)
       waterdrop (~> 1.3.0)
       zeitwerk (~> 2.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.0)
+    activesupport (6.0.2.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-      zeitwerk (~> 2.1, >= 2.1.8)
-    byebug (11.0.1)
-    concurrent-ruby (1.1.5)
-    delivery_boy (0.2.8)
+      zeitwerk (~> 2.2)
+    byebug (11.1.3)
+    concurrent-ruby (1.1.6)
+    delivery_boy (1.0.1)
       king_konf (~> 0.3)
-      ruby-kafka (~> 0.7.8)
+      ruby-kafka (~> 1.0)
     diff-lcs (1.3)
-    digest-crc (0.4.1)
+    digest-crc (0.5.1)
     docile (1.3.2)
-    dry-configurable (0.8.3)
+    dry-configurable (0.11.5)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.4, >= 0.4.7)
+      dry-equalizer (~> 0.2)
     dry-container (0.7.2)
       concurrent-ruby (~> 1.0)
       dry-configurable (~> 0.1, >= 0.1.3)
     dry-core (0.4.9)
       concurrent-ruby (~> 1.0)
-    dry-equalizer (0.2.2)
+    dry-equalizer (0.3.0)
     dry-events (0.2.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
-    dry-inflector (0.1.2)
-    dry-initializer (3.0.1)
-    dry-logic (1.0.3)
+    dry-inflector (0.2.0)
+    dry-initializer (3.0.3)
+    dry-logic (1.0.6)
       concurrent-ruby (~> 1.0)
       dry-core (~> 0.2)
       dry-equalizer (~> 0.2)
-    dry-monitor (0.3.1)
+    dry-monitor (0.3.2)
       dry-configurable (~> 0.5)
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
-      dry-events (~> 0.1)
-    dry-schema (1.3.3)
+      dry-events (~> 0.2)
+    dry-schema (1.5.0)
       concurrent-ruby (~> 1.0)
       dry-configurable (~> 0.8, >= 0.8.3)
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
       dry-initializer (~> 3.0)
       dry-logic (~> 1.0)
-      dry-types (~> 1.0)
-    dry-types (1.1.1)
+      dry-types (~> 1.4)
+    dry-types (1.4.0)
       concurrent-ruby (~> 1.0)
       dry-container (~> 0.3)
       dry-core (~> 0.4, >= 0.4.4)
-      dry-equalizer (~> 0.2, >= 0.2.2)
+      dry-equalizer (~> 0.3)
       dry-inflector (~> 0.1, >= 0.1.2)
       dry-logic (~> 1.0, >= 1.0.2)
-    dry-validation (1.3.1)
+    dry-validation (1.5.0)
       concurrent-ruby (~> 1.0)
       dry-container (~> 0.7, >= 0.7.1)
       dry-core (~> 0.4)
       dry-equalizer (~> 0.2)
       dry-initializer (~> 3.0)
-      dry-schema (~> 1.0, >= 1.3.1)
-    envlogic (1.1.0)
+      dry-schema (~> 1.5)
+    envlogic (1.1.2)
       dry-inflector (~> 0.1)
-    factory_bot (5.0.2)
+    factory_bot (5.1.2)
       activesupport (>= 4.2.0)
-    i18n (1.6.0)
+    i18n (1.8.2)
       concurrent-ruby (~> 1.0)
-    irb (1.0.0)
-    json (2.2.0)
+    io-console (0.5.6)
+    irb (1.2.3)
+      reline (>= 0.0.1)
     king_konf (0.3.7)
-    minitest (5.11.3)
-    multi_json (1.13.1)
-    rake (12.3.3)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.2)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.4)
+    minitest (5.14.0)
+    multi_json (1.14.1)
+    rake (13.0.1)
+    reline (0.1.3)
+      io-console (~> 0.5)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.1)
+      rspec-support (~> 3.9.1)
+    rspec-expectations (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.1)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.2)
-    ruby-kafka (0.7.10)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.2)
+    ruby-kafka (1.0.0)
       digest-crc
-    simplecov (0.17.0)
+    simplecov (0.18.5)
       docile (~> 1.1)
-      json (>= 1.8, < 3)
-      simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.2)
-    thor (0.20.3)
+      simplecov-html (~> 0.11)
+    simplecov-html (0.12.2)
+    thor (1.0.1)
     thread_safe (0.3.6)
-    tzinfo (1.2.5)
+    tzinfo (1.2.7)
       thread_safe (~> 0.1)
-    waterdrop (1.3.0)
-      delivery_boy (~> 0.2)
+    waterdrop (1.3.4)
+      delivery_boy (>= 0.2, < 2.x)
       dry-configurable (~> 0.8)
       dry-monitor (~> 0.3)
       dry-validation (~> 1.2)
       ruby-kafka (>= 0.7.8)
       zeitwerk (~> 2.1)
-    zeitwerk (2.1.10)
+    zeitwerk (2.3.0)
 
 PLATFORMS
   ruby
@@ -134,4 +137,4 @@ DEPENDENCIES
   simplecov
 
 BUNDLED WITH
-   2.0.2
+   2.1.4

data/README.md

@@ -2,11 +2,11 @@
 
 [![Build Status](https://travis-ci.org/karafka/karafka.svg?branch=master)](https://travis-ci.org/karafka/karafka)
 
-## New release in progress!
+**Note**: Documentation presented here refers to Karafka `1.3.x`.
 
-**Note**: Documentation presented here refers to Karafka `1.3.0`.
+If you're upgrading from `1.2.0`, please refer to our [Upgrade Notes article](https://mensfeld.pl/2019/09/karafka-framework-1-3-0-release-notes-ruby-kafka/).
 
-If you are looking for the documentation for Karafka `1.2.*`, it can be found [here](https://github.com/karafka/wiki/tree/1.2).
+If you are looking for the documentation for Karafka `1.2.x`, it can be found [here](https://github.com/karafka/wiki/tree/1.2).
 
 ## About Karafka
 

data/karafka.gemspec

@@ -26,11 +26,11 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'multi_json', '>= 1.12'
   spec.add_dependency 'rake', '>= 11.3'
   spec.add_dependency 'ruby-kafka', '>= 0.7.8'
-  spec.add_dependency 'thor', '~> 0.20'
+  spec.add_dependency 'thor', '>= 0.20'
   spec.add_dependency 'waterdrop', '~> 1.3.0'
   spec.add_dependency 'zeitwerk', '~> 2.1'
 
-  spec.required_ruby_version = '>= 2.4.0'
+  spec.required_ruby_version = '>= 2.5.0'
 
   if $PROGRAM_NAME.end_with?('gem')
     spec.signing_key = File.expand_path('~/.ssh/gem-private_key.pem')

data/lib/karafka.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 %w[
+  delegate
   English
   waterdrop
   kafka

data/lib/karafka/attributes_map.rb

@@ -52,14 +52,8 @@ module Karafka
         ignored_settings = api_adapter[:subscribe]
         defined_settings = api_adapter.values.flatten
         karafka_settings = %i[batch_fetching]
-        # This is a dirty and bad hack of dry-configurable to get keys before setting values
-        dynamically_proxied = Karafka::Setup::Config
-                              ._settings
-                              .settings
-                              .find { |s| s.name == :kafka }
-                              .value
-                              .names
-                              .to_a
+
+        dynamically_proxied = Karafka::Setup::Config.config.kafka.to_h.keys
 
         (defined_settings + dynamically_proxied).uniq + karafka_settings - ignored_settings
       end

data/lib/karafka/cli.rb

@@ -47,7 +47,7 @@ end
 if ENV['KARAFKA_CONSOLE']
   # Reloads Karafka irb console session
   def reload!
-    puts "Reloading...\n"
+    Karafka.logger.info "Reloading...\n"
     Kernel.exec Karafka::Cli::Console.command
   end
 end

data/lib/karafka/cli/flow.rb

@@ -11,19 +11,22 @@ module Karafka
       def call
         topics.each do |topic|
           any_topics = !topic.responder&.topics.nil?
+          log_messages = []
 
           if any_topics
-            puts "#{topic.name} =>"
+            log_messages << "#{topic.name} =>"
 
             topic.responder.topics.each_value do |responder_topic|
               features = []
               features << (responder_topic.required? ? 'always' : 'conditionally')
 
-              print responder_topic.name, "(#{features.join(', ')})"
+              log_messages << format(responder_topic.name, "(#{features.join(', ')})")
             end
           else
-            puts "#{topic.name} => (nothing)"
+            log_messages << "#{topic.name} => (nothing)"
           end
+
+          Karafka.logger.info(log_messages.join("\n"))
         end
       end
 
@@ -34,11 +37,11 @@ module Karafka
         Karafka::App.consumer_groups.map(&:topics).flatten.sort_by(&:name)
       end
 
-      # Prints a given value with label in a nice way
+      # Formats a given value with label in a nice way
       # @param label [String] label describing value
       # @param value [String] value that should be printed
-      def print(label, value)
-        printf "%-25s %s\n", "  - #{label}:", value
+      def format(label, value)
+        "  - #{label}:                #{value}"
       end
     end
   end

data/lib/karafka/cli/info.rb

@@ -24,7 +24,7 @@ module Karafka
           "Kafka seed brokers: #{config.kafka.seed_brokers}"
         ]
 
-        puts(info.join("\n"))
+        Karafka.logger.info(info.join("\n"))
       end
     end
   end

data/lib/karafka/cli/install.rb

@@ -13,7 +13,9 @@ module Karafka
       INSTALL_DIRS = %w[
         app/consumers
         app/responders
+        app/workers
         config
+        lib
         log
         tmp/pids
       ].freeze

data/lib/karafka/connection/api_adapter.rb

@@ -14,11 +14,12 @@ module Karafka
     module ApiAdapter
       class << self
         # Builds all the configuration settings for Kafka.new method
+        # @param consumer_group [Karafka::Routing::ConsumerGroup] consumer group details
         # @return [Array<Hash>] Array with all the client arguments including hash with all
         #   the settings required by Kafka.new method
         # @note We return array, so we can inject any arguments we want, in case of changes in the
         #   raw driver
-        def client
+        def client(consumer_group)
           # This one is a default that takes all the settings except special
           # cases defined in the map
           settings = {
@@ -26,14 +27,17 @@ module Karafka
             client_id: ::Karafka::App.config.client_id
           }
 
-          kafka_configs.each do |setting_name, setting_value|
+          kafka_configs.each_key do |setting_name|
             # All options for config adapter should be ignored as we're just interested
             # in what is left, as we want to pass all the options that are "typical"
             # and not listed in the api_adapter special cases mapping. All the values
             # from the api_adapter mapping go somewhere else, not to the client directly
             next if AttributesMap.api_adapter.values.flatten.include?(setting_name)
 
-            settings[setting_name] = setting_value
+            # Settings for each consumer group are either defined per consumer group or are
+            # inherited from the global/general settings level, thus we don't have to fetch them
+            # from the kafka settings as they are already on a consumer group level
+            settings[setting_name] = consumer_group.public_send(setting_name)
           end
 
           settings_hash = sanitize(settings)

data/lib/karafka/connection/builder.rb

@@ -6,9 +6,11 @@ module Karafka
     module Builder
       class << self
         # Builds a Kafka::Client instance that we use to work with Kafka cluster
+        # @param consumer_group [Karafka::Routing::ConsumerGroup] consumer group for which we want
+        #   to have a new Kafka client
         # @return [::Kafka::Client] returns a Kafka client
-        def call
-          Kafka.new(*ApiAdapter.client)
+        def call(consumer_group)
+          Kafka.new(*ApiAdapter.client(consumer_group))
         end
       end
     end

data/lib/karafka/connection/client.rb

@@ -97,7 +97,7 @@ module Karafka
       def kafka_consumer
         # @note We don't cache the connection internally because we cache kafka_consumer that uses
         #   kafka client object instance
-        @kafka_consumer ||= Builder.call.consumer(
+        @kafka_consumer ||= Builder.call(consumer_group).consumer(
           *ApiAdapter.consumer(consumer_group)
         ).tap do |consumer|
           consumer_group.topics.each do |topic|

data/lib/karafka/connection/listener.rb

@@ -47,10 +47,10 @@ module Karafka
           end
         end
         # This is on purpose - see the notes for this method
-        # rubocop:disable RescueException
+        # rubocop:disable Lint/RescueException
       rescue Exception => e
         Karafka.monitor.instrument('connection.listener.fetch_loop.error', caller: self, error: e)
-        # rubocop:enable RescueException
+        # rubocop:enable Lint/RescueException
         # We can stop client without a problem, as it will reinitialize itself when running the
         # `fetch_loop` again
         @client.stop

data/lib/karafka/contracts/consumer_group.rb

@@ -178,9 +178,9 @@ module Karafka
       # @param value [String] potential RSA key value
       # @return [Boolean] is the given string a valid RSA key
       def valid_private_key?(value)
-        OpenSSL::PKey::RSA.new(value)
+        OpenSSL::PKey.read(value)
         true
-      rescue OpenSSL::PKey::RSAError
+      rescue OpenSSL::PKey::PKeyError
         false
       end
 

data/lib/karafka/contracts/server_cli_options.rb

@@ -6,6 +6,8 @@ module Karafka
     # We validate some basics + the list of consumer_groups on which we want to use, to make
     # sure that all of them are defined, plus that a pidfile does not exist
     class ServerCliOptions < Dry::Validation::Contract
+      config.messages.load_paths << File.join(Karafka.gem_root, 'config', 'errors.yml')
+
       params do
         optional(:pid).filled(:str?)
         optional(:daemon).filled(:bool?)

data/lib/karafka/helpers/class_matcher.rb

@@ -44,7 +44,7 @@ module Karafka
       # @example From Namespaced::Super2Consumer matching responder
       #   matcher.name #=> Super2Responder
       def name
-        inflected = @klass.to_s.split('::').last.to_s
+        inflected = +@klass.to_s.split('::').last.to_s
         # We inject the from into the name just in case it is missing as in a situation like
         # that it would just sanitize the name without adding the "to" postfix.
         # It could create cases when we want to build for example a responder to a consumer

data/lib/karafka/instrumentation/logger.rb

@@ -36,10 +36,11 @@ module Karafka
           .to(STDOUT, file)
       end
 
-      # Makes sure the log directory exists
+      # Makes sure the log directory exists as long as we can write to it
       def ensure_dir_exists
-        dir = File.dirname(log_path)
-        FileUtils.mkdir_p(dir) unless Dir.exist?(dir)
+        FileUtils.mkdir_p(File.dirname(log_path))
+      rescue Errno::EACCES
+        nil
       end
 
       # @return [Pathname] Path to a file to which we should log

data/lib/karafka/server.rb

@@ -58,9 +58,12 @@ module Karafka
       def stop_supervised
         Karafka::App.stop!
 
+        # Temporary patch until https://github.com/dry-rb/dry-configurable/issues/93 is fixed
+        timeout = Thread.new { Karafka::App.config.shutdown_timeout }.join.value
+
         # We check from time to time (for the timeout period) if all the threads finished
         # their work and if so, we can just return and normal shutdown process will take place
-        (Karafka::App.config.shutdown_timeout * SUPERVISION_CHECK_FACTOR).to_i.times do
+        (timeout * SUPERVISION_CHECK_FACTOR).to_i.times do
           if consumer_threads.count(&:alive?).zero?
             Thread.new { Karafka.monitor.instrument('app.stopped') }.join
             return

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '1.3.0'
+  VERSION = '1.3.6'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.6
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -36,7 +36,7 @@ cert_chain:
   KJG/fhg1JV5vVDdVy6x+tv5SQ5ctU0feCsVfESi3rE3zRd+nvzE9HcZ5aXeL1UtJ
   nT5Xrioegu2w1jPyVEgyZgTZC5rvD0nNS5sFNQ==
   -----END CERTIFICATE-----
-date: 2019-09-09 00:00:00.000000000 Z
+date: 2020-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-configurable
@@ -168,14 +168,14 @@ dependencies:
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.20'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.20'
 - !ruby/object:Gem::Dependency
@@ -322,14 +322,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Ruby based framework for working with Apache Kafka