karafka 1.2.0.beta3 → 1.2.0.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf35bab1fc0751c78111ae2e82810b10113e0b7e9bfbf014c32f6239b4725b91
-  data.tar.gz: e908c0c6e02d3753b53844f993230cd924ecf09b453ec094550f3f81b6741d5d
+  metadata.gz: e7df4ccab5fe5e942f4d97bdcb099ed1f754e3902c52775f9272e0f351c879ff
+  data.tar.gz: 73417de830c717ab59a74375091d45c43308c58b43fd00bdc7bd579b6f2ded6b
 SHA512:
-  metadata.gz: '095c023b08f013114e21e891f8b97a6e3ab9b0aad5dd640948d766474adff7e04f13dd110fa72abf7e671e1996c8b618bbd0bb30093ae8fe4d1dfa41993aa245'
-  data.tar.gz: d096b0ff330e49dd2fad6ca474f7efd6703b6b8fcfef0eaee6d9064b961a319bd92b0b800eab3529cb43ce2912e372f2d2d549f15bbc7726253ae9f5acaa9893
+  metadata.gz: 37cfeeb29cf0728d21e1dcd269c0432ec972bd6cc0b08f690fa49c3e2026ab2b8d2c558229c227dded52ee8a631859a17757422041fdce3ad424993573a5e6ac
+  data.tar.gz: 85061228901bdced44d5cf699d10ceb51a0bc818d39fdbcbd1f24b667d75d459f405262ca9036e63357637850d7084da8e71429808e6fd6f094cfbb82f581f05

data/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Karafka framework changelog
 
-## 1.2.0
+## 1.2.0.beta4
 - Spec improvements
 - #260 - Specs missing randomization
 - #251 - Shutdown upon non responding (unreachable) cluster is not possible
@@ -34,6 +34,7 @@
 - Renamed ```after_fetched``` to ```after_fetch``` to normalize the naming convention
 - Instrumentation on a connection delegator level
 - Added ```params_batch#last``` method to retrieve last element after unparsing
+- All params keys are now strings
 
 ## 1.1.2
 - #256 - Default kafka.seed_brokers configuration is created in invalid format

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka (1.2.0.beta3)
+    karafka (1.2.0.beta4)
       activesupport (>= 4.0)
       dry-configurable (~> 0.7)
       dry-inflector (~> 0.1.1)
@@ -10,7 +10,7 @@ PATH
       envlogic (~> 1.0)
       multi_json (>= 1.12)
       rake (>= 11.3)
-      require_all (~> 2.0)
+      require_all (>= 1.4)
       ruby-kafka (>= 0.5.3)
       thor (~> 0.19)
       waterdrop (~> 1.2)

data/karafka.gemspec

@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'envlogic', '~> 1.0'
   spec.add_dependency 'multi_json', '>= 1.12'
   spec.add_dependency 'rake', '>= 11.3'
-  spec.add_dependency 'require_all', '~> 2.0'
+  spec.add_dependency 'require_all', '>= 1.4'
   spec.add_dependency 'ruby-kafka', '>= 0.5.3'
   spec.add_dependency 'thor', '~> 0.19'
   spec.add_dependency 'waterdrop', '~> 1.2'

data/lib/karafka/params/dsl.rb

@@ -14,9 +14,8 @@ module Karafka
     # heavy-parsing data without slowing down the whole application.
     module Dsl
       # Params keys that are "our" and internal. We use this list for additional backends
-      # that don't allow symbols to be transferred, to remap the interchanged params
-      # back into a valid form
-      SYSTEM_KEYS = %i[
+      # that somehow operatae on those keys
+      SYSTEM_KEYS = %w[
         parser
         value
         partition
@@ -33,7 +32,7 @@ module Karafka
       # Kafka passes internally Kafka::FetchedMessage object and the ruby-kafka consumer
       # uses those fields via method calls, so in order to be able to pass there our params
       # objects, have to have same api.
-      METHOD_ATTRIBUTES = %i[
+      METHOD_ATTRIBUTES = %w[
         topic
         partition
         offset
@@ -60,21 +59,24 @@ module Karafka
         #   Karafka::Params::Params.build(message) #=> params object
         def build(message, parser)
           instance = new
-          instance[:parser] = parser
+          instance['parser'] = parser
 
           # Non kafka fetched message can happen when we interchange data with an
           # additional backend
           if message.is_a?(Kafka::FetchedMessage)
-            instance[:value] = message.value
-            instance[:partition] = message.partition
-            instance[:offset] = message.offset
-            instance[:key] = message.key
-            instance[:create_time] = message.create_time
-            instance[:receive_time] = Time.now
-            # When we get raw messages, they might have a topic, that was modified by a
-            # topic mapper. We need to "reverse" this change and map back to the non-modified
-            # format, so our internal flow is not corrupted with the mapping
-            instance[:topic] = Karafka::App.config.topic_mapper.incoming(message.topic)
+            instance.send(
+              :merge!,
+              'value' => message.value,
+              'partition' => message.partition,
+              'offset' => message.offset,
+              'key' => message.key,
+              'create_time' => message.create_time,
+              'receive_time' => Time.now,
+              # When we get raw messages, they might have a topic, that was modified by a
+              # topic mapper. We need to "reverse" this change and map back to the non-modified
+              # format, so our internal flow is not corrupted with the mapping
+              'topic' => Karafka::App.config.topic_mapper.incoming(message.topic)
+            )
           else
             instance.send(:merge!, message)
           end
@@ -88,10 +90,10 @@ module Karafka
       #   to the current object. This object will be also marked as already parsed, so we won't
       #   parse it again.
       def retrieve!
-        return self if self[:parsed]
-        self[:parsed] = true
+        return self if self['parsed']
+        self['parsed'] = true
 
-        merge!(parse(delete(:value)))
+        merge!(parse(delete('value')))
       end
 
       # Includes and extends the base params klass with everything that is needed by Karafka to
@@ -143,7 +145,7 @@ module Karafka
       #   went wrong during parsing
       def parse(value)
         Karafka.monitor.instrument('params.params.parse', caller: self) do
-          self[:parser].parse(value)
+          self['parser'].parse(value)
         end
       rescue ::Karafka::Errors::ParserError => e
         Karafka.monitor.instrument('params.params.parse.error', caller: self, error: e)

data/lib/karafka/version.rb

@@ -3,5 +3,5 @@
 # Main module namespace
 module Karafka
   # Current Karafka version
-  VERSION = '1.2.0.beta3'
+  VERSION = '1.2.0.beta4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka
 version: !ruby/object:Gem::Version
-  version: 1.2.0.beta3
+  version: 1.2.0.beta4
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -128,16 +128,16 @@ dependencies:
   name: require_all
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.4'
 - !ruby/object:Gem::Dependency
   name: ruby-kafka
   requirement: !ruby/object:Gem::Requirement