karafka-web 0.7.9 → 0.7.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24bc5fe488a1304886f3f7f697a8662463f4c21fae60daf52d317852f9f43669
-  data.tar.gz: eaa8e4b7d9b9d70200c8929e8fa65ed7906a1b4085465b15525bfee670ebbcc9
+  metadata.gz: '0806cac6cd5ba083c727f4737a5bacbc6fb51a45229043745e401c3f5ccfd120'
+  data.tar.gz: f6f5743e8fe1b32eec5c126f81d8ed4bcb0501569c050b721a238388d608a7aa
 SHA512:
-  metadata.gz: 0ba2c668103a3b25169d86f2c0624fae04d144694040694ff79c4932bf81fe648e5ba11223be5a5f9e8d8ba0bbbac9da84f2ec5312e81d07b35873707b7b754c
-  data.tar.gz: b0ec51820b50dfde4f88e942e3b0dcc2400170d0fbe256503294f366e2f4fe0057249bb525528b789bed254ba6ec035d5502e515042bd094999663155f8a221d
+  metadata.gz: a70b5779abaa3440ffb85f8d735edf6a96723ab08c0c52a982c3ac09331d4a459053de0fcf4767bd79631d0314efe9d3a13949639d1b2ee62f88cda6e6519dbb
+  data.tar.gz: 2ab8bc6927e8e5d0cf6ef63e2be932322eeec8d0f668c7a144b61d5dfc3ceae74a758dcd58f32deac4ccf42c4cad1d799e7df4f5c0b0bbb0494b245362104262

data/.github/workflows/ci.yml

@@ -1,6 +1,8 @@
 name: ci
 
-concurrency: ci-${{ github.ref }}
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 on:
   pull_request:

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Karafka Web changelog
 
+## 0.7.10 (2023-10-31)
+- [Fix] Max LSO chart does not work as expected (#201)
+
 ## 0.7.9 (2023-10-25)
 - [Enhancement] Allow for `Karafka::Web.producer` reconfiguration from the default (`Karafka.producer`).
 - [Change] Rely on `karafka-core` `>=` `2.2.4` to support lazy loaded custom web producer.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka-web (0.7.9)
+    karafka-web (0.7.10)
       erubi (~> 1.4)
       karafka (>= 2.2.9, < 3.0.0)
       karafka-core (>= 2.2.4, < 3.0.0)

data/lib/karafka/web/processing/consumers/aggregators/metrics.rb

@@ -107,9 +107,18 @@ module Karafka
 
                 # Last stable offsets freeze durations - we pick the max freeze to indicate
                 # the longest open transaction that potentially may be hanging
-                ls_offsets_fd = partitions_data
-                                .map { |p_details| p_details.fetch(:ls_offset_fd, 0) }
-                                .reject(&:negative?)
+                # We select only those partitions for which LSO != HO as in any other case this
+                # just means we've reached the end of data and ls may freeze because there is no
+                # more data flowing. Such cases should not be reported as ls offset freezes because
+                # there is no more data to be processed and can grow until more data is present
+                # this does not indicate "bad" freezing that we are interested in
+                ls_offsets_fds = partitions_data.map do |p_details|
+                  next if p_details.fetch(:ls_offset, 0) == p_details.fetch(:hi_offset, 0)
+
+                  ls_offset_fd = p_details.fetch(:ls_offset_fd, 0)
+
+                  ls_offset_fd.negative? ? nil : ls_offset_fd
+                end
 
                 cgs[group_name] ||= {}
                 cgs[group_name][topic_name] = {
@@ -119,7 +128,7 @@ module Karafka
                   # Take max last stable offset duration without any change. This can
                   # indicate a hanging transaction, because the offset will not move forward
                   # and will stay with a growing freeze duration when stuck
-                  ls_offset_fd: ls_offsets_fd.max || 0
+                  ls_offset_fd: ls_offsets_fds.compact.max || 0
                 }
               end
 

data/lib/karafka/web/ui/models/metrics/charts/topics.rb

@@ -76,20 +76,11 @@ module Karafka
                   topic_without_cg = topic.split('[').first
 
                   metrics.each do |current|
-                    ls_offset = current.last[:ls_offset] || 0
                     ls_offset_fd = current.last[:ls_offset_fd] || 0
-                    hi_offset = current.last[:hi_offset] || 0
 
                     # We convert this to seconds from milliseconds due to our Web UI precision
                     # Reporting is in ms for consistency
                     normalized_fd = (ls_offset_fd / 1_000).round
-                    # In case ls_offset and hi_offset are the same, it means we're reached eof
-                    # and we just don't have more data. In cases like this, LSO freeze duration
-                    # will grow because LSO will remain unchanged, but it does not mean it is
-                    # frozen. It means there is just no more data in the topic partition
-                    # This means we need to nullify this case, otherwise it would report, that
-                    # lso is hanging.
-                    normalized_fd = 0 if ls_offset == hi_offset
 
                     topics[topic_without_cg][current.first] << normalized_fd
                   end

data/lib/karafka/web/version.rb

@@ -3,6 +3,6 @@
 module Karafka
   module Web
     # Current gem version
-    VERSION = '0.7.9'
+    VERSION = '0.7.10'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka-web
 version: !ruby/object:Gem::Version
-  version: 0.7.9
+  version: 0.7.10
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -35,7 +35,7 @@ cert_chain:
   AnG1dJU+yL2BK7vaVytLTstJME5mepSZ46qqIJXMuWob/YPDmVaBF39TDSG9e34s
   msG3BiCqgOgHAnL23+CN3Rt8MsuRfEtoTKpJVcCfoEoNHOkc
   -----END CERTIFICATE-----
-date: 2023-10-25 00:00:00.000000000 Z
+date: 2023-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubi