karafka-testing 2.4.0.rc1 → 2.4.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 587bb151db13812b7c26215c9357264f21a3357448fffe542363042db19c7744
-  data.tar.gz: 2c624b601afc5384ae7ce43bf6b0ac19f27a8ec8b00aacd796c33da5e19fdd40
+  metadata.gz: 91dfd9d61d189ef4382255dd90805291525c7ce596002f5932eddbf60d0ed4d4
+  data.tar.gz: c288612346f823379c454a2de964c6600a4705a99704c2261b78e8f685f33068
 SHA512:
-  metadata.gz: c70be00aeb884026f00025dc207219761ba5374e91980d89fffff2b4a76eef26098896cf60860d8f9dc088e8606569ab23c3b6ad6b75e31225ca6ad51f7296c4
-  data.tar.gz: 344b7a3176b89a1882656eb730a458093b580e25a4e6363472b3dd95f200999697c5216814fbecb4c214a50f231e6e32f46cca1af6c90a6274ce4b6b09f19e4d
+  metadata.gz: 49458d3a51b4d8ba2a6b073c67dd43a85d1987aa9a300a1047a5268d6f61ae85d4c60a587fe9e8078bec0c61a900b129a8272a931a81fef3f017d548d04ce83b
+  data.tar.gz: 27e88641a3c2b0795731bebddf56bb5a81159730152c8fb3859543af5dcdb8bca9f762e4edaaafee931ef8cfc6d18f62c44a2993c321d44b104160826922d974

data/CHANGELOG.md

@@ -2,7 +2,9 @@
 
 ## 2.4.0 (Unreleased)
 - **[Breaking]** Drop Ruby `2.7` support.
+- [Refactor] Extract common components for Minitest and RSpec.
 - [Fix] Support again `require: false` on gem loading.
+- [Fix] Fix a case where multiplexed SG would fail with `TopicInManyConsumerGroupsError`
 
 ## 2.3.2 (2024-04-03)
 - [Enhancement] Support `Minitest::Spec`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka-testing (2.4.0.rc1)
+    karafka-testing (2.4.0.rc2)
       karafka (>= 2.4.0.beta1, < 2.5.0)
       waterdrop (>= 2.7.0.rc1)
 

data/lib/karafka/testing/helpers.rb

@@ -0,0 +1,55 @@
+# frozen_string_literal: true
+
+module Karafka
+  module Testing
+    # Common helper methods that are shared in between RSpec and Minitest
+    module Helpers
+      class << self
+        # Finds all the routing topics matching requested topic within all topics or within
+        # provided consumer group based on name
+        #
+        # @param requested_topic [String] requested topic name
+        # @param requested_consumer_group [String] requested consumer group or nil to look in all
+        # @return [Array<Karafka::Routing::Topic>] all matching topics
+        #
+        # @note Since we run the lookup on subscription groups, the search will automatically
+        #   expand with matching patterns
+        def karafka_consumer_find_candidate_topics(requested_topic, requested_consumer_group)
+          karafka_consumer_find_subscription_groups(requested_consumer_group)
+            # multiplexed subscriptions of the same origin share name, thus we can reduced
+            # multiplexing to the first one as during testing, there is no multiplexing parallel
+            # execution anyhow
+            .uniq(&:name)
+            .map(&:topics)
+            .filter_map do |topics|
+              topics.find(requested_topic.to_s)
+            rescue Karafka::Errors::TopicNotFoundError
+              nil
+            end
+        end
+
+        # Finds subscription groups from the requested consumer group or selects all if no
+        # consumer group specified
+        # @param requested_consumer_group [String] requested consumer group or nil to look in all
+        # @return [Array<Karafka::Routing::SubscriptionGroup>] requested subscription groups
+        def karafka_consumer_find_subscription_groups(requested_consumer_group)
+          if requested_consumer_group && !requested_consumer_group.empty?
+            ::Karafka::App
+              .subscription_groups
+              # Find matching consumer group
+              .find { |cg, _sgs| cg.name == requested_consumer_group.to_s }
+              # Raise error if not found
+              .tap { |cg| cg || raise(Errors::ConsumerGroupNotFound, requested_consumer_group) }
+              # Since lookup was on a hash, get the value, that is subscription groups
+              .last
+          else
+            ::Karafka::App
+              .subscription_groups
+              .values
+              .flatten
+          end
+        end
+      end
+    end
+  end
+end

data/lib/karafka/testing/minitest/helpers.rb

@@ -2,6 +2,7 @@
 
 require 'karafka/testing'
 require 'karafka/testing/errors'
+require 'karafka/testing/helpers'
 require 'karafka/testing/spec_consumer_client'
 require 'karafka/testing/spec_producer_client'
 require 'karafka/testing/minitest/proxy'
@@ -56,7 +57,7 @@ module Karafka
         # @example Creates a consumer instance with settings for `my_requested_topic`
         #   consumer = @karafka.consumer_for(:my_requested_topic)
         def _karafka_consumer_for(requested_topic, requested_consumer_group = nil)
-          selected_topics = _karafka_consumer_find_candidate_topics(
+          selected_topics = Testing::Helpers.karafka_consumer_find_candidate_topics(
             requested_topic.to_s,
             requested_consumer_group.to_s
           )
@@ -169,48 +170,6 @@ module Karafka
           @consumer.instance_variable_set('@used', true)
           @consumer
         end
-
-        # Finds all the routing topics matching requested topic within all topics or within
-        # provided consumer group based on name
-        #
-        # @param requested_topic [String] requested topic name
-        # @param requested_consumer_group [String] requested consumer group or nil to look in all
-        # @return [Array<Karafka::Routing::Topic>] all matching topics
-        #
-        # @note Since we run the lookup on subscription groups, the search will automatically
-        #   expand with matching patterns
-        def _karafka_consumer_find_candidate_topics(requested_topic, requested_consumer_group)
-          _karafka_consumer_find_subscription_groups(requested_consumer_group)
-            .map(&:topics)
-            .filter_map do |topics|
-              topics.find(requested_topic.to_s)
-            rescue Karafka::Errors::TopicNotFoundError
-              nil
-            end
-            .uniq(&:consumer_group)
-        end
-
-        # Finds subscription groups from the requested consumer group or selects all if no
-        # consumer group specified
-        # @param requested_consumer_group [String] requested consumer group or nil to look in all
-        # @return [Array<Karafka::Routing::SubscriptionGroup>] requested subscription groups
-        def _karafka_consumer_find_subscription_groups(requested_consumer_group)
-          if requested_consumer_group && !requested_consumer_group.empty?
-            ::Karafka::App
-              .subscription_groups
-              # Find matching consumer group
-              .find { |cg, _sgs| cg.name == requested_consumer_group.to_s }
-              # Raise error if not found
-              .tap { |cg| cg || raise(Errors::ConsumerGroupNotFound, requested_consumer_group) }
-              # Since lookup was on a hash, get the value, that is subscription groups
-              .last
-          else
-            ::Karafka::App
-              .subscription_groups
-              .values
-              .flatten
-          end
-        end
       end
     end
   end

data/lib/karafka/testing/rspec/helpers.rb

@@ -3,6 +3,7 @@
 require 'waterdrop'
 require 'karafka/testing'
 require 'karafka/testing/errors'
+require 'karafka/testing/helpers'
 require 'karafka/testing/spec_consumer_client'
 require 'karafka/testing/spec_producer_client'
 require 'karafka/testing/rspec/proxy'
@@ -60,7 +61,7 @@ module Karafka
         #     subject(:consumer) { karafka.consumer_for(:my_requested_topic) }
         #   end
         def _karafka_consumer_for(requested_topic, requested_consumer_group = nil)
-          selected_topics = _karafka_consumer_find_candidate_topics(
+          selected_topics = Testing::Helpers.karafka_consumer_find_candidate_topics(
             requested_topic.to_s,
             requested_consumer_group.to_s
           )
@@ -179,48 +180,6 @@ module Karafka
           consumer.instance_variable_set('@used', true)
           consumer
         end
-
-        # Finds all the routing topics matching requested topic within all topics or within
-        # provided consumer group based on name
-        #
-        # @param requested_topic [String] requested topic name
-        # @param requested_consumer_group [String] requested consumer group or nil to look in all
-        # @return [Array<Karafka::Routing::Topic>] all matching topics
-        #
-        # @note Since we run the lookup on subscription groups, the search will automatically
-        #   expand with matching patterns
-        def _karafka_consumer_find_candidate_topics(requested_topic, requested_consumer_group)
-          _karafka_consumer_find_subscription_groups(requested_consumer_group)
-            .map(&:topics)
-            .filter_map do |topics|
-              topics.find(requested_topic.to_s)
-            rescue Karafka::Errors::TopicNotFoundError
-              nil
-            end
-            .uniq(&:consumer_group)
-        end
-
-        # Finds subscription groups from the requested consumer group or selects all if no
-        # consumer group specified
-        # @param requested_consumer_group [String] requested consumer group or nil to look in all
-        # @return [Array<Karafka::Routing::SubscriptionGroup>] requested subscription groups
-        def _karafka_consumer_find_subscription_groups(requested_consumer_group)
-          if requested_consumer_group && !requested_consumer_group.empty?
-            ::Karafka::App
-              .subscription_groups
-              # Find matching consumer group
-              .find { |cg, _sgs| cg.name == requested_consumer_group.to_s }
-              # Raise error if not found
-              .tap { |cg| cg || raise(Errors::ConsumerGroupNotFound, requested_consumer_group) }
-              # Since lookup was on a hash, get the value, that is subscription groups
-              .last
-          else
-            ::Karafka::App
-              .subscription_groups
-              .values
-              .flatten
-          end
-        end
       end
     end
   end

data/lib/karafka/testing/version.rb

@@ -4,6 +4,6 @@
 module Karafka
   module Testing
     # Current version of gem. It should match Karafka framework version
-    VERSION = '2.4.0.rc1'
+    VERSION = '2.4.0.rc2'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka-testing
 version: !ruby/object:Gem::Version
-  version: 2.4.0.rc1
+  version: 2.4.0.rc2
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -35,7 +35,7 @@ cert_chain:
   AnG1dJU+yL2BK7vaVytLTstJME5mepSZ46qqIJXMuWob/YPDmVaBF39TDSG9e34s
   msG3BiCqgOgHAnL23+CN3Rt8MsuRfEtoTKpJVcCfoEoNHOkc
   -----END CERTIFICATE-----
-date: 2024-04-10 00:00:00.000000000 Z
+date: 2024-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: karafka
@@ -97,6 +97,7 @@ files:
 - lib/karafka-testing.rb
 - lib/karafka/testing.rb
 - lib/karafka/testing/errors.rb
+- lib/karafka/testing/helpers.rb
 - lib/karafka/testing/minitest/helpers.rb
 - lib/karafka/testing/minitest/proxy.rb
 - lib/karafka/testing/rspec/helpers.rb