karafka-rdkafka 0.23.1.rc2-aarch64-linux-gnu → 0.24.0-aarch64-linux-gnu

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fb20d24f1ec1ea3caa230a576ac75a0f8d90549424783cee28c13c6f017893ab
-  data.tar.gz: 6c506eb1ed456a401fcaa4e703b8aa2252781a44be6b975e9cf2f8ac98b4999e
+  metadata.gz: a7058149bcea613963a7df4058b47b47a06992c5e864fff26f9fe3c15bfff12a
+  data.tar.gz: e4a861f2d1601e014b40ea380a5483863db3e13c0d89def2cdf6d1bb5627942e
 SHA512:
-  metadata.gz: f9a422050827abd2633eb735d5068acf18ad6ed4e0d078f37c79c374bab84627bab8c18286546cbfc1dee748193b404e54c6464ad9b866df59f1abac2322a78d
-  data.tar.gz: 90e7bffcca1b4f6ce6e194709cebaf282140f0e7c83895528ac4d28429ce3ed9ee30933fde1bdf84b4d99ce5c09664d2e138ac9041a05903392aca288297e3ce
+  metadata.gz: 0e4ec74b36320789abab70a0a2fa1283a7dec08949552c4ab5b1a96a40ede4a8b40a4ac1d44dc9089d306aba33483b16e8070ee008fc6638c5e907ca63ade985
+  data.tar.gz: '089aa71eccc39df14e639d8d10822050444e2475b2c13eaa5d0486d0722f13e837eaace7c73dfbe26aad303bdab3446b7728f38cb75ce904575523dd7c91f1e7'

data/CHANGELOG.md

@@ -1,6 +1,26 @@
 # Rdkafka Changelog
 
-## 0.23.1 (Unreleased)
+## 0.24.0 (2026-02-25)
+- **[Feature]** Add `Producer#queue_size` (and `#queue_length` alias) to report the number of messages waiting in the librdkafka output queue. Useful for monitoring producer backpressure, implementing custom flow control, debugging message delivery issues, and graceful shutdown logic.
+- **[Feature]** Add fiber scheduler API for integration with Ruby fiber schedulers (Falcon, Async) and custom event loops (from upstream). Expose `enable_queue_io_events` and `enable_background_queue_io_events` methods on `Consumer`, `Producer`, and `Admin`.
+- **[Deprecation]** `AbstractHandle#wait` parameter `max_wait_timeout` (seconds) is deprecated in favor of `max_wait_timeout_ms` (milliseconds). The old parameter still works with backwards compatibility but will be removed in v1.0.0.
+- **[Deprecation]** `PartitionsCountCache` constructor parameter `ttl` (seconds) is deprecated in favor of `ttl_ms` (milliseconds). The old parameter still works with backwards compatibility but will be removed in v1.0.0.
+- [Enhancement] Add Ruby 4.0 support.
+- [Enhancement] Add `Rdkafka::Defaults` module with centralized timeout constants (aligning with upstream refactor).
+- [Enhancement] Add `run_polling_thread` parameter to `Config#producer` and `Config#admin` for fiber scheduler integration (from upstream).
+- [Enhancement] Extract all hardcoded timeout values to named constants for better maintainability and discoverability.
+- [Enhancement] Add `timeout_ms` parameter to `Consumer#each` for configurable poll timeout (from upstream).
+- [Enhancement] Extract non-time configuration values (`METADATA_MAX_RETRIES`, `PARTITIONS_COUNT_CACHE_TTL_MS`) to `Rdkafka::Defaults` module (from upstream).
+- [Enhancement] Add descriptive error messages for glibc compatibility issues with instructions for resolution (from upstream).
+- [Enhancement] Use native ARM64 runners instead of QEMU emulation for Alpine musl aarch64 builds, improving build performance and reliability (from upstream).
+- [Enhancement] Enable parallel compilation (`make -j$(nproc)`) for ARM64 Alpine musl builds (from upstream).
+- [Enhancement] Bump librdkafka to 2.13.0.
+- [Enhancement] Add non-blocking poll methods (`poll_nb`, `events_poll_nb`) that skip GVL release for efficient fiber scheduler integration when using `poll(0)` (from upstream).
+- [Enhancement] Add `events_poll_nb_each` method on `Producer`, `Consumer`, and `Admin` for polling events in a single GVL/mutex session. Yields count after each iteration, caller returns `:stop` to break (from upstream).
+- [Enhancement] Add `poll_nb_each` method on `Consumer` for non-blocking message polling with proper resource cleanup, yielding each message and supporting early termination via `:stop` return value (from upstream).
+- [Fix] Fix Kerberos build on Alpine 3.23+ (GCC 15/C23) by forcing C17 semantics to maintain compatibility with old-style K&R declarations in MIT Kerberos and Cyrus SASL dependencies.
+
+## 0.23.1 (2025-11-14)
 - **[Feature]** Add integrated fatal error handling in `RdkafkaError.validate!` - automatically detects and handles fatal errors (-150) with single entrypoint API.
 - [Enhancement] Add optional `client_ptr` parameter to `validate!` for automatic fatal error remapping to actual underlying error codes.
 - [Enhancement] Update all Producer and Consumer `validate!` calls to provide `client_ptr` for comprehensive fatal error handling.

data/Gemfile

@@ -3,3 +3,11 @@
 source "https://rubygems.org"
 
 gemspec
+
+group :development do
+  gem "ostruct"
+  gem "pry"
+  gem "rspec"
+  gem "simplecov"
+  gem "warning"
+end

data/Gemfile.lint

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+source "https://rubygems.org"
+
+# Documentation linting
+gem "yard-lint"
+
+# Code style (StandardRB via RuboCop)
+gem "standard"
+gem "standard-performance"
+gem "rubocop-performance"
+gem "rubocop-rspec"
+gem "standard-rspec"
+gem "rubocop-thread_safety"

data/Gemfile.lint.lock

@@ -0,0 +1,123 @@
+GEM
+  remote: https://rubygems.org/
+  specs:
+    ast (2.4.3)
+    json (2.18.0)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
+    parallel (1.27.0)
+    parser (3.3.10.1)
+      ast (~> 2.4.1)
+      racc
+    prism (1.8.0)
+    racc (1.8.1)
+    rainbow (3.1.1)
+    regexp_parser (2.11.3)
+    rubocop (1.82.1)
+      json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
+      parallel (~> 1.10)
+      parser (>= 3.3.0.2)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.48.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.49.0)
+      parser (>= 3.3.7.2)
+      prism (~> 1.7)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-factory_bot (2.28.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-performance (1.26.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
+    rubocop-rspec (3.9.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.81)
+    rubocop-rspec_rails (2.32.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-rspec (~> 3.5)
+    rubocop-thread_safety (0.7.3)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    ruby-progressbar (1.13.0)
+    standard (1.53.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.82.0)
+      standard-custom (~> 1.0.0)
+      standard-performance (~> 1.8)
+    standard-custom (1.0.2)
+      lint_roller (~> 1.0)
+      rubocop (~> 1.50)
+    standard-performance (1.9.0)
+      lint_roller (~> 1.1)
+      rubocop-performance (~> 1.26.0)
+    standard-rspec (0.4.0)
+      lint_roller (>= 1.0)
+      rubocop-capybara (~> 2.22)
+      rubocop-factory_bot (~> 2.27)
+      rubocop-rspec (~> 3.9)
+      rubocop-rspec_rails (~> 2.31)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.2.0)
+    yard (0.9.38)
+    yard-lint (1.4.0)
+      yard (~> 0.9)
+      zeitwerk (~> 2.6)
+    zeitwerk (2.7.4)
+
+PLATFORMS
+  ruby
+  x86_64-linux
+
+DEPENDENCIES
+  rubocop-performance
+  rubocop-rspec
+  rubocop-thread_safety
+  standard
+  standard-performance
+  standard-rspec
+  yard-lint
+
+CHECKSUMS
+  ast (2.4.3) sha256=954615157c1d6a382bc27d690d973195e79db7f55e9765ac7c481c60bdb4d383
+  json (2.18.0) sha256=b10506aee4183f5cf49e0efc48073d7b75843ce3782c68dbeb763351c08fd505
+  language_server-protocol (3.17.0.5) sha256=fd1e39a51a28bf3eec959379985a72e296e9f9acfce46f6a79d31ca8760803cc
+  lint_roller (1.1.0) sha256=2c0c845b632a7d172cb849cc90c1bce937a28c5c8ccccb50dfd46a485003cc87
+  parallel (1.27.0) sha256=4ac151e1806b755fb4e2dc2332cbf0e54f2e24ba821ff2d3dcf86bf6dc4ae130
+  parser (3.3.10.1) sha256=06f6a725d2cd91e5e7f2b7c32ba143631e1f7c8ae2fb918fc4cebec187e6a688
+  prism (1.8.0) sha256=84453a16ef5530ea62c5f03ec16b52a459575ad4e7b9c2b360fd8ce2c39c1254
+  racc (1.8.1) sha256=4a7f6929691dbec8b5209a0b373bc2614882b55fc5d2e447a21aaa691303d62f
+  rainbow (3.1.1) sha256=039491aa3a89f42efa1d6dec2fc4e62ede96eb6acd95e52f1ad581182b79bc6a
+  regexp_parser (2.11.3) sha256=ca13f381a173b7a93450e53459075c9b76a10433caadcb2f1180f2c741fc55a4
+  rubocop (1.82.1) sha256=09f1a6a654a960eda767aebea33e47603080f8e9c9a3f019bf9b94c9cab5e273
+  rubocop-ast (1.49.0) sha256=49c3676d3123a0923d333e20c6c2dbaaae2d2287b475273fddee0c61da9f71fd
+  rubocop-capybara (2.22.1) sha256=ced88caef23efea53f46e098ff352f8fc1068c649606ca75cb74650970f51c0c
+  rubocop-factory_bot (2.28.0) sha256=4b17fc02124444173317e131759d195b0d762844a71a29fe8139c1105d92f0cb
+  rubocop-performance (1.26.1) sha256=cd19b936ff196df85829d264b522fd4f98b6c89ad271fa52744a8c11b8f71834
+  rubocop-rspec (3.9.0) sha256=8fa70a3619408237d789aeecfb9beef40576acc855173e60939d63332fdb55e2
+  rubocop-rspec_rails (2.32.0) sha256=4a0d641c72f6ebb957534f539d9d0a62c47abd8ce0d0aeee1ef4701e892a9100
+  rubocop-thread_safety (0.7.3) sha256=067cdd52fbf5deffc18995437e45b5194236eaff4f71de3375a1f6052e48f431
+  ruby-progressbar (1.13.0) sha256=80fc9c47a9b640d6834e0dc7b3c94c9df37f08cb072b7761e4a71e22cff29b33
+  standard (1.53.0) sha256=f3c9493385db7079d0abce6f7582f553122156997b81258cd361d3480eeacf9c
+  standard-custom (1.0.2) sha256=424adc84179a074f1a2a309bb9cf7cd6bfdb2b6541f20c6bf9436c0ba22a652b
+  standard-performance (1.9.0) sha256=49483d31be448292951d80e5e67cdcb576c2502103c7b40aec6f1b6e9c88e3f2
+  standard-rspec (0.4.0) sha256=0fdf64c887cd6404f1c3a1435b14ba6fde2e9e80c0f4dafe4b04a67f673db262
+  unicode-display_width (3.2.0) sha256=0cdd96b5681a5949cdbc2c55e7b420facae74c4aaf9a9815eee1087cb1853c42
+  unicode-emoji (4.2.0) sha256=519e69150f75652e40bf736106cfbc8f0f73aa3fb6a65afe62fefa7f80b0f80f
+  yard (0.9.38) sha256=721fb82afb10532aa49860655f6cc2eaa7130889df291b052e1e6b268283010f
+  yard-lint (1.4.0) sha256=7dd88fbb08fd77cb840bea899d58812817b36d92291b5693dd0eeb3af9f91f0f
+  zeitwerk (2.7.4) sha256=2bef90f356bdafe9a6c2bd32bcd804f83a4f9b8bc27f3600fff051eb3edcec8b
+
+BUNDLED WITH
+  4.0.3

data/README.md

@@ -63,6 +63,7 @@ Contributions should generally be made to the upstream [rdkafka-ruby repository]
 
 | rdkafka-ruby | librdkafka | patches |
 |-|-|-|
+| 0.24.x (Unreleased) | 2.13.0 (2026-01-05) | yes |
 | 0.23.x (2025-11-01) | 2.12.1 (2025-10-16)  | yes |
 | 0.22.x (2025-09-26) | 2.11.1 (2025-08-18)  | yes |
 | 0.21.x (2025-08-18) | 2.11.0 (2025-07-03)  | yes |

data/Rakefile

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
-require 'bundler/gem_tasks'
+require "bundler/gem_tasks"
 require "./lib/rdkafka"
 
-desc 'Generate some message traffic'
+desc "Generate some message traffic"
 task :produce_messages do
-  config = {:"bootstrap.servers" => "localhost:9092"}
+  config = { "bootstrap.servers": "localhost:9092" }
   if ENV["DEBUG"]
     config[:debug] = "broker,topic,msg"
   end
@@ -15,24 +15,24 @@ task :produce_messages do
   100.times do |i|
     puts "Producing message #{i}"
     delivery_handles << producer.produce(
-        topic:   "rake_test_topic",
-        payload: "Payload #{i} from Rake",
-        key:     "Key #{i} from Rake"
+      topic: "rake_test_topic",
+      payload: "Payload #{i} from Rake",
+      key: "Key #{i} from Rake"
     )
   end
-  puts 'Waiting for delivery'
+  puts "Waiting for delivery"
   delivery_handles.each(&:wait)
-  puts 'Done'
+  puts "Done"
 end
 
-desc 'Consume some messages'
+desc "Consume some messages"
 task :consume_messages do
   config = {
-    :"bootstrap.servers" => "localhost:9092",
-    :"group.id" => "rake_test",
-    :"enable.partition.eof" => false,
-    :"auto.offset.reset" => "earliest",
-    :"statistics.interval.ms" => 10_000
+    "bootstrap.servers": "localhost:9092",
+    "group.id": "rake_test",
+    "enable.partition.eof": false,
+    "auto.offset.reset": "earliest",
+    "statistics.interval.ms": 10_000
   }
   if ENV["DEBUG"]
     config[:debug] = "cgrp,topic,fetch"
@@ -40,7 +40,7 @@ task :consume_messages do
   Rdkafka::Config.statistics_callback = lambda do |stats|
     puts stats
   end
-  consumer = Rdkafka::Config.new(config).consumer
+  Rdkafka::Config.new(config).consumer
   consumer = Rdkafka::Config.new(config).consumer
   consumer.subscribe("rake_test_topic")
   consumer.each do |message|
@@ -48,14 +48,14 @@ task :consume_messages do
   end
 end
 
-desc 'Hammer down'
+desc "Hammer down"
 task :load_test do
   puts "Starting load test"
 
   config = Rdkafka::Config.new(
-    :"bootstrap.servers" => "localhost:9092",
-    :"group.id" => "load-test",
-    :"enable.partition.eof" => false
+    "bootstrap.servers": "localhost:9092",
+    "group.id": "load-test",
+    "enable.partition.eof": false
   )
 
   # Create a producer in a thread
@@ -65,9 +65,9 @@ task :load_test do
       handles = []
       1000.times do |i|
         handles.push(producer.produce(
-          topic:   "load_test_topic",
+          topic: "load_test_topic",
           payload: "Payload #{i}",
-          key:     "Key #{i}"
+          key: "Key #{i}"
         ))
       end
       handles.each(&:wait)

data/docker-compose-ssl.yml

@@ -1,7 +1,7 @@
 services:
   kafka:
     container_name: kafka
-    image: confluentinc/cp-kafka:8.1.0
+    image: confluentinc/cp-kafka:8.1.1
     ports:
       - 9092:9092 # Support PLAINTEXT so we can run one docker setup for SSL and PLAINTEXT
       - 9093:9093

data/docker-compose.yml

@@ -1,7 +1,7 @@
 services:
   kafka:
     container_name: kafka
-    image: confluentinc/cp-kafka:8.1.0
+    image: confluentinc/cp-kafka:8.1.1
 
     ports:
       - 9092:9092

data/karafka-rdkafka.gemspec

@@ -1,52 +1,51 @@
 # frozen_string_literal: true
 
-require File.expand_path('lib/rdkafka/version', __dir__)
+require File.expand_path("lib/rdkafka/version", __dir__)
 
 Gem::Specification.new do |gem|
-  gem.authors = ['Thijs Cadier', 'Maciej Mensfeld']
+  gem.authors = ["Thijs Cadier", "Maciej Mensfeld"]
   gem.email = ["contact@karafka.io"]
   gem.description = "Modern Kafka client library for Ruby based on librdkafka"
   gem.summary = "The rdkafka gem is a modern Kafka client library for Ruby based on librdkafka. It wraps the production-ready C client using the ffi gem and targets Kafka 1.0+ and Ruby 2.7+."
-  gem.license = 'MIT'
+  gem.license = "MIT"
 
-  gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
-  gem.name = 'karafka-rdkafka'
-  gem.require_paths = ['lib']
+  gem.name = "karafka-rdkafka"
+  gem.require_paths = ["lib"]
   gem.version = Rdkafka::VERSION
-  gem.required_ruby_version = '>= 3.2'
+  gem.required_ruby_version = ">= 3.2"
 
   files = `git ls-files`.split($\)
   files = files.reject do |file|
-    next true if file.start_with?('.')
-    next true if file.start_with?('spec/')
-    next true if file.start_with?('ext/README.md')
+    next true if file.start_with?(".")
+    next true if file.start_with?("spec/")
+    next true if file.start_with?("ext/README.md")
 
     false
   end
 
-  if ENV['RUBY_PLATFORM']
-    gem.platform = ENV['RUBY_PLATFORM']
+  if ENV["RUBY_PLATFORM"]
+    gem.platform = ENV["RUBY_PLATFORM"]
 
     # Do not include the source code for librdkafka as it should be precompiled already per
     # platform. Same applies to any possible patches.
     # Do not include github actions details in RubyGems releases
     gem.files = files.reject do |file|
-      next true if file.start_with?('dist/')
-      next true if file.start_with?('ext/build_')
-      next true if file.start_with?('ext/ci_')
-      next true if file.start_with?('ext/Rakefile')
-      next true if file.start_with?('ext/generate-')
+      next true if file.start_with?("dist/")
+      next true if file.start_with?("ext/build_")
+      next true if file.start_with?("ext/ci_")
+      next true if file.start_with?("ext/Rakefile")
+      next true if file.start_with?("ext/generate-")
 
       false
     end
 
     # Add the compiled extensions that exist (not in git)
-    if File.exist?('ext/librdkafka.so')
-      gem.files << 'ext/librdkafka.so'
+    if File.exist?("ext/librdkafka.so")
+      gem.files << "ext/librdkafka.so"
     end
 
-    if File.exist?('ext/librdkafka.dylib')
-      gem.files << 'ext/librdkafka.dylib'
+    if File.exist?("ext/librdkafka.dylib")
+      gem.files << "ext/librdkafka.dylib"
     end
   else
     gem.platform = Gem::Platform::RUBY
@@ -54,39 +53,32 @@ Gem::Specification.new do |gem|
     # Do not include code used for building native extensions
     # Do not include github actions details in RubyGems releases
     gem.files = files.reject do |file|
-      next true if file.start_with?('ext/build_')
-      next true if file.start_with?('ext/ci_')
-      next true if file.start_with?('ext/generate-')
-      next false unless file.start_with?('dist/')
-      next false if file.start_with?('dist/patches')
-      next false if file.start_with?('dist/librdkafka-')
+      next true if file.start_with?("ext/build_")
+      next true if file.start_with?("ext/ci_")
+      next true if file.start_with?("ext/generate-")
+      next false unless file.start_with?("dist/")
+      next false if file.start_with?("dist/patches")
+      next false if file.start_with?("dist/librdkafka-")
 
       true
     end
 
-    gem.extensions = %w(ext/Rakefile)
+    gem.extensions = %w[ext/Rakefile]
   end
 
-  gem.add_dependency 'ffi', '~> 1.17.1'
-  gem.add_dependency 'json', '> 2.0'
-  gem.add_dependency 'logger'
-  gem.add_dependency 'mini_portile2', '~> 2.6'
-  gem.add_dependency 'rake', '> 12'
-
-  gem.add_development_dependency 'ostruct'
-  gem.add_development_dependency 'pry'
-  gem.add_development_dependency 'rspec', '~> 3.5'
-  gem.add_development_dependency 'rake'
-  gem.add_development_dependency 'simplecov'
-  gem.add_development_dependency 'warning'
+  gem.add_dependency "ffi", "~> 1.17.1"
+  gem.add_dependency "json", "> 2.0"
+  gem.add_dependency "logger"
+  gem.add_dependency "mini_portile2", "~> 2.6"
+  gem.add_dependency "rake", "> 12"
 
   gem.metadata = {
-    'funding_uri' => 'https://karafka.io/#become-pro',
-    'homepage_uri' => 'https://karafka.io',
-    'changelog_uri' => 'https://karafka.io/docs/Changelog-Karafka-Rdkafka/',
-    'bug_tracker_uri' => 'https://github.com/karafka/karafka-rdkafka/issues',
-    'source_code_uri' => 'https://github.com/karafka/karafka-rdkafka',
-    'documentation_uri' => 'https://karafka.io/docs',
-    'rubygems_mfa_required' => 'true'
+    "funding_uri" => "https://karafka.io/#become-pro",
+    "homepage_uri" => "https://karafka.io",
+    "changelog_uri" => "https://karafka.io/docs/Changelog-Karafka-Rdkafka/",
+    "bug_tracker_uri" => "https://github.com/karafka/karafka-rdkafka/issues",
+    "source_code_uri" => "https://github.com/karafka/karafka-rdkafka",
+    "documentation_uri" => "https://karafka.io/docs",
+    "rubygems_mfa_required" => "true"
   }
 end

data/lib/rdkafka/abstract_handle.rb

@@ -54,16 +54,34 @@ module Rdkafka
     # If there is a timeout this does not mean the operation failed, rdkafka might still be working
     # on the operation. In this case it is possible to call wait again.
     #
-    # @param max_wait_timeout [Numeric, nil] Amount of time to wait before timing out.
-    #   If this is nil we will wait forever
+    # @param max_wait_timeout [Numeric, nil] DEPRECATED: Use max_wait_timeout_ms instead.
+    #   Amount of time in seconds to wait before timing out. Will be removed in v1.0.0.
+    # @param max_wait_timeout_ms [Numeric, nil] Amount of time in milliseconds to wait before
+    #   timing out. If this is nil we will wait forever. Defaults to 60,000ms (60 seconds).
     # @param raise_response_error [Boolean] should we raise error when waiting finishes
     #
     # @return [Object] Operation-specific result
     #
     # @raise [RdkafkaError] When the operation failed
     # @raise [WaitTimeoutError] When the timeout has been reached and the handle is still pending
-    def wait(max_wait_timeout: 60, raise_response_error: true)
-      timeout = max_wait_timeout ? monotonic_now + max_wait_timeout : MAX_WAIT_TIMEOUT_FOREVER
+    def wait(max_wait_timeout: :not_provided, max_wait_timeout_ms: :not_provided, raise_response_error: true)
+      # Determine which timeout value to use
+      if max_wait_timeout != :not_provided && max_wait_timeout_ms != :not_provided
+        warn "DEPRECATION WARNING: Both max_wait_timeout and max_wait_timeout_ms were provided. " \
+             "Using max_wait_timeout_ms. The max_wait_timeout parameter is deprecated and will be removed in v1.0.0."
+        timeout_ms = max_wait_timeout_ms
+      elsif max_wait_timeout != :not_provided
+        warn "DEPRECATION WARNING: max_wait_timeout (seconds) is deprecated. " \
+             "Use max_wait_timeout_ms (milliseconds) instead. This parameter will be removed in v1.0.0."
+        timeout_ms = max_wait_timeout ? (max_wait_timeout * 1000).to_i : nil
+      elsif max_wait_timeout_ms == :not_provided
+        timeout_ms = Defaults::HANDLE_WAIT_TIMEOUT_MS
+      else
+        timeout_ms = max_wait_timeout_ms
+      end
+
+      timeout_s = timeout_ms ? timeout_ms / 1000.0 : nil
+      timeout = timeout_s ? monotonic_now + timeout_s : MAX_WAIT_TIMEOUT_FOREVER
 
       @mutex.synchronize do
         loop do
@@ -74,7 +92,7 @@ module Rdkafka
               @resource.wait(@mutex, to_wait)
             else
               raise WaitTimeoutError.new(
-                "Waiting for #{operation_name} timed out after #{max_wait_timeout} seconds"
+                "Waiting for #{operation_name} timed out after #{timeout_ms} ms"
               )
             end
           elsif self[:response] != Rdkafka::Bindings::RD_KAFKA_RESP_ERR_NO_ERROR && raise_response_error

data/lib/rdkafka/admin/acl_binding_result.rb

@@ -3,17 +3,17 @@
 module Rdkafka
   class Admin
     # Extracts attributes of rd_kafka_AclBinding_t
-    #
     class AclBindingResult
       attr_reader :result_error, :error_string, :matching_acl_resource_type,
-                  :matching_acl_resource_name, :matching_acl_resource_pattern_type,
-                  :matching_acl_principal, :matching_acl_host, :matching_acl_operation,
-                  :matching_acl_permission_type
+        :matching_acl_resource_name, :matching_acl_resource_pattern_type,
+        :matching_acl_principal, :matching_acl_host, :matching_acl_operation,
+        :matching_acl_permission_type
 
       # This attribute was initially released under the name that is now an alias
       # We keep it for backwards compatibility but it was changed for the consistency
-      alias matching_acl_pattern_type matching_acl_resource_pattern_type
+      alias_method :matching_acl_pattern_type, :matching_acl_resource_pattern_type
 
+      # @param matching_acl [FFI::Pointer] pointer to the ACL binding struct
       def initialize(matching_acl)
         rd_kafka_error_pointer = Rdkafka::Bindings.rd_kafka_AclBinding_error(matching_acl)
         @result_error = Rdkafka::Bindings.rd_kafka_error_code(rd_kafka_error_pointer)

data/lib/rdkafka/admin/config_resource_binding_result.rb

@@ -6,6 +6,7 @@ module Rdkafka
     class ConfigResourceBindingResult
       attr_reader :name, :type, :configs, :configs_count
 
+      # @param config_resource_ptr [FFI::Pointer] pointer to the config resource struct
       def initialize(config_resource_ptr)
         ffi_binding = Bindings::ConfigResource.new(config_resource_ptr)
 

data/lib/rdkafka/admin/create_acl_handle.rb

@@ -2,10 +2,11 @@
 
 module Rdkafka
   class Admin
+    # Handle for create ACL operation
     class CreateAclHandle < AbstractHandle
       layout :pending, :bool,
-             :response, :int,
-             :response_string, :pointer
+        :response, :int,
+        :response_string, :pointer
 
       # @return [String] the name of the operation
       def operation_name
@@ -17,10 +18,12 @@ module Rdkafka
         CreateAclReport.new(rdkafka_response: self[:response], rdkafka_response_string: self[:response_string])
       end
 
+      # Raises an error if the operation failed
+      # @raise [RdkafkaError]
       def raise_error
         raise RdkafkaError.new(
-            self[:response],
-            broker_message: self[:response_string].read_string
+          self[:response],
+          broker_message: self[:response_string].read_string
         )
       end
     end

data/lib/rdkafka/admin/create_acl_report.rb

@@ -2,17 +2,18 @@
 
 module Rdkafka
   class Admin
+    # Report for create ACL operation result
     class CreateAclReport
-
       # Upon successful creation of Acl RD_KAFKA_RESP_ERR_NO_ERROR - 0 is returned as rdkafka_response
       # @return [Integer]
       attr_reader :rdkafka_response
 
-
       # Upon successful creation of Acl empty string will be returned as rdkafka_response_string
       # @return [String]
       attr_reader :rdkafka_response_string
 
+      # @param rdkafka_response [Integer] response code from librdkafka
+      # @param rdkafka_response_string [FFI::Pointer] pointer to response string
       def initialize(rdkafka_response:, rdkafka_response_string:)
         @rdkafka_response = rdkafka_response
         if rdkafka_response_string != FFI::Pointer::NULL

data/lib/rdkafka/admin/create_partitions_handle.rb

@@ -1,10 +1,11 @@
 module Rdkafka
   class Admin
+    # Handle for create partitions operation
     class CreatePartitionsHandle < AbstractHandle
       layout :pending, :bool,
-             :response, :int,
-             :error_string, :pointer,
-             :result_name, :pointer
+        :response, :int,
+        :error_string, :pointer,
+        :result_name, :pointer
 
       # @return [String] the name of the operation
       def operation_name
@@ -16,6 +17,8 @@ module Rdkafka
         CreatePartitionsReport.new(self[:error_string], self[:result_name])
       end
 
+      # Raises an error if the operation failed
+      # @raise [RdkafkaError]
       def raise_error
         RdkafkaError.validate!(
           self[:response],

data/lib/rdkafka/admin/create_partitions_report.rb

@@ -1,5 +1,6 @@
 module Rdkafka
   class Admin
+    # Report for create partitions operation result
     class CreatePartitionsReport < CreateTopicReport
     end
   end

data/lib/rdkafka/admin/create_topic_handle.rb

@@ -2,11 +2,12 @@
 
 module Rdkafka
   class Admin
+    # Handle for create topic operation
     class CreateTopicHandle < AbstractHandle
       layout :pending, :bool,
-             :response, :int,
-             :error_string, :pointer,
-             :result_name, :pointer
+        :response, :int,
+        :error_string, :pointer,
+        :result_name, :pointer
 
       # @return [String] the name of the operation
       def operation_name
@@ -18,6 +19,8 @@ module Rdkafka
         CreateTopicReport.new(self[:error_string], self[:result_name])
       end
 
+      # Raises an error if the operation failed
+      # @raise [RdkafkaError]
       def raise_error
         RdkafkaError.validate!(
           self[:response],