karafka-rdkafka 0.17.0 → 0.17.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f0a60c074ecbf580c271442ac5e86a2152acf2542fc88c841f3adf8de99a8326
-  data.tar.gz: ab81215e4a2d4d641521efbd8f0e679a169bea6920378fab237f8401b0b8f3ac
+  metadata.gz: c24a6e6092e6f39f66f81e4a1ab3e07fff2afb92df937232f5237e7602d1eea9
+  data.tar.gz: 1fcda4b35822c4c89c9a3a92ee67de8f2cb1f059f4e84f23cc12462c74bbd701
 SHA512:
-  metadata.gz: 9595e54c497e0018da1df9611d1b2dca8b4e03fab8ca5ef26e3e20da93fb2ccdc9c0f568ddf7c371fe4f59873187e653744f087afea1dc6ebfc57a151b572dfc
-  data.tar.gz: 6ce0c6d3baee8e939dcfe1867771d2ca41b8d8c9d6018a5d00e63e5c9d79c499beebfdca3f75d8624862351191e36d4ec20fb86fad3eaeb8f169dca2802e83c2
+  metadata.gz: dfc563c4b071bf6ee6a2595fbc98122eff9758fdfa90f297cd27541b14a39ad71ffa11290d0ddc02687c5aa6cbbdf8cf7a26594582595403f6bb05de9ef25273
+  data.tar.gz: 8d9644f980260d159cd26624fbbbb56360a3dd3e94cebabe0eb89775143379aeef1c46e96b8b5e82daa2e7a296c97b65cba821b48eb12f6b80c3e940ddaa04d6

data/CHANGELOG.md

@@ -1,10 +1,15 @@
 # Rdkafka Changelog
 
+## 0.17.1 (2024-08-01)
+- [Enhancement] Support ability to release patches to librdkafka.
+- [Patch] Patch cooperative-sticky assignments in librdkafka.
+
 ## 0.17.0 (2024-07-21)
 - [Enhancement] Bump librdkafka to 2.5.0
 
 ## 0.16.1 (2024-07-10)
 - [Feature] Add `#seek_by` to be able to seek for a message by topic, partition and offset (zinahia)
+- [Change] Remove old producer timeout API warnings.
 - [Fix] Switch to local release of librdkafka to mitigate its unavailability.
 
 ## 0.16.0 (2024-06-17)
@@ -26,6 +31,12 @@
 - **[Feature]** Oauthbearer token refresh callback (bruce-szalwinski-he)
 - **[Feature]** Support incremental config describe + alter API (mensfeld)
 - [Enhancement] name polling Thread as `rdkafka.native_kafka#<name>` (nijikon)
+- [Enhancement] Replace time poll based wait engine with an event based to improve response times on blocking operations and wait (nijikon + mensfeld)
+- [Enhancement] Allow for usage of the second regex engine of librdkafka by setting `RDKAFKA_DISABLE_REGEX_EXT` during build (mensfeld)
+- [Enhancement] name polling Thread as `rdkafka.native_kafka#<name>` (nijikon)
+- [Change] Allow for native kafka thread operations deferring and manual start for consumer, producer and admin.
+- [Change] The `wait_timeout` argument in `AbstractHandle.wait` method is deprecated and will be removed in future versions without replacement. We don't rely on it's value anymore (nijikon)
+- [Fix] Fix bogus case/when syntax. Levels 1, 2, and 6 previously defaulted to UNKNOWN (jjowdy)
 
 ## 0.14.11 (2024-07-10)
 - [Fix] Switch to local release of librdkafka to mitigate its unavailability.

data/README.md

@@ -161,13 +161,14 @@ bundle exec rake produce_messages
 
 ## Versions
 
-| rdkafka-ruby | librdkafka |
-|-|-|
-| 0.17.0 (Unreleased) | 2.5.0 (2024-07-10) |
-| 0.16.0 (2024-06-13) | 2.4.0 (2024-05-07) |
-| 0.15.0 (2023-12-03) | 2.3.0 (2023-10-25) |
-| 0.14.0 (2023-11-21) | 2.2.0 (2023-07-12) |
-| 0.13.0 (2023-07-24) | 2.0.2 (2023-01-20) |
-| 0.12.0 (2022-06-17) | 1.9.0 (2022-06-16) |
-| 0.11.0 (2021-11-17) | 1.8.2 (2021-10-18) |
-| 0.10.0 (2021-09-07) | 1.5.0 (2020-07-20) |
+| rdkafka-ruby | librdkafka | patches |
+|-|-|-|
+| 0.17.0 (2024-08-01) | 2.5.0 (2024-07-10) | yes |
+| 0.17.0 (2024-07-21) | 2.5.0 (2024-07-10) | no  |
+| 0.16.0 (2024-06-13) | 2.4.0 (2024-05-07) | no  |
+| 0.15.0 (2023-12-03) | 2.3.0 (2023-10-25) | no  |
+| 0.14.0 (2023-11-21) | 2.2.0 (2023-07-12) | no  |
+| 0.13.0 (2023-07-24) | 2.0.2 (2023-01-20) | no  |
+| 0.12.0 (2022-06-17) | 1.9.0 (2022-06-16) | no  |
+| 0.11.0 (2021-11-17) | 1.8.2 (2021-10-18) | no  |
+| 0.10.0 (2021-09-07) | 1.5.0 (2020-07-20) | no  |

data/dist/patches/rdkafka_sticky_assignor.c.patch

@@ -0,0 +1,26 @@
+# This patch is released under the 2-clause BSD license, same as librdkafka
+# Fixes: https://github.com/confluentinc/librdkafka/issues/4783
+#
+--- librdkafka_2.5.0/src/rdkafka_sticky_assignor.c	2024-07-08 09:47:43.000000000 +0200
++++ librdkafka_2.5.0/src/rdkafka_sticky_assignor.c	2024-07-30 09:44:38.529759640 +0200
+@@ -769,7 +769,7 @@
+         const rd_kafka_topic_partition_list_t *partitions;
+         const char *consumer;
+         const rd_map_elem_t *elem;
+-        int i;
++        int i, j;
+ 
+         /* The assignment is balanced if minimum and maximum numbers of
+          * partitions assigned to consumers differ by at most one. */
+@@ -836,9 +836,9 @@
+ 
+                 /* Otherwise make sure it can't get any more partitions */
+ 
+-                for (i = 0; i < potentialTopicPartitions->cnt; i++) {
++                for (j = 0; j < potentialTopicPartitions->cnt; j++) {
+                         const rd_kafka_topic_partition_t *partition =
+-                            &potentialTopicPartitions->elems[i];
++                            &potentialTopicPartitions->elems[j];
+                         const char *otherConsumer;
+                         int otherConsumerPartitionCount;
+ 

data/docker-compose.yml

@@ -3,7 +3,7 @@ version: '2'
 services:
   kafka:
     container_name: kafka
-    image: confluentinc/cp-kafka:7.6.2
+    image: confluentinc/cp-kafka:7.7.0
 
     ports:
       - 9092:9092

data/ext/Rakefile

@@ -31,6 +31,8 @@ task :default => :clean do
     }
     recipe.configure_options = ["--host=#{recipe.host}"]
 
+    recipe.patch_files = Dir[File.join(releases, 'patches', "*.patch")].sort
+
     # Disable using libc regex engine in favor of the embedded one
     # The default regex engine of librdkafka does not always work exactly as most of the users
     # would expect, hence this flag allows for changing it to the other one
@@ -117,6 +119,7 @@ namespace :build do
     recipe = MiniPortile.new("librdkafka", version)
     recipe.files << "https://github.com/confluentinc/librdkafka/archive/#{ref}.tar.gz"
     recipe.configure_options = ["--host=#{recipe.host}","--enable-static", "--enable-zstd"]
+    recipe.patch_files = Dir[File.join(releases, 'patches', "*.patch")].sort
     recipe.cook
 
     ext = recipe.host.include?("darwin") ? "dylib" : "so"

data/lib/rdkafka/abstract_handle.rb

@@ -16,9 +16,6 @@ module Rdkafka
     REGISTRY = {}
     # Default wait timeout is 31 years
     MAX_WAIT_TIMEOUT_FOREVER = 10_000_000_000
-    # Deprecation message for wait_timeout argument in wait method
-    WAIT_TIMEOUT_DEPRECATION_MESSAGE = "The 'wait_timeout' argument is deprecated and will be removed in future versions without replacement. " \
-      "We don't rely on it's value anymore. Please refactor your code to remove references to it."
 
     private_constant :MAX_WAIT_TIMEOUT_FOREVER
 
@@ -59,16 +56,13 @@ module Rdkafka
     #
     # @param max_wait_timeout [Numeric, nil] Amount of time to wait before timing out.
     #   If this is nil we will wait forever
-    # @param wait_timeout [nil] deprecated
     # @param raise_response_error [Boolean] should we raise error when waiting finishes
     #
     # @return [Object] Operation-specific result
     #
     # @raise [RdkafkaError] When the operation failed
     # @raise [WaitTimeoutError] When the timeout has been reached and the handle is still pending
-    def wait(max_wait_timeout: 60, wait_timeout: nil, raise_response_error: true)
-      Kernel.warn(WAIT_TIMEOUT_DEPRECATION_MESSAGE) unless wait_timeout.nil?
-
+    def wait(max_wait_timeout: 60, raise_response_error: true)
       timeout = max_wait_timeout ? monotonic_now + max_wait_timeout : MAX_WAIT_TIMEOUT_FOREVER
 
       @mutex.synchronize do

data/lib/rdkafka/version.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Rdkafka
-  VERSION = "0.17.0"
+  VERSION = "0.17.1"
   LIBRDKAFKA_VERSION = "2.5.0"
   LIBRDKAFKA_SOURCE_SHA256 = "3dc62de731fd516dfb1032861d9a580d4d0b5b0856beb0f185d06df8e6c26259"
 end

data/spec/rdkafka/abstract_handle_spec.rb

@@ -80,7 +80,6 @@ describe Rdkafka::AbstractHandle do
       let(:pending_handle) { true }
 
       it "should wait until the timeout and then raise an error" do
-        expect(Kernel).not_to receive(:warn)
         expect {
           subject.wait(max_wait_timeout: 0.1)
         }.to raise_error Rdkafka::AbstractHandle::WaitTimeoutError, /test_operation/
@@ -90,22 +89,15 @@ describe Rdkafka::AbstractHandle do
     context 'when pending_handle false' do
       let(:pending_handle) { false }
 
-      it 'should show a deprecation warning when wait_timeout is set' do
-        expect(Kernel).to receive(:warn).with(Rdkafka::AbstractHandle::WAIT_TIMEOUT_DEPRECATION_MESSAGE)
-        subject.wait(wait_timeout: 0.1)
-      end
-
       context "without error" do
         let(:result) { 1 }
 
         it "should return a result" do
-          expect(Kernel).not_to receive(:warn)
           wait_result = subject.wait
           expect(wait_result).to eq(result)
         end
 
         it "should wait without a timeout" do
-          expect(Kernel).not_to receive(:warn)
           wait_result = subject.wait(max_wait_timeout: nil)
           expect(wait_result).to eq(result)
         end
@@ -115,7 +107,6 @@ describe Rdkafka::AbstractHandle do
         let(:response) { 20 }
 
         it "should raise an rdkafka error" do
-          expect(Kernel).not_to receive(:warn)
           expect {
             subject.wait
           }.to raise_error Rdkafka::RdkafkaError

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka-rdkafka
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.17.1
 platform: ruby
 authors:
 - Thijs Cadier
@@ -36,7 +36,7 @@ cert_chain:
   AnG1dJU+yL2BK7vaVytLTstJME5mepSZ46qqIJXMuWob/YPDmVaBF39TDSG9e34s
   msG3BiCqgOgHAnL23+CN3Rt8MsuRfEtoTKpJVcCfoEoNHOkc
   -----END CERTIFICATE-----
-date: 2024-07-21 00:00:00.000000000 Z
+date: 2024-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -187,6 +187,7 @@ files:
 - Rakefile
 - certs/cert_chain.pem
 - dist/librdkafka_2.5.0.tar.gz
+- dist/patches/rdkafka_sticky_assignor.c.patch
 - docker-compose.yml
 - ext/README.md
 - ext/Rakefile
@@ -286,7 +287,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
+rubygems_version: 3.5.11
 signing_key: 
 specification_version: 4
 summary: The rdkafka gem is a modern Kafka client library for Ruby based on librdkafka.