karafka-rdkafka 0.13.2 → 0.13.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8d216b3535772b9039cb4f81113f75b1f1262052282c3bb159c78095cddccf3a
-  data.tar.gz: ce7e3a921cd0c4a0da1b1d00c4af672949445b0ed05e325c975a3b8533e8a134
+  metadata.gz: c954a06b4461885d7648e8081d0426ebb895a82f1a27607f2224fc9e60843574
+  data.tar.gz: a25bf01b430920c7fd2cf22b0dd23ea1de9dd15d1b45f614025e97a3b725f8f3
 SHA512:
-  metadata.gz: 5acb41af183c6a101c5b7bc88166573c22f2e84516d060b1afb78c6d958b44ffc1b13bcdb08fd8891f16c16ebd6acdabea6c51131d58c30c93e86fe7e3f714dd
-  data.tar.gz: a8daa33c897782dfb3875e9e8be078f40ed40a97c926c809f9cb349689d78d1fdeec8bfb70ca1e7a88dadade9f70dcd74ece2e647c30ed3fb855a4dfb3495aa7
+  metadata.gz: afe480fedbbe5dc6f055709aaf3601acb17aaaa890f1c6e7423b90263eb8fa893de0e8b9bb571e6abf1c5fc0b8df2a6be2e5de4af1de1b68414204275981246e
+  data.tar.gz: 7bb81ff6dcbc95b018ede8bd986eda701f1f5f3bb3985684d436a38a2173f8753b01e1642780eb9ad52a65ad02e2b3b7d656c4259758c8571ef2858822384875

data/.github/workflows/ci.yml

@@ -1,6 +1,8 @@
 name: ci
 
-concurrency: ci-${{ github.ref }}
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
 
 on:
   pull_request:
@@ -20,6 +22,7 @@ jobs:
       fail-fast: false
       matrix:
         ruby:
+          - '3.3.0-preview2'
           - '3.2'
           - '3.1'
           - '3.1.0'
@@ -27,15 +30,18 @@ jobs:
           - '3.0.0'
           - '2.7'
           - '2.7.0'
-          - '2.6.8'
         include:
           - ruby: '3.2'
             coverage: 'true'
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Install package dependencies
         run: "[ -e $APT_DEPS ] || sudo apt-get install -y --no-install-recommends $APT_DEPS"
 
+      - name: Start Kafka with docker-compose
+        run: |
+          docker-compose up -d || (sleep 5 && docker-compose up -d)
+
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:
@@ -47,7 +53,6 @@ jobs:
           GITHUB_COVERAGE: ${{matrix.coverage}}
 
         run: |
-          docker-compose up -d --no-recreate
           bundle install --path vendor/bundle
           cd ext && bundle exec rake && cd ..
           bundle exec rspec

data/.gitignore

@@ -1,3 +1,6 @@
+# Ignore bundler config.
+/.bundle
+
 Gemfile.lock
 ext/ports
 ext/tmp
@@ -6,3 +9,4 @@ ext/librdkafka.*
 .yardoc
 doc
 coverage
+vendor

data/.rspec

@@ -1 +1,2 @@
+--require spec_helper
 --format documentation

data/.ruby-gemset

@@ -0,0 +1 @@
+rdkafka-ruby

data/.ruby-version

@@ -0,0 +1 @@
+3.2.2

data/CHANGELOG.md

@@ -1,11 +1,39 @@
-# 0.13.2
+# Rdkafka Changelog
+
+## 0.13.9 (2023-11-07)
+- [Enhancement] Expose alternative way of managing consumer events via a separate queue.
+- [Enhancement] Allow for setting `statistics_callback` as nil to reset predefined settings configured by a different gem.
+
+## 0.13.8 (2023-10-31)
+- [Enhancement] Get consumer position (thijsc & mensfeld)
+
+## 0.13.7 (2023-10-31)
+- [Change] Drop support for Ruby 2.6 due to incompatibilities in usage of `ObjectSpace::WeakMap`
+- [Fix] Fix dangling Opaque references.
+
+## 0.13.6 (2023-10-17)
+* **[Feature]** Support transactions API in the producer
+* [Enhancement] Add `raise_response_error` flag to the `Rdkafka::AbstractHandle`.
+* [Enhancement] Provide `#purge` to remove any outstanding requests from the producer.
+* [Enhancement] Fix `#flush` does not handle the timeouts errors by making it return true if all flushed or false if failed. We do **not** raise an exception here to keep it backwards compatible.
+
+## 0.13.5
+* Fix DeliveryReport `create_result#error` being nil despite an error being associated with it
+
+## 0.13.4
+* Always call initial poll on librdkafka to make sure oauth bearer cb is handled pre-operations.
+
+## 0.13.3
+* Bump librdkafka to 2.2.0
+
+## 0.13.2
 * Ensure operations counter decrement is fully thread-safe
 * Bump librdkafka to 2.1.1
 
-# 0.13.1
+## 0.13.1
 * Add offsets_for_times method on consumer (timflapper)
 
-# 0.13.0
+## 0.13.0 (2023-07-24)
 * Support cooperative sticky partition assignment in the rebalance callback (methodmissing)
 * Support both string and symbol header keys (ColinDKelley)
 * Handle tombstone messages properly (kgalieva)
@@ -26,32 +54,32 @@
 * Retry metadta fetches on certain errors with a backoff (mensfeld)
 * Do not lock access to underlying native kafka client and rely on Karafka granular locking (mensfeld)
 
-# 0.12.3
+## 0.12.3
 - Include backtrace in non-raised binded errors.
 - Include topic name in the delivery reports
 
-# 0.12.2
+## 0.12.2
 * Increase the metadata default timeout from 250ms to 2 seconds. This should allow for working with remote clusters.
 
-# 0.12.1
+## 0.12.1
 * Bumps librdkafka to 2.0.2 (lmaia)
 * Add support for adding more partitions via Admin API
 
-# 0.12.0
+## 0.12.0 (2022-06-17)
 * Bumps librdkafka to 1.9.0
 * Fix crash on empty partition key (mensfeld)
 * Pass the delivery handle to the callback (gvisokinskas)
 
-# 0.11.0
+## 0.11.0 (2021-11-17)
 * Upgrade librdkafka to 1.8.2
 * Bump supported minimum Ruby version to 2.6
 * Better homebrew path detection
 
-# 0.10.0
+## 0.10.0 (2021-09-07)
 * Upgrade librdkafka to 1.5.0
 * Add error callback config
 
-# 0.9.0
+## 0.9.0 (2021-06-23)
 * Fixes for Ruby 3.0
 * Allow any callable object for callbacks (gremerritt)
 * Reduce memory allocations in Rdkafka::Producer#produce (jturkel)
@@ -59,13 +87,13 @@
 * Allow passing in topic configuration on create_topic (dezka)
 * Add each_batch method to consumer (mgrosso)
 
-# 0.8.1
+## 0.8.1 (2020-12-07)
 * Fix topic_flag behaviour and add tests for Metadata (geoff2k)
 * Add topic admin interface (geoff2k)
 * Raise an exception if @native_kafka is nil (geoff2k)
 * Option to use zstd compression (jasonmartens)
 
-# 0.8.0
+## 0.8.0 (2020-06-02)
 * Upgrade librdkafka to 1.4.0
 * Integrate librdkafka metadata API and add partition_key (by Adithya-copart)
 * Ruby 2.7 compatibility fix (by Geoff Thé)A
@@ -73,22 +101,22 @@
 * Don't override CPPFLAGS and LDFLAGS if already set on Mac (by Hiroshi Hatake)
 * Allow use of Rake 13.x and up (by Tomasz Pajor)
 
-# 0.7.0
+## 0.7.0 (2019-09-21)
 * Bump librdkafka to 1.2.0 (by rob-as)
 * Allow customizing the wait time for delivery report availability (by mensfeld)
 
-# 0.6.0
+## 0.6.0 (2019-07-23)
 * Bump librdkafka to 1.1.0 (by Chris Gaffney)
 * Implement seek (by breunigs)
 
-# 0.5.0
+## 0.5.0 (2019-04-11)
 * Bump librdkafka to 1.0.0 (by breunigs)
 * Add cluster and member information (by dmexe)
 * Support message headers for consumer & producer (by dmexe)
 * Add consumer rebalance listener (by dmexe)
 * Implement pause/resume partitions (by dmexe)
 
-# 0.4.2
+## 0.4.2 (2019-01-12)
 * Delivery callback for producer
 * Document list param of commit method
 * Use default Homebrew openssl location if present
@@ -97,10 +125,10 @@
 * Add support for storing message offsets
 * Add missing runtime dependency to rake
 
-# 0.4.1
+## 0.4.1 (2018-10-19)
 * Bump librdkafka to 0.11.6
 
-# 0.4.0
+## 0.4.0 (2018-09-24)
 * Improvements in librdkafka archive download
 * Add global statistics callback
 * Use Time for timestamps, potentially breaking change if you
@@ -112,34 +140,34 @@
 * Support committing a topic partition list
 * Add consumer assignment method
 
-# 0.3.5
+## 0.3.5 (2018-01-17)
 * Fix crash when not waiting for delivery handles
 * Run specs on Ruby 2.5
 
-# 0.3.4
+## 0.3.4 (2017-12-05)
 * Bump librdkafka to 0.11.3
 
-# 0.3.3
+## 0.3.3 (2017-10-27)
 * Fix bug that prevent display of `RdkafkaError` message
 
-# 0.3.2
+## 0.3.2 (2017-10-25)
 * `add_topic` now supports using a partition count
 * Add way to make errors clearer with an extra message
 * Show topics in subscribe error message
 * Show partition and topic in query watermark offsets error message
 
-# 0.3.1
+## 0.3.1 (2017-10-23)
 * Bump librdkafka to 0.11.1
 * Officially support ranges in `add_topic` for topic partition list.
 * Add consumer lag calculator
 
-# 0.3.0
+## 0.3.0 (2017-10-17)
 * Move both add topic methods to one `add_topic` in `TopicPartitionList`
 * Add committed offsets to consumer
 * Add query watermark offset to consumer
 
-# 0.2.0
+## 0.2.0 (2017-10-13)
 * Some refactoring and add inline documentation
 
-# 0.1.x
+## 0.1.x (2017-09-10)
 * Initial working version including producing and consuming

data/{LICENSE → MIT-LICENSE}

@@ -1,6 +1,7 @@
 The MIT License (MIT)
 
-Copyright (c) 2017 Thijs Cadier
+Copyright (c) 2017-2023 Thijs Cadier
+              2023, Maciej Mensfeld
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -1,26 +1,25 @@
 # Rdkafka
 
-[![Build Status](https://appsignal.semaphoreci.com/badges/rdkafka-ruby/branches/master.svg?style=shields)](https://appsignal.semaphoreci.com/projects/rdkafka-ruby)
+[![Build Status](https://github.com/karafka/rdkafka-ruby/actions/workflows/ci.yml/badge.svg)](https://github.com/karafka/rdkafka-ruby/actions/workflows/ci.yml)
 [![Gem Version](https://badge.fury.io/rb/rdkafka.svg)](https://badge.fury.io/rb/rdkafka)
-[![Maintainability](https://api.codeclimate.com/v1/badges/ecb1765f81571cccdb0e/maintainability)](https://codeclimate.com/github/appsignal/rdkafka-ruby/maintainability)
+[![Join the chat at https://slack.karafka.io](https://raw.githubusercontent.com/karafka/misc/master/slack.svg)](https://slack.karafka.io)
+
+> [!NOTE]
+> The `rdkafka-ruby` gem was created and developed by [AppSignal](https://www.appsignal.com/). Their impactful contributions have significantly shaped the Ruby Kafka and Karafka ecosystems. For robust monitoring, we highly recommend AppSignal.
+
+---
 
 The `rdkafka` gem is a modern Kafka client library for Ruby based on
-[librdkafka](https://github.com/edenhill/librdkafka/).
+[librdkafka](https://github.com/confluentinc/librdkafka/).
 It wraps the production-ready C client using the [ffi](https://github.com/ffi/ffi)
-gem and targets Kafka 1.0+ and Ruby versions that are under security or
-active maintenance. We remove Ruby version from our CI builds if they 
+gem and targets Kafka 1.0+ and Ruby versions under security or
+active maintenance. We remove a Ruby version from our CI builds when they 
 become EOL.
 
-`rdkafka` was written because we needed a reliable Ruby client for
-Kafka that supports modern Kafka at [AppSignal](https://appsignal.com).
-We run it in production on very high traffic systems.
-
-This gem only provides a high-level Kafka consumer. If you are running
-an older version of Kafka and/or need the legacy simple consumer we
-suggest using the [Hermann](https://github.com/reiseburo/hermann) gem.
+`rdkafka` was written because of the need for a reliable Ruby client for Kafka that supports modern Kafka at [AppSignal](https://appsignal.com). AppSignal runs it in production on very high-traffic systems.
 
 The most important pieces of a Kafka client are implemented. We're
-working towards feature completeness, you can track that here:
+working towards feature completeness. You can track that here:
 https://github.com/appsignal/rdkafka-ruby/milestone/1
 
 ## Table of content
@@ -39,7 +38,7 @@ https://github.com/appsignal/rdkafka-ruby/milestone/1
 ## Installation
 
 This gem downloads and compiles librdkafka when it is installed. If you
-have any problems installing the gem please open an issue.
+If you have any problems installing the gem, please open an issue.
 
 ## Usage
 
@@ -65,9 +64,9 @@ end
 
 ### Producing messages
 
-Produce a number of messages, put the delivery handles in an array and
+Produce a number of messages, put the delivery handles in an array, and
 wait for them before exiting. This way the messages will be batched and
-sent to Kafka in an efficient way.
+efficiently sent to Kafka.
 
 ```ruby
 config = {:"bootstrap.servers" => "localhost:9092"}
@@ -92,7 +91,7 @@ released until it `#close` is explicitly called, so be sure to call
 
 ## Higher level libraries
 
-Currently, there are two actively developed frameworks based on rdkafka-ruby, that provide higher level API that can be used to work with Kafka messages and one library for publishing messages.
+Currently, there are two actively developed frameworks based on rdkafka-ruby, that provide higher-level API that can be used to work with Kafka messages and one library for publishing messages.
 
 ### Message processing frameworks
 
@@ -105,7 +104,7 @@ Currently, there are two actively developed frameworks based on rdkafka-ruby, th
 
 ## Development
 
-A Docker Compose file is included to run Kafka and Zookeeper. To run
+A Docker Compose file is included to run Kafka. To run
 that:
 
 ```
@@ -123,7 +122,7 @@ DEBUG_PRODUCER=true bundle exec rspec
 DEBUG_CONSUMER=true bundle exec rspec
 ```
 
-After running the tests you can bring the cluster down to start with a
+After running the tests, you can bring the cluster down to start with a
 clean slate:
 
 ```
@@ -132,7 +131,7 @@ docker-compose down
 
 ## Example
 
-To see everything working run these in separate tabs:
+To see everything working, run these in separate tabs:
 
 ```
 bundle exec rake consume_messages

data/certs/cert_chain.pem

@@ -1,26 +1,26 @@
 -----BEGIN CERTIFICATE-----
 MIIEcDCCAtigAwIBAgIBATANBgkqhkiG9w0BAQsFADA/MRAwDgYDVQQDDAdjb250
 YWN0MRcwFQYKCZImiZPyLGQBGRYHa2FyYWZrYTESMBAGCgmSJomT8ixkARkWAmlv
-MB4XDTIyMDgxOTE3MjEzN1oXDTIzMDgxOTE3MjEzN1owPzEQMA4GA1UEAwwHY29u
+MB4XDTIzMDgyMTA3MjU1NFoXDTI0MDgyMDA3MjU1NFowPzEQMA4GA1UEAwwHY29u
 dGFjdDEXMBUGCgmSJomT8ixkARkWB2thcmFma2ExEjAQBgoJkiaJk/IsZAEZFgJp
-bzCCAaIwDQYJKoZIhvcNAQEBBQADggGPADCCAYoCggGBAODzeO3L6lxdATzMHKNW
-jFA/GGunoPuylO/BMzy8RiQHh7VIvysAKs0tHhTx3g2D0STDpF+hcQcPELFikiT2
-F+1wOHj/SsrK7VKqfA8+gq04hKc5sQoX2Egf9k3V0YJ3eZ6R/koHkQ8A0TVt0w6F
-ZQckoV4MqnEAx0g/FZN3mnHTlJ3VFLSBqJEIe+S6FZMl92mSv+hTrlUG8VaYxSfN
-lTCvnKk284F6QZq5XIENLRmcDd/3aPBLnLwNnyMyhB+6gK8cUO+CFlDO5tjo/aBA
-rUnl++wGG0JooF1ed0v+evOn9KoMBG6rHewcf79qJbVOscbD8qSAmo+sCXtcFryr
-KRMTB8gNbowJkFRJDEe8tfRy11u1fYzFg/qNO82FJd62rKAw2wN0C29yCeQOPRb1
-Cw9Y4ZwK9VFNEcV9L+3pHTHn2XfuZHtDaG198VweiF6raFO4yiEYccodH/USP0L5
-cbcCFtmu/4HDSxL1ByQXO84A0ybJuk3/+aPUSXe9C9U8fwIDAQABo3cwdTAJBgNV
-HRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHQ4EFgQUSlcEakb7gfn/5E2WY6z73BF/
-iZkwHQYDVR0RBBYwFIESY29udGFjdEBrYXJhZmthLmlvMB0GA1UdEgQWMBSBEmNv
-bnRhY3RAa2FyYWZrYS5pbzANBgkqhkiG9w0BAQsFAAOCAYEA1aS+E7RXJ1w9g9mJ
-G0NzFxe64OEuENosNlvYQCbRKGCXAU1qqelYkBQHseRgRKxLICrnypRo9IEobyHa
-vDnJ4r7Tsb34dleqQW2zY/obG+cia3Ym2JsegXWF7dDOzCXJ4FN8MFoT2jHlqLLw
-yrap0YO5zx0GSQ0Dwy8h2n2v2vanMEeCx7iNm3ERgR5WuN5sjzWoz2A/JLEEcK0C
-EnAGKCWAd1fuG8IemDjT1edsd5FyYR4bIX0m+99oDuFZyPiiIbalmyYiSBBp59Yb
-Q0P8zeBi4OfwCZNcxqz0KONmw9JLNv6DgyEAH5xe/4JzhMEgvIRiPj0pHfA7oqQF
-KUNqvD1KlxbEC+bZfE5IZhnqYLdld/Ksqd22FI1RBhiS1Ejfsj99LVIm9cBuZEY2
-Qf04B9ceLUaC4fPVEz10FyobjaFoY4i32xRto3XnrzeAgfEe4swLq8bQsR3w/EF3
-MGU0FeSV2Yj7Xc2x/7BzLK8xQn5l7Yy75iPF+KP3vVmDHnNl
+bzCCAaIwDQYJKoZIhvcNAQEBBQADggGPADCCAYoCggGBAOuZpyQKEwsTG9plLat7
+8bUaNuNBEnouTsNMr6X+XTgvyrAxTuocdsyP1sNCjdS1B8RiiDH1/Nt9qpvlBWon
+sdJ1SYhaWNVfqiYStTDnCx3PRMmHRdD4KqUWKpN6VpZ1O/Zu+9Mw0COmvXgZuuO9
+wMSJkXRo6dTCfMedLAIxjMeBIxtoLR2e6Jm6MR8+8WYYVWrO9kSOOt5eKQLBY7aK
+b/Dc40EcJKPg3Z30Pia1M9ZyRlb6SOj6SKpHRqc7vbVQxjEw6Jjal1lZ49m3YZMd
+ArMAs9lQZNdSw5/UX6HWWURLowg6k10RnhTUtYyzO9BFev0JFJftHnmuk8vtb+SD
+5VPmjFXg2VOcw0B7FtG75Vackk8QKfgVe3nSPhVpew2CSPlbJzH80wChbr19+e3+
+YGr1tOiaJrL6c+PNmb0F31NXMKpj/r+n15HwlTMRxQrzFcgjBlxf2XFGnPQXHhBm
+kp1OFnEq4GG9sON4glRldkwzi/f/fGcZmo5fm3d+0ZdNgwIDAQABo3cwdTAJBgNV
+HRMEAjAAMAsGA1UdDwQEAwIEsDAdBgNVHQ4EFgQUPVH5+dLA80A1kJ2Uz5iGwfOa
+1+swHQYDVR0RBBYwFIESY29udGFjdEBrYXJhZmthLmlvMB0GA1UdEgQWMBSBEmNv
+bnRhY3RAa2FyYWZrYS5pbzANBgkqhkiG9w0BAQsFAAOCAYEAnpa0jcN7JzREHMTQ
+bfZ+xcvlrzuROMY6A3zIZmQgbnoZZNuX4cMRrT1p1HuwXpxdpHPw7dDjYqWw3+1h
+3mXLeMuk7amjQpYoSWU/OIZMhIsARra22UN8qkkUlUj3AwTaChVKN/bPJOM2DzfU
+kz9vUgLeYYFfQbZqeI6SsM7ltilRV4W8D9yNUQQvOxCFxtLOetJ00fC/E7zMUzbK
+IBwYFQYsbI6XQzgAIPW6nGSYKgRhkfpmquXSNKZRIQ4V6bFrufa+DzD0bt2ZA3ah
+fMmJguyb5L2Gf1zpDXzFSPMG7YQFLzwYz1zZZvOU7/UCpQsHpID/YxqDp4+Dgb+Y
+qma0whX8UG/gXFV2pYWpYOfpatvahwi+A1TwPQsuZwkkhi1OyF1At3RY+hjSXyav
+AnG1dJU+yL2BK7vaVytLTstJME5mepSZ46qqIJXMuWob/YPDmVaBF39TDSG9e34s
+msG3BiCqgOgHAnL23+CN3Rt8MsuRfEtoTKpJVcCfoEoNHOkc
 -----END CERTIFICATE-----

data/docker-compose.yml

@@ -1,24 +1,25 @@
----
-
 version: '2'
 
 services:
-  zookeeper:
-    image: confluentinc/cp-zookeeper:5.2.6
-    environment:
-      ZOOKEEPER_CLIENT_PORT: 2181
-      ZOOKEEPER_TICK_TIME: 2000
-
   kafka:
-    image: confluentinc/cp-kafka:5.2.5-10
-    depends_on:
-      - zookeeper
+    container_name: kafka
+    image: confluentinc/cp-kafka:7.5.1
+
     ports:
       - 9092:9092
+
     environment:
-      KAFKA_BROKER_ID: 1
-      KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
-      KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://localhost:29092,PLAINTEXT_HOST://localhost:9092
-      KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: PLAINTEXT:PLAINTEXT,PLAINTEXT_HOST:PLAINTEXT
+      CLUSTER_ID: kafka-docker-cluster-1
       KAFKA_INTER_BROKER_LISTENER_NAME: PLAINTEXT
       KAFKA_OFFSETS_TOPIC_REPLICATION_FACTOR: 1
+      KAFKA_PROCESS_ROLES: broker,controller
+      KAFKA_CONTROLLER_LISTENER_NAMES: CONTROLLER
+      KAFKA_LISTENERS: PLAINTEXT://:9092,CONTROLLER://:9093
+      KAFKA_LISTENER_SECURITY_PROTOCOL_MAP: CONTROLLER:PLAINTEXT,PLAINTEXT:PLAINTEXT
+      KAFKA_ADVERTISED_LISTENERS: PLAINTEXT://127.0.0.1:9092
+      KAFKA_BROKER_ID: 1
+      KAFKA_CONTROLLER_QUORUM_VOTERS: 1@127.0.0.1:9093
+      ALLOW_PLAINTEXT_LISTENER: 'yes'
+      KAFKA_AUTO_CREATE_TOPICS_ENABLE: 'true'
+      KAFKA_TRANSACTION_STATE_LOG_REPLICATION_FACTOR: 1
+      KAFKA_TRANSACTION_STATE_LOG_MIN_ISR: 1

data/ext/README.md

@@ -5,7 +5,7 @@ this gem is installed.
 
 To update the `librdkafka` version follow the following steps:
 
-* Go to https://github.com/edenhill/librdkafka/releases to get the new
+* Go to https://github.com/confluentinc/librdkafka/releases to get the new
   version number and asset checksum for `tar.gz`.
 * Change the version in `lib/rdkafka/version.rb`
 * Change the `sha256` in `lib/rdkafka/version.rb`

data/ext/Rakefile

@@ -17,7 +17,7 @@ task :default => :clean do
   end
 
   recipe.files << {
-    :url => "https://codeload.github.com/edenhill/librdkafka/tar.gz/v#{Rdkafka::LIBRDKAFKA_VERSION}",
+    :url => "https://codeload.github.com/confluentinc/librdkafka/tar.gz/v#{Rdkafka::LIBRDKAFKA_VERSION}",
     :sha256 => Rdkafka::LIBRDKAFKA_SOURCE_SHA256
   }
   recipe.configure_options = ["--host=#{recipe.host}"]

data/karafka-rdkafka.gemspec

@@ -4,7 +4,7 @@ require File.expand_path('lib/rdkafka/version', __dir__)
 
 Gem::Specification.new do |gem|
   gem.authors = ['Thijs Cadier']
-  gem.email = ["thijs@appsignal.com"]
+  gem.email = ["contact@karafka.io"]
   gem.description = "Modern Kafka client library for Ruby based on librdkafka"
   gem.summary = "The rdkafka gem is a modern Kafka client library for Ruby based on librdkafka. It wraps the production-ready C client using the ffi gem and targets Kafka 1.0+ and Ruby 2.4+."
   gem.license = 'MIT'
@@ -15,7 +15,7 @@ Gem::Specification.new do |gem|
   gem.name = 'karafka-rdkafka'
   gem.require_paths = ['lib']
   gem.version = Rdkafka::VERSION
-  gem.required_ruby_version = '>= 2.6'
+  gem.required_ruby_version = '>= 2.7'
   gem.extensions = %w(ext/Rakefile)
   gem.cert_chain = %w[certs/cert_chain.pem]
 

data/lib/rdkafka/abstract_handle.rb

@@ -1,28 +1,37 @@
 # frozen_string_literal: true
 
-require "ffi"
-
 module Rdkafka
+  # This class serves as an abstract base class to represent handles within the Rdkafka module.
+  # As a subclass of `FFI::Struct`, this class provides a blueprint for other specific handle
+  # classes to inherit from, ensuring they adhere to a particular structure and behavior.
+  #
+  # Subclasses must define their own layout, and the layout must start with:
+  #
+  # layout :pending, :bool,
+  #        :response, :int
   class AbstractHandle < FFI::Struct
-    # Subclasses must define their own layout, and the layout must start with:
-    #
-    # layout :pending, :bool,
-    #        :response, :int
+    include Helpers::Time
 
+    # Registry for registering all the handles.
     REGISTRY = {}
 
-    CURRENT_TIME = -> { Process.clock_gettime(Process::CLOCK_MONOTONIC) }.freeze
-
-    private_constant :CURRENT_TIME
+    class << self
+      # Adds handle to the register
+      #
+      # @param handle [AbstractHandle] any handle we want to register
+      def register(handle)
+        address = handle.to_ptr.address
+        REGISTRY[address] = handle
+      end
 
-    def self.register(handle)
-      address = handle.to_ptr.address
-      REGISTRY[address] = handle
+      # Removes handle from the register based on the handle address
+      #
+      # @param address [Integer] address of the registered handle we want to remove
+      def remove(address)
+        REGISTRY.delete(address)
+      end
     end
 
-    def self.remove(address)
-      REGISTRY.delete(address)
-    end
 
     # Whether the handle is still pending.
     #
@@ -32,29 +41,34 @@ module Rdkafka
     end
 
     # Wait for the operation to complete or raise an error if this takes longer than the timeout.
-    # If there is a timeout this does not mean the operation failed, rdkafka might still be working on the operation.
-    # In this case it is possible to call wait again.
+    # If there is a timeout this does not mean the operation failed, rdkafka might still be working
+    # on the operation. In this case it is possible to call wait again.
+    #
+    # @param max_wait_timeout [Numeric, nil] Amount of time to wait before timing out.
+    #   If this is nil it does not time out.
+    # @param wait_timeout [Numeric] Amount of time we should wait before we recheck if the
+    #   operation has completed
+    # @param raise_response_error [Boolean] should we raise error when waiting finishes
     #
-    # @param max_wait_timeout [Numeric, nil] Amount of time to wait before timing out. If this is nil it does not time out.
-    # @param wait_timeout [Numeric] Amount of time we should wait before we recheck if the operation has completed
+    # @return [Object] Operation-specific result
     #
     # @raise [RdkafkaError] When the operation failed
     # @raise [WaitTimeoutError] When the timeout has been reached and the handle is still pending
-    #
-    # @return [Object] Operation-specific result
-    def wait(max_wait_timeout: 60, wait_timeout: 0.1)
+    def wait(max_wait_timeout: 60, wait_timeout: 0.1, raise_response_error: true)
       timeout = if max_wait_timeout
-                  CURRENT_TIME.call + max_wait_timeout
+                  monotonic_now + max_wait_timeout
                 else
                   nil
                 end
       loop do
         if pending?
-          if timeout && timeout <= CURRENT_TIME.call
-            raise WaitTimeoutError.new("Waiting for #{operation_name} timed out after #{max_wait_timeout} seconds")
+          if timeout && timeout <= monotonic_now
+            raise WaitTimeoutError.new(
+              "Waiting for #{operation_name} timed out after #{max_wait_timeout} seconds"
+            )
           end
           sleep wait_timeout
-        elsif self[:response] != 0
+        elsif self[:response] != 0 && raise_response_error
           raise_error
         else
           return create_result
@@ -74,7 +88,7 @@ module Rdkafka
 
     # Allow subclasses to override
     def raise_error
-      raise RdkafkaError.new(self[:response])
+      RdkafkaError.validate!(self[:response])
     end
 
     # Error that is raised when waiting for the handle to complete

data/lib/rdkafka/admin/create_partitions_handle.rb

@@ -17,9 +17,12 @@ module Rdkafka
       end
 
       def raise_error
-        raise RdkafkaError.new(
-            self[:response],
-            broker_message: CreatePartitionsReport.new(self[:error_string], self[:result_name]).error_string
+        RdkafkaError.validate!(
+          self[:response],
+          broker_message: CreatePartitionsReport.new(
+            self[:error_string],
+            self[:result_name]
+          ).error_string
         )
       end
     end

data/lib/rdkafka/admin/create_topic_handle.rb

@@ -19,9 +19,12 @@ module Rdkafka
       end
 
       def raise_error
-        raise RdkafkaError.new(
-            self[:response],
-            broker_message: CreateTopicReport.new(self[:error_string], self[:result_name]).error_string
+        RdkafkaError.validate!(
+          self[:response],
+          broker_message: CreateTopicReport.new(
+            self[:error_string],
+            self[:result_name]
+          ).error_string
         )
       end
     end

data/lib/rdkafka/admin/delete_topic_handle.rb

@@ -19,9 +19,12 @@ module Rdkafka
       end
 
       def raise_error
-        raise RdkafkaError.new(
-            self[:response],
-            broker_message: DeleteTopicReport.new(self[:error_string], self[:result_name]).error_string
+        RdkafkaError.validate!(
+          self[:response],
+          broker_message: DeleteTopicReport.new(
+            self[:error_string],
+            self[:result_name]
+          ).error_string
         )
       end
     end