karafka-core 2.5.3 → 2.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8893405950939cce7d2c5f908984363927426b166cfe3afbd3a4ace9895acbe7
-  data.tar.gz: 19db627e288c6ae32af18be68691ca9cf4754447a6e4ee3f3a47ac8f8025ffb1
+  metadata.gz: 3c18e5fcc92a84b8eb5b27e5948947edb009da964e68861e63bfb54c6131a533
+  data.tar.gz: 3d1da54043e8f87a05ea8b9caba3a5c3fffba4bbe582f1dadb21444eb24d7f17
 SHA512:
-  metadata.gz: 5c680542fb2a726ec1339a2c157d6579a3bb76fac4204676721fc2ed75f52ef6ef1bd3c2ab03983e066603014d74e804a2e737656dfba55ad9858ae57cceda57
-  data.tar.gz: 4f27f566b94e246ff989edf08680574a336f3a9a85d46008d22c3de8abfbd7a7adac87158f51639d50a03efb502232bc20fc3ba29d081db596688b635985dac8
+  metadata.gz: 3e4bd0ec7a8e0ecc72317cf404a0b5be21025182043063d343ee75ac068c17d24a75c9679dcff6bae4b795592bdb66d649e9cedacec4e9d45416c7d0accf9103
+  data.tar.gz: 4a71c0c9f4cdb03136af352ae77fbe94de8ddd89f47c99f02c22f7634d52509298c3168c9e1487ef6fdf7dadda535bd324d6242552ac9ef501906247c7f77bf5

data/CHANGELOG.md

@@ -1,5 +1,8 @@
 # Karafka Core Changelog
 
+## 2.5.4 (2025-08-04)
+- [Fix] Fix old regression on misbehaviour when Object methods are overwritten.
+
 ## 2.5.3 (2025-08-04)
 - [Enhancement] Optimize code to mitigate the Ruby performance warning from `Karafka::Core::Configurable::Node` (#208)
 - [Enhancement] Raise errors on detected Ruby warnings.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka-core (2.5.3)
+    karafka-core (2.5.4)
       karafka-rdkafka (>= 0.19.2, < 0.21.0)
       logger (>= 1.6.0)
 

data/lib/karafka/core/configurable/node.rb

@@ -23,6 +23,7 @@ module Karafka
           @nestings = nestings
           @compiled = false
           @configs_refs = {}
+          @local_defs = Set.new
           instance_eval(&nestings)
         end
 
@@ -180,9 +181,18 @@ module Karafka
         #
         # @param value [Leaf]
         def build_accessors(value)
-          unless respond_to?(value.node_name.to_sym)
-            define_singleton_method(value.node_name) do
-              @configs_refs[value.node_name]
+          reader_name = value.node_name.to_sym
+          reader_respond = respond_to?(reader_name)
+          # There is a weird edge-case from 2020, where nodes would not redefine methods that
+          # would be defined on Object. Some of users were defining things like `#logger` on
+          # object and then we would not redefine it for nodes. This ensures that we only do not
+          # redefine our own definitions but we do redefine any user "accidentally" inherited
+          # methods
+          if reader_respond ? !@local_defs.include?(reader_name) : true
+            @local_defs << reader_name
+
+            define_singleton_method(reader_name) do
+              @configs_refs[reader_name]
             end
           end
 

data/lib/karafka/core/version.rb

@@ -4,6 +4,6 @@ module Karafka
   module Core
     # Current Karafka::Core version
     # We follow the versioning schema of given Karafka version
-    VERSION = '2.5.3'
+    VERSION = '2.5.4'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka-core
 version: !ruby/object:Gem::Version
-  version: 2.5.3
+  version: 2.5.4
 platform: ruby
 authors:
 - Maciej Mensfeld