karafka-core 2.5.2 → 2.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcd7aa040c5e5025430de4755c6e3de2850f8e697a8222328a304f571d9bd1fc
-  data.tar.gz: b3498c28bf38256e7012a950a51f464d66a503c045227f1dde0e503b6d9550c3
+  metadata.gz: 3c18e5fcc92a84b8eb5b27e5948947edb009da964e68861e63bfb54c6131a533
+  data.tar.gz: 3d1da54043e8f87a05ea8b9caba3a5c3fffba4bbe582f1dadb21444eb24d7f17
 SHA512:
-  metadata.gz: 350399becfcf8a702a9c106cb6f6310dc57255549fbe54cd7bbadae4e1c2c1e13efc53b9d60972c20c2a057775483461f73f60dc2839da964db39de47b7f608d
-  data.tar.gz: 4b94de1f08121280d3321dad105487e7b3e3ddaefe2ba2d4a3dd67a5c2fe3b23cb5588fa707d8ad513346c860749f9389431751b26c1688b19104a585bda4de6
+  metadata.gz: 3e4bd0ec7a8e0ecc72317cf404a0b5be21025182043063d343ee75ac068c17d24a75c9679dcff6bae4b795592bdb66d649e9cedacec4e9d45416c7d0accf9103
+  data.tar.gz: 4a71c0c9f4cdb03136af352ae77fbe94de8ddd89f47c99f02c22f7634d52509298c3168c9e1487ef6fdf7dadda535bd324d6242552ac9ef501906247c7f77bf5

data/.github/workflows/ci.yml

@@ -24,6 +24,7 @@ jobs:
       fail-fast: false
       matrix:
         ruby:
+          - '3.5.0-preview1'
           - '3.4'
           - '3.3'
           - '3.2'
@@ -40,7 +41,7 @@ jobs:
         run: "[ -e $APT_DEPS ] || sudo apt-get install -y --no-install-recommends $APT_DEPS"
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@13e7a03dc3ac6c3798f4570bfead2aed4d96abfb # v1.244.0
+        uses: ruby/setup-ruby@bb6434c747fa7022e12fa1cae2a0951fcffcff26 # v1.253.0
         with:
           ruby-version: ${{matrix.ruby}}
           bundler: 'latest'
@@ -71,7 +72,7 @@ jobs:
         with:
           fetch-depth: 0
       - name: Set up Ruby
-        uses: ruby/setup-ruby@13e7a03dc3ac6c3798f4570bfead2aed4d96abfb # v1.244.0
+        uses: ruby/setup-ruby@bb6434c747fa7022e12fa1cae2a0951fcffcff26 # v1.253.0
         with:
           ruby-version: 3.4
       - name: Install latest bundler

data/.github/workflows/push.yml

@@ -24,7 +24,7 @@ jobs:
           fetch-depth: 0
 
       - name: Set up Ruby
-        uses: ruby/setup-ruby@13e7a03dc3ac6c3798f4570bfead2aed4d96abfb # v1.244.0
+        uses: ruby/setup-ruby@bb6434c747fa7022e12fa1cae2a0951fcffcff26 # v1.253.0
         with:
           bundler-cache: false
 

data/.github/workflows/trigger-wiki-refresh.yml

@@ -0,0 +1,30 @@
+name: Trigger Wiki Refresh
+
+on:
+  release:
+    types: [published]
+  push:
+    branches: [master]
+
+jobs:
+  trigger-wiki-refresh:
+    runs-on: ubuntu-latest
+    environment: wiki-trigger
+    if: github.repository_owner == 'karafka'
+    steps:
+      - name: Trigger wiki refresh
+        uses: peter-evans/repository-dispatch@ff45666b9427631e3450c54a1bcbee4d9ff4d7c0 # v3.0.0
+        with:
+          token: ${{ secrets.WIKI_REPO_TOKEN }}
+          repository: karafka/wiki
+          event-type: sync-trigger
+          client-payload: |
+            {
+              "repository": "${{ github.repository }}",
+              "event_name": "${{ github.event_name }}",
+              "release_tag": "${{ github.event.release.tag_name || '' }}",
+              "release_name": "${{ github.event.release.name || '' }}",
+              "commit_sha": "${{ github.sha }}",
+              "commit_message": "Trigger Wiki Refresh",
+              "triggered_by": "${{ github.actor }}"
+            }

data/.github/workflows/verify-action-pins.yml

@@ -4,7 +4,7 @@ on:
     paths:
       - '.github/workflows/**'
 jobs:
-  verify:
+  verify_action_pins:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

data/.ruby-version

@@ -1 +1 @@
-3.4.4
+3.4.5

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Karafka Core Changelog
 
+## 2.5.4 (2025-08-04)
+- [Fix] Fix old regression on misbehaviour when Object methods are overwritten.
+
+## 2.5.3 (2025-08-04)
+- [Enhancement] Optimize code to mitigate the Ruby performance warning from `Karafka::Core::Configurable::Node` (#208)
+- [Enhancement] Raise errors on detected Ruby warnings.
+- [Change] Remove unused Ruby 2.7 code.
+- [Change] Remove `funding_uri` from the gemspec to minimize double-funding info.
+
 ## 2.5.2 (2025-06-11)
 - [Enhancement] Support `#unsubscribe`.
 - [Enhancement] Allow for providing a root scope path for error keys.

data/Gemfile

@@ -10,4 +10,5 @@ group :test do
   gem 'byebug'
   gem 'rspec'
   gem 'simplecov'
+  gem 'warning'
 end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    karafka-core (2.5.2)
+    karafka-core (2.5.4)
       karafka-rdkafka (>= 0.19.2, < 0.21.0)
       logger (>= 1.6.0)
 
@@ -48,6 +48,7 @@ GEM
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
+    warning (1.5.0)
 
 PLATFORMS
   aarch64-linux-gnu
@@ -67,6 +68,7 @@ DEPENDENCIES
   karafka-core!
   rspec
   simplecov
+  warning
 
 BUNDLED WITH
    2.6.9

data/karafka-core.gemspec

@@ -25,7 +25,6 @@ Gem::Specification.new do |spec|
   spec.require_paths = %w[lib]
 
   spec.metadata = {
-    'funding_uri' => 'https://karafka.io/#become-pro',
     'homepage_uri' => 'https://karafka.io',
     'changelog_uri' => 'https://karafka.io/docs/Changelog-Karafka-Core',
     'bug_tracker_uri' => 'https://github.com/karafka/karafka-core/issues',

data/lib/karafka/core/configurable/node.rb

@@ -22,6 +22,8 @@ module Karafka
           @children = []
           @nestings = nestings
           @compiled = false
+          @configs_refs = {}
+          @local_defs = Set.new
           instance_eval(&nestings)
         end
 
@@ -58,7 +60,14 @@ module Karafka
 
           @children.each do |value|
             config[value.node_name] = if value.is_a?(Leaf)
-                                        result = public_send(value.node_name)
+                                        result = if @configs_refs.key?(value.node_name)
+                                                   @configs_refs[value.node_name]
+                                                 elsif value.constructor
+                                                   value.constructor.call
+                                                 elsif value.default
+                                                   value.default
+                                                 end
+
                                         # We need to check if value is not a result node for cases
                                         # where we merge additional config
                                         result.is_a?(Node) ? result.to_h : result
@@ -96,12 +105,12 @@ module Karafka
           @children.each do |value|
             # Do not redefine something that was already set during compilation
             # This will allow us to reconfigure things and skip override with defaults
-            skippable = respond_to?(value.node_name) || (value.is_a?(Leaf) && value.compiled?)
+            skippable = @configs_refs.key?(value.node_name) || (value.is_a?(Leaf) && value.compiled?)
             lazy_leaf = value.is_a?(Leaf) && value.lazy?
 
             # Do not create accessor for leafs that are lazy as they will get a custom method
             # created instead
-            singleton_class.attr_accessor(value.node_name) unless lazy_leaf
+            build_accessors(value) unless lazy_leaf
 
             next if skippable
 
@@ -123,7 +132,7 @@ module Karafka
             if lazy_leaf && !initialized
               build_dynamic_accessor(value)
             else
-              public_send("#{value.node_name}=", initialized)
+              @configs_refs[value.node_name] = initialized
             end
           end
 
@@ -139,16 +148,18 @@ module Karafka
         #
         # @param value [Leaf]
         def build_dynamic_accessor(value)
-          singleton_class.attr_writer(value.node_name)
-
           define_singleton_method(value.node_name) do
-            existing = instance_variable_get("@#{value.node_name}")
+            existing = @configs_refs.fetch(value.node_name, false)
 
-            return existing if existing
+            return existing unless existing == false
 
             built = call_constructor(value)
 
-            instance_variable_set("@#{value.node_name}", built)
+            @configs_refs[value.node_name] = built
+          end
+
+          define_singleton_method(:"#{value.node_name}=") do |new_value|
+            @configs_refs[value.node_name] = new_value
           end
         end
 
@@ -165,6 +176,32 @@ module Karafka
             constructor.call(value.default)
           end
         end
+
+        # Builds regular accessors for value fetching
+        #
+        # @param value [Leaf]
+        def build_accessors(value)
+          reader_name = value.node_name.to_sym
+          reader_respond = respond_to?(reader_name)
+          # There is a weird edge-case from 2020, where nodes would not redefine methods that
+          # would be defined on Object. Some of users were defining things like `#logger` on
+          # object and then we would not redefine it for nodes. This ensures that we only do not
+          # redefine our own definitions but we do redefine any user "accidentally" inherited
+          # methods
+          if reader_respond ? !@local_defs.include?(reader_name) : true
+            @local_defs << reader_name
+
+            define_singleton_method(reader_name) do
+              @configs_refs[reader_name]
+            end
+          end
+
+          return if respond_to?(:"#{value.node_name}=")
+
+          define_singleton_method(:"#{value.node_name}=") do |new_value|
+            @configs_refs[value.node_name] = new_value
+          end
+        end
       end
     end
   end

data/lib/karafka/core/configurable.rb

@@ -63,23 +63,9 @@ module Karafka
           config.configure(&block)
         end
 
-        # Two versions are needed to pass arguments in the correct way
-        if RUBY_VERSION >= '2.7'
-          class_eval <<~CODE, __FILE__, __LINE__ + 1
-            # Pipes the settings setup to the config root node
-            def setting(...)
-              config.setting(...)
-            end
-          CODE
-        else
-          class_eval <<~CODE, __FILE__, __LINE__ + 1
-            # Pipes the settings setup to the config root node
-            # @param args [Object] anything provided to settings
-            # @param block [Proc] block for settings
-            def setting(*args, &block)
-              config.setting(*args, &block)
-            end
-          CODE
+        # Pipes the settings setup to the config root node
+        def setting(...)
+          config.setting(...)
         end
       end
     end

data/lib/karafka/core/version.rb

@@ -4,6 +4,6 @@ module Karafka
   module Core
     # Current Karafka::Core version
     # We follow the versioning schema of given Karafka version
-    VERSION = '2.5.2'
+    VERSION = '2.5.4'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: karafka-core
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.5.4
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -59,6 +59,7 @@ files:
 - ".github/ISSUE_TEMPLATE/feature_request.md"
 - ".github/workflows/ci.yml"
 - ".github/workflows/push.yml"
+- ".github/workflows/trigger-wiki-refresh.yml"
 - ".github/workflows/verify-action-pins.yml"
 - ".gitignore"
 - ".rspec"
@@ -101,7 +102,6 @@ homepage: https://karafka.io
 licenses:
 - MIT
 metadata:
-  funding_uri: https://karafka.io/#become-pro
   homepage_uri: https://karafka.io
   changelog_uri: https://karafka.io/docs/Changelog-Karafka-Core
   bug_tracker_uri: https://github.com/karafka/karafka-core/issues
@@ -122,7 +122,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Karafka ecosystem core modules
 test_files: []