kanrisuru 0.7.0 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bb8de477e2168c782b7cb082a6a6760fd56aa6925f1820ee80e45baff76a7b27
-  data.tar.gz: ad21e0b9787a2e42d8626a367f11b44ff97ec27f000a6ec8f7967d7b22da066d
+  metadata.gz: 4f5fe692ff53ac4de87ca38181765a63cf88f0beab4e44145c780ba9af934ede
+  data.tar.gz: 58acc02d34aff916670ab26c9659f7e40205d31492ec5f043ea51487df33cb62
 SHA512:
-  metadata.gz: 0cdeb2cda038612234429eb9ca172f294f60bb8bdcb0d5db2490231dfc4ab4205ae240b3f8ef8ebab41b5de6ef9d2599c7db76dd0ebe229b8b896e3a831c8805
-  data.tar.gz: b32d4fe02fe5897a8f56d827290516ceb393db63068f9cba3a4396b79e667dd62a332013fbb6fe674cd680ccd374faff877441f92f57048d5b782e244b23ec20
+  metadata.gz: e2b8134ef2351a86f88286a7ed50a1f768510c75f65ecbf9d9684f376606b46ea023f1b78723ae550183c7606e230d7152614d263b19f1a31c6bf6fe0cfa2cc3
+  data.tar.gz: f7382ab716a20185ec071f96b6793afa7fcc1e11d32a0dd3174455cb7a5ba19d3fb61aa0fbb7d5574f26af36d983b3fae4ee9ec5757f16ef2a21edc43d5d83cd

data/CHANGELOG.md

@@ -1,3 +1,26 @@
+## Kanrisuru 0.8.0 (August 18, 2021) ##
+* Add last / lastb implementation in system core module. 
+
+## Kanrisuru 0.7.3 (August 9, 2021) ##
+* Fixed bug with zypper remove package, where the package names weren't being added to the linux command. 
+* Test case added to ensure package is removed.
+
+## Kanrisuru 0.7.2 (August 9, 2021) ##
+* Fixed bug with the `os_method_cache` instance variable set in the namespaced instance of a host. This was causing collision issues inbetween host instances, where, hosts with the same aliased method name was getting overwritten (with a different OS), since the namespace instance variable existing on the host class definition wasn't getting reset inbetween host instantiations. Given that the `os_method_cache` is normally re-instantiated, this bug fix addresses this so that the `os_method_cache` is always defined on the host instance, ie:
+
+  ```ruby
+  host.instance_variable_get(:@os_method_cache)
+  host.instance_variable_set(:@os_method_cache, os_method_cache)
+  ```
+  This is done instead of being saved on the namespace module. With the previous bug fix of using namespaced keys, there's no way for a method to be overwritten otherwise with a global `os_method_cache`.
+
+## Kanrisuru 0.7.1 (August 8, 2021) ##
+* Fix bug with `os_include` when caching namespace unbound methods, use the namespace in the 
+cache key to avoid any namespace collisions with the same method name, namely:
+```ruby
+"#{namespace}.#{method_name}"
+```
+
 ## Kanrisuru 0.7.0 (August 8, 2021) ##
 * Simplify `FileInfo` struct for return object of `ls` command.
 * Rename `size` to `fsize` for the `OpenFile` struct to avoid method naming conflicts of the struct class. 

data/lib/kanrisuru/core/system.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'date'
+require 'ipaddr'
 
 module Kanrisuru
   module Core
@@ -19,6 +20,7 @@ module Kanrisuru
       os_define :linux, :kstat
 
       os_define :linux, :lsof
+      os_define :linux, :last
 
       os_define :linux, :uptime
 
@@ -116,6 +118,19 @@ module Kanrisuru
         :name
       )
 
+      SessionDetail = Struct.new(
+        :tty,
+        :login_at,
+        :logout_at,
+        :ip_address,
+        :success
+      )
+
+      LoginUser = Struct.new(
+        :user,
+        :sessions
+      )
+
       def load_env
         command = Kanrisuru::Command.new('env')
         execute_shell(command)
@@ -271,6 +286,65 @@ module Kanrisuru
         Kanrisuru::Result.new(command, &:to_i)
       end
 
+      def last(opts = {})
+        command =
+          if opts[:failed_attempts]
+            Kanrisuru::Command.new('lastb')
+          else
+            Kanrisuru::Command.new('last')
+          end
+
+        command.append_flag('-i')
+        command.append_flag('-F')
+        command.append_arg('-f', opts[:file])
+
+        ## Some systems only use 1 space between user and TTY field
+        ## Add an additional space in output formatting for simple parsing
+        ## logic.
+        command | "sed 's/ /  /'"
+
+        execute_shell(command)
+
+        Kanrisuru::Result.new(command) do |cmd|
+          lines = cmd.to_a
+
+          mapping = {}
+
+          lines.each do |line|
+            next if Kanrisuru::Util.blank?(line)
+            next if line.include?('wtmp') || line.include?('btmp')
+
+            line = line.gsub('  still logged in', '- still logged in') if line.include?('still logged in')
+
+            values = line.split(/\s{2,}/, 4)
+            user   = values[0]
+            tty    = values[1]
+            ip     = IPAddr.new(values[2])
+
+            date_range = values[3]
+            login, logout = date_range.split(' - ')
+
+            login = parse_last_date(login) if login
+
+            logout = parse_last_date(logout) if logout
+
+            detail = SessionDetail.new
+            detail.tty = tty
+            detail.ip_address = ip
+            detail.login_at = login
+            detail.logout_at = logout
+
+            detail.success = !Kanrisuru::Util.present?(opts[:failed_attemps])
+
+            mapping[user] = LoginUser.new(user, []) unless mapping.key?(user)
+
+            mapping[user].sessions << detail
+          end
+
+          mapping.values
+        end
+      end
+
       def ps(opts = {})
         group = opts[:group]
         user  = opts[:user]
@@ -567,6 +641,19 @@ module Kanrisuru
         line.split(char, 2)[1]
       end
 
+      def parse_last_date(string)
+        tokens = string.split
+
+        return if tokens.length < 4
+
+        month_abbr = tokens[1]
+        day = tokens[2]
+        timestamp = tokens[3]
+        year = tokens[4]
+
+        DateTime.parse("#{day} #{month_abbr} #{year} #{timestamp}")
+      end
+
       def parse_policy_abbr(value)
         case value
         when '-'

data/lib/kanrisuru/core/zypper.rb

@@ -714,6 +714,9 @@ module Kanrisuru
         zypper_package_type_opt(command, opts)
         zypper_solver_opts(command, opts)
 
+        packages = Kanrisuru::Util.string_join_array(opts[:packages], ' ')
+        command << packages
+
         execute_shell(command)
         Kanrisuru::Result.new(command)
       end

data/lib/kanrisuru/os_package.rb

@@ -8,7 +8,6 @@ module Kanrisuru
       def self.extended(base)
         base.instance_variable_set(:@os_method_properties, {})
         base.instance_variable_set(:@os_methods, Set.new)
-        base.instance_variable_set(:@os_method_cache, {})
       end
 
       def os_define(os_name, method_name, options = {})
@@ -102,12 +101,6 @@ module Kanrisuru
         include_methods   = (public_methods + protected_methods + private_methods).flatten
 
         include_method_bindings = proc do
-          define_method 'os_method_cache' do
-            @os_method_cache ||= {}
-          end
-
-          private :os_method_cache
-
           include_methods.each do |method_name|
             define_method method_name do |*args, &block|
               unbound_method = mod.instance_method(method_name)
@@ -144,10 +137,11 @@ module Kanrisuru
           ## defined with the methods added.
           if Kanrisuru::Remote::Host.instance_variable_defined?("@#{namespace}")
             namespace_class = Kanrisuru::Remote::Host.const_get(Kanrisuru::Util.camelize(namespace))
-            namespace_instance = instance_variable_get("@#{namespace}")
+            namespace_instance = Kanrisuru::Remote::Host.instance_variable_get("@#{namespace}")
           else
             namespace_class    = Kanrisuru::Remote::Host.const_set(Kanrisuru::Util.camelize(namespace), Class.new)
             namespace_instance = Kanrisuru::Remote::Host.instance_variable_set("@#{namespace}", namespace_class.new)
+
             class_eval do
               define_method namespace do
                 namespace_instance.instance_variable_set(:@host, self)
@@ -168,11 +162,12 @@ module Kanrisuru
                 define_method method_name do |*args, &block|
                   unbound_method = nil
 
-                  if os_method_cache.key?(method_name)
-                    unbound_method = os_method_cache[method_name]
-                  else
-                    host = namespace_instance.instance_variable_get(:@host)
+                  host = namespace_instance.instance_variable_get(:@host)
+                  os_method_cache = host.instance_variable_get(:@os_method_cache) || {}
 
+                  if os_method_cache.key?("#{namespace}.#{method_name}")
+                    unbound_method = os_method_cache["#{namespace}.#{method_name}"]
+                  else
                     ## Find the correct method to resolve based on the OS for the remote host.
                     defined_method_name = host.resolve_os_method_name(os_method_properties, method_name)
                     unless defined_method_name
@@ -185,7 +180,8 @@ module Kanrisuru
 
                     ## Cache the unbound method on this host instance for faster resolution on
                     ## the next invocation of this method
-                    os_method_cache[method_name] = unbound_method
+                    os_method_cache["#{namespace}.#{method_name}"] = unbound_method
+                    host.instance_variable_set(:@os_method_cache, os_method_cache)
                   end
 
                   ## Bind the method to host instance and
@@ -197,11 +193,12 @@ module Kanrisuru
               define_method method_name do |*args, &block|
                 unbound_method = nil
 
+                host = self
+                os_method_cache = host.instance_variable_get(:@os_method_cache) || {}
+
                 if os_method_cache.key?(method_name)
                   unbound_method = os_method_cache[method_name]
                 else
-                  host = self
-
                   ## Find the correct method to resolve based on the OS for the remote host.
                   defined_method_name = host.resolve_os_method_name(os_method_properties, method_name)
                   raise NoMethodError, "undefined method `#{method_name}' for #{self.class}" unless defined_method_name
@@ -213,6 +210,7 @@ module Kanrisuru
                   ## Cache the unbound method on this host instance for faster resolution on
                   ## the next invocation of this method
                   os_method_cache[method_name] = unbound_method
+                  host.instance_variable_set(:@os_method_cache, os_method_cache)
                 end
 
                 ## Bind the method to host instance and

data/lib/kanrisuru/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Kanrisuru
-  VERSION = '0.7.0'
+  VERSION = '0.8.0'
 end

data/spec/functional/core/system_spec.rb

@@ -96,6 +96,21 @@ RSpec.describe Kanrisuru::Core::System do
         expect(result.cpus.length).to eq(host.cpu.cores)
       end
 
+      it 'gets login details' do
+        host.su('root')
+
+        result = host.last
+        expect(result).to be_success
+      end
+
+      it 'gets failed login attempts' do
+        host.su('root')
+
+        result = host.last(failed_attempts: true)
+        puts result.data
+        expect(result).to be_success
+      end
+
       it 'gets process details' do
         result = host.ps
 

data/spec/functional/core/zypper_spec.rb

@@ -40,6 +40,12 @@ RSpec.describe Kanrisuru::Core::Zypper do
         expect(result).to be_success
       end
 
+      it 'removes a package' do
+        host.su('root')
+        result = host.zypper('remove', packages: ['ffmpeg'])
+        expect(result).to be_success
+      end
+
       it 'lists updates' do
         result = host.zypper('list-updates')
         expect(result).to be_success

data/spec/functional/os_package_spec.rb

@@ -40,18 +40,66 @@ module Kanrisuru
       a - b
     end
   end
+
+  module TestAliasNames
+    extend Kanrisuru::OsPackage::Define
+
+    os_define :fedora, :output_fedora, alias: :output
+    os_define :debian, :output_debian, alias: :output
+    os_define :sles,   :output_sles, alias: :output
+
+    def output_debian
+      'debian'
+    end
+
+    def output_fedora
+      'fedora'
+    end
+
+    def output_sles
+      'sles'
+    end
+  end
+
+  module TestAliasNamesNamespace
+    extend Kanrisuru::OsPackage::Define
+
+    os_define :fedora, :output_fedora, alias: :output
+    os_define :debian, :output_debian, alias: :output
+    os_define :sles,   :output_sles, alias: :output
+
+    def output_debian
+      'debian'
+    end
+
+    def output_fedora
+      'fedora'
+    end
+
+    def output_sles
+      'sles'
+    end
+  end
 end
 
 module Kanrisuru
   module Remote
     class Host
       os_include Kanrisuru::TestInclude
+
+      os_include Kanrisuru::TestAliasNames
+      os_include Kanrisuru::TestAliasNamesNamespace, namespace: :alias
+
       os_include Kanrisuru::TestNamespaceAdditions, namespace: :asdf
       os_include Kanrisuru::TestNamespace, namespace: :asdf
     end
 
     class Cluster
       os_collection Kanrisuru::TestInclude
+
+      os_collection Kanrisuru::TestAliasNames
+      os_collection Kanrisuru::TestAliasNamesNamespace, namespace: :alias
+
       os_collection Kanrisuru::TestNamespaceAdditions, namespace: :asdf
       os_collection Kanrisuru::TestNamespace, namespace: :asdf
     end
@@ -94,6 +142,52 @@ RSpec.describe Kanrisuru::OsPackage do
     expect(cluster.asdf.tester).to be_instance_of(Array)
 
     host.disconnect
+    host2.disconnect
+    cluster.disconnect
+  end
+
+  it 'includes the correct alias named method' do
+    host1 = Kanrisuru::Remote::Host.new(host: 'ubuntu-host', username: 'ubuntu', keys: ['~/.ssh/id_rsa'])
+    host2 = Kanrisuru::Remote::Host.new(host: 'centos-host', username: 'centos', keys: ['~/.ssh/id_rsa'])
+    host3 = Kanrisuru::Remote::Host.new(host: 'opensuse-host', username: 'opensuse', keys: ['~/.ssh/id_rsa'])
+
+    cluster = Kanrisuru::Remote::Cluster.new([host1, host2, host3])
+
+    expect(host1).to respond_to(:output)
+    expect(host2).to respond_to(:output)
+    expect(host3).to respond_to(:output)
+    expect(host1.output).to eq('debian')
+    expect(host2.output).to eq('fedora')
+    expect(host3.output).to eq('sles')
+
+    expect(cluster).to respond_to(:output)
+    expect(cluster.output).to eq([
+                                   { host: 'ubuntu-host', result: 'debian' },
+                                   { host: 'centos-host', result: 'fedora' },
+                                   { host: 'opensuse-host', result: 'sles' }
+                                 ])
+
+    expect(host1).to respond_to(:alias)
+    expect(host2).to respond_to(:alias)
+    expect(host3).to respond_to(:alias)
+    expect(host1.alias).to respond_to(:output)
+    expect(host2.alias).to respond_to(:output)
+    expect(host3.alias).to respond_to(:output)
+    expect(host1.alias.output).to eq('debian')
+    expect(host2.alias.output).to eq('fedora')
+    expect(host3.alias.output).to eq('sles')
+
+    expect(cluster).to respond_to(:alias)
+    expect(cluster.alias).to respond_to(:output)
+    expect(cluster.alias.output).to eq([
+                                         { host: 'ubuntu-host', result: 'debian' },
+                                         { host: 'centos-host', result: 'fedora' },
+                                         { host: 'opensuse-host', result: 'sles' }
+                                       ])
+
+    host1.disconnect
+    host2.disconnect
+    host3.disconnect
     cluster.disconnect
   end
 end

data/spec/spec_helper.rb

@@ -4,7 +4,6 @@ require 'simplecov'
 SimpleCov.start
 
 require 'kanrisuru'
-
 require_relative 'helper/test_hosts'
 
 Kanrisuru.logger.level = Logger::WARN

data/spec/unit/core/system_spec.rb

@@ -86,5 +86,17 @@ RSpec.describe Kanrisuru::Core::System do
       :inode,
       :name
     )
+    expect(Kanrisuru::Core::System::SessionDetail.new).to respond_to(
+      :tty,
+      :login_at,
+      :logout_at,
+      :ip_address,
+      :success
+    )
+
+    expect(Kanrisuru::Core::System::LoginUser.new).to respond_to(
+      :user,
+      :sessions
+    )
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kanrisuru
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.8.0
 platform: ruby
 authors:
 - Ryan Mammina
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-08 00:00:00.000000000 Z
+date: 2021-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec