kanban 0.3.1 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1269e09e1ed2b1e5fe61f15a0bc6afca6de16fe4
-  data.tar.gz: 5a9d91b4fa9422ad18b3dddfb9d7586f01db9085
+  metadata.gz: 5571f4ff8d96226cd84855428ad20f875669991f
+  data.tar.gz: 3ef547ba9f47b0dd43ef43e851052848374e8197
 SHA512:
-  metadata.gz: 4294deecdd8f137be52fc4478815b2d65fcf0d2f4b583d78831ff166c95fe1794235f81b6f813a13845775ee08bc96c52d9a93a0522900b9989825d0f4fa5dfe
-  data.tar.gz: 1bd3f95ede9394a0f93d15a3c722b6d91ffefae87be9f59bc325aa001d71480e8a01235ba0fdeed24bd4f7c503d436517c4ae56119d972c5b0ec425a022e0a0d
+  metadata.gz: fbf31b07bfbbcc2a3fd32d4096c0a082c52d880eca58fd7cd041d3deee1f2ebab7448ba1a94eac68c8fb0ac9967ac5d2b42e45fc0102b1b25d1e00364937e2ee
+  data.tar.gz: 08a57add1ad3040481c6ce516ed90ecbbccf2df861038f311f82fec3e3e0557c9e49497c2f69d4d85730e095c3349ee50cbb1e8dfbfd1bbc61488be127a00855

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.5.1

data/kanban.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: kanban 0.3.1 ruby lib
+# stub: kanban 0.5.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "kanban"
-  s.version = "0.3.1"
+  s.version = "0.5.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Chris Olstrom"]
-  s.date = "2015-05-26"
+  s.date = "2015-05-28"
   s.description = "Because your code totally needed an Agile Workflow"
   s.email = "chris@olstrom.com"
   s.extra_rdoc_files = [

data/lib/kanban.rb

@@ -10,7 +10,7 @@ module Kanban
     def initialize(backend:, **options)
       @namespace = options.fetch :namespace, 'default'
       @queue = "#{@namespace}:#{options.fetch :queue, 'tasks'}"
-      @item = "#{@namespace}:#{options.fetch :item, 'tasks'}"
+      @item = "#{@namespace}:#{options.fetch :item, 'task'}"
       @backend = backend
     end
 
@@ -38,5 +38,27 @@ module Kanban
       safe = task.with_string_keys
       add(safe)
     end
+
+    def claim(duration: 3)
+      id = @backend.brpoplpush("#{@queue}:todo", "#{@queue}:doing")
+      @backend.set "#{@item}:#{id}:claimed", true, ex: duration
+      id.to_i
+    end
+
+    def claimed?(id)
+      @backend.exists "#{@item}:#{id}:claimed"
+    end
+
+    def doing
+      @backend.lrange("#{@queue}:doing", 0, -1).map(&:to_i)
+    end
+
+    def complete(id)
+      @backend.setbit("#{@queue}:completed", id, 1).zero?
+    end
+
+    def completed?(id)
+      @backend.getbit("#{@queue}:completed", id) == 1
+    end
   end
 end

data/spec/kanban_spec.rb

@@ -1,29 +1,32 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+require 'timeout'
 
 describe 'Backlog' do
   before do
-    @backlog = Kanban::Backlog.new backend: Redis.new
+    @backlog = Kanban::Backlog.new backend: Redis.new, namespace: 'kanban:test'
   end
 
-  it 'instantiates without error' do
-    expect(@backlog).to be_an_instance_of(Kanban::Backlog)
+  after(:all) do
+    redis = Redis.new
+    redis.keys('kanban:test:*').each do |key|
+      redis.del key
+    end
   end
 
-  it 'should have a namespace' do
-    expect(@backlog.namespace).to eq 'default'
+  it 'instantiates without error' do
+    expect(@backlog).to be_an_instance_of(Kanban::Backlog)
   end
 
   it 'should allow namespace configuration at initialization' do
-    backlog = Kanban::Backlog.new namespace: 'foo', backend: nil
-    expect(backlog.namespace).to eq 'foo'
+    expect(@backlog.namespace).to eq 'kanban:test'
   end
 
   it 'should prefix queue keys with the namespace' do
-    expect(@backlog.queue).to start_with('default')
+    expect(@backlog.queue).to start_with('kanban:test')
   end
 
   it 'should prefix item keys with the namespace' do
-    expect(@backlog.item).to start_with('default')
+    expect(@backlog.item).to start_with('kanban:test')
   end
 
   it 'should require a backend' do
@@ -71,4 +74,55 @@ describe 'Backlog' do
     id = @backlog.add(task)
     expect(@backlog.todo).to include(id)
   end
+
+  it 'should allow a task to be claimed' do
+    expect(@backlog.claim).to be_a Fixnum
+  end
+
+  it 'should track the claim separately from the queue it is in' do
+    id = @backlog.claim
+    redis = Redis.new
+    expect(redis.exists("#{@backlog.item}:#{id}:claimed")).to be true
+  end
+
+  it 'should allow claims to expire' do
+    id = @backlog.claim(duration: 1)
+    sleep 1.1
+    redis = Redis.new
+    expect(redis.exists("#{@backlog.item}:#{id}:claimed")).to be false
+  end
+
+  it 'should block if there are no pending tasks' do
+    redis = Redis.new
+    redis.del "#{@backlog.queue}:todo"
+    expect do
+      Timeout.timeout(0.1) do
+        @backlog.claim
+      end
+    end.to raise_error(Timeout::Error)
+  end
+
+  it 'should report if a task is claimed' do
+    task = { 'test' => 'data' }
+    5.times { @backlog.add(task) }
+    id = @backlog.claim
+    expect(@backlog.claimed?(id)).to be true
+    expect(@backlog.claimed?(0)).to be false
+  end
+
+  it 'should have a list of tasks being worked on' do
+    id = @backlog.claim
+    expect(@backlog.doing).to include(id)
+  end
+
+  it 'should allow indicating completion of a task only once' do
+    expect(@backlog.complete(1)).to be true
+    expect(@backlog.complete(1)).to be false
+  end
+
+  it 'should check if a task is completed' do
+    expect(@backlog.completed?(2)).to be false
+    @backlog.complete 2
+    expect(@backlog.completed?(2)).to be true
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kanban
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.5.1
 platform: ruby
 authors:
 - Chris Olstrom
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-26 00:00:00.000000000 Z
+date: 2015-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis