kaminari 0.14.1 → 0.15.0

data/spec/models/configuration_methods_spec.rb

@@ -0,0 +1,125 @@
+require 'spec_helper'
+
+describe "configuration methods" do
+  let(:model){ User }
+
+  describe "#default_per_page" do
+    if defined? ActiveRecord
+      describe 'AR::Base' do
+        subject { ActiveRecord::Base }
+        it { should_not respond_to :paginates_per }
+      end
+    end
+
+    subject { model.page(1) }
+
+    context "by default" do
+      its(:limit_value){ should == 25 }
+    end
+
+    context "when configuring both on global and model-level" do
+      before do
+        Kaminari.configure {|c| c.default_per_page = 50 }
+        model.paginates_per 100
+      end
+
+      its(:limit_value){ should == 100 }
+    end
+
+    context "when configuring multiple times" do
+      before do
+        Kaminari.configure {|c| c.default_per_page = 10 }
+        Kaminari.configure {|c| c.default_per_page = 20 }
+      end
+
+      its(:limit_value){ should == 20 }
+    end
+
+    after do
+      Kaminari.configure {|c| c.default_per_page = 25 }
+      model.paginates_per nil
+    end
+  end
+
+  describe "#max_per_page" do
+    if defined? ActiveRecord
+      describe 'AR::Base' do
+        subject { ActiveRecord::Base }
+        it { should_not respond_to :max_pages_per }
+      end
+    end
+
+    subject { model.page(1).per(1000) }
+
+    context "by default" do
+      its(:limit_value){ should == 1000 }
+    end
+
+    context "when configuring both on global and model-level" do
+      before do
+        Kaminari.configure {|c| c.max_per_page = 50 }
+        model.max_paginates_per 100
+      end
+
+      its(:limit_value){ should == 100 }
+    end
+
+    context "when configuring multiple times" do
+      before do
+        Kaminari.configure {|c| c.max_per_page = 10 }
+        Kaminari.configure {|c| c.max_per_page = 20 }
+      end
+
+      its(:limit_value){ should == 20 }
+    end
+
+    after do
+      Kaminari.configure {|c| c.max_per_page = nil }
+      model.max_paginates_per nil
+    end
+  end
+
+  describe "#max_pages" do
+    if defined? ActiveRecord
+      describe 'AR::Base' do
+        subject { ActiveRecord::Base }
+        it { should_not respond_to :max_paginates_per }
+      end
+    end
+
+    before do
+      100.times do |count|
+        model.create!(:name => "User#{count}")
+      end
+    end
+
+    subject { model.page(1).per(5) }
+
+    context "by default" do
+      its(:total_pages){ should == 20 }
+    end
+
+    context "when configuring both on global and model-level" do
+      before do
+        Kaminari.configure {|c| c.max_pages = 10 }
+        model.max_pages_per 15
+      end
+
+      its(:total_pages){ should == 15 }
+    end
+
+    context "when configuring multiple times" do
+      before do
+        Kaminari.configure {|c| c.max_pages = 10 }
+        Kaminari.configure {|c| c.max_pages = 15 }
+      end
+
+      its(:total_pages){ should == 15 }
+    end
+
+    after do
+      Kaminari.configure {|c| c.max_pages = nil }
+      model.max_pages_per nil
+    end
+  end
+end

data/spec/models/data_mapper/data_mapper_spec.rb

@@ -1,6 +1,34 @@
 require 'spec_helper'
 
 if defined? DataMapper
+  # tests for issue #203
+  describe Kaminari::DataMapperCollectionMethods do
+    before do
+      100.times do |i|
+        User.create(:name => "User#{i}", :age => i)
+      end
+
+      worker0 = User[0]
+      50.times do |i|
+        worker0.projects << Project.create(:name => "Project#{i}")
+      end
+      worker0.projects.save
+    end
+
+    describe 'Model' do
+      subject { User }
+      it { User.all.count.should == 100 }
+      it { User.page(1).length.should == 25 }
+      it {
+        User.paginates_per(5)
+        User.page(1).length.should == 5
+        User.all.page(1).length.should == 5
+        User.paginates_per(nil) # reset to default
+      }
+    end
+
+  end
+
   describe Kaminari::DataMapperExtension do
     before do
       100.times do |i|
@@ -32,6 +60,8 @@ if defined? DataMapper
         subject { User.all(:age.gte => 60).page 0 }
         it { should be_a DataMapper::Collection }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its('query.limit') { should == 25 }
         its('query.offset') { should == 0 }
         its(:total_count) { should == User.count(:age.gte => 60) }
@@ -42,6 +72,8 @@ if defined? DataMapper
         subject { User.all(:age.gte => 0).page 1 }
         it { should be_a DataMapper::Collection }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its('query.limit') { should == 25 }
         its('query.offset') { should == 0 }
         its(:total_count) { should == 100 }
@@ -52,6 +84,8 @@ if defined? DataMapper
         subject { User.page 2 }
         it { should be_a DataMapper::Collection }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should == 3 }
         its(:limit_value) { should == 25 }
         its('query.limit') { should == 25 }
         its('query.offset') { should == 25 }
@@ -63,6 +97,8 @@ if defined? DataMapper
         subject { User.page 'foobar' }
         it { should be_a DataMapper::Collection }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its('query.limit') { should == 25 }
         its('query.offset') { should == 0 }
         its(:total_count) { should == 100 }
@@ -73,6 +109,8 @@ if defined? DataMapper
         subject { User.all(:age.gt => 60).page 2 }
         it { should be_a DataMapper::Collection }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should be_nil }
         its('query.limit') { should == 25 }
         its('query.offset') { should == 25 }
         its(:total_count) { should == User.count(:age.gt => 60) }
@@ -83,6 +121,8 @@ if defined? DataMapper
         subject { User.page(2).all(:age.gt => 60) }
         it { should be_a DataMapper::Collection }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should be_nil }
         its('query.limit') { should == 25 }
         its('query.offset') { should == 25 }
         its(:total_count) { should == User.count(:age.gt => 60) }
@@ -95,6 +135,8 @@ if defined? DataMapper
         subject { User.page(2).per(20) }
         it { should be_a DataMapper::Collection }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should == 3 }
         its('query.limit') { should == 20 }
         its(:limit_value) { should == 20 }
         its('query.offset') { should == 20 }
@@ -105,6 +147,8 @@ if defined? DataMapper
       context 'on query with condition' do
         subject { User.page(5).all(:age.lte => 80).per(13) }
         its(:current_page) { should == 5 }
+        its(:prev_page) { should == 4 }
+        its(:next_page) { should == 6 }
         its('query.limit') { should == 13 }
         its('query.offset') { should == 52 }
         its(:total_count) { should == 81 }
@@ -118,6 +162,8 @@ if defined? DataMapper
         it('includes user with age 52') { should include(User.first(:age => 64)) }
         it('does not include user with age 51') { should_not include(User.first(:age => 65)) }
         its(:current_page) { should == 5 }
+        its(:prev_page) { should == 4 }
+        its(:next_page) { should == 6 }
         its('query.limit') { should == 13 }
         its('query.offset') { should == 52 }
         its(:total_count) { should == 81 }
@@ -127,6 +173,8 @@ if defined? DataMapper
       context 'on chained queries' do
         subject { User.all(:age.gte => 50).page(3).all(:age.lte => 80).per(13) }
         its(:current_page) { should == 3 }
+        its(:prev_page) { should == 2 }
+        its(:next_page) { should be_nil }
         its('query.limit') { should == 13 }
         its('query.offset') { should == 26 }
         its(:total_count) { should == 31 }
@@ -136,6 +184,8 @@ if defined? DataMapper
       context 'on query on association' do
         subject { User[0].projects.page(3).all(:name.like => 'Project%').per(5) }
         its(:current_page) { should == 3 }
+        its(:prev_page) { should == 2 }
+        its(:next_page) { should == 4 }
         its('query.limit') { should == 5 }
         its('query.offset') { should == 10 }
         its(:total_count) { should == 50 }
@@ -145,6 +195,8 @@ if defined? DataMapper
       context 'on query with association conditions' do
         subject { User.page(3).all(:projects => Project.all).per(5) }
         its(:current_page) { should == 3 }
+        its(:prev_page) { should == 2 }
+        its(:next_page) { should == 4 }
         its('query.limit') { should == 5 }
         its('query.offset') { should == 10 }
         its(:total_count) { should == 50 }

data/spec/models/mongo_mapper/mongo_mapper_spec.rb

@@ -12,6 +12,8 @@ if defined? MongoMapper
         subject { User.page(1) }
         it { should be_a Plucky::Query }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip(0) }
@@ -21,6 +23,8 @@ if defined? MongoMapper
         subject { User.page 2 }
         it { should be_a Plucky::Query }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should be_nil }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip 25 }
@@ -30,6 +34,8 @@ if defined? MongoMapper
         subject { User.page 'foobar' }
         it { should be_a Plucky::Query }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip 0 }
@@ -42,6 +48,8 @@ if defined? MongoMapper
 
         subject { User.where(:salary => 1).page 2 }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should be_nil }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip 25 }
@@ -54,6 +62,8 @@ if defined? MongoMapper
 
         subject { User.page(2).where(:salary => 1) }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should be_nil }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip 25 }
@@ -64,6 +74,8 @@ if defined? MongoMapper
       subject { User.page(2).per(10) }
       it { should be_a Plucky::Query }
       its(:current_page) { should == 2 }
+      its(:prev_page) { should == 1 }
+      its(:next_page) { should == 3 }
       its(:limit_value) { should == 10 }
       its(:total_pages) { should == 5 }
       it { should skip 10 }

data/spec/models/mongoid/mongoid_spec.rb

@@ -14,6 +14,8 @@ if defined? Mongoid
         subject { User.page 1 }
         it { should be_a Mongoid::Criteria }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip(0) }
@@ -23,6 +25,8 @@ if defined? Mongoid
         subject { User.page 2 }
         it { should be_a Mongoid::Criteria }
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should be_nil }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip 25 }
@@ -32,6 +36,8 @@ if defined? Mongoid
         subject { User.page 'foobar' }
         it { should be_a Mongoid::Criteria }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip 0 }
@@ -44,6 +50,8 @@ if defined? Mongoid
           its(:selector) { should == {:salary => 1} }
         end
         its(:current_page) { should == 2 }
+        its(:prev_page) { should == 1 }
+        its(:next_page) { should be_nil }
         its(:limit_value) { should == 25 }
         its(:total_pages) { should == 2 }
         it { should skip 25 }
@@ -64,6 +72,8 @@ if defined? Mongoid
       subject { User.page(2).per(10) }
       it { should be_a Mongoid::Criteria }
       its(:current_page) { should == 2 }
+      its(:prev_page) { should == 1 }
+      its(:next_page) { should == 3 }
       its(:limit_value) { should == 10 }
       its(:total_pages) { should == 5 }
       it { should skip 10 }
@@ -85,6 +95,8 @@ if defined? Mongoid
         its(:total_count) { should == 5 }
         its(:limit_value) { should == 1 }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its(:total_pages) { should == 5 }
       end
 
@@ -94,6 +106,8 @@ if defined? Mongoid
         its(:total_count) { should == 3 }
         its(:limit_value) { should == 2 }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its(:total_pages) { should == 2 }
       end
 
@@ -103,6 +117,8 @@ if defined? Mongoid
         its(:total_count) { should == 3 }
         its(:limit_value) { should == 2 }
         its(:current_page) { should == 1 }
+        its(:prev_page) { should be_nil }
+        its(:next_page) { should == 2 }
         its(:total_pages) { should == 2 }
       end
     end

data/spec/spec_helper.rb

@@ -9,6 +9,7 @@ end
 require 'bundler/setup'
 Bundler.require
 
+require 'capybara/rspec'
 require 'database_cleaner'
 
 # Simulate a gem providing a subclass of ActiveRecord::Base before the Railtie is loaded.

data/spec/spec_helper_for_sinatra.rb

@@ -1,7 +1,7 @@
 require 'kaminari/sinatra'
+require 'kaminari/helpers/action_view_extension'
 require 'rack/test'
 require 'sinatra/test_helpers'
-require 'capybara/dsl'
 require 'capybara/rspec'
 
 require 'fake_app/sinatra_app'
@@ -17,14 +17,13 @@ module HelperMethodForHelperSpec
 
   def helper
     # OMG terrible object...
-    Kaminari::Helpers::SinatraHelpers::ActionViewTemplateProxy.new(:current_params => {}, :current_path => '/', :param_name => Kaminari.config.param_name).extend(Padrino::Helpers, Kaminari::ActionViewExtension, Kaminari::Helpers::SinatraHelpers::HelperMethods, FakeEnv)
+    ::Kaminari::Helpers::SinatraHelpers::ActionViewTemplateProxy.new(:current_params => {}, :current_path => '/', :param_name => Kaminari.config.param_name).extend(Padrino::Helpers, Kaminari::ActionViewExtension, Kaminari::Helpers::SinatraHelpers::HelperMethods, FakeEnv)
   end
 end
 
 RSpec.configure do |config|
   config.include Rack::Test::Methods
   config.include Sinatra::TestHelpers
-  config.include Capybara::DSL
   config.include HelperMethodForHelperSpec
 #   config.include HelperMethodForHelperSpec, :type => :helper
 end

data/spec/support/database_cleaner.rb

@@ -1,11 +1,14 @@
 DatabaseCleaner[:active_record].strategy = :transaction if defined? ActiveRecord
-DatabaseCleaner[:data_mapper].strategy = :transaction if defined? DataMapper
+DatabaseCleaner[:data_mapper].strategy = :truncation if defined? DataMapper
 DatabaseCleaner[:mongoid].strategy = :truncation if defined? Mongoid
 DatabaseCleaner[:mongo_mapper].strategy = :truncation if defined? MongoMapper
 
 RSpec.configure do |config|
   config.before :suite do
-    DatabaseCleaner.clean_with :truncation
+    DatabaseCleaner.clean_with :truncation if defined? ActiveRecord
+    DatabaseCleaner.clean_with :truncation if defined? DataMapper
+    DatabaseCleaner.clean_with :truncation if defined? Mongoid
+    DatabaseCleaner.clean_with :truncation if defined? MongoMapper
   end
   config.before :each do
     DatabaseCleaner.start