kalibro_gem 0.0.4 → 0.0.5

data/spec/entities/metric_result_spec.rb

@@ -24,7 +24,7 @@ describe KalibroGem::Entities::MetricResult do
     context 'with value NaN' do
       it 'should set the value with aggregated_value' do
         metric_result = KalibroGem::Entities::MetricResult.new( FactoryGirl.attributes_for(:metric_result, {value: "NaN", aggregated_value: 1.6}) )
-        metric_result.value.should eq(1.6)
+        expect(metric_result.value).to eq(1.6)
       end
     end
   end
@@ -32,35 +32,35 @@ describe KalibroGem::Entities::MetricResult do
   describe 'id=' do
     it 'should set the value of the attribute id' do
       subject.id = 42
-      subject.id.should eq(42)
+      expect(subject.id).to eq(42)
     end
   end
 
   describe 'configuration=' do
     it 'should set the configuration' do
       subject.configuration = metric_configuration_snapshot.to_hash
-      subject.configuration.code.should eq(metric_configuration_snapshot.code)
+      expect(subject.configuration.code).to eq(metric_configuration_snapshot.code)
     end
   end
 
   describe 'metric_configuration_snapshot' do
     it 'should be an alias to configuration' do
       subject.configuration = metric_configuration_snapshot.to_hash
-      subject.metric_configuration_snapshot.code.should eq(metric_configuration_snapshot.code)
+      expect(subject.metric_configuration_snapshot.code).to eq(metric_configuration_snapshot.code)
     end
   end
 
   describe 'value=' do
     it 'should set the value of the attribute value' do
       subject.value = 42
-      subject.value.should eq(42)
+      expect(subject.value).to eq(42)
     end
   end
 
   describe 'aggregated_value=' do
     it 'should set the value of the attribute aggregated_value' do
       subject.aggregated_value = 42
-      subject.aggregated_value.should eq(42)
+      expect(subject.aggregated_value).to eq(42)
     end
   end
 
@@ -74,7 +74,7 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return an unitary list with the descendant result' do
-        subject.descendant_results.should eq([13.3])
+        expect(subject.descendant_results).to eq([13.3])
       end
     end
 
@@ -87,7 +87,7 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return an empty list' do
-        subject.descendant_results.should eq([])
+        expect(subject.descendant_results).to eq([])
       end
     end
 
@@ -100,7 +100,7 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return a list with the descendant results' do
-        subject.descendant_results.should eq([-13.3, 42.42, 1])
+        expect(subject.descendant_results).to eq([-13.3, 42.42, 1])
       end
     end
   end
@@ -115,7 +115,7 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return an unitary list with the metric result' do
-        KalibroGem::Entities::MetricResult.metric_results_of(123).first.value.should eq(subject.value)
+        expect(KalibroGem::Entities::MetricResult.metric_results_of(123).first.value).to eq(subject.value)
       end
     end
 
@@ -128,7 +128,7 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return an empty list' do
-        KalibroGem::Entities::MetricResult.metric_results_of(42).should eq([])
+        expect(KalibroGem::Entities::MetricResult.metric_results_of(42)).to eq([])
       end
     end
 
@@ -142,7 +142,7 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return a list with the descendant results' do
-        metric_results.first.value.should eq(subject.value)
+        expect(metric_results.first.value).to eq(subject.value)
       end
     end
   end
@@ -160,7 +160,7 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return an empty list' do
-        KalibroGem::Entities::MetricResult.history_of(metric.name, module_result.id).should eq([])
+        expect(KalibroGem::Entities::MetricResult.history_of(metric.name, module_result.id)).to eq([])
       end
     end
 
@@ -175,8 +175,8 @@ describe KalibroGem::Entities::MetricResult do
       end
 
       it 'should return the date metric result as an object into a list' do
-        KalibroGem::Entities::MetricResult.history_of(metric.name, module_result.id).
-          first.metric_result.id.should eq(subject.id)
+        expect(KalibroGem::Entities::MetricResult.history_of(metric.name, module_result.id).
+          first.metric_result.id).to eq(subject.id)
       end
     end
 
@@ -193,8 +193,8 @@ describe KalibroGem::Entities::MetricResult do
 
       it 'should return a list of date metric results as objects' do
         response = KalibroGem::Entities::MetricResult.history_of(metric.name, module_result.id)
-        response.first.metric_result.id.should eq(date_metric_result.metric_result.id)
-        response.last.metric_result.id.should eq(another_date_metric_result.metric_result.id)
+        expect(response.first.metric_result.id).to eq(date_metric_result.metric_result.id)
+        expect(response.last.metric_result.id).to eq(another_date_metric_result.metric_result.id)
       end
     end
   end

data/spec/entities/metric_spec.rb

@@ -21,14 +21,14 @@ describe KalibroGem::Entities::Metric do
     subject { FactoryGirl.build(:metric) }
 
     it 'should return the value of the language attribute' do
-      subject.languages.should eq(["C", "CPP", "JAVA"])
+      expect(subject.languages).to eq(["C", "CPP", "JAVA"])
     end
   end
 
   describe 'languages=' do
     it 'should set the value of the attribute language' do
       subject.languages = ["Java", "C"]
-      subject.languages.should eq(["Java", "C"])
+      expect(subject.languages).to eq(["Java", "C"])
     end
   end
 
@@ -41,7 +41,7 @@ describe KalibroGem::Entities::Metric do
 
     it 'should convert the value to an array of objects' do
       subject.language = "Java"
-      subject.languages.should eq(["Java"])
+      expect(subject.languages).to eq(["Java"])
     end
   end
 end

data/spec/entities/model_spec.rb

@@ -22,17 +22,17 @@ describe KalibroGem::Entities::Model do
   describe 'new' do
     it 'should create a model from an empty hash' do
       subject = KalibroGem::Entities::Model.new {}
-      subject.kalibro_errors.should eq([])
+      expect(subject.kalibro_errors).to eq([])
     end
   end
 
   describe 'class_name' do
     it 'should be a String' do
-      subject.class.class_name.should be_a(String)
+      expect(subject.class.class_name).to be_a(String)
     end
 
     it 'should return Model' do
-      subject.class.class_name.should eq('Model')
+      expect(subject.class.class_name).to eq('Model')
     end
   end
 
@@ -40,13 +40,13 @@ describe KalibroGem::Entities::Model do
     it 'should return the class_name' do
       endpoint = 'test'
       KalibroGem::Entities::Model.expects(:class_name).returns(endpoint)
-      KalibroGem::Entities::Model.endpoint.should eq(endpoint)
+      expect(KalibroGem::Entities::Model.endpoint).to eq(endpoint)
     end
   end
 
   describe 'client' do
     it 'returns a Savon::Client' do
-      KalibroGem::Entities::Model.client('Model').should be_a(Savon::Client)
+      expect(KalibroGem::Entities::Model.client('Model')).to be_a(Savon::Client)
     end
   end
 
@@ -63,8 +63,8 @@ describe KalibroGem::Entities::Model do
           expects(:client).
           with(any_parameters).
           returns(client)
-        KalibroGem::Entities::Model.
-          request(:project_exists, {project_id: 1})[:exists].should eq(false)
+        expect(KalibroGem::Entities::Model.
+          request(:project_exists, {project_id: 1})[:exists]).to eq(false)
       end
     end
 
@@ -79,36 +79,36 @@ describe KalibroGem::Entities::Model do
           expects(:client).
           with(any_parameters).
           returns(client)
-        Child.
-          request(:project_exists, {project_id: 1})[:exists].should eq(false)
+        expect(Child.
+          request(:project_exists, {project_id: 1})[:exists]).to eq(false)
       end
     end
   end
 
   describe 'to_hash' do
     it 'should return an empty hash' do
-      subject.to_hash.should eq({kalibro_errors: []})
+      expect(subject.to_hash).to eq({kalibro_errors: []})
     end
   end
 
   describe 'to_object' do
     it 'should return an Object with an empty hash' do
-      KalibroGem::Entities::Model.to_object({}).should eq(FactoryGirl.build(:model))
+      expect(KalibroGem::Entities::Model.to_object({})).to eq(FactoryGirl.build(:model))
     end
 
     it "should remain an object if it isn't a Hash" do
-      KalibroGem::Entities::Model.to_object(Object.new).should be_an(Object)
+      expect(KalibroGem::Entities::Model.to_object(Object.new)).to be_an(Object)
     end
   end
 
   describe 'to_objects_array' do
     it 'should convert [{}] to [Model]' do
-      KalibroGem::Entities::Model.to_objects_array({}).should eq([FactoryGirl.build(:model)]) 
+      expect(KalibroGem::Entities::Model.to_objects_array({})).to eq([FactoryGirl.build(:model)]) 
     end
 
     it 'should remain an array if it already is one' do
       object = Object.new
-      KalibroGem::Entities::Model.to_objects_array([object]).should eq([object]) 
+      expect(KalibroGem::Entities::Model.to_objects_array([object])).to eq([object]) 
     end
   end
 
@@ -121,8 +121,8 @@ describe KalibroGem::Entities::Model do
 
     context "when it doesn't have the method id=" do
       it 'should make a request to save model with id returning false and an error' do
-        subject.save.should be(false)
-        subject.kalibro_errors[0].should be_a(NoMethodError)
+        expect(subject.save).to be(false)
+        expect(subject.kalibro_errors[0]).to be_a(NoMethodError)
       end
     end
 
@@ -135,8 +135,8 @@ describe KalibroGem::Entities::Model do
       end
 
       it 'should make a request to save model with id and return true without errors' do
-        subject.save.should be(true)
-        subject.kalibro_errors.should be_empty
+        expect(subject.save).to be(true)
+        expect(subject.kalibro_errors).to be_empty
       end
     end
   end
@@ -160,14 +160,14 @@ describe KalibroGem::Entities::Model do
     end
 
     it 'should instantiate and save the model' do
-      (KalibroGem::Entities::Model.create {}).should eq(subject)
+      expect(KalibroGem::Entities::Model.create {}).to eq(subject)
     end
   end
 
   describe '==' do
     context 'comparing objects from different classes' do
       it 'should return false' do
-        subject.should_not eq(Object.new)
+        expect(subject).not_to eq(Object.new)
       end
     end
 
@@ -180,13 +180,13 @@ describe KalibroGem::Entities::Model do
       end 
 
       it 'should return false' do
-        subject.should_not eq(another_model)
+        expect(subject).not_to eq(another_model)
       end
     end
 
     context 'with two empty models' do
       it 'should return true' do
-        subject.should eq(FactoryGirl.build(:model))
+        expect(subject).to eq(FactoryGirl.build(:model))
       end
     end
   end
@@ -201,7 +201,7 @@ describe KalibroGem::Entities::Model do
       end
 
       it 'should return false' do
-        KalibroGem::Entities::Model.exists?(0).should eq(false)
+        expect(KalibroGem::Entities::Model.exists?(0)).to eq(false)
       end
     end
 
@@ -214,7 +214,7 @@ describe KalibroGem::Entities::Model do
       end
 
       it 'should return false' do
-        KalibroGem::Entities::Model.exists?(42).should eq(true)
+        expect(KalibroGem::Entities::Model.exists?(42)).to eq(true)
       end
     end
   end
@@ -241,7 +241,7 @@ describe KalibroGem::Entities::Model do
       end
 
       it 'should return an empty model' do
-        KalibroGem::Entities::Model.find(42).should eq(subject)
+        expect(KalibroGem::Entities::Model.find(42)).to eq(subject)
       end
     end
   end
@@ -257,7 +257,7 @@ describe KalibroGem::Entities::Model do
 
       it 'should remain with the errors array empty' do
         subject.destroy
-        subject.kalibro_errors.should be_empty
+        expect(subject.kalibro_errors).to be_empty
       end
     end
 
@@ -272,7 +272,7 @@ describe KalibroGem::Entities::Model do
       it "should have an exception inside it's errors" do
         subject.destroy
 
-        subject.kalibro_errors[0].should be_an(Exception)
+        expect(subject.kalibro_errors[0]).to be_an(Exception)
       end
     end
   end
@@ -280,13 +280,13 @@ describe KalibroGem::Entities::Model do
   describe 'create_objects_array_from_hash' do
     context 'with nil' do
       it 'should return an empty array' do
-        KalibroGem::Entities::Model.create_objects_array_from_hash(nil).should eq([])
+        expect(KalibroGem::Entities::Model.create_objects_array_from_hash(nil)).to eq([])
       end
     end
 
     context 'with a Hash' do
       it 'should return the correspondent object to the given hash inside of an Array' do
-        KalibroGem::Entities::Model.create_objects_array_from_hash({}).should eq([subject])
+        expect(KalibroGem::Entities::Model.create_objects_array_from_hash({})).to eq([subject])
       end
     end
   end
@@ -295,7 +295,7 @@ describe KalibroGem::Entities::Model do
     it 'should assign to kalibro_errors' do
       subject.errors = "test"
 
-      subject.kalibro_errors.should eq('test')
+      expect(subject.kalibro_errors).to eq('test')
     end
   end
 end

data/spec/entities/module_result_spec.rb

@@ -29,8 +29,8 @@ describe KalibroGem::Entities::ModuleResult do
       end
 
       it 'should return a hash with module result' do
-        KalibroGem::Entities::ModuleResult.
-          find(subject.id).id.should eq(subject.id)
+        expect(KalibroGem::Entities::ModuleResult.
+          find(subject.id).id).to eq(subject.id)
       end
     end
 
@@ -61,7 +61,7 @@ describe KalibroGem::Entities::ModuleResult do
     end
 
     it 'should return a list of a objects' do
-      subject.children.should eq [subject]
+      expect(subject.children).to eq [subject]
     end
   end
 
@@ -77,13 +77,13 @@ describe KalibroGem::Entities::ModuleResult do
       end
 
       it 'should return its parent' do
-        subject.parents.should eq [root_module_result]
+        expect(subject.parents).to eq [root_module_result]
       end
     end
 
     context 'when module result does not have a parent' do
       it 'should return an empty list' do
-        root_module_result.parents.should eq []
+        expect(root_module_result.parents).to eq []
       end
     end
   end
@@ -91,7 +91,7 @@ describe KalibroGem::Entities::ModuleResult do
   describe 'id=' do
     it 'should set the id attribute as integer' do
       subject.id = "23"
-      subject.id.should eq 23
+      expect(subject.id).to eq 23
     end
   end
 
@@ -100,21 +100,21 @@ describe KalibroGem::Entities::ModuleResult do
 
     it 'should set the module attribute as a Module object' do
       subject.module = another_module.to_hash
-      subject.module.should eq another_module
+      expect(subject.module).to eq another_module
     end
   end
 
   describe 'grade=' do
     it 'should set the grade attribute as float' do
       subject.grade = "12.5"
-      subject.grade.should eq 12.5
+      expect(subject.grade).to eq 12.5
     end
   end
 
   describe 'parent_id=' do
     it 'should set the parent_id attribute as integer' do
       subject.parent_id = "73"
-      subject.parent_id.should eq 73
+      expect(subject.parent_id).to eq 73
     end
   end
 
@@ -129,7 +129,7 @@ describe KalibroGem::Entities::ModuleResult do
 
     it 'should return a list of date_module_results' do
       date_module_results = KalibroGem::Entities::ModuleResult.history_of subject.id
-      date_module_results.first.result.should eq date_module_result.result
+      expect(date_module_results.first.result).to eq date_module_result.result
     end
   end
 
@@ -142,8 +142,8 @@ describe KalibroGem::Entities::ModuleResult do
       end
 
       it 'should return true for folder? and false for file?' do
-        subject.folder?.should be_true
-        subject.file?.should be_false
+        expect(subject.folder?).to be_truthy
+        expect(subject.file?).to be_falsey
       end
     end
 
@@ -155,8 +155,8 @@ describe KalibroGem::Entities::ModuleResult do
       end
 
       it 'should return true for folder? and false for file?' do
-        subject.folder?.should be_false
-        subject.file?.should be_true
+        expect(subject.folder?).to be_falsey
+        expect(subject.file?).to be_truthy
       end
     end
   end