kalibro_gatekeeper_client 1.0.0.rc1 → 1.0.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2608c0043b948d427c8295b29c89a9c1696359af
-  data.tar.gz: b7fbddd6d727b1e7a3729b3c4b0747fb9e759c0c
+  metadata.gz: 949d2afc43f14ed6cae9ab66b710a27305cd3210
+  data.tar.gz: 661a875588669e291ca48e35b83ad765b345a00b
 SHA512:
-  metadata.gz: 1d8b5ccf430eb37250245f3d6c5a0665d094b2cd6a323d3f05736e1935a2ab34db357ab2f800facda853b30ce861ce58a55ce68614ccd3577ef5ef5708681173
-  data.tar.gz: 4032a1103cb3b26f2e9b7a0d3a8eb38ca9eba02c57ebe380c368c948cce7e9821a7fbf409bd03b744ce1995cbf599129fec6d21364aa381c80ebbc445808dbfc
+  metadata.gz: 0f06455e7c3b1011a031a7c6f5c003eac519d6cb0414bc2400ddf27dfcc3a6b81e0c4b8cfb8ea92c130c4fddbeda531dd6596ee512f9dd5599ddc91a3eea7b9e
+  data.tar.gz: 68730d8631441a827badd7b8ce203d582860182f85758bef5969072dce8e729956476ad354464e33ff4944aa26c4e4a674b02484acf34eb2ca6d896802a8a916

data/features/reading/all.feature

@@ -8,6 +8,6 @@ Feature: Reading listing
     Given I have a reading group with name "Kalibro"
     And the given reading group has the following readings:
       |   label   | grade |     color    |
-      | "Awesome" |  10   |     3333FF   |
+      | "Awesome" |  10   |     3333ff   |
     When I ask for all the readings
     Then the response should contain the given reading

data/features/reading/exists.feature

@@ -8,6 +8,6 @@ Feature: Reading listing
     Given I have a reading group with name "RG"
     And the given reading group has the following readings:
       |   label   | grade |     color    |
-      | "Awesome" |  10   |     3333FF   |
+      | "Awesome" |  10   |     3333ff   |
     When I ask to check if the given reading exists
     Then I should get true

data/features/reading/readings_of.feature

@@ -1,4 +1,4 @@
-Feature: Find
+Feature: Readings Of
   In order to be able to have readings
   As an developer
   I want to get the readings of the given reading group

data/features/step_definitions/metric_configuration_steps.rb

@@ -42,12 +42,10 @@ When(/^I request all metric configurations of the given configuration$/) do
 end
 
 Then(/^it should return the same metric configuration as the given one$/) do
-  pending
   expect(@found_metric_configuration).to eq(@metric_configuration)
 end
 
 Then(/^I should get a list of its metric configurations$/) do
-  pending
   expect(@metric_configurations).to eq([@metric_configuration])
 end
 

data/features/step_definitions/reading_steps.rb

@@ -27,16 +27,13 @@ When(/^I ask to check if the given reading exists$/) do
 end
 
 Then(/^I should get the given reading$/) do
-  pending
   expect(@found_reading).to eq(@reading)
 end
 
 Then(/^I should get a list with the given reading$/) do
-  pending
   expect(@found_readings.first).to eq(@reading)
 end
 
 Then(/^the response should contain the given reading$/) do
-  pending
   expect(@all_readings.first).to eq(@reading)
 end

data/lib/kalibro_gatekeeper_client/entities/metric_collector.rb

@@ -19,18 +19,18 @@ require "kalibro_gatekeeper_client/entities/model"
 module KalibroGatekeeperClient
   module Entities
     class MetricCollector < Model
-      attr_accessor :name, :description, :collector_class_name, :supported_metric, :wanted_metrics, :processing
+      attr_accessor :name, :description, :supported_metrics, :wanted_metrics, :processing
 
-      def supported_metric=(value)
-        @supported_metric = KalibroGatekeeperClient::Entities::Metric.to_objects_array value
-      end
-
-      def supported_metrics
-        @supported_metric
+      def supported_metrics=(value)
+        @supported_metrics = {}
+        value.each do |code, metric|
+          @supported_metrics[code] = KalibroGatekeeperClient::Entities::Metric.new metric
+        end
       end
 
       def metric(name)
-        supported_metrics.find {|metric| metric.name == name}
+        metric = self.supported_metrics.find {|code, metric| metric.name == name}
+        metric.nil? ? nil : metric.last
       end
 
       def self.find_by_name(metric_collector_name)
@@ -47,9 +47,9 @@ module KalibroGatekeeperClient
       end
 
       def self.all
-        metric_collectors = all_names
-        metric_collectors.map{ |name| find_by_name(name) }
+        metric_collectors_names = all_names
+        metric_collectors_names.map{ |name| find_by_name(name) }
       end
     end
   end
-end
+end

data/lib/kalibro_gatekeeper_client/entities/reading.rb

@@ -28,6 +28,10 @@ module KalibroGatekeeperClient
         @grade = value.to_f
       end
 
+      def group_id=(value)
+        @group_id = value.to_i
+      end
+
       def self.find(id)
         response = request('get', {id: id})
         raise KalibroGatekeeperClient::Errors::RecordNotFound unless response['error'].nil?

data/lib/kalibro_gatekeeper_client/version.rb

@@ -15,5 +15,5 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 module KalibroGatekeeperClient
-  VERSION = "1.0.0.rc1"
+  VERSION = "1.0.0.rc2"
 end

data/spec/entities/metric_collector_spec.rb

@@ -67,8 +67,8 @@ describe KalibroGatekeeperClient::Entities::MetricCollector do
     end
 
     context 'with many metric collectors' do
-      let(:metric_collector) { FactoryGirl.build(:metric_collector) }
-      let(:another_metric_collector) { FactoryGirl.build(:another_metric_collector) }
+      let!(:metric_collector) { FactoryGirl.build(:metric_collector) }
+      let!(:another_metric_collector) { FactoryGirl.build(:another_metric_collector) }
 
       before :each do
         KalibroGatekeeperClient::Entities::MetricCollector.
@@ -77,14 +77,14 @@ describe KalibroGatekeeperClient::Entities::MetricCollector do
           returns({'metric_collector_names' => [metric_collector.name, another_metric_collector.name]}.to_json)
 
         KalibroGatekeeperClient::Entities::MetricCollector.
-          expects(:request).
-          with(:get, {name: metric_collector.name}).
-          returns(metric_collector.to_hash)
+          expects(:find_by_name).
+          with(metric_collector.name).
+          returns(metric_collector)
 
         KalibroGatekeeperClient::Entities::MetricCollector.
-          expects(:request).
-          with(:get, {name: another_metric_collector.name}).
-          returns(another_metric_collector.to_hash)
+          expects(:find_by_name).
+          with(another_metric_collector.name).
+          returns(another_metric_collector)
       end
 
       it 'should return the two elements' do
@@ -115,11 +115,15 @@ describe KalibroGatekeeperClient::Entities::MetricCollector do
     end
 
     context 'with an existent name' do
+      #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with sybols and integers
+      let!(:params) { Hash[FactoryGirl.attributes_for(:metric_collector).map { |k,v| [k.to_s, v.to_s]}] }
+      let(:metric_params) { { "total_abstract_classes" => Hash[FactoryGirl.attributes_for(:metric).map { |k,v| if v.is_a?(Array) then [k.to_s, v] else [k.to_s, v.to_s] end}] } }
       before :each do
+        params["supported_metrics"] = metric_params
         KalibroGatekeeperClient::Entities::MetricCollector.
           expects(:request).
           with(:get,{name: subject.name}).
-          returns(subject.to_hash)
+          returns(params)
       end
 
       it 'should return a metric_collector' do
@@ -128,34 +132,22 @@ describe KalibroGatekeeperClient::Entities::MetricCollector do
     end
   end
 
-  describe 'Supported Metric' do
-    let(:metric) { FactoryGirl.build(:metric) }
-
-    before :each do
-      KalibroGatekeeperClient::Entities::Metric.
-        expects(:to_objects_array).at_least_once.
-        with(metric.to_hash).
-        returns([metric])
-    end
+  describe 'Supported Metrics' do
+    let(:code_and_metric) { { "total_abstract_classes" => FactoryGirl.build(:metric) } }
+    #FIXME: Mocha is creating the expectations with strings, but FactoryGirl returns everything with sybols and integers
+    let(:code_and_metric_parameter) { { "total_abstract_classes" => Hash[FactoryGirl.attributes_for(:metric).map { |k,v| if v.is_a?(Array) then [k.to_s, v] else [k.to_s, v.to_s] end}] } }
 
-    context 'supported_metric=' do
+    context 'supported_metrics acessors' do
       it 'should set the value of the array of supported metrics' do
-        subject.supported_metric = metric.to_hash
-        expect(subject.supported_metric.first.name).to eq(metric.name)
-      end
-    end
-
-    context 'supported_metrics' do
-      it 'should return the array of the supported metrics' do
-        subject.supported_metric = metric.to_hash
-        expect(subject.supported_metrics.first.name).to eq(metric.name)
+        subject.supported_metrics = code_and_metric_parameter
+        expect(subject.supported_metrics).to eq(code_and_metric)
       end
     end
   end
 
   describe 'metric' do
     subject { FactoryGirl.build(:metric_collector) }
-    let(:metric) { subject.supported_metrics.first }
+    let(:metric) { subject.supported_metrics["loc"] }
 
     it 'should return nil with an inexistent name' do
       expect(subject.metric("fake name")).to be_nil
@@ -165,4 +157,4 @@ describe KalibroGatekeeperClient::Entities::MetricCollector do
       expect(subject.metric(metric.name).name).to eq(metric.name)
     end
   end
-end
+end

data/spec/factories/metric_collectors.rb

@@ -18,8 +18,7 @@ FactoryGirl.define do
   factory :metric_collector, class: KalibroGatekeeperClient::Entities::MetricCollector do
     name "Analizo"
     description "Analizo is a suite of source code analysis tools."
-    collector_class_name "org.analizo.AnalizoMetricCollector"
-    supported_metric { [FactoryGirl.build(:metric), FactoryGirl.build(:metric)] }
+    supported_metrics { { "total_abstract_classes" => FactoryGirl.build(:metric).to_hash, "loc" => FactoryGirl.build(:loc).to_hash } }
 
     trait :another_metric_collector do
       name "Avalio"
@@ -28,4 +27,4 @@ FactoryGirl.define do
 
     factory  :another_metric_collector, traits: [:another_metric_collector]
   end
-end
+end

data/spec/factories/metrics.rb

@@ -17,19 +17,19 @@
 FactoryGirl.define do
   factory :metric, class: KalibroGatekeeperClient::Entities::Metric do
     name "Total Abstract Classes"
-    compound false
+    compound "false"
     scope "SOFTWARE"
-    description nil
+    description ""
     script ""
     language ["C", "CPP", "JAVA"]
   end
 
   factory :loc, class: KalibroGatekeeperClient::Entities::Metric do
     name "Lines of Code"
-    compound false
+    compound "false"
     scope "CLASS"
-    description nil
+    description ""
     script ""
     language ["C", "CPP", "JAVA"]
   end
-end
+end

data/spec/factories/reading_groups.rb

@@ -5,7 +5,7 @@
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
-# 
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ -19,5 +19,5 @@ FactoryGirl.define do
     id 1
     name "Mussum"
     description "Cacildis!"
-  end  
+  end
 end

data/spec/factories/readings.rb

@@ -5,7 +5,7 @@
 # it under the terms of the GNU General Public License as published by
 # the Free Software Foundation, either version 3 of the License, or
 # (at your option) any later version.
-# 
+#
 # This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ -18,8 +18,8 @@ FactoryGirl.define do
   factory :reading, class: KalibroGatekeeperClient::Entities::Reading do
     id 42
     label "Good"
-    grade 10.5 
-    color "33DD33" 
+    grade 10.5
+    color "33dd33"
     group_id 31
-  end  
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kalibro_gatekeeper_client
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.0.0.rc2
 platform: ruby
 authors:
 - Diego Araújo Martinez
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-09 00:00:00.000000000 Z
+date: 2014-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler