kalibro_gatekeeper_client 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3d38c2656e3dee67a4f88b3269ff764f3070bbea
-  data.tar.gz: 944b361d3fef5157ffe4c8c6895e43c02aec6c24
+  metadata.gz: 84a0ce9402375b7ad0808157427a4289530d0692
+  data.tar.gz: 70ab4e629016adbb2ded06b897f7be43e7fb8b2c
 SHA512:
-  metadata.gz: f23504ffbf5cb432e37fc2b548b74ee99fa6712f71656df494c2e4f1daf378a5b8630a47e8ed02da5c7fdcc0dc3fb16a134dd977c0ad6c769a2c5d2494acf7f4
-  data.tar.gz: 9c9da2ac04cd95040d03d0479fcefffaf436d2988bba5a5ae580fe3d170e5223e835e3ba0f52318223934461536fed679146afb4d5297f7ff1eac8fff9c752dc
+  metadata.gz: eb82d09dd8b19b9de2dec1dcfc2a88026cb422e02ad9d394cfd3f9716e29bcafa6cfd3839f23eacfaf0f1c87347d0901360f9c4c3271fa9a542b612dd9e7a7ec
+  data.tar.gz: c72ce98773cfa90616ab65466d9b3ae5cf7f7876cf01b631c2620c364d3d340dd167e98c1b3c985ece827684dc54c099d4c71ab3545c4339269c33a518957e62

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.ruby-version

@@ -1 +1 @@
-ruby-2.1.1
+ruby-2.1.2

data/.travis.yml

@@ -1,14 +1,16 @@
 language: ruby
 rvm:
-  - 2.1.1
+  - 2.1.2
 
 before_script:
-  - wget https://gist.github.com/rafamanzo/6179925/raw/77653bd6229e99d5251180a4488e2fa54d0cd4ac/db_bootstrap.sql
-  - wget https://gist.github.com/rafamanzo/6179925/raw/a38c3b33af3b1784eece46450cca65503337e4b5/install.sh
-  - chmod +x install.sh
-  - ./install.sh
+  - git clone https://gist.github.com/0c4ad3b5700c6364abf1.git -b v1.0 kalibro_install
+  - pushd kalibro_install
+    # Remove bugged libzmq3 package, see https://github.com/travis-ci/travis-ci/issues/982 and https://github.com/travis-ci/travis-ci/issues/1715 for details
+  - sudo apt-get remove libzmq3
+  - bash install.sh
+  - popd
   - cp features/support/kalibro_cucumber_helpers.yml.sample features/support/kalibro_cucumber_helpers.yml
-  - git clone https://github.com/mezuro/kalibro_gatekeeper.git
+  - git clone https://github.com/mezuro/kalibro_gatekeeper.git -b v0.0.1 kalibro_gatekeeper
   - cd kalibro_gatekeeper
   - cp config/database.yml.sample config/database.yml
   - export BUNDLE_GEMFILE=$PWD/Gemfile

data/features/step_definitions/base_tool_steps.rb

@@ -8,21 +8,21 @@ end
 
 When(/^I search base tool Avalio by name$/) do
   @is_error = false
-  begin 
+  begin
   	KalibroGatekeeperClient::Entities::BaseTool.find_by_name("Avalio")
 	rescue KalibroGatekeeperClient::Errors::RecordNotFound
-  	@is_error = true 
+  	@is_error = true
   end
 end
 
 Then(/^it should return Checkstyle and Analizo strings inside of an array$/) do
-  (@base_tool_names.include?("Checkstyle") && @base_tool_names.include?("Analizo")).should be_true
+  expect(@base_tool_names.include?("Checkstyle") && @base_tool_names.include?("Analizo")).to be_truthy
 end
 
 Then(/^I should get Analizo base tool$/) do
-  @result.name.should eq "Analizo"
+  expect(@result.name).to eq("Analizo")
 end
 
 Then(/^I should get an error$/) do
-  @is_error.should be_true
+  expect(@is_error).to be_truthy
 end

data/features/step_definitions/configuration_steps.rb

@@ -6,14 +6,14 @@ When(/^I get all the configurations$/) do
   @all_configurations = KalibroGatekeeperClient::Entities::Configuration.all
 end
 
-Then(/^I should get a list with the given configuration$/) do
-  @all_configurations.include?(@configuration).should be_true
-end
-
 When(/^I create the configuration with name "(.*?)"$/) do |name|
   @configuration = FactoryGirl.create(:configuration, {name: name, id: nil})
 end
 
+Then(/^I should get a list with the given configuration$/) do
+  expect(@all_configurations.include?(@configuration)).to be_truthy
+end
+
 Then(/^the configuration should exist$/) do
-  KalibroGatekeeperClient::Entities::Configuration.exists?(@configuration.id).should be_true
+  expect(KalibroGatekeeperClient::Entities::Configuration.exists?(@configuration.id)).to be_truthy
 end

data/features/step_definitions/metric_configuration_steps.rb

@@ -40,13 +40,15 @@ When(/^I request all metric configurations of the given configuration$/) do
 end
 
 Then(/^it should return the same metric configuration as the given one$/) do
-  @found_metric_configuration == @metric_configuration
+  pending
+  expect(@found_metric_configuration).to eq(@metric_configuration)
 end
 
 Then(/^I should get a list of its metric configurations$/) do
-  @metric_configurations == [@metric_configuration]
+  pending
+  expect(@metric_configurations).to eq([@metric_configuration])
 end
 
 Then(/^I should get an empty list of metric configurations$/) do
-  @metric_configurations == []
+  expect(@metric_configurations).to eq([])
 end

data/features/step_definitions/metric_result_steps.rb

@@ -14,16 +14,16 @@ When(/^I call the history of method with the metric name and the results root id
 end
 
 Then (/^I should get a Float list$/) do
-  @response.should be_a(Array)
-  @response.first.should be_a(Float)
+  expect(@response).to be_a(Array)
+  expect(@response.first).to be_a(Float)
 end
 
 Then(/^I should get a list of metric results$/) do
-  @response.should be_a(Array)
-  @response.first.should be_a(KalibroGatekeeperClient::Entities::MetricResult)
+  expect(@response).to be_a(Array)
+  expect(@response.first).to be_a(KalibroGatekeeperClient::Entities::MetricResult)
 end
 
 Then(/^I should get a list of date metric results$/) do
-  @response.should be_a(Array)
-  @response.first.should be_a(KalibroGatekeeperClient::Entities::DateMetricResult)
+  expect(@response).to be_a(Array)
+  expect(@response.first).to be_a(KalibroGatekeeperClient::Entities::DateMetricResult)
 end

data/features/step_definitions/module_result_steps.rb

@@ -16,15 +16,15 @@ When(/^I ask for an inexistent module result$/) do
   end
 end
 
-Then(/^I should get the given module result$/) do
-  @found_module_result == @module_result
-end
-
 When(/^I ask for the children of the processing root module result$/) do
   @children = KalibroGatekeeperClient::Entities::ModuleResult.
     find(KalibroGatekeeperClient::Entities::Processing.processing_of(@repository.id).results_root_id)
 end
 
 Then(/^I should get a list with the children module results$/) do
-  @children.should be_a(KalibroGatekeeperClient::Entities::ModuleResult)
+  expect(@children).to be_a(KalibroGatekeeperClient::Entities::ModuleResult)
+end
+
+Then(/^I should get the given module result$/) do
+  expect(@found_module_result).to eq(@module_result)
 end

data/features/step_definitions/processing_steps.rb

@@ -67,25 +67,25 @@ When(/^I call the processing_with_date_of method for the given repository and ye
 end
 
 Then(/^I should get a Processing with state "(.*?)"$/) do |state|
-  @response.state.should eq(state)
+  expect(@response.state).to eq(state)
 end
 
 Then(/^I should get nil$/) do
-  @response.should be_nil
+  expect(@response).to be_nil
 end
 
 Then(/^I should get "(.*?)"$/) do |state|
-  @response.should eq(state)
+  expect(@response).to eq(state)
 end
 
 Then(/^I should get false$/) do
-  @response.should be_false
+  expect(@response).to be_falsey
 end
 
 Then(/^I should get true$/) do
-  @response.should be_true
+  expect(@response).to be_truthy
 end
 
 Then(/^I should get a Processing$/) do
-  @response.should be_a(KalibroGatekeeperClient::Entities::Processing)
+  expect(@response).to be_a(KalibroGatekeeperClient::Entities::Processing)
 end

data/features/step_definitions/project_steps.rb

@@ -32,17 +32,17 @@ When(/^I ask for all the projects$/) do
 end
 
 Then(/^the project should exist$/) do
-  KalibroGatekeeperClient::Entities::Project.exists?(@project.id).should be_true
+  expect(KalibroGatekeeperClient::Entities::Project.exists?(@project.id)).to be_truthy
 end
 
 Then(/^it should return the same project as the given one$/) do
-  @found_project == @project
+  expect(@found_project).to eq(@project)
 end
 
 Then(/^the project should not exist$/) do
-  KalibroGatekeeperClient::Entities::Project.exists?(@found_project.id).should be_false
+  expect(KalibroGatekeeperClient::Entities::Project.exists?(@found_project.id)).to be_falsey
 end
 
 Then(/^I should get a list with the given project$/) do
-  @all_projects.include?(@project)
+  expect(@all_projects).to include(@project)
 end

data/features/step_definitions/range_steps.rb

@@ -17,7 +17,7 @@ end
 
 When(/^I ask to save the given range with an inexistent metric configuration$/) do
   @range.metric_configuration_id = rand(Time.now.to_i)
-  @range.save 
+  @range.save
 end
 
 When(/^I ask ranges of the given metric configuration$/) do
@@ -27,8 +27,8 @@ end
 When(/^I try to save a range with an inexistent metric configuration$/) do
     @range = FactoryGirl.build(:range, {id: nil, reading_id: @reading.id})
     @range.metric_configuration_id = rand(Time.now.to_i)
-    @range.save 
-end 
+    @range.save
+end
 
 When(/^I ask for all the ranges$/) do
   @response = KalibroGatekeeperClient::Entities::Range.all
@@ -39,30 +39,30 @@ When(/^I search a range with the same id of the given range$/) do
 end
 
 Then(/^I should get an empty list$/) do
-  @response.should eq([])
+  expect(@response).to eq([])
 end
 
 Then(/^I should not get an empty list$/) do
-  @response.should_not eq([])
+  expect(@response).to_not eq([])
 end
 
 Then(/^I should get a list with the given range$/) do
-  @response.size.should eq(1)
-  @response.first.comments.should eq(@range.comments)
+  expect(@response.size).to eq(1)
+  expect(@response.first.comments).to eq(@range.comments)
 end
 
 Then(/^I should get an error in range kalibro errors attribute$/) do
-  @range.kalibro_errors.should_not eq([])
+  expect(@range.kalibro_errors).to_not eq([])
 end
 
 Then(/^the id of the given range should be set$/) do
-  @range.id.should_not eq(0)
+  expect(@range.id).to_not eq(0)
 end
 
 Then(/^it should return the same range as the given one$/) do
-  @found_range == @range
+  expect(@found_range).to eq(@range)
 end
 
 Then(/^the range should exist$/) do
-  KalibroGatekeeperClient::Entities::Range.exists?(@range.id)
+  expect(KalibroGatekeeperClient::Entities::Range.exists?(@range.id)).to be_truthy
 end

data/features/step_definitions/reading_group_steps.rb

@@ -11,9 +11,9 @@ When(/^I call the reading_group_of method for the given MetricConfiguration$/) d
 end
 
 Then(/^I should get a list with the given reading group$/) do
-   @all_reading_groups.include?(@reading_group)
+  expect(@all_reading_groups).to include(@reading_group)
 end
 
 Then(/^I should get the given RedingGroup$/) do
-  @metric_configuration_reading_group.should eq(@reading_group)  
+  expect(@metric_configuration_reading_group).to eq(@reading_group)
 end

data/features/step_definitions/reading_steps.rb

@@ -27,13 +27,16 @@ When(/^I ask to check if the given reading exists$/) do
 end
 
 Then(/^I should get the given reading$/) do
-  @found_reading == @reading
+  pending
+  expect(@found_reading).to eq(@reading)
 end
 
 Then(/^I should get a list with the given reading$/) do
-  @found_readings.first == @reading
+  pending
+  expect(@found_readings.first).to eq(@reading)
 end
 
 Then(/^the response should contain the given reading$/) do
-  @all_readings.first == @reading
+  pending
+  expect(@all_readings.first).to eq(@reading)
 end

data/features/step_definitions/repository_steps.rb

@@ -36,26 +36,26 @@ When(/^I ask to check if the given repository exists$/) do
 end
 
 Then(/^I should get success$/) do
-  @response == true
+  expect(@response).to be_truthy
 end
 
 Then(/^I should get a list with the given repository$/) do
-  @response.should include(@repository)
+  expect(@response).to include(@repository)
 end
 
 Then(/^I should get an array of types$/) do
-  @repository_types.is_a?(Array)
-  @repository_types.count >= 1
+  expect(@repository_types).to be_a(Array)
+  expect(@repository_types.count >= 1).to be_truthy
 end
 
 Then(/^I should get the given repository$/) do
-  @response.should eq(@repository)
+  expect(@response).to eq(@repository)
 end
 
 Then(/^the response should contain the given repository$/) do
-  @response.first.project_id.should eq(@project.id)
+  expect(@response.first.project_id).to eq(@project.id)
 end
 
 Then(/^the repositories should contain the project id$/) do
-  @response.first.project_id.should eq(@project.id)
+  expect(@response.first.project_id).to eq(@project.id)
 end

data/kalibro_gatekeeper_client.gemspec

@@ -37,9 +37,9 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 2.14"
+  spec.add_development_dependency "rspec", "~> 3.0.0"
   spec.add_development_dependency "cucumber", "~> 1.3.14"
-  spec.add_development_dependency "mocha", "~> 1.0.0"
+  spec.add_development_dependency "mocha", "~> 1.1.0"
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "factory_girl", "~> 4.4.0"
   spec.add_development_dependency 'coveralls'

data/lib/kalibro_gatekeeper_client/entities/metric.rb

@@ -1,7 +1,6 @@
 module KalibroGatekeeperClient
   module Entities
     class Metric < Model
-      
       attr_accessor :name, :compound, :scope, :description, :script, :language
 
       def languages
@@ -16,6 +15,11 @@ module KalibroGatekeeperClient
         @language = self.class.to_objects_array value
       end
 
+      def compound
+        return true if @compound == true || @compound =~ (/(true|t|yes|y|1)$/i)
+        return false if @compound == false || @compound.empty? || @compound =~ (/(false|f|no|n|0)$/i)
+        raise ArgumentError.new("invalid value for Boolean: \"#{@compound}\"")
+      end
     end
   end
 end

data/lib/kalibro_gatekeeper_client/version.rb

@@ -15,5 +15,5 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 module KalibroGatekeeperClient
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/spec/entities/base_tool_spec.rb

@@ -27,7 +27,7 @@ describe KalibroGatekeeperClient::Entities::BaseTool do
       end
 
       it 'should return empty array' do
-        KalibroGatekeeperClient::Entities::BaseTool.all_names.should be_empty
+        expect(KalibroGatekeeperClient::Entities::BaseTool.all_names).to be_empty
       end
     end
 
@@ -45,9 +45,9 @@ describe KalibroGatekeeperClient::Entities::BaseTool do
       it 'should return the two elements' do
         names = KalibroGatekeeperClient::Entities::BaseTool.all_names
 
-        names.size.should eq(2)
-        names.first.should eq(JSON.parse(base_tool_hash.to_json))
-        names.last.should eq(JSON.parse(another_base_tool_hash.to_json))
+        expect(names.size).to eq(2)
+        expect(names.first).to eq(JSON.parse(base_tool_hash.to_json))
+        expect(names.last).to eq(JSON.parse(another_base_tool_hash.to_json))
       end
     end
   end
@@ -62,7 +62,7 @@ describe KalibroGatekeeperClient::Entities::BaseTool do
       end
 
       it 'should return empty array' do
-        KalibroGatekeeperClient::Entities::BaseTool.all_names.should be_empty
+        expect(KalibroGatekeeperClient::Entities::BaseTool.all_names).to be_empty
       end
     end
 
@@ -90,9 +90,9 @@ describe KalibroGatekeeperClient::Entities::BaseTool do
       it 'should return the two elements' do
         base_tools = KalibroGatekeeperClient::Entities::BaseTool.all
 
-        base_tools.size.should eq(2)
-        base_tools.first.name.should eq(base_tool.name)
-        base_tools.last.name.should eq(another_base_tool.name)
+        expect(base_tools.size).to eq(2)
+        expect(base_tools.first.name).to eq(base_tool.name)
+        expect(base_tools.last.name).to eq(another_base_tool.name)
       end
     end
   end
@@ -123,7 +123,7 @@ describe KalibroGatekeeperClient::Entities::BaseTool do
       end
 
       it 'should return a base_tool' do
-        KalibroGatekeeperClient::Entities::BaseTool.find_by_name(subject.name).name.should eq(subject.name)
+        expect(KalibroGatekeeperClient::Entities::BaseTool.find_by_name(subject.name).name).to eq(subject.name)
       end
     end
   end
@@ -141,14 +141,14 @@ describe KalibroGatekeeperClient::Entities::BaseTool do
     context 'supported_metric=' do
       it 'should set the value of the array of supported metrics' do
         subject.supported_metric = metric.to_hash
-        subject.supported_metric.first.name.should eq(metric.name)
+        expect(subject.supported_metric.first.name).to eq(metric.name)
       end
     end
 
     context 'supported_metrics' do
       it 'should return the array of the supported metrics' do
         subject.supported_metric = metric.to_hash
-        subject.supported_metrics.first.name.should eq(metric.name)
+        expect(subject.supported_metrics.first.name).to eq(metric.name)
       end
     end
   end
@@ -158,11 +158,11 @@ describe KalibroGatekeeperClient::Entities::BaseTool do
     let(:metric) { subject.supported_metrics.first }
     
     it 'should return nil with an inexistent name' do
-      subject.metric("fake name").should be_nil
+      expect(subject.metric("fake name")).to be_nil
     end
 
     it 'should return a metric with an existent name' do
-      subject.metric(metric.name).name.should eq(metric.name)
+      expect(subject.metric(metric.name).name).to eq(metric.name)
     end
   end
 end