kalibro_client 3.0.1 → 4.0.0.alpha1

data/spec/entities/configurations/kalibro_configuration_spec.rb

@@ -24,41 +24,6 @@ describe KalibroClient::Entities::Configurations::KalibroConfiguration do
     end
   end
 
-  describe 'all' do
-    context 'with no configurations' do
-      before :each do
-        KalibroClient::Entities::Configurations::KalibroConfiguration.
-          expects(:request).
-          with('', {}, :get).
-          returns({'kalibro_configurations' => []})
-      end
-
-      it 'is expected to return nil' do
-        expect(KalibroClient::Entities::Configurations::KalibroConfiguration.all).to be_empty
-      end
-    end
-
-    context 'with many configurations' do
-      let(:kalibro_configuration) { FactoryGirl.build(:kalibro_configuration_with_id) }
-      let(:another_kalibro_configuration) { FactoryGirl.build(:another_kalibro_configuration) }
-
-      before :each do
-        KalibroClient::Entities::Configurations::KalibroConfiguration.
-          expects(:request).
-          with('', {}, :get).
-          returns({'kalibro_configurations' => [kalibro_configuration.to_hash, another_kalibro_configuration.to_hash]})
-      end
-
-      it 'is expected to return the two elements' do
-        kalibro_configurations = KalibroClient::Entities::Configurations::KalibroConfiguration.all
-
-        expect(kalibro_configurations.size).to eq(2)
-        expect(kalibro_configurations.first.name).to eq(kalibro_configuration.name)
-        expect(kalibro_configurations.last.name).to eq(another_kalibro_configuration.name)
-      end
-    end
-  end
-
   describe 'metric_configurations' do
     context 'with no metric configurations' do
       before :each do

data/spec/entities/configurations/kalibro_range_spec.rb

@@ -123,7 +123,7 @@ describe KalibroClient::Entities::Configurations::KalibroRange do
     before :each do
       KalibroClient::Entities::Configurations::KalibroRange.
         expects(:request).
-        with('', {:kalibro_range => subject.to_hash, :metric_configuration_id => subject.metric_configuration_id}, :post, "metric_configurations/#{subject.metric_configuration_id}").
+        with('', {:kalibro_range => subject.to_hash, :metric_configuration_id => subject.metric_configuration_id}, :post, "metric_configurations/#{subject.metric_configuration_id}", {}).
         returns("kalibro_range" => { 'id' => 2, 'kalibro_errors' => []})
     end
 
@@ -140,7 +140,7 @@ describe KalibroClient::Entities::Configurations::KalibroRange do
     before :each do
       KalibroClient::Entities::Configurations::KalibroRange.
         expects(:request).
-        with(":id", {id: subject.id}, :delete, "metric_configurations/#{subject.metric_configuration_id}").returns({})
+        with(":id", {id: subject.id}, :delete, "metric_configurations/#{subject.metric_configuration_id}", {}).returns({})
     end
 
     it 'should make a request to destroy' do
@@ -156,7 +156,7 @@ describe KalibroClient::Entities::Configurations::KalibroRange do
       subject.end = "555"
       KalibroClient::Entities::Configurations::KalibroRange.
         expects(:request).
-        with(':id', {:kalibro_range => subject.to_hash, :id => subject.id}, :put, "metric_configurations/#{subject.metric_configuration_id}").
+        with(':id', {:kalibro_range => subject.to_hash, :id => subject.id}, :put, "metric_configurations/#{subject.metric_configuration_id}", {}).
         returns("errors" => nil)
     end
 

data/spec/entities/configurations/metric_configuration_spec.rb

@@ -159,7 +159,7 @@ describe KalibroClient::Entities::Configurations::MetricConfiguration do
     before :each do
       KalibroClient::Entities::Configurations::MetricConfiguration.
       expects(:request).
-      with('', {:metric_configuration => subject.to_hash, :kalibro_configuration_id => subject.kalibro_configuration_id}, :post, '').
+      with('', {:metric_configuration => subject.to_hash, :kalibro_configuration_id => subject.kalibro_configuration_id}, :post, '', {}).
       returns("metric_configuration" => {'id' => 1, 'kalibro_errors' => []})
     end
 
@@ -169,63 +169,6 @@ describe KalibroClient::Entities::Configurations::MetricConfiguration do
     end
   end
 
-  describe 'exists?' do
-    subject {FactoryGirl.build(:metric_configuration_with_id)}
-
-    context 'when the metric configuration exists' do
-      before :each do
-        KalibroClient::Entities::Configurations::MetricConfiguration.expects(:find).with(subject.id).returns(subject)
-      end
-
-      it 'should return true' do
-        expect(KalibroClient::Entities::Configurations::MetricConfiguration.exists?(subject.id)).to be_truthy
-      end
-    end
-
-    context 'when the metric configuration does not exist' do
-      before :each do
-        KalibroClient::Entities::Configurations::MetricConfiguration.expects(:find).with(subject.id).raises(KalibroClient::Errors::RecordNotFound)
-      end
-
-      it 'should return false' do
-        expect(KalibroClient::Entities::Configurations::MetricConfiguration.exists?(subject.id)).to be_falsey
-      end
-    end
-  end
-
-  describe 'find' do
-    let(:metric_configuration) { FactoryGirl.build(:metric_configuration_with_id) }
-
-    context 'with an existant MetricConfiguration' do
-      before :each do
-        KalibroClient::Entities::Configurations::MetricConfiguration.
-        expects(:request).
-        with(':id', {id: metric_configuration.id}, :get).
-        returns({'metric_configuration' => metric_configuration.to_hash})
-      end
-
-      it 'should return the metric_configuration' do
-        found_metric_configuration = KalibroClient::Entities::Configurations::MetricConfiguration.find(metric_configuration.id)
-        expect(found_metric_configuration.id).to eq(metric_configuration.id)
-        expect(found_metric_configuration.persisted).to be_truthy
-      end
-    end
-
-    context 'with an inexistant MetricConfiguration' do
-      before :each do
-        KalibroClient::Entities::Configurations::MetricConfiguration.
-        expects(:request).
-        with(':id', {id: metric_configuration.id}, :get).
-        raises(KalibroClient::Errors::RequestError)
-      end
-
-      it 'should raise the RecordNotFound error' do
-        expect {KalibroClient::Entities::Configurations::MetricConfiguration.find(metric_configuration.id)}.
-        to raise_error(KalibroClient::Errors::RecordNotFound)
-      end
-    end
-  end
-
   describe 'kalibro ranges' do
     let(:metric_configuration) { FactoryGirl.build(:metric_configuration_with_id) }
     let(:kalibro_range_1) { FactoryGirl.build(:range, metric_configuration_id: metric_configuration.id) }

data/spec/entities/configurations/reading_group_spec.rb

@@ -26,38 +26,6 @@ describe KalibroClient::Entities::Configurations::ReadingGroup do
     end
   end
 
-  describe 'all' do
-    context 'with no reading_groups' do
-      before :each do
-        KalibroClient::Entities::Configurations::ReadingGroup.
-          expects(:request).
-          with('', {}, :get).
-          returns({'reading_groups' => []})
-      end
-
-      it 'should return nil' do
-        expect(KalibroClient::Entities::Configurations::ReadingGroup.all).to be_empty
-      end
-    end
-
-    context 'with many reading_groups' do
-      let(:reading_group) { FactoryGirl.build(:reading_group_with_id) }
-      before :each do
-        KalibroClient::Entities::Configurations::ReadingGroup.
-          expects(:request).
-          with('', {}, :get).
-          returns({'reading_groups' => [reading_group.to_hash, reading_group.to_hash]})
-      end
-
-      it 'should return nil' do
-        reading_groups = KalibroClient::Entities::Configurations::ReadingGroup.all
-
-        expect(reading_groups.first.name).to eq(reading_group.name)
-        expect(reading_groups.last.name).to eq(reading_group.name)
-      end
-    end
-  end
-
   describe 'readings' do
     let(:reading_group) { FactoryGirl.build(:reading_group_with_id) }
 

data/spec/entities/configurations/reading_spec.rb

@@ -52,7 +52,7 @@ describe KalibroClient::Entities::Configurations::Reading do
     before :each do
       KalibroClient::Entities::Configurations::Reading.
         expects(:request).
-        with('', {reading: reading.to_hash, reading_group_id: reading.reading_group_id}, :post, "reading_groups/#{reading.reading_group_id}").
+        with('', {reading: reading.to_hash, reading_group_id: reading.reading_group_id}, :post, "reading_groups/#{reading.reading_group_id}", {}).
         returns("reading" => {'id' => reading_id, 'kalibro_errors' => []})
     end
 
@@ -70,7 +70,7 @@ describe KalibroClient::Entities::Configurations::Reading do
     before :each do
       KalibroClient::Entities::Configurations::Reading.
         expects(:request).
-        with(":id", {id: subject.id}, :delete, "reading_groups/#{subject.reading_group_id}").returns({})
+        with(":id", {id: subject.id}, :delete, "reading_groups/#{subject.reading_group_id}", {}).returns({})
     end
 
     it 'should make a request to destroy' do
@@ -85,7 +85,7 @@ describe KalibroClient::Entities::Configurations::Reading do
     before :each do
       KalibroClient::Entities::Configurations::Reading.
         expects(:request).
-        with(":id", {reading: subject.to_hash, id: subject.id}, :put, "reading_groups/#{subject.reading_group_id}").returns({})
+        with(":id", {reading: subject.to_hash, id: subject.id}, :put, "reading_groups/#{subject.reading_group_id}", {}).returns({})
     end
 
     it 'should make a request to update' do

data/spec/entities/processor/metric_collector_details_spec.rb

@@ -52,42 +52,37 @@ describe KalibroClient::Entities::Processor::MetricCollectorDetails do
     end
   end
 
-  describe 'all' do
-    context 'with no metric collector details' do
+  describe 'find_by_name' do
+    subject { FactoryGirl.build(:metric_collector_details) }
+
+    context 'with an inexistent name' do
       before :each do
         KalibroClient::Entities::Processor::MetricCollectorDetails.
-          expects(:request).
-          with('', {}, :get).
-          returns({"metric_collector_details" => []})
+          expects(:find_by_name!).
+          with(subject.name).
+          raises(Likeno::Errors::RecordNotFound)
       end
 
-      it 'should return empty array' do
-        expect(KalibroClient::Entities::Processor::MetricCollectorDetails.all).to be_empty
+      it 'is expected to return nil' do
+        expect(KalibroClient::Entities::Processor::MetricCollectorDetails.find_by_name(subject.name)).to be_nil
       end
     end
 
-    context 'with many metric collector details' do
-      let!(:metric_collector_details_hash) { FactoryGirl.attributes_for(:metric_collector_details) }
-      let!(:another_metric_collector_details_hash) { FactoryGirl.attributes_for(:another_metric_collector_details) }
-
+    context 'with an existent name' do
       before :each do
         KalibroClient::Entities::Processor::MetricCollectorDetails.
-          expects(:request).
-          with('', {}, :get).
-          returns({"metric_collector_details" => [metric_collector_details_hash, another_metric_collector_details_hash]})
+          expects(:find_by_name!).
+          with(subject.name).
+          returns(subject)
       end
 
-      it 'should return the two elements' do
-        metric_collector_details = KalibroClient::Entities::Processor::MetricCollectorDetails.all
-
-        expect(metric_collector_details.size).to eq(2)
-        expect(metric_collector_details.first.name).to eq(metric_collector_details_hash[:name])
-        expect(metric_collector_details.last.name).to eq(another_metric_collector_details_hash[:name])
+      it 'should return a metric_collector_details' do
+        expect(KalibroClient::Entities::Processor::MetricCollectorDetails.find_by_name(subject.name).name).to eq(subject.name)
       end
     end
   end
 
-  describe 'find_by_name' do
+  describe 'find_by_name!' do
     subject { FactoryGirl.build(:metric_collector_details) }
 
     context 'with an inexistent name' do
@@ -95,12 +90,12 @@ describe KalibroClient::Entities::Processor::MetricCollectorDetails do
         KalibroClient::Entities::Processor::MetricCollectorDetails.
           expects(:request).
           with(:find, {name: subject.name}).
-          returns(nil)
+          raises(Likeno::Errors::RecordNotFound)
       end
 
       it 'should raise a RecordNotFound error' do
-        expect { KalibroClient::Entities::Processor::MetricCollectorDetails.find_by_name(subject.name)}.
-          to raise_error(KalibroClient::Errors::RecordNotFound)
+        expect { KalibroClient::Entities::Processor::MetricCollectorDetails.find_by_name!(subject.name)}.
+          to raise_error(Likeno::Errors::RecordNotFound)
       end
     end
 
@@ -108,7 +103,7 @@ describe KalibroClient::Entities::Processor::MetricCollectorDetails do
       before :each do
         KalibroClient::Entities::Processor::MetricCollectorDetails.
           expects(:request).
-          with(:find,{name: subject.name}).
+          with(:find, {name: subject.name}).
           returns({"metric_collector_details" => subject.to_hash({except: ["supported_metrics"]})})
       end
 
@@ -146,6 +141,19 @@ describe KalibroClient::Entities::Processor::MetricCollectorDetails do
     end
   end
 
+  describe 'find_metric_by_name!' do
+    subject { FactoryGirl.build(:metric_collector_details) }
+    let(:metric) { subject.supported_metrics["loc"] }
+
+    it 'should return nil with an inexistent name' do
+      expect { subject.find_metric_by_name!("fake name") }.to raise_error(Likeno::Errors::RecordNotFound)
+    end
+
+    it 'should return a metric with an existent name' do
+      expect(subject.find_metric_by_name!(metric.name)).to eq(metric)
+    end
+  end
+
   describe 'find_metric_by_code' do
     subject { FactoryGirl.build(:metric_collector_details) }
     let(:metric) { subject.supported_metrics["loc"] }
@@ -158,4 +166,17 @@ describe KalibroClient::Entities::Processor::MetricCollectorDetails do
       expect(subject.find_metric_by_code(metric.code)).to eq(metric)
     end
   end
+
+  describe 'find_metric_by_code!' do
+    subject { FactoryGirl.build(:metric_collector_details) }
+    let(:metric) { subject.supported_metrics["loc"] }
+
+    it 'should return nil with an inexistent code' do
+      expect{subject.find_metric_by_code!("fake code")}.to raise_error(Likeno::Errors::RecordNotFound)
+    end
+
+    it 'should return a metric with an existent code' do
+      expect(subject.find_metric_by_code!(metric.code)).to eq(metric)
+    end
+  end
 end

data/spec/entities/processor/module_result_spec.rb

@@ -223,45 +223,4 @@ describe KalibroClient::Entities::Processor::ModuleResult do
       expect(subject.processing).to eq(processing)
     end
   end
-
-  describe 'find' do
-    let(:id) { 1 }
-
-    context 'when the ModuleResult exists' do
-      let!(:module_result) { FactoryGirl.build(:module_result) }
-      before :each do
-        KalibroClient::Entities::Base.expects(:find).with(id).returns(module_result)
-      end
-
-      it 'is expected to return the found module result' do
-        expect(described_class.find(id)).to eq(module_result)
-      end
-    end
-
-    context 'when the ModuleResult does not exist' do
-      before :each do
-        response = mock('response')
-        response.expects(:status).at_least_once.returns(422)
-
-        KalibroClient::Entities::Base.expects(:find).with(id).raises(KalibroClient::Errors::RequestError.new(response: response))
-      end
-
-      it 'is expected to raise a RecordNotFound error' do
-        expect { described_class.find(id) }.to raise_error(KalibroClient::Errors::RecordNotFound)
-      end
-    end
-
-    context 'when there is an unexpected server error' do
-      before :each do
-        response = mock('response')
-        response.expects(:status).at_least_once.returns(500)
-
-        KalibroClient::Entities::Base.expects(:find).with(id).raises(KalibroClient::Errors::RequestError.new(response: response))
-      end
-
-      it 'is expected to raise a RequestError' do
-        expect { described_class.find(id) }.to raise_error(KalibroClient::Errors::RequestError)
-      end
-    end
-  end
 end

data/spec/entities/processor/project_spec.rb

@@ -31,40 +31,6 @@ describe KalibroClient::Entities::Processor::Project do
     end
   end
 
-  describe 'all' do
-    context 'with no projects' do
-      before :each do
-        KalibroClient::Entities::Processor::Project.
-          expects(:request).
-          with('', {}, :get).
-          returns({"projects" => []})
-      end
-
-      it 'should return nil' do
-        expect(KalibroClient::Entities::Processor::Project.all).to be_empty
-      end
-    end
-
-    context 'with many projects' do
-      let(:project) { FactoryGirl.build(:project) }
-      let(:another_project) { FactoryGirl.build(:another_project) }
-
-      before :each do
-        KalibroClient::Entities::Processor::Project.
-          expects(:request).
-          with('', {}, :get).
-          returns({"projects" => [project.to_hash, another_project.to_hash]})
-      end
-
-      it 'should return a list with projects' do
-        projects = KalibroClient::Entities::Processor::Project.all
-
-        expect(projects.first.name).to eq(project.name)
-        expect(projects.last.name).to eq(another_project.name)
-      end
-    end
-  end
-
   describe 'repositories' do
     let(:project) { FactoryGirl.build(:project) }
     let(:repository) { FactoryGirl.build(:repository) }
@@ -102,7 +68,7 @@ describe KalibroClient::Entities::Processor::Project do
       before :each do
         KalibroClient::Entities::Processor::Project.
           expects(:request).
-          with(':id', {project: {"name" => "Another Name", "description" => subject.description, "id" => subject.id.to_s}, id: subject.id}, :put, '').
+          with(':id', {project: {"name" => "Another Name", "description" => subject.description, "id" => subject.id.to_s}, id: subject.id}, :put, '', {}).
           returns({"project" => {"id" => subject.id, "name" => "Another Name", "kalibro_errors" => []}})
       end
 

data/spec/entities/processor/repository_spec.rb

@@ -99,19 +99,6 @@ describe KalibroClient::Entities::Processor::Repository do
     end
   end
 
-  describe 'all' do
-    before :each do
-      KalibroClient::Entities::Processor::Repository.
-        expects(:request).
-        with("", {}, :get).
-        returns({'repositories' => [subject.to_hash]})
-    end
-
-    it 'should list all the repositories' do
-      expect(KalibroClient::Entities::Processor::Repository.all).to include(subject)
-    end
-  end
-
   # The only purpose of this test is to cover the overrided save_params method
   describe 'save' do
     subject {FactoryGirl.build(:repository)}
@@ -119,7 +106,7 @@ describe KalibroClient::Entities::Processor::Repository do
     before :each do
       KalibroClient::Entities::Processor::Repository.
         expects(:request).
-        with('', {:repository => subject.to_hash, :project_id => 1}, :post, '').
+        with('', {:repository => subject.to_hash, :project_id => 1}, :post, '', {}).
         returns("repository" => {'id' => 1, 'kalibro_errors' => []})
 
       KalibroClient::Entities::Processor::Repository.any_instance.