kalibro_client 1.4.1 → 2.0.0

data/spec/entities/configurations/metric_configuration_spec.rb

@@ -216,7 +216,7 @@ describe KalibroClient::Entities::Configurations::MetricConfiguration do
         KalibroClient::Entities::Configurations::MetricConfiguration.
         expects(:request).
         with(':id', {id: metric_configuration.id}, :get).
-        returns({'errors' => 'RecordNotFound'})
+        raises(KalibroClient::Errors::RequestError)
       end
 
       it 'should raise the RecordNotFound error' do

data/spec/entities/processor/hotspot_metric_result_spec.rb

@@ -0,0 +1,49 @@
+# This file is part of KalibroClient
+# Copyright (C) 2013  it's respectives authors (please see the AUTHORS file)
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+require 'spec_helper'
+
+describe KalibroClient::Entities::Processor::HotspotMetricResult do
+  describe 'new' do
+    context 'with the expected attributes' do
+      let(:attributes) { FactoryGirl.build(:hotspot_metric_result).to_hash }
+      subject { KalibroClient::Entities::Processor::HotspotMetricResult.new attributes } 
+
+      it 'should cast the line_number attribute to an integer' do
+        expect(subject.line_number).to be_a Integer
+      end
+    end
+  end
+
+  describe 'related_results' do
+    subject { FactoryGirl.build(:hotspot_metric_result) }
+    context 'with related metric results' do
+      let(:related_result) { FactoryGirl.build(:hotspot_metric_result) }
+
+      before do
+        KalibroClient::Entities::Processor::HotspotMetricResult.expects(:request).with(':id/related_results', {id: subject.id}, :get).returns({"hotspot_metric_results" => [subject.to_hash, related_result.to_hash]})
+      end
+
+      it 'should return the related metric results and itself' do
+        results = subject.related_results
+        expect(results).to include(subject)
+        expect(results).to include(related_result)
+        expect(results.size).to eq(2)
+      end
+    end
+  end
+end
+

data/spec/entities/processor/metric_result_spec.rb

@@ -27,20 +27,6 @@ describe KalibroClient::Entities::Processor::MetricResult do
       returns({'metric_configuration' => metric_configuration.to_hash})
   end
 
-  describe 'new' do
-    before :each do
-      subject.metric_configuration_id = metric_configuration.id
-    end
-    context 'with value NaN' do
-      it 'should set the value with aggregated_value' do
-        attributes_hash = FactoryGirl.build(:metric_result, {"aggregated_value" => 1.6}).to_hash
-        attributes_hash["value"] = "NaN"
-        metric_result = KalibroClient::Entities::Processor::MetricResult.new(attributes_hash)
-        expect(metric_result.value).to eq(1.6)
-      end
-    end
-  end
-
   describe 'id=' do
     it 'should set the value of the attribute id' do
       subject.id = 42
@@ -59,96 +45,52 @@ describe KalibroClient::Entities::Processor::MetricResult do
     end
   end
 
-  describe 'value=' do
-    it 'should set the value of the attribute value' do
-      subject.value = 42
-      expect(subject.value).to eq(42)
-    end
-  end
-
-  describe 'aggregated_value=' do
-    it 'should set the value of the attribute aggregated_value' do
-      subject.aggregated_value = 42
-      expect(subject.aggregated_value).to eq(42)
-    end
-  end
-
-  describe 'descendant_values' do
-    context 'when there is one descendant value for the given metric_result' do
+  describe 'metric_configuration' do
+    context 'when metric_configuration_id is nil' do
       before :each do
-        KalibroClient::Entities::Processor::MetricResult.
-        expects(:request).
-        with(':id/descendant_values', { id: subject.id }, :get).
-        returns({'descendant_values' => [13.3]})
+        subject.metric_configuration_id = nil
       end
 
-      it 'should return an unitary list with the descendant value' do
-        expect(subject.descendant_values).to eq([13.3])
+      it 'is expected to return nil' do
+        expect(subject.metric_configuration).to be_nil
       end
     end
 
-    context 'when there is no descendant value for the given metric_result' do
-      before :each do
-        KalibroClient::Entities::Processor::MetricResult.
-        expects(:request).
-        with(':id/descendant_values', { id: subject.id }, :get).
-        returns({'descendant_values' => []})
-      end
+    context 'when metric_configuration_id is not nil' do
+      subject { FactoryGirl.build(:metric_result,
+                                  metric_configuration: nil,
+                                  metric_configuration_id: metric_configuration.id) }
 
-      it 'should return an empty list' do
-        expect(subject.descendant_values).to eq([])
-      end
-    end
-  end
-
-  describe 'history_of' do
-    let(:kalibro_module) { FactoryGirl.build(:kalibro_module_with_id) }
-    let(:metric) { FactoryGirl.build(:metric) }
-    let(:repository) { FactoryGirl.build(:repository_with_id) }
+      context 'and it has already been memoized' do
+        before :each do
+          subject.metric_configuration = metric_configuration
+        end
 
-    context 'when there is not a date metric result' do
-      before :each do
-        KalibroClient::Entities::Processor::Repository.
-        expects(:request).
-        with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
-        returns({'metric_result_history_of' => []})
+        it 'is expected to return the memoized instance' do
+          expect(subject.metric_configuration).to eq(metric_configuration)
+        end
       end
 
-      it 'should return an empty list' do
-        expect(KalibroClient::Entities::Processor::MetricResult.history_of(metric.name, kalibro_module.id, repository.id)).to eq([])
-      end
-    end
+      context 'and it has not been memoized' do
+        before do
+          subject.metric_configuration_id = metric_configuration.id
+        end
 
-    context 'when there is only one date metric result' do
-      let!(:date_metric_result) { FactoryGirl.build(:date_metric_result, metric_result: subject.to_hash) }
+        it 'is expected to find the metric configuration from its id' do
+          KalibroClient::Entities::Configurations::MetricConfiguration.expects(:find).
+            with(subject.metric_configuration_id).
+            returns(metric_configuration)
 
-      before :each do
-        KalibroClient::Entities::Processor::Repository.
-        expects(:request).with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id})
-        .returns({'metric_result_history_of' => [date_metric_result.to_hash]})
-      end
-
-      it 'should return the date metric result as an object into a list' do
-        expect(KalibroClient::Entities::Processor::MetricResult.history_of(metric.name, kalibro_module.id, repository.id).first.metric_result.id).to eq(subject.id)
+          expect(subject.metric_configuration).to eq(metric_configuration)
+        end
       end
     end
+  end
 
-    context 'when there are many date metric results' do
-      let(:date_metric_result) { FactoryGirl.build(:date_metric_result, {metric_result: subject.to_hash}) }
-      let(:another_date_metric_result) { FactoryGirl.build(:another_date_metric_result, {metric_result: subject.to_hash}) }
-
-      before :each do
-        KalibroClient::Entities::Processor::Repository.
-        expects(:request).
-        with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
-        returns({'metric_result_history_of' => [date_metric_result.to_hash, another_date_metric_result.to_hash]})
-      end
-
-      it 'should return a list of date metric results as objects' do
-        response = KalibroClient::Entities::Processor::MetricResult.history_of(metric.name, kalibro_module.id, repository.id)
-        expect(response.first.metric_result.id).to eq(date_metric_result.metric_result.id)
-        expect(response.last.metric_result.id).to eq(another_date_metric_result.metric_result.id)
-      end
+  describe 'value=' do
+    it 'should set the value of the attribute value' do
+      subject.value = 42
+      expect(subject.value).to eq(42)
     end
   end
 end

data/spec/entities/processor/module_result_spec.rb

@@ -19,40 +19,6 @@ require 'spec_helper'
 describe KalibroClient::Entities::Processor::ModuleResult do
   subject { FactoryGirl.build(:module_result, id: rand(Time.now.to_i)) }
 
-  describe 'find' do
-    context 'when there is a module result for the given id' do
-      before :each do
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).
-          with(':id/exists', { id: subject.id }, :get).
-          returns("exists" => true)
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).
-          with(':id', { id: subject.id }, :get).
-          returns("module_result" => subject.to_hash)
-      end
-
-      it 'should return a hash with module result' do
-        expect(KalibroClient::Entities::Processor::ModuleResult.
-          find(subject.id).id).to eq(subject.id)
-      end
-    end
-
-    context "when there isn't a module result for the given id" do
-      before :each do
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).
-          with(':id/exists', { id: subject.id }, :get).
-          returns("exists" => false)
-      end
-
-      it 'should raise an error' do
-        expect {KalibroClient::Entities::Processor::ModuleResult.find(subject.id)}.
-          to raise_error KalibroClient::Errors::RecordNotFound
-      end
-    end
-  end
-
   describe 'children' do
     before :each do
       KalibroClient::Entities::Processor::ModuleResult.
@@ -71,14 +37,7 @@ describe KalibroClient::Entities::Processor::ModuleResult do
 
     context 'when module result has a parent' do
       before :each do
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).
-          with(':id/exists', { id: subject.parent_id }, :get).
-          returns("exists" => true)
-        KalibroClient::Entities::Processor::ModuleResult.
-          expects(:request).at_least_once.
-          with(':id', { id: subject.parent_id }, :get).
-          returns("module_result" => root_module_result.to_hash)
+        subject.class.expects(:find).with(subject.parent_id).returns(root_module_result)
       end
 
       it 'should return its parent' do
@@ -178,39 +137,68 @@ describe KalibroClient::Entities::Processor::ModuleResult do
     end
   end
 
-  describe 'metric_results' do
+  describe 'tree_metric_results' do
+    subject { FactoryGirl.build(:root_module_result) }
+    let(:metric_configuration) { FactoryGirl.build(:metric_configuration, :with_id) }
+    let(:tree_metric_result_1) { FactoryGirl.build(:tree_metric_result, metric_configuration: metric_configuration) }
+    let(:tree_metric_result_2) { FactoryGirl.build(:tree_metric_result, metric_configuration: metric_configuration) }
+
+    context 'with tree metric results' do
+      before :each do
+        KalibroClient::Entities::Processor::ModuleResult.
+          expects(:request).
+          with(':id/metric_results', {id: subject.id}, :get).
+          returns({'tree_metric_results' => [tree_metric_result_1.to_hash, tree_metric_result_2.to_hash]})
+      end
+
+      it 'should return the tree metric results' do
+        expect(subject.tree_metric_results).to eq([tree_metric_result_1, tree_metric_result_2])
+      end
+    end
+
+    context 'without tree metric results' do
+      before :each do
+        KalibroClient::Entities::Processor::ModuleResult.
+          expects(:request).
+          with(':id/metric_results', {id: subject.id}, :get).
+          returns({'tree_metric_results' => []})
+      end
+
+      it 'should return an empty array' do
+        expect(subject.tree_metric_results).to eq([])
+      end
+    end
+  end
+
+  describe 'hotspot_metric_results' do
     subject { FactoryGirl.build(:root_module_result) }
     let(:metric_configuration) { FactoryGirl.build(:metric_configuration_with_id) }
-    let(:metric_result_1) { FactoryGirl.build(:metric_result, metric_configuration: metric_configuration) }
-    let(:metric_result_2) { FactoryGirl.build(:metric_result, metric_configuration: metric_configuration) }
+    let(:hotspot_metric_result_1) { FactoryGirl.build(:hotspot_metric_result, metric_configuration: metric_configuration) }
+    let(:hotspot_metric_result_2) { FactoryGirl.build(:hotspot_metric_result, metric_configuration: metric_configuration) }
 
-    context 'with metric results' do
+    context 'with hotspot metric results' do
       before :each do
         KalibroClient::Entities::Processor::ModuleResult.
-        expects(:request).
-        with(':id/metric_results', {id: subject.id}, :get).
-        returns({'metric_results' => [metric_result_1.to_hash, metric_result_2.to_hash]})
-        KalibroClient::Entities::Configurations::MetricConfiguration.
-        expects(:request).
-        with(':id', {id: metric_configuration.id}, :get).twice.
-        returns({'metric_configuration' => metric_configuration.to_hash})
+          expects(:request).
+          with(':id/hotspot_metric_results', {id: subject.id}, :get).
+          returns({'hotspot_metric_results' => [hotspot_metric_result_1.to_hash, hotspot_metric_result_2.to_hash]})
       end
 
-      it 'should return the metric results' do
-        expect(subject.metric_results).to eq([metric_result_1, metric_result_2])
+      it 'should return the hotspot metric results' do
+        expect(subject.hotspot_metric_results).to eq([hotspot_metric_result_1, hotspot_metric_result_2])
       end
     end
 
-    context 'without metric results' do
+    context 'without hotspot metric results' do
       before :each do
         KalibroClient::Entities::Processor::ModuleResult.
-        expects(:request).
-        with(':id/metric_results', {id: subject.id}, :get).
-        returns({'metric_results' => []})
+          expects(:request).
+          with(':id/hotspot_metric_results', {id: subject.id}, :get).
+          returns({'hotspot_metric_results' => []})
       end
 
-      it 'should return the metric results' do
-        expect(subject.metric_results).to eq([])
+      it 'should return an empty array' do
+        expect(subject.hotspot_metric_results).to eq([])
       end
     end
   end
@@ -224,4 +212,45 @@ describe KalibroClient::Entities::Processor::ModuleResult do
       expect(subject.processing).to eq(processing)
     end
   end
+
+  describe 'find' do
+    let(:id) { 1 }
+
+    context 'when the ModuleResult exists' do
+      let!(:module_result) { FactoryGirl.build(:module_result) }
+      before :each do
+        KalibroClient::Entities::Base.expects(:find).with(id).returns(module_result)
+      end
+
+      it 'is expected to return the found module result' do
+        expect(described_class.find(id)).to eq(module_result)
+      end
+    end
+
+    context 'when the ModuleResult does not exist' do
+      before :each do
+        response = mock('response')
+        response.expects(:status).at_least_once.returns(422)
+
+        KalibroClient::Entities::Base.expects(:find).with(id).raises(KalibroClient::Errors::RequestError.new(response: response))
+      end
+
+      it 'is expected to raise a RecordNotFound error' do
+        expect { described_class.find(id) }.to raise_error(KalibroClient::Errors::RecordNotFound)
+      end
+    end
+
+    context 'when there is an unexpected server error' do
+      before :each do
+        response = mock('response')
+        response.expects(:status).at_least_once.returns(500)
+
+        KalibroClient::Entities::Base.expects(:find).with(id).raises(KalibroClient::Errors::RequestError.new(response: response))
+      end
+
+      it 'is expected to raise a RequestError' do
+        expect { described_class.find(id) }.to raise_error(KalibroClient::Errors::RequestError)
+      end
+    end
+  end
 end

data/spec/entities/processor/tree_metric_result_spec.rb

@@ -0,0 +1,128 @@
+# This file is part of KalibroClient
+# Copyright (C) 2013  it's respectives authors (please see the AUTHORS file)
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+require 'spec_helper'
+
+describe KalibroClient::Entities::Processor::TreeMetricResult do
+  let(:metric_configuration) { FactoryGirl.build(:metric_configuration_with_id) }
+
+  before do
+    KalibroClient::Entities::Configurations::MetricConfiguration.
+      stubs(:request).
+      with(':id', {id: metric_configuration.id}, :get).
+      returns({'metric_configuration' => metric_configuration.to_hash})
+  end
+
+  describe 'new' do
+    before :each do
+      subject.metric_configuration_id = metric_configuration.id
+    end
+    context 'with value NaN' do
+      it 'should set the value with aggregated_value' do
+        attributes_hash = FactoryGirl.build(:tree_metric_result, {"aggregated_value" => 1.6}).to_hash
+        attributes_hash["value"] = "NaN"
+        metric_result = KalibroClient::Entities::Processor::TreeMetricResult.new(attributes_hash)
+        expect(metric_result.value).to eq(1.6)
+      end
+    end
+  end
+
+  describe 'aggregated_value=' do
+    it 'should set the value of the attribute aggregated_value' do
+      subject.aggregated_value = 42
+      expect(subject.aggregated_value).to eq(42)
+    end
+  end
+
+  describe 'descendant_values' do
+    context 'when there is one descendant value for the given metric_result' do
+      before :each do
+        KalibroClient::Entities::Processor::TreeMetricResult.
+        expects(:request).
+        with(':id/descendant_values', { id: subject.id }, :get).
+        returns({'descendant_values' => [13.3]})
+      end
+
+      it 'should return an unitary list with the descendant value' do
+        expect(subject.descendant_values).to eq([13.3])
+      end
+    end
+
+    context 'when there is no descendant value for the given metric_result' do
+      before :each do
+        KalibroClient::Entities::Processor::TreeMetricResult.
+        expects(:request).
+        with(':id/descendant_values', { id: subject.id }, :get).
+        returns({'descendant_values' => []})
+      end
+
+      it 'should return an empty list' do
+        expect(subject.descendant_values).to eq([])
+      end
+    end
+  end
+
+  describe 'history_of' do
+    let(:kalibro_module) { FactoryGirl.build(:kalibro_module_with_id) }
+    let(:metric) { FactoryGirl.build(:metric) }
+    let(:repository) { FactoryGirl.build(:repository_with_id) }
+
+    context 'when there is not a date metric result' do
+      before :each do
+        KalibroClient::Entities::Processor::Repository.
+        expects(:request).
+        with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
+        returns({'metric_result_history_of' => []})
+      end
+
+      it 'should return an empty list' do
+        expect(KalibroClient::Entities::Processor::TreeMetricResult.history_of(metric.name, kalibro_module.id, repository.id)).to eq([])
+      end
+    end
+
+    context 'when there is only one date metric result' do
+      let!(:date_metric_result) { FactoryGirl.build(:date_metric_result, metric_result: subject.to_hash) }
+
+      before :each do
+        KalibroClient::Entities::Processor::Repository.
+        expects(:request).with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id})
+        .returns({'metric_result_history_of' => [date_metric_result.to_hash]})
+      end
+
+      it 'should return the date metric result as an object into a list' do
+        expect(KalibroClient::Entities::Processor::TreeMetricResult.history_of(metric.name, kalibro_module.id, repository.id).first.metric_result.id).to eq(subject.id)
+      end
+    end
+
+    context 'when there are many date metric results' do
+      let(:date_metric_result) { FactoryGirl.build(:date_metric_result, {metric_result: subject.to_hash}) }
+      let(:another_date_metric_result) { FactoryGirl.build(:another_date_metric_result, {metric_result: subject.to_hash}) }
+
+      before :each do
+        KalibroClient::Entities::Processor::Repository.
+        expects(:request).
+        with(':id/metric_result_history_of', {:metric_name => metric.name, :kalibro_module_id => kalibro_module.id, id: repository.id}).
+        returns({'metric_result_history_of' => [date_metric_result.to_hash, another_date_metric_result.to_hash]})
+      end
+
+      it 'should return a list of date metric results as objects' do
+        response = KalibroClient::Entities::Processor::TreeMetricResult.history_of(metric.name, kalibro_module.id, repository.id)
+        expect(response.first.metric_result.id).to eq(date_metric_result.metric_result.id)
+        expect(response.last.metric_result.id).to eq(another_date_metric_result.metric_result.id)
+      end
+    end
+  end
+end