kagu 3.0.5 → 3.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f42802bc51d1c4527070117392111e06dc86a5a076abdafbb323a57b81d3e4e0
-  data.tar.gz: 7f095724080e80aa06d323bfdfc6ad7bb562e3f671ce14c26d8e985bd64c888f
+  metadata.gz: 9edb39356c4523c2f2682c519ad5557d91cdc20107ca3022d0222be2fd66f9bb
+  data.tar.gz: d35d8c4c55f71acc49d89a904a6cc43186d561988b0669ba6a751452ef339603
 SHA512:
-  metadata.gz: 2f64f022b5b4562ab006346d4171c363b5c84c0494d8f4002cf2ff222d8e4526f7f30de48de5087a7eabc96db84760997ae33c446c84e3f5fea7d2d26729790a
-  data.tar.gz: 3c44ac6690a8ea947b0a2a77c76167fd1e0200a64ffc28850c22d85fa33ff85b0388127ebda179304ef3da8d76f97edcbf281fd4fcd9c92566c3e69f9d4da436
+  metadata.gz: a6368d27b74e8d21b14ade2233c91a63be38e6013415eda29b1ae0ddb4f2715316e7a392bf6bbf128ddbcd27e130ed387f280f75d26d6ea520942d99713d3ebc
+  data.tar.gz: ba74cc6b7117ee7f50517b625f0bbcffa2b20169e4baae4b21c4a8f36663b7ecd8d5158aaa5bcbeca84e321e77869e3f155bbcd78269a62ad900403b1cac90f1

data/VERSION

@@ -1 +1 @@
-3.0.5
+3.0.10

data/lib/kagu/attributes_initializer.rb

@@ -7,7 +7,7 @@ module Kagu
         send("#{name}=", value) if respond_to?("#{name}=", true)
       end
       self.class.const_get(:MANDATORY_ATTRIBUTES).each do |attribute|
-        raise Error.new("#{self.class}##{attribute} is mandatory") if send(attribute).nil?
+        raise Error.new("#{self.class}##{attribute} is mandatory for #{inspect}") if send(attribute).nil?
       end
     end
 

data/lib/kagu/playlist.rb

@@ -34,7 +34,7 @@ module Kagu
         AppleScript.execute(%Q{
           tell application #{Kagu::OSX_APP_NAME.inspect}
             set playlistToPush to user playlist #{name.inspect}
-            set idsToAdd to {#{ids.join(',')}}
+            set idsToAdd to {#{ids.map(&:inspect).join(',')}}
             repeat with idToAdd in idsToAdd
               duplicate (tracks of library playlist 1 whose persistent ID is idToAdd) to playlistToPush
             end repeat

data/lib/kagu/playlists.rb

@@ -28,11 +28,11 @@ module Kagu
           print("BEGIN_PLAYLIST")
           print(playlist.name)
           for track in playlist.items.filter({ $0.mediaKind == ITLibMediaItemMediaKind.kindSong }) {
-            print(String(format: "%02X", track.persistentID.intValue))
+            print(String(track.persistentID.uint64Value, radix: 16).uppercased())
           }
           print("END_PLAYLIST")
         }
-      }) do |line|
+      }).each do |line|
         if line == 'BEGIN_PLAYLIST'
           playlist_name = nil
           playlist_tracks = []
@@ -44,6 +44,7 @@ module Kagu
           playlist_tracks << tracks[line]
         end
       end
+      nil
     end
 
   end

data/lib/kagu/swift_helper.rb

@@ -2,7 +2,7 @@ module Kagu
 
   module SwiftHelper
 
-    def self.execute(code, &block)
+    def self.execute(code)
       tempfile = Tempfile.new
       begin
         tempfile << code
@@ -12,12 +12,7 @@ module Kagu
       begin
         stdout, stderr, result = Open3.capture3("swift #{tempfile.path.inspect}")
         raise(stderr.presence || "Swift command returned with code: #{result.exitstatus}") unless result.success?
-        if block_given?
-          stdout.lines.each { |line| yield(line.chomp) }
-          nil
-        else
-          stdout
-        end
+        stdout.lines.map(&:chomp)
       ensure
         tempfile.unlink
       end

data/lib/kagu/track.rb

@@ -5,7 +5,7 @@ module Kagu
     include AttributesInitializer
     include Comparable
 
-    MANDATORY_ATTRIBUTES = %w(added_at id length path)
+    MANDATORY_ATTRIBUTES = %w(added_at id length)
 
     attr_reader :added_at, :album, :artist, :bpm, :genre, :id, :length, :path, :title, :year
 
@@ -22,8 +22,8 @@ module Kagu
       super || self == other
     end
 
-    def exists?
-      path.file?
+    def exists_on_disk?
+      path.present? && path.file?
     end
 
     def hash
@@ -31,6 +31,7 @@ module Kagu
     end
 
     def relative_path(directory)
+      return nil if path.blank?
       directory = directory.to_s
       directory.present? ? Pathname.new(path.to_s.gsub(/\A#{Regexp.escape(directory)}\//, '')) : path
     end
@@ -59,7 +60,8 @@ module Kagu
     end
 
     def bpm=(value)
-      @bpm = value.to_s =~ /\A[0-9]+\z/ ? value.to_i : nil
+      value = value.to_s =~ /\A[0-9]+\z/ ? value.to_i : nil
+      @bpm = (value && value > 0) ? value : nil
     end
 
     def genre=(value)
@@ -76,11 +78,9 @@ module Kagu
 
     def path=(value)
       value = value.to_s.presence
-      value = URI.unescape(URI.parse(value).path) if value.is_a?(String) && value.starts_with?('file://')
-      value = value.encode('UTF-8', 'UTF-8-MAC') if Kagu::IS_MAC_OS
-      @path = Pathname.new(value)
-      raise Error.new("No such file: #{path.to_s.inspect}") if path.exist? && !exists?
-      Kagu.logger.error('Kagu') { "No such track: #{path.inspect}" } unless exists?
+      value = URI.unescape(URI.parse(value).path).presence if value.is_a?(String) && value.starts_with?('file://')
+      value = value.encode('UTF-8', 'UTF-8-MAC') if value.present? && Kagu::IS_MAC_OS
+      @path = value.present? ? Pathname.new(value) : nil
     end
 
     def title=(value)

data/lib/kagu/tracks.rb

@@ -35,7 +35,7 @@ module Kagu
           printObjectProperty(name: "year", value: track.year)
           print("END_TRACK")
         }
-      }) do |line|
+      }).each do |line|
         if line == 'BEGIN_TRACK'
           attributes = {}
         elsif line == 'END_TRACK'
@@ -44,6 +44,7 @@ module Kagu
           attributes[match[1]] = JSON.parse(match[2])
         end
       end
+      nil
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kagu
 version: !ruby/object:Gem::Version
-  version: 3.0.5
+  version: 3.0.10
 platform: ruby
 authors:
 - Alexis Toulotte
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-06 00:00:00.000000000 Z
+date: 2020-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -134,7 +134,7 @@ homepage: https://github.com/alexistoulotte/kagu
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -150,7 +150,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: API for macOS Music
 test_files: []