kagu 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c8cfd404d70114c5ab0432216ae8d4b1e978357c
-  data.tar.gz: c07c6fa355ab50c7bd1033de65cd4495b5fb11db
+  metadata.gz: e5d4e5df146ca66edf6bf1cbe4f640dbfddd33f3
+  data.tar.gz: d2e1ee38ab2c17b049fe58fbbfbfadb7fe271dbb
 SHA512:
-  metadata.gz: 23c65772592525da40e5ebc004f6a98f812bc91da10d88a1301de5b925bbee511e88491615a20555e39a0538390a545c06ca2b34dc71242d7dd5757c10e683f5
-  data.tar.gz: d0c149fb4d705457b6b4a4760c0b9519b18ad77b8743f6597a389633dd00b5f2c3eaba33ec5279d94efc73e25143e7eaa0be3fe1de5341229575674a18b4bc2a
+  metadata.gz: 4ec012cf7b2b9aafee03ebe394b4e2f901809fa023ac888ba0ddefd7b71a552e16bf0e989ee355fbb3a018578eca4e8dd8c37fb4df859ca42fd6bf9c4810ec96
+  data.tar.gz: 0f8848137e743a15f8e6ccf97f77817d100af3bb658c168fcec74f0564d315743c87e837ed4ec2720668eafa5e4ce6c1327385f678f885f856d1d22724ad6c3a

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.1.1

data/lib/kagu/attributes_initializer.rb

@@ -1,12 +1,16 @@
-module AttributesInitializer
+module Kagu
 
-  def initialize(attributes = {})
-    attributes.each do |name, value|
-      send("#{name}=", value) if respond_to?("#{name}=", true)
-    end
-    self.class.const_get(:MANDATORY_ATTRIBUTES).each do |attribute|
-      raise("#{self.class}##{attribute} is mandatory") if send(attribute).nil?
+  module AttributesInitializer
+
+    def initialize(attributes = {})
+      attributes.each do |name, value|
+        send("#{name}=", value) if respond_to?("#{name}=", true)
+      end
+      self.class.const_get(:MANDATORY_ATTRIBUTES).each do |attribute|
+        raise Error.new("#{self.class}##{attribute} is mandatory") if send(attribute).nil?
+      end
     end
+
   end
 
 end

data/lib/kagu/error.rb

@@ -0,0 +1,15 @@
+module Kagu
+
+  class Error < StandardError
+
+    attr_reader :original
+
+    def initialize(message)
+      @original = message.is_a?(Exception) ? message : nil
+      message = original.message if original.is_a?(Exception)
+      super(message.to_s.squish.presence)
+    end
+
+  end
+
+end

data/lib/kagu/library.rb

@@ -2,7 +2,7 @@ module Kagu
 
   class Library
 
-    PATH = "#{ENV['HOME']}/Music/iTunes/iTunes Music Library.xml"
+    PATH = File.expand_path("#{ENV['HOME']}/Music/iTunes/iTunes Music Library.xml")
 
     attr_reader :path
 
@@ -21,7 +21,7 @@ module Kagu
     private
 
     def path=(path)
-      raise IOError.new("No such file: #{path.inspect}") unless File.file?(path)
+      raise Error.new("No such file: #{path.inspect}") unless File.file?(path)
       @path = path
     end
 

data/lib/kagu/playlists.rb

@@ -7,7 +7,8 @@ module Kagu
     attr_reader :library
 
     def initialize(library)
-      @library = library.is_a?(Library) ? library : raise("#{self.class}#library must be a library, #{library.inspect} given")
+      raise ArgumentError.new("#{self.class}#library must be a library, #{library.inspect} given") unless library.is_a?(Library)
+      @library = library
     end
 
     def each(&block)

data/lib/kagu/track.rb

@@ -11,7 +11,7 @@ module Kagu
 
     def initialize(attributes = {})
       super
-      raise("No such file: #{path.inspect}") unless File.file?(path)
+      raise Error.new("No such file: #{path.inspect}") unless File.file?(path)
     end
 
     def <=>(other)

data/lib/kagu/tracks.rb

@@ -7,7 +7,8 @@ module Kagu
     attr_reader :library
 
     def initialize(library)
-      @library = library.is_a?(Library) ? library : raise("#{self.class}#library must be a library, #{library.inspect} given")
+      raise ArgumentError.new("#{self.class}#library must be a library, #{library.inspect} given") unless library.is_a?(Library)
+      @library = library
     end
 
     def each(&block)

data/lib/kagu.rb

@@ -1,11 +1,11 @@
 require 'active_support/core_ext'
 require 'byebug' if ENV['DEBUGGER']
-require 'fileutils'
 require 'htmlentities'
 
 lib_path = "#{__dir__}/kagu"
 
 require "#{lib_path}/attributes_initializer"
+require "#{lib_path}/error"
 require "#{lib_path}/library"
 require "#{lib_path}/playlist"
 require "#{lib_path}/playlists"

data/spec/kagu/error_spec.rb

@@ -0,0 +1,40 @@
+require 'spec_helper'
+
+describe Kagu::Error do
+
+  let(:error) { Kagu::Error.new('BAM!') }
+  let(:original) { StandardError.new('BIM!') }
+
+  describe '#message' do
+
+    it 'is message set at initialization' do
+      expect(error.message).to eq('BAM!')
+    end
+
+    it 'message is squished' do
+      expect(Kagu::Error.new(" hello  \n world").message).to eq('hello world')
+    end
+
+    it 'default one if blank' do
+      expect(Kagu::Error.new(" ").message).to eq('Kagu::Error')
+    end
+
+  end
+
+  describe '#original' do
+
+    it 'is nil by default' do
+      expect(error.original).to be_nil
+    end
+
+    it 'is exception given at initialization' do
+      expect(Kagu::Error.new(original).original).to be(original)
+    end
+
+    it 'sets message from original' do
+      expect(Kagu::Error.new(original).message).to eq('BIM!')
+    end
+
+  end
+
+end

data/spec/kagu/library_spec.rb

@@ -13,13 +13,13 @@ describe Kagu::Library do
     it 'raise an error if directory' do
       expect {
         Kagu::Library.new('/tmp')
-      }.to raise_error(IOError, 'No such file: "/tmp"')
+      }.to raise_error(Kagu::Error, 'No such file: "/tmp"')
     end
 
     it "raise an error if file can't be found" do
       expect {
         Kagu::Library.new('/tmp/bar.foo.baz')
-      }.to raise_error(IOError, 'No such file: "/tmp/bar.foo.baz"')
+      }.to raise_error(Kagu::Error, 'No such file: "/tmp/bar.foo.baz"')
     end
 
   end

data/spec/kagu/playlist_spec.rb

@@ -42,7 +42,7 @@ describe Kagu::Playlist do
     it 'is mandatory' do
       expect {
         Kagu::Playlist.new(name: ' ')
-      }.to raise_error('Kagu::Playlist#name is mandatory')
+      }.to raise_error(Kagu::Error, 'Kagu::Playlist#name is mandatory')
     end
 
   end

data/spec/kagu/playlists_spec.rb

@@ -30,12 +30,16 @@ describe Kagu::Playlists do
 
   end
 
-  describe '#initialize' do
+  describe '#library' do
+
+    it 'is library given at initialization' do
+      expect(playlists.library).to be(library)
+    end
 
     it 'raise an error if library is nil' do
       expect {
         Kagu::Playlists.new(nil)
-      }.to raise_error('Kagu::Playlists#library must be a library, nil given')
+      }.to raise_error(ArgumentError, 'Kagu::Playlists#library must be a library, nil given')
     end
 
   end

data/spec/kagu/track_spec.rb

@@ -85,7 +85,7 @@ describe Kagu::Track do
     it 'raise an error if not specified' do
       expect {
         Kagu::Track.new(attributes.except(:added_at))
-      }.to raise_error('Kagu::Track#added_at is mandatory')
+      }.to raise_error(Kagu::Error, 'Kagu::Track#added_at is mandatory')
     end
 
   end
@@ -142,7 +142,7 @@ describe Kagu::Track do
     it 'raise an error if not specified' do
       expect {
         Kagu::Track.new(attributes.except(:id))
-      }.to raise_error('Kagu::Track#id is mandatory')
+      }.to raise_error(Kagu::Error, 'Kagu::Track#id is mandatory')
     end
 
   end
@@ -167,7 +167,7 @@ describe Kagu::Track do
     it 'raise an error if not specified' do
       expect {
         Kagu::Track.new(attributes.except(:length))
-      }.to raise_error('Kagu::Track#length is mandatory')
+      }.to raise_error(Kagu::Error, 'Kagu::Track#length is mandatory')
     end
 
   end
@@ -182,19 +182,19 @@ describe Kagu::Track do
     it 'raise an error if not specified' do
       expect {
         Kagu::Track.new(attributes.except(:path))
-      }.to raise_error('Kagu::Track#path is mandatory')
+      }.to raise_error(Kagu::Error, 'Kagu::Track#path is mandatory')
     end
 
     it 'raise an error if not found' do
       expect {
         Kagu::Track.new(attributes.merge(path: '/tmp/bar.mp3'))
-      }.to raise_error('No such file: "/tmp/bar.mp3"')
+      }.to raise_error(Kagu::Error, 'No such file: "/tmp/bar.mp3"')
     end
 
     it 'raise an error if not a file' do
       expect {
         Kagu::Track.new(attributes.merge(path: '/tmp'))
-      }.to raise_error('No such file: "/tmp"')
+      }.to raise_error(Kagu::Error, 'No such file: "/tmp"')
     end
 
   end

data/spec/kagu/tracks_spec.rb

@@ -39,12 +39,16 @@ describe Kagu::Tracks do
 
   end
 
-  describe '#initialize' do
+  describe '#library' do
+
+    it 'is library given at initialization' do
+      expect(tracks.library).to be(library)
+    end
 
     it 'raise an error if library is nil' do
       expect {
         Kagu::Tracks.new(nil)
-      }.to raise_error('Kagu::Tracks#library must be a library, nil given')
+      }.to raise_error(ArgumentError, 'Kagu::Tracks#library must be a library, nil given')
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: kagu
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Alexis Toulotte
@@ -126,11 +126,13 @@ files:
 - kagu.gemspec
 - lib/kagu.rb
 - lib/kagu/attributes_initializer.rb
+- lib/kagu/error.rb
 - lib/kagu/library.rb
 - lib/kagu/playlist.rb
 - lib/kagu/playlists.rb
 - lib/kagu/track.rb
 - lib/kagu/tracks.rb
+- spec/kagu/error_spec.rb
 - spec/kagu/library_spec.rb
 - spec/kagu/playlist_spec.rb
 - spec/kagu/playlists_spec.rb
@@ -162,6 +164,7 @@ signing_key:
 specification_version: 4
 summary: API for iTunes
 test_files:
+- spec/kagu/error_spec.rb
 - spec/kagu/library_spec.rb
 - spec/kagu/playlist_spec.rb
 - spec/kagu/playlists_spec.rb