kafo_module_lint 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 752b9e1a6d3cd3ef1e00ceba3b59a434fd3f934f
-  data.tar.gz: 8d2572d6b70764a308ce9661221b4b715a0263df
+  metadata.gz: 3e95e511f9b75a6c8e88f407a5ae3dc6f34bc49c
+  data.tar.gz: 5674891c5698c9be89b5f392bf64d1f67a7f4ed4
 SHA512:
-  metadata.gz: 9bbe2cb56ca7ed23a6d1d5b5bbf8aedb500d8809d4e0389fed4f6d8ae5fab6e179ed7cef7143130b8cea2e7af8584a53dd6422745f5d7f537ff1f1e839424f2a
-  data.tar.gz: 1e4621a943b6abe4aebeffb52add2ed07b29ec112f35f108c8cd3a671b47472965483d14ac65bfbc06f8982091e9d5e7e3c4a77d9aba88b2524ad7575e218bfa
+  metadata.gz: b91ec3fe9bb3d4fd39271d96c9f628e47ef4ef3d5a61c2b6611fa3085407d3c67c0653c4446a119fe45dc1a9f21740b28346d54f9758f2bc59324a1fada4a14b
+  data.tar.gz: 66b0f4838a7b9c2d66477767ebb45fc2ddba43d8b01a7a52c1df5b5ad59a3711b0a6f68f74b2c5886865918d4a427f7854e9a89ff2d4bf6a0ce37c4ede1d6b1f

data/bin/kafo-module-lint

@@ -19,7 +19,7 @@ files = ARGV.empty? ? Dir['manifests/**/*.pp'] : ARGV
 
 result = true
 KafoModuleLint::TypeLoader.new(options[:modulepath]).with_types do
-  files.map { |f| File.expand_path(f) }.each do |manifest|
+  files.each do |manifest|
     puts "Checking #{manifest}" if options[:verbose]
     linter = KafoModuleLint::Linter.new(manifest)
     result = false unless linter.pass?

data/lib/kafo_module_lint/linter.rb

@@ -7,11 +7,11 @@ module KafoModuleLint
     attr_reader :path
 
     def initialize(path)
-      @path = path
+      @path = File.expand_path(path)
     end
 
     def pass?
-      errors.empty?
+      skip? || errors.empty?
     end
 
     def errors
@@ -19,7 +19,7 @@ module KafoModuleLint
         errors = []
         parsed[:types].each do |param,type|
           check_param(param, type, errors)
-        end
+        end unless skip?
         errors
       end
     end
@@ -48,5 +48,10 @@ module KafoModuleLint
         false
       end
     end
+
+    def skip?
+      # kafo_parsers doesn't support 3.x future parser
+      ENV['FUTURE_PARSER'] == 'yes'
+    end
   end
 end

data/lib/kafo_module_lint/version.rb

@@ -1,3 +1,3 @@
 module KafoModuleLint
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/test/kafo_module_lint/binary_test.rb

@@ -1,4 +1,5 @@
 require 'test_helper'
+require 'pathname'
 
 module KafoModuleLint
   describe 'kafo-module-lint' do
@@ -33,5 +34,13 @@ module KafoModuleLint
       specify { stdout.must_equal (error + $/) }
       specify { stderr.must_equal '' }
     end
+
+    describe "with relative path" do
+      let(:manifest) { ManifestFactory.build({}) }
+      let(:manifest_file) do
+        Pathname.new(ManifestFileFactory.build(manifest).path).relative_path_from(Pathname.new(Dir.pwd)).to_s
+      end
+      specify { exit_code.success?.must_equal true }
+    end
   end
 end

data/test/kafo_module_lint/linter_test.rb

@@ -1,5 +1,6 @@
 require 'test_helper'
 require 'kafo_module_lint/linter'
+require 'pathname'
 
 module KafoModuleLint
   describe Linter do
@@ -27,5 +28,23 @@ module KafoModuleLint
       specify { linter.errors.must_equal [error] }
       specify { proc { linter.puts_errors }.must_output (error + $/) }
     end
+
+    describe "with relative path" do
+      let(:manifest) { ManifestFactory.build({}) }
+      let(:manifest_file) do
+        Pathname.new(ManifestFileFactory.build(manifest).path).relative_path_from(Pathname.new(Dir.pwd)).to_s
+      end
+      specify { linter.pass?.must_equal true }
+    end
+
+    describe "with future parser" do
+      let(:manifest) { ManifestFactory.build({'a' => 'String', 'b' => 'Unknown[String]'}) }
+      before { ENV['FUTURE_PARSER'] = 'yes' }
+      after { ENV.delete('FUTURE_PARSER') }
+
+      specify { linter.pass?.must_equal true }
+      specify { linter.errors.must_equal [] }
+      specify { proc { linter.puts_errors }.must_output nil }
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: kafo_module_lint
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Dominic Cleal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-09 00:00:00.000000000 Z
+date: 2016-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -153,7 +153,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Validate Puppet modules are correctly documented for Kafo