jump_back 0.2.2 → 0.3.1

data/spec/features/controller_methods_spec.rb

@@ -0,0 +1,38 @@
+feature 'controller methods' do
+  describe 'redirect_back' do
+    it 'redirects back' do
+      visit save_path
+      click_button 'Post to redirect_with_options'
+      expect(current_path).to eq(save_path)
+    end
+  end
+  
+  describe 'return_to_referer' do
+    it 'returns to saved referer' do
+      visit clear_and_save_path
+      click_link 'Go to save page'
+      visit blank_path
+      click_button 'Put to return_with_options'
+      expect(current_path).to eq(clear_and_save_path)
+    end
+    
+    it 'doesn\'t reset referer if not cleared' do
+      visit clear_and_save_path
+      click_link 'Go to save page'
+      visit blank_path
+      click_link 'Go to save page'
+      visit blank_path
+      click_button 'Put to return_with_options'
+      expect(current_path).to eq(clear_and_save_path)
+    end
+    
+    it 'resets referer if cleared' do
+      visit clear_and_save_path
+      click_link 'Go to save page'
+      click_link 'Go to edit page'
+      visit blank_path
+      click_button 'Put to return_with_options'
+      expect(current_path).to eq(save_path)
+    end
+  end
+end

data/spec/features/view_helpers_spec.rb

@@ -0,0 +1,87 @@
+feature 'view helpers' do
+  
+  describe 'link_back' do
+
+    it 'creates a link back to referer' do
+      visit clear_and_save_path
+      click_link 'Go to save page'
+      click_link 'back'
+      expect(current_path).to eq(clear_and_save_path)
+    end
+    
+    it 'links to default with no referer' do
+      visit save_path
+      click_link 'back'
+      expect(current_path).to eq(root_path)
+    end
+    
+    it 'links to provided path with no referer' do
+      visit blank_path
+      click_link 'back'
+      expect(current_path).to eq(clear_and_save_path)
+    end
+    
+    it 'ignores provided path if referer exists' do
+      visit save_path
+      click_link 'Go to blank page'
+      click_link 'back'
+      expect(current_path).to eq(save_path)
+    end
+    
+    describe 'arguments' do
+    
+      it 'accepts a name argument' do
+        visit clear_and_save_path
+        expect(page).to have_link('Go back from whence you came!')
+      end
+      
+      it 'accepts both name and path arguments' do
+        visit blank_path
+        click_link 'A back link'
+        expect(current_path).to eq(save_path)
+      end
+      
+      it 'accepts additional link_to options' do
+        visit clear_and_save_path
+        expect(page).to have_css('a.red', text: 'back')
+      end
+      
+      it 'accepts additional link_to options with a name but no path' do
+        visit clear_and_save_path
+        expect(page).to have_css('a#just-name[data-remote=true]', text: 'Just a name!')
+      end
+      
+      it 'accepts additional link_to options with a path but no name' do
+        visit clear_and_save_path
+        expect(page).to have_css('a[href="/tests/save"][data-method=put]', text: 'back')
+      end
+      
+      it 'accepts all three arguments' do
+        visit clear_and_save_path
+        expect(page).to have_css('a#all-options[href="/tests/save"]', text: 'All options!')
+      end
+      
+      it 'handles an href as text if a default argument exists' do
+        visit clear_and_save_path
+        expect(page).to have_css('a[href="/tests/save"]', text: 'http://localhost:3000/tests/clear_and_save')
+      end
+    end
+    
+    context 'with an offsite referer' do
+    
+      it 'doesn\'t link back to offsite referers' do
+        Capybara.current_session.driver.header 'Referer', 'http://rubyonrails.org/'
+        visit clear_and_save_path
+        click_link 'Go back from whence you came!'
+        expect(current_path).to eq(root_path)
+      end
+      
+      it 'links back to offsite referers with offsite flag' do
+        Capybara.current_session.driver.header 'Referer', 'http://rubyonrails.org/'
+        visit clear_and_save_path
+        click_link 'Offsite okay!'
+        expect(current_url).to eq('http://rubyonrails.org/')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jump_back
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.3.1
 platform: ruby
 authors:
 - Peter Debelak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-15 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -79,11 +79,12 @@ files:
 - Rakefile
 - lib/jump_back.rb
 - lib/jump_back/engine.rb
+- lib/jump_back/link_back.rb
 - lib/jump_back/options_parser.rb
+- lib/jump_back/path_finder.rb
 - lib/jump_back/redirect_back.rb
-- lib/jump_back/redirection_determiner.rb
-- lib/jump_back/referer_interpreter.rb
 - lib/jump_back/return_to_referer.rb
+- lib/jump_back/urls.rb
 - lib/jump_back/version.rb
 - lib/tasks/jump_back_tasks.rake
 - spec/controller/application_controller_spec.rb
@@ -96,9 +97,9 @@ files:
 - spec/dummy/app/controllers/tests_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/views/layouts/application.html.erb
-- spec/dummy/app/views/tests/edit.html.erb
-- spec/dummy/app/views/tests/index.html.erb
-- spec/dummy/app/views/tests/new.html.erb
+- spec/dummy/app/views/tests/blank.html.erb
+- spec/dummy/app/views/tests/clear_and_save.html.erb
+- spec/dummy/app/views/tests/save.html.erb
 - spec/dummy/bin/bundle
 - spec/dummy/bin/rails
 - spec/dummy/bin/rake
@@ -121,7 +122,6 @@ files:
 - spec/dummy/config/locales/en.yml
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
-- spec/dummy/db/development.sqlite3
 - spec/dummy/db/schema.rb
 - spec/dummy/db/test.sqlite3
 - spec/dummy/log/development.log
@@ -136,7 +136,8 @@ files:
 - spec/dummy/tmp/cache/assets/test/sprockets/cffd775d018f68ce5dba1ee0d951a994
 - spec/dummy/tmp/cache/assets/test/sprockets/d771ace226fc8215a3572e0aa35bb0d6
 - spec/dummy/tmp/cache/assets/test/sprockets/f7cbd26ba1d28d48de824f0e94586655
-- spec/features/jump_back_feature_spec.rb
+- spec/features/controller_methods_spec.rb
+- spec/features/view_helpers_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/pdebelak/jump_back
 licenses:
@@ -171,9 +172,9 @@ test_files:
 - spec/dummy/app/controllers/tests_controller.rb
 - spec/dummy/app/helpers/application_helper.rb
 - spec/dummy/app/views/layouts/application.html.erb
-- spec/dummy/app/views/tests/edit.html.erb
-- spec/dummy/app/views/tests/index.html.erb
-- spec/dummy/app/views/tests/new.html.erb
+- spec/dummy/app/views/tests/blank.html.erb
+- spec/dummy/app/views/tests/clear_and_save.html.erb
+- spec/dummy/app/views/tests/save.html.erb
 - spec/dummy/bin/bundle
 - spec/dummy/bin/rails
 - spec/dummy/bin/rake
@@ -196,7 +197,6 @@ test_files:
 - spec/dummy/config/routes.rb
 - spec/dummy/config/secrets.yml
 - spec/dummy/config.ru
-- spec/dummy/db/development.sqlite3
 - spec/dummy/db/schema.rb
 - spec/dummy/db/test.sqlite3
 - spec/dummy/log/development.log
@@ -213,5 +213,6 @@ test_files:
 - spec/dummy/tmp/cache/assets/test/sprockets/cffd775d018f68ce5dba1ee0d951a994
 - spec/dummy/tmp/cache/assets/test/sprockets/d771ace226fc8215a3572e0aa35bb0d6
 - spec/dummy/tmp/cache/assets/test/sprockets/f7cbd26ba1d28d48de824f0e94586655
-- spec/features/jump_back_feature_spec.rb
+- spec/features/controller_methods_spec.rb
+- spec/features/view_helpers_spec.rb
 - spec/spec_helper.rb

data/lib/jump_back/redirection_determiner.rb

@@ -1,14 +0,0 @@
-module JumpBack
-  
-  class RedirectionDeterminer
-    attr_reader :path
-    
-    def initialize(request, path, options)
-      @path = path_determiner(request, path, options)
-    end
-    
-    def path_determiner(request, path, options)
-      RefererInterpreter.back?(request, options) ? :back : path
-    end
-  end
-end

data/lib/jump_back/referer_interpreter.rb

@@ -1,34 +0,0 @@
-module JumpBack
-  
-  class RefererInterpreter
-    
-    def self.back?(request, options)
-      has_referer?(request) ? is_local?(request, options) ? true : false : false
-    end
-    
-    def self.has_referer?(request)
-      !request.env["HTTP_REFERER"].blank? and request.env["HTTP_REFERER"] != request.env["REQUEST_URI"]
-    end
-    
-    def self.is_local?(request, options)
-      return true if options[:offsite]
-      host = host(request.env["HTTP_REFERER"])
-      !(host && host != request.host)
-    end
-    
-    private
-    
-      def self.host(string)
-        return URI.parse(string).host if uri? string
-      end
-    
-      def self.uri?(string)
-        uri = URI.parse(string)
-        %w( http https ).include?(uri.scheme)
-        rescue URI::BadURIError
-        false
-        rescue URI::InvalidURIError
-        false
-      end
-  end
-end

data/spec/dummy/app/views/tests/edit.html.erb

@@ -1,3 +0,0 @@
-Edit Page
-
-<%= link_to 'Go to new page', new_test_path %>

data/spec/dummy/app/views/tests/index.html.erb

@@ -1,6 +0,0 @@
-Index Page
-<%= form_tag test_path(1), method: :put do %>
-  <%= submit_tag 'Update test' %>
-<% end %>
-
-<%= link_to 'Go to new page', new_test_path %>

data/spec/dummy/app/views/tests/new.html.erb

@@ -1,6 +0,0 @@
-New Page
-<%= form_tag tests_path do %>
-  <%= submit_tag 'New test' %>
-<% end %>
-
-<%= link_to 'Go to edit page', edit_test_path(1) %>

data/spec/features/jump_back_feature_spec.rb

@@ -1,38 +0,0 @@
-feature 'jump_back features' do
-  describe 'redirect_back' do
-    it 'should redirect back' do
-      visit new_test_path
-      click_button 'New test'
-      expect(page).to have_content('New Page')
-    end
-  end
-  
-  describe 'return_to_referer' do
-    it 'should return to saved referer' do
-      visit edit_test_path(1)
-      click_link 'Go to new page'
-      visit tests_path
-      click_button 'Update test'
-      expect(page).to have_content('Edit Page')
-    end
-    
-    it 'should not reset referer if not cleared' do
-      visit edit_test_path(1)
-      click_link 'Go to new page'
-      visit tests_path
-      click_link 'Go to new page'
-      visit tests_path
-      click_button 'Update test'
-      expect(page).to have_content('Edit Page')
-    end
-    
-    it 'should reset referer if cleared' do
-      visit edit_test_path(1)
-      click_link 'Go to new page'
-      click_link 'Go to edit page'
-      visit tests_path
-      click_button 'Update test'
-      expect(page).to have_content('New Page')
-    end
-  end
-end