jumbotron 0.1.3 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 70b7fd9c8a5076c1337d2a6cf9e02016fd6cfa28ec64c9cc0a57c82ff3892698
-  data.tar.gz: 5051beb14f8770e109f382abd0729952446ecd40a50fbd143ac4e5b5746800b0
+  metadata.gz: 31fa4d11ab93d13b5e6db4ab799f05f69b6153067ceb0894677e07bd785c27a3
+  data.tar.gz: 2f660fdbdf85bb67f9212c6c8c55b6bc9f49a2699c643070a5496946d8894259
 SHA512:
-  metadata.gz: c684624b00cded82fb1e274b793a5e0c7cca6d0720589192def2ea53357ce933d631e59373728bfb3052343706df6684ddfd082482100aef79160a65fb8b9dbf
-  data.tar.gz: 72f5a0934b87a9008e6fc782b377ac166f762119504f646bcf4d964892475c2df66871a3222bdf81c20a8eaba264f3e5c519bbbfc5bf4acd1396ac95a94d308c
+  metadata.gz: ee10748cd68f85baa4c3774ef6f7fbcd4c6376f76927a442a8e4ce1b4e28e34c56f7c6355af29545ba1306f7367e37499a56dbdb00f990e413aea020cf37079e
+  data.tar.gz: 30e89a701a8dc935ac6d0d4aeffc61d982b6a800d97f86ac43035a23d4ac480bd60485c6c8e96093eaef022b128693ccf0b663b63716dab53385bce0e79ea174

data/app/models/jumbotron/historical_change.rb

@@ -4,6 +4,12 @@ module Jumbotron
   class HistoricalChange < ApplicationRecord
     belongs_to :observation_batch, inverse_of: :historical_changes
 
+    # Force JSON attribute types so writes are JSON.generate'd on every adapter.
+    # MariaDB stores t.json as LONGTEXT + json_valid CHECK; without :json, AR
+    # persists Ruby #inspect and discovery/evidence writes fail CheckViolation.
+    attribute :previous_value, :json
+    attribute :new_value, :json
+
     validates :subject_type, :subject_id, :attribute_name, :observed_at, :provider, presence: true
   end
 end

data/app/models/jumbotron/observation_batch.rb

@@ -9,6 +9,8 @@ module Jumbotron
              inverse_of: :observation_batch,
              dependent: :restrict_with_exception
 
+    attribute :metadata, :json, default: -> { {} }
+
     validates :provider, :adapter_scope, :observed_at, presence: true
   end
 end

data/app/models/jumbotron/public.rb

@@ -19,7 +19,7 @@ module Jumbotron
       :season_phase,
       :kind
     )
-    Team = Data.define(:id, :name)
+    Team = Data.define(:id, :name, :key)
     Venue = Data.define(:id, :name)
     Participant = Data.define(:role, :score, :result, :team)
     GameSegment = Data.define(:kind, :number)

data/app/models/jumbotron/team.rb

@@ -7,5 +7,16 @@ module Jumbotron
     has_many :provider_identities, as: :target, inverse_of: :target, dependent: :restrict_with_exception
 
     validates :name, presence: true
+    validates :key, presence: true, uniqueness: true
+    validate :key_format_must_be_semantic
+
+    private
+
+    def key_format_must_be_semantic
+      return if key.blank?
+      return if Jumbotron::TeamKey.valid_format?(key)
+
+      errors.add(:key, "must be a lowercase kebab-case semantic key")
+    end
   end
 end

data/app/services/jumbotron/services/canonical/upsert_team.rb

@@ -57,6 +57,7 @@ module Jumbotron
             team.name = team_input.name
             team.changed_at = observed_at
           end
+          # key is immutable after assignment — never regenerate from name or provider id
           team.observed_at = observed_at
           team.save!
           team
@@ -65,13 +66,28 @@ module Jumbotron
         def create_new!
           team = Team.create!(
             name: team_input.name,
+            key: allocate_key!(team_input.name),
             observed_at: observed_at,
             changed_at: observed_at
           )
           change_set.record(subject: team, attribute: "name", previous: nil, new_value: team.name)
+          change_set.record(subject: team, attribute: "key", previous: nil, new_value: team.key)
           team
         end
 
+        def allocate_key!(name)
+          base = Jumbotron::TeamKey.normalize(name)
+          return base unless Team.exists?(key: base)
+
+          suffix = 2
+          loop do
+            candidate = "#{base}-#{suffix}"
+            return candidate unless Team.exists?(key: candidate)
+
+            suffix += 1
+          end
+        end
+
         def recover_after_race!
           ref = team_input.provider_identities.first
           identity = ProviderIdentity.find_by!(

data/app/services/jumbotron/services/public/assemble_public_game.rb

@@ -69,7 +69,11 @@ module Jumbotron
             role: participant.role,
             score: participant.score,
             result: participant.result,
-            team: Jumbotron::Public::Team.new(id: participant.team.id, name: participant.team.name)
+            team: Jumbotron::Public::Team.new(
+              id: participant.team.id,
+              name: participant.team.name,
+              key: participant.team.key
+            )
           )
         end
 

data/db/migrate/20260827150001_add_key_to_jumbotron_teams.rb

@@ -0,0 +1,49 @@
+# frozen_string_literal: true
+
+class AddKeyToJumbotronTeams < ActiveRecord::Migration[8.1]
+  def up
+    add_column :jumbotron_teams, :key, :string, limit: 191
+    backfill_keys!
+    change_column_null :jumbotron_teams, :key, false
+    add_index :jumbotron_teams, :key, unique: true, name: "index_jumbotron_teams_on_key"
+  end
+
+  def down
+    remove_index :jumbotron_teams, name: "index_jumbotron_teams_on_key"
+    remove_column :jumbotron_teams, :key
+  end
+
+  private
+
+  def backfill_keys!
+    say_with_time "backfill jumbotron_teams.key" do
+      taken = {}
+      connection.select_all("SELECT id, name FROM jumbotron_teams ORDER BY id").each do |row|
+        key = allocate_key(normalize_name(row["name"]), taken)
+        taken[key] = true
+        connection.execute(
+          "UPDATE jumbotron_teams SET `key` = #{connection.quote(key)} WHERE id = #{row['id'].to_i}"
+        )
+      end
+    end
+  end
+
+  def normalize_name(name)
+    slug = name.to_s.unicode_normalize(:nfc).downcase
+    slug = slug.gsub(/[^a-z0-9]+/, "-").gsub(/\A-+|-+\z/, "")
+    slug = "team" if slug.blank?
+    slug
+  end
+
+  def allocate_key(base, taken)
+    return base unless taken[base]
+
+    suffix = 2
+    loop do
+      candidate = "#{base}-#{suffix}"
+      return candidate unless taken[candidate]
+
+      suffix += 1
+    end
+  end
+end

data/docs/upgrades/0.1.4.md

@@ -0,0 +1,34 @@
+# Upgrade: Jumbotron 0.1.4
+
+**From:** `0.1.3`  
+**To:** `0.1.4`
+
+Patch release for MariaDB-safe observation evidence JSON persistence. No public consumer contract break. Hosts must already run CommandTower `>= 0.12`.
+
+## Host-facing change
+
+| Change | Host impact |
+|--------|-------------|
+| `HistoricalChange` JSON coding | `previous_value` and `new_value` declare `attribute :…, :json`. Fixes `ActiveRecord::CheckViolation` on MariaDB 10.11 where `t.json` is LONGTEXT + `json_valid` CHECK (discovery / sync evidence writes). |
+| `ObservationBatch` JSON coding | `metadata` declares `attribute :metadata, :json`. Defense in depth for non-empty metadata. |
+
+## Upgrade checklist
+
+1. Bump gem to `0.1.4` (or `>= 0.1.4`).
+2. **No new migration** — runtime model coder only; existing `jumbotron_*` tables unchanged.
+3. **No** recurring schedule rematerialize required for this patch.
+4. After deploy, run a **one-shot** full-season discovery if the catalog is still empty (boot discovery remains off on Pick'em):
+
+   ```ruby
+   Jumbotron::DiscoveryJob.perform_later(
+     adapter_id: "espn_nfl",
+     discovery_id: "full_season",
+     continuation_attempt: 1
+   )
+   ```
+
+5. Smoke: `Jumbotron::Game.count` > 0 after discovery completes; live `GameUpdateJob` ticks without `CheckViolation` on evidence writes.
+
+## Dummy host (engine repo)
+
+Jumbotron dummy Compose now uses **MariaDB 10.11.14** (production parity). Recreate the Compose `mysql` volume after pulling this release.

data/lib/jumbotron/team_key.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module Jumbotron
+  # Immutable semantic public team identity helper.
+  # Derives a kebab-case slug once at assignment; callers must not re-run on rename.
+  module TeamKey
+    FORMAT = /\A[a-z0-9]+(?:-[a-z0-9]+)*\z/
+
+    module_function
+
+    def normalize(name)
+      slug = name.to_s.unicode_normalize(:nfc).downcase
+      slug = slug.gsub(/[^a-z0-9]+/, "-").gsub(/\A-+|-+\z/, "")
+      slug = "team" if slug.blank?
+      slug
+    end
+
+    def valid_format?(key)
+      key.to_s.match?(FORMAT)
+    end
+  end
+end

data/lib/jumbotron/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Jumbotron
-  VERSION = "0.1.3"
+  VERSION = "0.1.5"
 end

data/lib/jumbotron.rb

@@ -3,6 +3,7 @@
 require "rails"
 require "command_tower"
 require "jumbotron/version"
+require "jumbotron/team_key"
 require "jumbotron/engine"
 require "jumbotron/client"
 

data/spec/factories/jumbotron/team.rb

@@ -5,5 +5,11 @@ FactoryBot.define do
     sequence(:name) { |n| "Team #{n}" }
     observed_at { Time.current }
     changed_at { Time.current }
+
+    after(:build) do |team|
+      next if team.key.present?
+
+      team.key = Jumbotron::TeamKey.normalize(team.name)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: jumbotron
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.5
 platform: ruby
 authors:
 - matt-taylor
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2026-08-24 00:00:00.000000000 Z
+date: 2026-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: command_tower
@@ -205,12 +205,15 @@ files:
 - db/migrate/20260813000001_create_jumbotron_schedule_groups.rb
 - db/migrate/20260814000001_create_jumbotron_line_observations.rb
 - db/migrate/20260820000001_add_progress_to_jumbotron_games.rb
+- db/migrate/20260827150001_add_key_to_jumbotron_teams.rb
 - docs/testing.md
 - docs/upgrades/0.1.2.md
 - docs/upgrades/0.1.3.md
+- docs/upgrades/0.1.4.md
 - lib/jumbotron.rb
 - lib/jumbotron/client.rb
 - lib/jumbotron/engine.rb
+- lib/jumbotron/team_key.rb
 - lib/jumbotron/testing.rb
 - lib/jumbotron/version.rb
 - lib/tasks/jumbotron_schedules.rake