julewire-core 1.0.1 → 1.1.1

data/lib/julewire/core/fields/lookup.rb

@@ -8,25 +8,21 @@ module Julewire
           def value(source, key)
             return unless source.respond_to?(:[])
 
-            direct = source[key]
-            return direct unless direct.nil?
-
-            alternate_key(source, key)
+            source[key]
           rescue StandardError
             nil
           end
 
-          def blank?(value)
-            value.nil? || (value.respond_to?(:empty?) && value.empty?)
+          # Decoded wire records have String keys, while in-process records use
+          # Symbols. Keep this conversion at presentation boundaries instead of
+          # making ordinary core lookups tolerant.
+          def wire_value(source, key)
+            result = value(source, key)
+            result.nil? ? value(source, key.to_s) : result
           end
 
-          private
-
-          def alternate_key(source, key)
-            case key
-            when Symbol then source[key.name]
-            when String then source[key.to_sym]
-            end
+          def blank?(value)
+            value.nil? || (value.respond_to?(:empty?) && value.empty?)
           end
         end
       end

data/lib/julewire/core/fields/section_proxy.rb

@@ -34,7 +34,7 @@ module Julewire
 
         def to_h = section_hash
 
-        def [](key) = nil_if_missing(section_value(key, default: MISSING))
+        def [](key) = call_store(:value, key, default: nil)
 
         private
 
@@ -51,10 +51,6 @@ module Julewire
           yield coerce_fields(fields, keyword_fields)
         end
 
-        def nil_if_missing(value)
-          value.equal?(MISSING) ? nil : value
-        end
-
         def add_section(fields)
           call_store(:add, fields)
         end
@@ -67,10 +63,6 @@ module Julewire
           call_store(:hash)
         end
 
-        def section_value(key, default:)
-          call_store(:value, key, default: default)
-        end
-
         def call_store(action, ...)
           @store.public_send(store_method(action), ...)
         end

data/lib/julewire/core/fields/stack_set.rb

@@ -4,13 +4,12 @@ module Julewire
   module Core
     module Fields
       class StackSet
-        EMPTY_HASH = {}.freeze
-        private_constant :EMPTY_HASH
-
         class << self
-          def inherit_from(source, inherit_attributes: true)
-            stacks = Bags.stack_sections.to_h do |section|
-              [section, inherited_stack(source, section, inherit_section?(section, inherit_attributes))]
+          def inherit_from(source, inherit_attributes:)
+            stacks = Bags.stack_sections.each_with_object({}) do |section, inherited|
+              next unless inherit_section?(section, inherit_attributes)
+
+              inherited[section] = source.stack(section).branch
             end
             new(**stacks)
           end
@@ -20,16 +19,12 @@ module Julewire
           def inherit_section?(section, inherit_attributes)
             inherit_attributes || !%i[attributes neutral].include?(section)
           end
-
-          def inherited_stack(source, section, inherit)
-            inherit ? source.stack(section).fork : FieldStack.new
-          end
         end
 
         def initialize(**sections)
           @stacks = Bags.stack_sections.to_h do |section|
-            [section, field_stack(sections.fetch(section, EMPTY_HASH), section)]
-          end.freeze
+            [section, field_stack(sections.fetch(section, nil), section)]
+          end
         end
 
         def stack(section)

data/lib/julewire/core/fields/static_labels.rb

@@ -19,7 +19,7 @@ module Julewire
         end
 
         def remove(key)
-          Fields::Internal.delete_key!(@fields, key)
+          Internal.delete_key!(@fields, key)
           self
         end
 

data/lib/julewire/core/integration/configurable.rb

@@ -28,7 +28,7 @@ module Julewire
         end
 
         def reset!
-          @config = build_config
+          @config = nil
         end
 
         private
@@ -38,9 +38,10 @@ module Julewire
         end
 
         def validate_config!(configuration)
-          return if configuration.is_a?(configuration_class)
+          klass = configuration_class
+          return if configuration.is_a?(klass)
 
-          raise TypeError, "expected #{configuration_class.name}"
+          raise TypeError, "expected #{klass}"
         end
 
         def configuration_class

data/lib/julewire/core/integration/destination_health.rb

@@ -10,7 +10,6 @@ module Julewire
           @state = Diagnostics::Health.new(
             callback_failure_counter: callback_failure_counter,
             counter_keys: counter_keys,
-            failure_counter: failure_counter,
             track_failures: failure_counter == :failures
           )
         end
@@ -20,20 +19,31 @@ module Julewire
         end
 
         def record_failure(error, counter: @failure_counter, **metadata)
-          @state.record_failure(error, counter: counter, degrade: false, **metadata)
+          @state.record_failure(error, counter: counter, **metadata)
         end
 
         def record_loss(reason:, counter: reason, **metadata)
-          @state.record_loss(reason: reason, counter: counter, degrade: false, **metadata)
+          @state.record_loss(reason: reason, counter: counter, **metadata)
         end
 
         def record_callback_failure(callback_failure)
           @state.record_callback_failure(callback_failure)
         end
 
-        def clear_degraded! = @state.clear_failures!
+        def degradation_marker = @state.degradation_marker
 
-        def degraded? = @state.degraded?(status_from: :failure_or_loss)
+        def clear_degradation_if_unchanged(marker) = @state.clear_degradation_if_unchanged(marker)
+
+        def recover_if_successful
+          marker = degradation_marker
+          result = yield
+          clear_degradation_if_unchanged(marker) unless result == false
+          result
+        end
+
+        def clear_failures! = @state.clear_failures!
+
+        def degraded? = @state.degraded?
 
         def last_callback_failure = @state.last_callback_failure
 
@@ -42,8 +52,8 @@ module Julewire
         def last_failure = @state.last_failure
 
         def snapshot(status: nil, **fields)
-          snapshot = @state.snapshot(status: status, status_from: :failure_or_loss, include_loss: true, **fields)
-          callback_failure = @state.last_callback_failure
+          snapshot = @state.snapshot(status: status, include_loss: true, **fields)
+          callback_failure = last_callback_failure
           return snapshot unless callback_failure
 
           snapshot.merge(last_callback_failure: callback_failure).freeze

data/lib/julewire/core/integration/event_subscriber.rb

@@ -55,7 +55,7 @@ module Julewire
 
         private
 
-        def after_configuration_change = nil
+        def after_configuration_change; end
       end
     end
   end

data/lib/julewire/core/integration/facade.rb

@@ -6,24 +6,16 @@ module Julewire
       # @api integration_spi
       module Facade
         class << self
-          def emit(record = Core::UNSET, enforce_level: true, **fields)
+          def emit(record = UNSET, enforce_level: true, **fields)
             record = Core.emit_input(record, fields)
-            runtime = RuntimeLocator.current
-            if runtime.respond_to?(:emit_integration)
-              runtime.emit_integration(record, enforce_level: enforce_level)
-            elsif enforce_level
-              runtime.emit(record)
-            else
-              runtime.emit_without_level(record)
-            end
+            RuntimeLocator.current.emit_integration(record, enforce_level: enforce_level)
             nil
           end
 
-          def with_execution(type:, **, &)
-            raise ArgumentError, "block required" unless block_given?
-
+          def with_execution(type:, **options, &)
             integration_write_section!(:execution)
-            RuntimeLocator.current.with_execution(type: type, owned: true, **, &)
+            validate_owned_fields!(options)
+            RuntimeLocator.current.with_execution(type: type, owned: true, **options, &)
           end
 
           def with_attributes(fields, &)
@@ -88,6 +80,7 @@ module Julewire
             raise ArgumentError, "block required" unless block_given?
 
             integration_write_section!(section)
+            validate_owned_fields!(fields)
             case section
             when :attributes then ContextStore.current.with_attributes(fields, owned: true, &)
             when :carry then ContextStore.current.with_carry(fields, owned: true, &)
@@ -104,7 +97,6 @@ module Julewire
             when :context then ContextStore.current.add_context(fields, owned: true)
             when :neutral then ContextStore.current.add_neutral(fields, owned: true)
             end
-            nil
           end
 
           def integration_write_section!(section)
@@ -115,10 +107,15 @@ module Julewire
             raise ArgumentError, "integration cannot write #{section}"
           end
 
+          def validate_owned_fields!(value)
+            Protocol.validate_symbol_hash(value)
+          end
+
           def add_summary_fields(fields, writer)
             integration_write_section!(:summary)
+            validate_owned_fields!(fields)
             scope = ContextStore.current.current_scope
-            return unless scope && fields.is_a?(Hash)
+            return unless scope
 
             fields = Serialization::DeepCompactEmpty.compact_owned!(fields)
             scope.public_send(writer, fields, owned: true) unless fields.empty?

data/lib/julewire/core/integration/fork_hooks.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "concurrent/map"
+
 module Julewire
   module Core
     module Integration
@@ -7,51 +9,28 @@ module Julewire
         Entry = Data.define(:integration, :component, :callback)
         private_constant :Entry
 
-        @mutex = Mutex.new
-        @entries = {}
+        @entries = Concurrent::Map.new
 
         class << self
           def register(integration, component:, &callback)
             raise ArgumentError, "block required" unless callback
 
-            name = integration_name(integration)
-            component = component.to_sym
-            register_entry(name, component, callback)
+            validate_symbol_name!(integration, name: :integration)
+            validate_symbol_name!(component, name: :component)
+            register_entry(integration, component, callback)
           end
 
           def run
-            snapshot = mutex.synchronize { entries.values }
+            snapshot = entries.values
             snapshot.each { run_entry(it) }
-            nil
-          end
-
-          def after_fork!
-            @mutex = Mutex.new
-            nil
-          end
-
-          def reset!
-            mutex.synchronize { entries.clear }
-            nil
           end
 
           private
 
-          attr_reader :entries, :mutex
+          attr_reader :entries
 
           def register_entry(name, component, callback)
-            mutex.synchronize do
-              entries[[name, component]] = Entry.new(name, component, callback)
-            end
-            nil
-          rescue StandardError => e
-            Diagnostics::ProcessIntegrationHealth.record_failure(
-              name,
-              e,
-              action: :register_after_fork,
-              component: component
-            )
-            nil
+            entries[[name, component]] = Entry.new(name, component, callback)
           end
 
           def run_entry(entry)
@@ -63,14 +42,11 @@ module Julewire
               action: :after_fork,
               component: entry.component
             )
-            nil
           end
 
-          def integration_name(value)
-            name = value.to_s
-            raise ArgumentError, "integration name is required" if name.empty?
-
-            name.to_sym
+          def validate_symbol_name!(value, name:)
+            raise TypeError, "#{name} must be a Symbol" unless value.instance_of?(Symbol)
+            raise ArgumentError, "#{name} is required" if value == :""
           end
         end
       end

data/lib/julewire/core/integration/health.rb

@@ -12,7 +12,6 @@ module Julewire
             else
               Diagnostics::ProcessIntegrationHealth.record_failure(integration, error, **metadata)
             end
-            nil
           end
 
           def record_success(integration, runtime: nil, **)
@@ -21,14 +20,12 @@ module Julewire
             else
               Diagnostics::ProcessIntegrationHealth.record_success(integration)
             end
-            nil
           end
 
           def with_failure_health(integration, component:, action:, runtime: nil, **metadata)
             yield.tap { record_success(integration, runtime: runtime) }
           rescue StandardError => e
             record_failure(integration, e, runtime: runtime, component: component, action: action, **metadata)
-            nil
           end
 
           def scoped(integration, runtime: nil)

data/lib/julewire/core/integration/ivar_state.rb

@@ -10,18 +10,13 @@ module Julewire
         end
 
         def fetch(owner)
-          return unless owner.respond_to?(:instance_variable_get)
-
           owner.instance_variable_get(@marker)
         rescue StandardError
           nil
         end
 
         def store(owner, value)
-          return value unless owner.respond_to?(:instance_variable_set)
-
           owner.instance_variable_set(@marker, value)
-          value
         rescue StandardError
           value
         end

data/lib/julewire/core/integration/protocol.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+
+module Julewire
+  module Core
+    module Integration
+      # @api integration_spi
+      module Protocol
+        class << self
+          def validate_symbol_keys(value)
+            Serialization::DeepFreeze.validate_symbol_keys(value)
+          end
+
+          def validate_symbol_hash(value)
+            Serialization::DeepFreeze.validate_symbol_hash(value)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/julewire/core/integration/settings.rb

@@ -13,7 +13,7 @@ module Julewire
 
         module ClassMethods
           def setting(name, default: nil, predicate: false, validate: nil, &block)
-            settings_defaults[name] = block || proc { default }
+            settings_defaults[name] = block || -> { default }
             settings_validators[name] = validate if validate
             ivar = :"@#{name}"
 
@@ -60,7 +60,7 @@ module Julewire
         end
 
         def setting_default(default)
-          Core::Fields::FieldSet.deep_dup(instance_exec(&default))
+          Fields::FieldSet.deep_dup(instance_exec(&default))
         end
 
         def validate_settings!
@@ -81,9 +81,9 @@ module Julewire
           case validator
           when Symbol
             validator_method = method(validator)
-            validator_method.arity == 1 ? validator_method.call(value) : validator_method.call(value, name)
+            validator_method.arity == 2 ? validator_method.call(value, name) : validator_method.call(value)
           else
-            validator.arity == 1 ? instance_exec(value, &validator) : instance_exec(value, name, &validator)
+            validator.arity == 2 ? instance_exec(value, name, &validator) : instance_exec(value, &validator)
           end
         end
       end

data/lib/julewire/core/integration/subscriber_install.rb

@@ -17,10 +17,10 @@ module Julewire
         private
 
         def update_subscription(configuration)
-          @subscription&.update(configuration)
+          @subscription.update(configuration)
         end
 
-        def store_subscription(subscriber, unsubscribe: nil)
+        def store_subscription(subscriber, unsubscribe:)
           @subscription = Subscription.new(subscriber, unsubscribe: unsubscribe)
           subscriber
         end

data/lib/julewire/core/integration/subscription.rb

@@ -7,7 +7,8 @@ module Julewire
       class Subscription
         attr_reader :subscriber
 
-        def initialize(subscriber, unsubscribe: nil)
+        def initialize(subscriber, unsubscribe:)
+          Validation.validate_callable!(unsubscribe, name: :unsubscribe)
           @subscriber = subscriber
           @unsubscribe = unsubscribe
         end
@@ -18,7 +19,7 @@ module Julewire
         end
 
         def reset
-          @unsubscribe&.call
+          @unsubscribe.call
           nil
         rescue StandardError
           nil

data/lib/julewire/core/integration/values.rb

@@ -59,8 +59,6 @@ module Julewire
             def path_value(object, path, default: nil)
               current = object
               Array(path).each do |key|
-                return default if current.nil?
-
                 current = indexed_value(current, key)
                 return default if current.equal?(MISSING)
               end
@@ -68,11 +66,6 @@ module Julewire
             end
 
             def first_value(source, keys:)
-              if source.is_a?(Hash)
-                found = direct_hash_first_value(source, keys)
-                return found unless found.equal?(MISSING)
-              end
-
               keys.each do |key|
                 found = indexed_value(source, key)
                 return found unless found.equal?(MISSING) || blank_value?(found)
@@ -82,16 +75,6 @@ module Julewire
 
             private
 
-            def direct_hash_first_value(source, keys)
-              keys.each do |key|
-                next unless source.key?(key)
-
-                found = source[key]
-                return found unless blank_value?(found)
-              end
-              MISSING
-            end
-
             def indexed_value(source, key)
               return hash_value(source, key, default: MISSING) if source.is_a?(Hash)
               return MISSING unless source.respond_to?(:[])

data/lib/julewire/core/local_storage.rb

@@ -15,15 +15,12 @@ module Julewire
       private_constant :RUNTIME_KEY, :CONTEXT_STORE_THREAD_KEY, :CONTEXT_STORE_FIBER_IVAR
 
       @runtime_ref = Concurrent::AtomicReference.new
-      @runtime_mutex = Mutex.new
 
       class << self
         def runtime
           return ractor_runtime if ractor_local_storage?
 
-          runtime_ref.get || runtime_mutex.synchronize do
-            runtime_ref.get || Runtime.new.tap { runtime_ref.set(it) }
-          end
+          runtime_ref.update { it || Runtime.new }
         end
 
         def runtime=(runtime)
@@ -42,22 +39,9 @@ module Julewire
           store_context(nil)
         end
 
-        def after_fork!
-          runtime = runtime_ref.get
-          @runtime_mutex = Mutex.new
-          @runtime_ref = Concurrent::AtomicReference.new(runtime)
-          nil
-        end
-
-        # Private testing seam for storage-selection behavior.
-        def main_ractor?
-          ::Ractor.main?
-        end
-        private :main_ractor?
-
         private
 
-        attr_reader :runtime_mutex, :runtime_ref
+        attr_reader :runtime_ref
 
         def ractor_runtime
           ::Ractor.store_if_absent(RUNTIME_KEY) { Runtime.new }
@@ -83,7 +67,7 @@ module Julewire
         end
 
         def ractor_local_storage?
-          !main_ractor?
+          !::Ractor.main?
         end
       end
     end

data/lib/julewire/core/processing/invalid_result_failure.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Julewire
+  module Core
+    module Processing
+      module InvalidResultFailure
+        class << self
+          def build(message:, phase:, processor_name:, record_metadata:, result:)
+            [
+              ArgumentError.new(message),
+              {
+                phase: phase,
+                processor: processor_name,
+                record_metadata: record_metadata,
+                result_class: result.class.name
+              }
+            ]
+          end
+        end
+      end
+    end
+  end
+end

data/lib/julewire/core/processing/level_threshold.rb

@@ -4,7 +4,6 @@ module Julewire
   module Core
     module Processing
       class LevelThreshold
-        DEFAULT_EVENT = "log"
         DEFAULT_SEVERITY = :info
 
         attr_reader :level
@@ -20,32 +19,26 @@ module Julewire
         end
 
         def raw_input_allowed?(input)
-          return allow?(DEFAULT_SEVERITY) unless Records::RawInput.hash_input?(input)
-
-          severity, invalid, invalid_raw_value = raw_input_severity(input)
+          severity, invalid_raw_value = raw_input_severity(input)
           allowed = allow?(severity)
           # Surviving inputs warn later at Records::Draft normalization.
-          record_invalid_raw_severity(input, invalid_raw_value) if invalid && !allowed
+          record_invalid_raw_severity(invalid_raw_value) unless invalid_raw_value.equal?(MISSING) || allowed
           allowed
         end
 
         private
 
         def raw_input_severity(input)
-          return [DEFAULT_SEVERITY, false, nil] unless Records::RawInput.explicit_severity?(input)
+          return [DEFAULT_SEVERITY, MISSING] unless Records::RawInput.explicit_severity?(input)
 
           raw_value = Records::RawInput.value(input, :severity)
-          [Records::Severity.normalize(raw_value), false, nil]
+          [Records::Severity.normalize(raw_value), MISSING]
         rescue ArgumentError
-          [DEFAULT_SEVERITY, true, raw_value]
+          [DEFAULT_SEVERITY, raw_value]
         end
 
-        def record_invalid_raw_severity(input, raw_value)
-          @invalid_severity_reporter.call(
-            raw_value,
-            source: Records::RawInput.value(input, :source),
-            event: Records::RawInput.value(input, :event) || DEFAULT_EVENT
-          )
+        def record_invalid_raw_severity(raw_value)
+          @invalid_severity_reporter.call(raw_value)
         end
       end
     end

data/lib/julewire/core/processing/match.rb

@@ -17,7 +17,7 @@ module Julewire
           raise ArgumentError, "match handler is required" unless handler
 
           conditions = normalize_conditions(conditions, keyword_conditions)
-          @rules << Rule.new(conditions.freeze, handler)
+          @rules << Rule.new(conditions, handler)
           self
         end
 
@@ -46,7 +46,9 @@ module Julewire
         end
 
         def matches_conditions?(draft, conditions)
-          conditions.all? { |key, pattern| matches_value?(pattern, draft[key]) }
+          conditions.all? do |key, pattern|
+            draft.key?(key) && matches_value?(pattern, draft.fetch(key))
+          end
         end
 
         def matches_value?(pattern, value)
@@ -64,8 +66,8 @@ module Julewire
           return false unless value.is_a?(Hash)
 
           pattern.all? do |key, nested_pattern|
-            nested_value = Fields::FieldSet.value_for(value, key, default: Core::UNSET)
-            !nested_value.equal?(Core::UNSET) && matches_value?(nested_pattern, nested_value)
+            nested_value = Fields::FieldSet.value_for(value, key, default: UNSET)
+            !nested_value.equal?(UNSET) && matches_value?(nested_pattern, nested_value)
           end
         end
       end