judopay 1.0.2.pre → 2.0.0

data/spec/faraday/response_spec.rb

@@ -1,17 +1,15 @@
 require 'spec_helper'
 
 describe Faraday::Response do
-  Judopay.configure
-  {
-    400 => Judopay::BadRequest,
-    401 => Judopay::NotAuthorized,
-    404 => Judopay::NotFound,
-    409 => Judopay::Conflict,
-    500 => Judopay::InternalServerError,
-    503 => Judopay::ServiceUnavailable
-  }.each do |status, exception|
+  [
+    400,
+    401,
+    404,
+    409,
+    500,
+    503
+  ].each do |status|
     context "when response status is #{status}" do
-
       before do
         stub_get('/transactions').
           to_return(:status => status,
@@ -19,10 +17,10 @@ describe Faraday::Response do
                     :headers => { 'Content-Type' => 'application/json' })
       end
 
-      it "should raise #{exception.name} error" do
+      it 'should raise APIError exception' do
         expect(lambda do
           Judopay::Transaction.all
-        end).to raise_error(exception)
+        end).to raise_error(Judopay::APIError)
       end
     end
   end

data/spec/fixtures/card_payments/create_bad_request.json

@@ -1,5 +1,12 @@
 {
-  "errorMessage": "Please check the card token.",
-  "errorType": "9",
-  "modelErrors": ["Something went pear-shaped"]
-}
+  "details": [
+    {
+      "code": 46,
+      "fieldName": "ExpiryDate",
+      "message": "Sorry, but the expiry date entered is in the past. Please check your details and try again."
+    }
+  ],
+  "message": "Sorry, we're unable to process your request. Please check your details and try again.",
+  "code": 1,
+  "category": 2
+}

data/spec/fixtures/transactions/register_card.json

@@ -0,0 +1,29 @@
+{
+  "receiptId": "5050240",
+  "yourPaymentReference": "Judo_RegisterCardPreAuth_636059257945294942",
+  "type": "PreAuth",
+  "createdAt": "2016-08-04T16:43:14.7482+01:00",
+  "result": "Success",
+  "message": "AuthCode: 910333",
+  "judoId": 100435197,
+  "merchantName": "Oleg",
+  "appearsOnStatementAs": "APL\/Oleg    ",
+  "originalAmount": "1.01",
+  "amountCollected": "0.00",
+  "netAmount": "1.01",
+  "amount": "1.01",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "3436",
+    "endDate": "1220",
+    "cardToken": "123123123",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "123123123",
+    "yourConsumerReference": "12345"
+  },
+  "risks": {
+    "postCodeCheck": "UNKNOWN"
+  }
+}

data/spec/fixtures/transactions/save_card.json

@@ -0,0 +1,28 @@
+{
+  "receiptId": "123123123",
+  "yourPaymentReference": "Judo_RegisterCard_636051228548063948",
+  "type": "Register",
+  "createdAt": "2016-07-26T09:40:54.9313+01:00",
+  "result": "Success",
+  "message": "Register Card",
+  "judoId": 323123123,
+  "merchantName": "SomeMerch",
+  "appearsOnStatementAs": "APL123",
+  "originalAmount": "0.00",
+  "netAmount": "0.00",
+  "amount": "0.00",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "3436",
+    "endDate": "1220",
+    "cardToken": "abc",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "abc",
+    "yourConsumerReference": "12345"
+  },
+  "risks": {
+    "postCodeCheck": "UNKNOWN"
+  }
+}

data/spec/fixtures/transactions/void.json

@@ -0,0 +1,27 @@
+{
+  "receiptId": "XXXXXX",
+  "originalReceiptId": "12345",
+  "yourPaymentReference": "12345",
+  "type": "VOID",
+  "createdAt": "2016-08-11T13:30:38.1849+01:00",
+  "result": "Success",
+  "message": "Void successful",
+  "judoId": 123123123,
+  "merchantName": "xxxx",
+  "appearsOnStatementAs": "xxxxxxx",
+  "originalAmount": "1.02",
+  "amountCollected": "0.00",
+  "netAmount": "1.02",
+  "amount": "1.02",
+  "currency": "GBP",
+  "cardDetails": {
+    "cardLastfour": "3436",
+    "endDate": "1220",
+    "cardToken": "xxxxxxxxxxxxxxxxxxxx",
+    "cardType": 1
+  },
+  "consumer": {
+    "consumerToken": "xxxxxxxxxxxxxxxx",
+    "yourConsumerReference": "12345"
+  }
+}

data/spec/judopay/card_address_spec.rb

@@ -5,6 +5,6 @@ describe Judopay::CardAddress do
   it "should not allow querying of the API if a resource path isn't set on the model" do
     expect(lambda do
       Judopay::CardAddress.all
-    end).to raise_error(Judopay::Error)
+    end).to raise_error(Judopay::ValidationError)
   end
 end

data/spec/judopay/card_payment_spec.rb

@@ -34,7 +34,6 @@ describe Judopay::CardPayment do
   end
 
   it "should use the configured Judo ID if one isn't provided in the payment request" do
-
     stub_post('/transactions/payments').
       to_return(:status => 200,
                 :body => lambda { |_request| fixture('card_payments/create.json') })
@@ -43,7 +42,7 @@ describe Judopay::CardPayment do
       config.judo_id = '123-456'
     end
 
-    payment = build(:card_payment)
+    payment = build(:card_payment, :judo_id => nil)
     payment.create
 
     expect(payment.valid?).to eq(true)

data/spec/judopay/collection_spec.rb

@@ -9,7 +9,7 @@ describe Judopay::Collection do
 
     transactions = Judopay::Collection.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 
   it 'should create a new collection given a valid payment reference' do

data/spec/judopay/error_spec.rb

@@ -1,23 +1,40 @@
 require 'spec_helper'
 require_relative '../../lib/judopay/error'
+require 'active_model'
 
-describe Judopay::Error do
-  it "returns a 'message' equal to the class name if the message is not set, because 'message' should not be nil" do
-    e = Judopay::Error.new
-    expect(e.message).to eq('Judopay::Error')
+describe Judopay::FieldError do
+  it 'returns fields that was set in message' do
+    e = Judopay::FieldError.new('msg', 123, 'field', 'detail')
+    expect(e.to_s).to eq('Field "field" (code 123): msg')
   end
+end
+
+describe Judopay::ValidationError do
+  it 'returns fields that was set' do
+    errors = ActiveModel::Errors.new(nil)
+    errors['some_field'] = 'some error'
+    e = Judopay::ValidationError.new('Error', errors)
+    expect(e.to_s).to eq("Error\nField errors:\nsome_field: some error")
+  end
+end
 
-  it "returns the 'message' that was set" do
+describe Judopay::APIError do
+  it 'returns the fields that was set' do
     message = 'An explicitly set message'
-    e = Judopay::Error.new(message)
+
+    e = Judopay::APIError.new(message, 1, 12, 23, [])
     expect(e.message).to eq(message)
+    expect(e.error_code).to eq(1)
+    expect(e.status_code).to eq(12)
+    expect(e.category).to eq(23)
+    expect(e.field_errors).to eq([])
   end
 
-  it 'contains exceptions in Judopay' do
-    expect(Judopay::BadRequest.new).to be_a_kind_of(Judopay::APIError)
+  it 'return class name when there is no message and field errors' do
+    expect(Judopay::APIError.new(nil).message).to eq('Judopay::APIError')
   end
 
-  it 'makes error information available on the exception object for API errors' do
+  it 'creates valid APIError from response using factory method' do
     stub_post('/transactions/payments').
       to_return(:status => 400,
                 :body => lambda { |_request| fixture('card_payments/create_bad_request.json') },
@@ -27,16 +44,20 @@ describe Judopay::Error do
 
     begin
       payment.create
-    rescue Judopay::BadRequest => e
-      expect(e.http_status).to eq(400)
-      expect(e.model_errors).to be_a_kind_of(Hash)
-      expect(e.error_type).to eq(9)
-      expect(e.message).to eq('Please check the card token.')
+    rescue Judopay::APIError => e
+      expect(e.status_code).to eq(400)
+      expect(e.field_errors).to be_a_kind_of(Array)
+      expect(e.field_errors[0]).to be_a_kind_of(Judopay::FieldError)
+      expect(e.field_errors[0].code).to eq(46)
+      expect(e.error_code).to eq(1)
+      expect(e.category).to eq(2)
+      expect(e.message).to eq("Sorry, we're unable to process your request. Please check your details and try again.\n\
+Fields errors:\nField \"ExpiryDate\" (code 46): Sorry, but the expiry date entered is in the past. \
+Please check your details and try again.")
     end
   end
 
   it 'makes error information available on the exception object for validation errors' do
-
     payment = Judopay::CardPayment.new
 
     begin

data/spec/judopay/judopay_spec.rb

@@ -9,7 +9,7 @@ describe Judopay do
       config.use_production = true
     end
 
-    expect(Judopay.configuration.endpoint_url).to include('production')
+    expect(Judopay.configuration.endpoint_url).to_not include('sandbox')
 
     # Reset to sandbox for other tests
     Judopay.configure do |config|

data/spec/judopay/market/collection_spec.rb

@@ -9,7 +9,7 @@ describe Judopay::Market::Collection do
 
     transactions = Judopay::Market::Collection.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 
   it 'should create a new collection given a valid payment reference' do

data/spec/judopay/market/payment_spec.rb

@@ -9,6 +9,6 @@ describe Judopay::Market::Payment do
 
     transactions = Judopay::Market::Payment.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 end

data/spec/judopay/market/preauth_spec.rb

@@ -9,6 +9,6 @@ describe Judopay::Market::Preauth do
 
     transactions = Judopay::Market::Preauth.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 end

data/spec/judopay/market/refund_spec.rb

@@ -9,7 +9,7 @@ describe Judopay::Market::Refund do
 
     transactions = Judopay::Market::Refund.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 
   it 'should create a new refund given a valid payment reference' do

data/spec/judopay/market/transaction_spec.rb

@@ -9,6 +9,6 @@ describe Judopay::Market::Transaction do
 
     transactions = Judopay::Market::Transaction.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 end

data/spec/judopay/payment_spec.rb

@@ -9,6 +9,6 @@ describe Judopay::Payment do
 
     transactions = Judopay::Payment.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 end

data/spec/judopay/preauth_spec.rb

@@ -9,6 +9,6 @@ describe Judopay::Preauth do
 
     transactions = Judopay::Preauth.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 end

data/spec/judopay/refund_spec.rb

@@ -9,7 +9,7 @@ describe Judopay::Refund do
 
     transactions = Judopay::Refund.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 
   it 'should create a new refund given a valid payment reference' do

data/spec/judopay/register_card_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+require_relative '../../lib/judopay/models/register_card'
+
+describe Judopay::RegisterCard do
+  it 'should register a new card with valid card details' do
+    stub_post('/transactions/registercard').
+      to_return(:status => 200,
+                :body => lambda { |_request| fixture('transactions/register_card.json') })
+
+    register_card = build(:register_card)
+    response = register_card.create
+
+    expect(response).to be_a(Hash)
+    expect(response.result).to eq('Success')
+    expect(response.type).to eq('PreAuth')
+    expect(response.amount).to eq('1.01')
+  end
+
+  it 'should return a bad request exception if basic validation fails' do
+    expect(lambda do
+      Judopay::RegisterCard.new.create
+    end).to raise_error(Judopay::ValidationError)
+  end
+end

data/spec/judopay/save_card_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require_relative '../../lib/judopay/models/save_card'
+
+describe Judopay::SaveCard do
+  it 'should save a new card with valid card details' do
+    stub_post('/transactions/savecard').
+      to_return(:status => 200,
+                :body => lambda { |_request| fixture('transactions/save_card.json') })
+
+    save_card = build(:save_card)
+    response = save_card.create
+
+    expect(response).to be_a(Hash)
+    expect(response.result).to eq('Success')
+    expect(response.type).to eq('Register')
+  end
+
+  it 'should return a bad request exception if basic validation fails' do
+    expect(lambda do
+      Judopay::SaveCard.new.create
+    end).to raise_error(Judopay::ValidationError)
+  end
+end

data/spec/judopay/transaction_spec.rb

@@ -9,7 +9,7 @@ describe Judopay::Transaction do
 
     transactions = Judopay::Transaction.all
     expect(transactions).to be_a(Hash)
-    expect(transactions.results[0].amount).to equal(1.01)
+    expect(transactions.results[0].amount).to eq(1.01)
   end
 
   it 'should give details of a single transaction given a valid receipt ID' do

data/spec/judopay/void_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+require_relative '../../lib/judopay/models/void'
+
+describe Judopay::Void do
+  it 'should create new void with valid details' do
+    stub_post('/transactions/voids').
+      to_return(:status => 200,
+                :body => lambda { |_request| fixture('transactions/void.json') })
+
+    void = build(:void)
+    response = void.create
+
+    expect(response).to be_a(Hash)
+    expect(response.result).to eq('Success')
+    expect(response.type).to eq('VOID')
+    expect(response.original_amount).to eq('1.02')
+  end
+
+  it 'should return a bad request exception if basic validation fails' do
+    expect(lambda do
+      Judopay::Void.new.create
+    end).to raise_error(Judopay::ValidationError)
+  end
+end

data/spec/spec_helper.rb

@@ -17,8 +17,12 @@ RSpec.configure do |config|
   end
 end
 
-# Use Judopay default configuration
-Judopay.configure
+# Mock configuration
+Judopay.configure do |config|
+  config.judo_id = 'id'
+  config.api_token = 'token'
+  config.api_secret = 'secret'
+end
 
 def stub_get(path)
   stub_request(:get, /judopay/i)