judges 0.0.31 → 0.0.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c9e50999193ddf009d02379799add455856fae20b4f47e67a1760d56d7de3b0
-  data.tar.gz: af70fa8273042c07df059589181795769518c94d54c4430cf9fe9d2999da799a
+  metadata.gz: cf26642d3989b5d0097e54b224bd8c8b431f5e488f04a6c6cc778f9a914e0ad6
+  data.tar.gz: 79974f0a047a19f499e8b9b69566ded6b9b78d3bf6f470bfc67e9aead9988dc9
 SHA512:
-  metadata.gz: ce9ee17c4b5cf1aadc125678bde1e0a7b4bd07a6e1cb2e54696e5e478a68371f9e4c7a6c18f7961be77f056903a1e49eb943d4c9d949fedb96db71ed2f23350e
-  data.tar.gz: fbadf8ca9127b21114b483b7a7f5e6b109d8c804f101a27fe6140c6a77e68a0f522bda5b32a366415b946d1c59c01130ab509a22e9f5c95037dbf605414d7667
+  metadata.gz: f7af589ce71752db5991f3838ea4e6b0e13969f3caab954f21d991d692d75b592c5f3bbe5d42e26cdc9a5d2c68a8ed3fcbe87401c34b1d6daa92c380f6fc7688
+  data.tar.gz: 25a4cc8aa470fb2f457c9f00b1581d5e4c05ab07d8580da124fd59d92c768796b4548948cb03abfc88256936b3ad8a2ae2fa4dd0edd66a7f1ae69a8530176fcf

data/.github/workflows/license.yml

@@ -0,0 +1,57 @@
+# Copyright (c) 2024 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+---
+name: license
+'on':
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  license:
+    runs-on: ubuntu-22.04
+    steps:
+      - uses: actions/checkout@v4
+      - shell: bash
+        run: |
+          header="Copyright (c) $(date +%Y) Yegor Bugayenko"
+          failed="false"
+          while IFS= read -r file; do
+            if ! grep -q "${header}" "${file}"; then
+              failed="true"
+              echo "⚠️ Copyright header is not found in: ${file}"
+            else
+              echo "File looks good: ${file}"
+            fi
+          done < <(find . -type f \( \
+            -name "Dockerfile" -o \
+            -name "LICENSE.txt" -o \
+            -name "Makefile" -o \
+            -name "Rakefile" -o \
+            -name "*.sh" -o \
+            -name "*.rb" -o \
+            -name "*.fe" -o \
+            -name "*.yml" \
+            \) -print)
+          if [ "${failed}" = "true" ]; then
+            exit 1
+          fi

data/Gemfile

@@ -24,10 +24,10 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'cucumber', '9.2.0', require: false
-gem 'minitest', '5.23.0', require: false
+gem 'minitest', '5.23.1', require: false
 gem 'rake', '13.2.1', require: false
 gem 'rspec-rails', '6.1.2', require: false
-gem 'rubocop', '1.63.5', require: false
+gem 'rubocop', '1.64.0', require: false
 gem 'rubocop-performance', '1.21.0', require: false
 gem 'rubocop-rspec', '2.29.2', require: false
 gem 'simplecov', '0.22.0', require: false

data/Gemfile.lock

@@ -95,7 +95,7 @@ GEM
       nokogiri (>= 1.12.0)
     loog (0.5.1)
     mini_mime (1.1.5)
-    minitest (5.23.0)
+    minitest (5.23.1)
     multi_test (1.1.0)
     mutex_m (0.2.0)
     nokogiri (1.16.5-arm64-darwin)
@@ -138,7 +138,7 @@ GEM
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
     rake (13.2.1)
-    rdoc (6.6.3.1)
+    rdoc (6.7.0)
       psych (>= 4.0.0)
     regexp_parser (2.9.2)
     reline (0.5.7)
@@ -162,7 +162,7 @@ GEM
       rspec-mocks (~> 3.13)
       rspec-support (~> 3.13)
     rspec-support (3.13.1)
-    rubocop (1.63.5)
+    rubocop (1.64.0)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
@@ -221,10 +221,10 @@ PLATFORMS
 DEPENDENCIES
   cucumber (= 9.2.0)
   judges!
-  minitest (= 5.23.0)
+  minitest (= 5.23.1)
   rake (= 13.2.1)
   rspec-rails (= 6.1.2)
-  rubocop (= 1.63.5)
+  rubocop (= 1.64.0)
   rubocop-performance (= 1.21.0)
   rubocop-rspec (= 2.29.2)
   simplecov (= 0.22.0)

data/bin/judges

@@ -32,7 +32,7 @@ Encoding.default_internal = Encoding::UTF_8
 class App
   extend GLI::App
 
-  ver = '0.0.31'
+  ver = '0.0.32'
 
   loog = Loog::REGULAR
 

data/features/step_definitions/steps.rb

@@ -49,7 +49,7 @@ When(%r{^I run bin/judges with "([^"]*)"$}) do |arg|
   home = File.join(File.dirname(__FILE__), '../..')
   cmd = "ruby -I#{home}/lib #{home}/bin/judges #{arg}"
   cmd = "GLI_DEBUG=true #{cmd}" unless Gem.win_platform?
-  @stdout = `#{cmd}`
+  @stdout = `#{cmd} 2>&1`
   @exitstatus = $CHILD_STATUS.exitstatus
 end
 

data/features/test.feature

@@ -8,7 +8,7 @@ Feature: Test
     And Exit code is zero
 
   Scenario: Simple test of just one pack
-    Given I run bin/judges with "test --pack reward_for_good_bug ./fixtures"
+    Given I run bin/judges with "test --pack guess ./fixtures"
     Then Stdout contains "judge(s) tested successfully"
     And Exit code is zero
 

data/features/update.feature

@@ -30,3 +30,23 @@ Feature: Update
     Then Stdout contains "1 judge(s) processed"
     Then Stdout contains "Update finished: 1 cycles"
     And Exit code is zero
+
+  Scenario: The update fails when a bug in a judge
+    Given I make a temp directory
+    Then I have a "mypacks/mypack/broken.rb" file with content:
+    """
+    a < 1
+    """
+    Then I run bin/judges with "update mypacks simple.fb"
+    Then Stdout contains "Failed to update correctly"
+    And Exit code is not zero
+
+  Scenario: The update fails when a broken Ruby syntax in a judge
+    Given I make a temp directory
+    Then I have a "mypacks/mypack/broken.rb" file with content:
+    """
+    invalid$ruby$syntax$here
+    """
+    Then I run bin/judges with "update mypacks simple.fb"
+    Then Stdout contains "Failed to update correctly"
+    And Exit code is not zero

data/fixtures/guess/guess.rb

@@ -0,0 +1,28 @@
+# frozen_string_literal: true
+
+# Copyright (c) 2024 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+
+$loog.info("Trying to guess a number (judge=#{$judge})...")
+$fb.txn do |fbt|
+  n = fbt.insert
+  n.number = Random.rand(100)
+  n.time = Time.now
+end

data/fixtures/{reward_for_good_bug/simple-reward.yml → guess/guess_made.yml}

@@ -18,17 +18,8 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 ---
-input:
-  -
-    kind: bug was accepted
-    reporter: yegor256
-    time: 2024-01-01T03:15:45
-    seen:
-      - one
-      - two
-      - three
+input: []
 expected:
-  - /fb[count(f)=2]
-  - /fb/f[kind='nominate for good bug']
-  - /fb/f[payee='yegor256']
-  - /fb/f[amount='15']
+  - /fb[count(f)=1]
+  - /fb/f/number
+  - /fb/f/time

data/fixtures/guess/skipped.yml

@@ -0,0 +1,24 @@
+# Copyright (c) 2024 Yegor Bugayenko
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the 'Software'), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in all
+# copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+# SOFTWARE.
+---
+skip: true
+input: []
+expected:
+  - /should-never-reach-this-point

data/fixtures/{reward_for_good_bug/no-reward.yml → try/tried.yml}

@@ -20,12 +20,8 @@
 ---
 input:
   -
-    kind: bug was accepted
-    reporter: yegor256
+    number: 42
     time: 2024-01-01T03:15:45
-    seen:
-      - one
-      - reward_for_good_bug
-      - two
 expected:
-  - /fb[count(f)=1]
+  - /fb[count(f)=2]
+  - /fb/f/guess

data/fixtures/{reward_for_good_bug/reward_it.rb → try/try.rb}

@@ -20,13 +20,7 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 # SOFTWARE.
 
-$loog.info("Trying to reward a good reported bug (judge=#{$judge})...")
-
-once($fb).query("(eq kind 'bug was accepted')").each do |f|
-  $loog.info('Good candidate found!')
+once($fb).query("(and (exists number) (lt time #{Time.now.utc.iso8601}))").each do |f|
   n = $fb.insert
-  n.kind = 'nominate for good bug'
-  n.payee = f.reporter
-  n.amount = 15
-  n.message = 'thanks for reporting a bug; you get +15 points for this'
+  n.guess = f.number
 end

data/judges.gemspec

@@ -26,7 +26,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = Gem::Requirement.new('>= 0') if s.respond_to? :required_rubygems_version=
   s.required_ruby_version = '>=3.2'
   s.name = 'judges'
-  s.version = '0.0.31'
+  s.version = '0.0.32'
   s.license = 'MIT'
   s.summary = 'Command-Line Tool for a Factbase'
   s.description = '

data/lib/judges/commands/test.rb

@@ -46,17 +46,19 @@ class Judges::Test
     @loog.info("Testing judges in #{dir.to_rel}...")
     errors = []
     done = 0
-    global = {}
     elapsed(@loog) do
       Judges::Packs.new(dir, opts['lib'], @loog).each_with_index do |p, i|
-        local = {}
         next unless include?(opts, p.name)
         @loog.info("\n👉 Testing #{p.script} (##{i}) in #{p.dir.to_rel}...")
         p.tests.each do |f|
           yaml = YAML.load_file(f, permitted_classes: [Time])
+          if yaml['skip']
+            @loog.info("Skippped #{f.to_rel}")
+            next
+          end
           @loog.info("Testing #{f.to_rel}:")
           begin
-            test_one(p, global, local, yaml)
+            test_one(p, yaml)
           rescue StandardError => e
             @loog.warn(Backtrace.new(e))
             errors << f
@@ -80,7 +82,7 @@ class Judges::Test
     packs.include?(name)
   end
 
-  def test_one(pack, global, local, yaml)
+  def test_one(pack, yaml)
     fb = Factbase.new
     yaml['input'].each do |i|
       f = fb.insert
@@ -94,7 +96,7 @@ class Judges::Test
         end
       end
     end
-    pack.run(Factbase::Looged.new(fb, @loog), global, local, Judges::Options.new(yaml['options']))
+    pack.run(Factbase::Looged.new(fb, @loog), {}, {}, Judges::Options.new(yaml['options']))
     xml = Nokogiri::XML.parse(Factbase::ToXML.new(fb).xml)
     yaml['expected'].each do |xp|
       raise "#{pack.script} doesn't match '#{xp}':\n#{xml}" if xml.xpath(xp).empty?

data/lib/judges/commands/update.rb

@@ -85,7 +85,7 @@ class Judges::Update
         before = fb.size
         begin
           p.run(fb, global, local, options)
-        rescue StandardError => e
+        rescue StandardError, SyntaxError => e
           @loog.warn(Backtrace.new(e))
           errors << p.script
         end
@@ -96,7 +96,10 @@ class Judges::Update
       throw :"👍 #{done} judge(s) processed" if errors.empty?
       throw :"❌ #{done} judge(s) processed with #{errors.size} errors"
     end
-    raise "Failed to update correctly (#{errors.size} errors)" unless errors.empty? || opts['quiet']
+    unless errors.empty?
+      raise "Failed to update correctly (#{errors.size} errors)" unless opts['quiet']
+      @loog.info('Not failing because of the --quiet flag provided')
+    end
     diff
   end
 end

data/test/commands/test_update.rb

@@ -62,9 +62,19 @@ class TestUpdate < Minitest::Test
 
   def test_update_with_error
     Dir.mktmpdir do |d|
-      File.write(File.join(d, 'foo.rb'), 'this is a broken Ruby script')
+      File.write(File.join(d, 'foo.rb'), 'this$is$a$broken$Ruby$script')
       file = File.join(d, 'base.fb')
       Judges::Update.new(Loog::NULL).run({ 'quiet' => true }, [d, file])
     end
   end
+
+  def test_update_with_error_no_quiet
+    assert_raises do
+      Dir.mktmpdir do |d|
+        File.write(File.join(d, 'foo.rb'), 'a < 1')
+        file = File.join(d, 'base.fb')
+        Judges::Update.new(Loog::NULL).run({ 'quiet' => false }, [d, file])
+      end
+    end
+  end
 end

data/test/test_pack.rb

@@ -107,4 +107,28 @@ class TestPack < Minitest::Test
       assert_equal(42, fb.query('()').each.to_a.first.bar)
     end
   end
+
+  def test_with_broken_ruby_syntax
+    assert_raises do
+      Dir.mktmpdir do |d|
+        dir = File.join(d, 'packs')
+        FileUtils.mkdir_p(dir)
+        File.write(File.join(dir, 'x.rb'), 'this$is$broken$syntax')
+        pack = Judges::Pack.new(dir, lib, Loog::NULL)
+        pack.run(Factbase.new, {}, {}, {})
+      end
+    end
+  end
+
+  def test_with_runtime_ruby_error
+    assert_raises do
+      Dir.mktmpdir do |d|
+        dir = File.join(d, 'packs')
+        FileUtils.mkdir_p(dir)
+        File.write(File.join(dir, 'x.rb'), 'a < 1')
+        pack = Judges::Pack.new(dir, lib, Loog::NULL)
+        pack.run(Factbase.new, {}, {}, {})
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: judges
 version: !ruby/object:Gem::Version
-  version: 0.0.31
+  version: 0.0.32
 platform: ruby
 authors:
 - Yegor Bugayenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-05-21 00:00:00.000000000 Z
+date: 2024-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backtrace
@@ -96,6 +96,7 @@ files:
 - ".gitattributes"
 - ".github/workflows/actionlint.yml"
 - ".github/workflows/codecov.yml"
+- ".github/workflows/license.yml"
 - ".github/workflows/markdown-lint.yml"
 - ".github/workflows/pdd.yml"
 - ".github/workflows/rake.yml"
@@ -123,10 +124,11 @@ files:
 - features/test.feature
 - features/trim.feature
 - features/update.feature
-- fixtures/reward_for_good_bug/README.md
-- fixtures/reward_for_good_bug/no-reward.yml
-- fixtures/reward_for_good_bug/reward_it.rb
-- fixtures/reward_for_good_bug/simple-reward.yml
+- fixtures/guess/guess.rb
+- fixtures/guess/guess_made.yml
+- fixtures/guess/skipped.yml
+- fixtures/try/tried.yml
+- fixtures/try/try.rb
 - judges.gemspec
 - lib/judges.rb
 - lib/judges/commands/eval.rb

data/fixtures/reward_for_good_bug/README.md

@@ -1,8 +0,0 @@
-# Why bugs reports are rewarded?
-
-Every bug reported and accepted deserves a reward, which
-are given to the reporter of the bug. A bug is considered as
-"accepted" only if it has the `bug`, `enhancement`, or `question` label
-attached to it. Such a reward encourages programmers to report
-more bugs, thus revealing problems that will be fixed before they
-are shipped to a customer.